44767 2010-08-27 08:24:41 -0700 [EFL] WebCore depends on symbols from WebKit 2010-12-14 05:19:03 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Linux RESOLVED WONTFIX P2 Normal --- 44609 1 lucas.de.marchi webkit-unassigned darin gyuyoung.kim kenneth luiz tonikitoo webkit.review.bot oldest_to_newest 270507 0 lucas.de.marchi 2010-08-27 08:24:41 -0700 Current ContextMenu implementation adds a dependency in WebCore from WebKit. This should not happen since it's WebKit that depends on WebCore. 270591 1 65733 lucas.de.marchi 2010-08-27 10:59:52 -0700 Created attachment 65733 Patch 270593 2 webkit.review.bot 2010-08-27 11:02:14 -0700 Attachment 65733 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit/efl/ChangeLog:14: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style. 270603 3 65737 lucas.de.marchi 2010-08-27 11:14:17 -0700 Created attachment 65737 Patch 271018 4 tonikitoo 2010-08-28 10:30:54 -0700 (In reply to comment #3) > Created an attachment (id=65737) [details] > Patch Looks good. @luiz, could you please informally review that patch? (he is our lord on it currentl :) 272581 5 65737 abarth 2010-08-31 19:36:44 -0700 Comment on attachment 65737 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=65737&action=prettypatch > WebCore/page/ContextMenuClient.h:60 > +#elif PLATFORM(EFL) > + virtual PlatformMenuDescription createPlatformDescription(ContextMenu*) = 0; > + virtual void freePlatformDescription(PlatformMenuDescription) = 0; > + virtual void appendItem(PlatformMenuDescription, ContextMenuItem&) = 0; > + virtual void show(PlatformMenuDescription menu) = 0; I'm not sure we should have platform specific methods here. I see that Mac does it, but that doesn't mean it's a good pattern. 272671 6 kenneth 2010-09-01 00:26:26 -0700 Darin, can you give your comments on this? 275938 7 luiz 2010-09-08 10:58:57 -0700 If ContextMenu was an abstract class, EFL could have its own ContextMenu inherited class implemented in WebKit layer. The ContextMenu instance to be used would need to be provided by one of the clients (maybe ContextMenuClient). Then there would be no layering violations. It would demand a lot of changes in all platforms. Those changes would not be complex but they would be extensive. An other possibility would be to have a new pure abstract class that inherits from ContextMenuClient in WebCore/platform/efl. This new class would have the EFL specific methods (createPlatformDescription, freePlatformDescription, appendItem and show) and could be used by ContextMenu with no layering violations (am I right?). ContextMenuClientEfl would then inherit from this new class instead of ContextMenuClient. 321911 8 lucas.de.marchi 2010-12-14 05:19:03 -0800 After the refactoring on context menu in WebCore, this is not needed anymore. Instead, EFL port must fix its implementation to adhere to the new API. 65733 2010-08-27 10:59:52 -0700 2010-08-27 11:14:11 -0700 Patch bug-44767-20100827145956.patch text/plain 7245 lucas.de.marchi ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ01ha2VMaXN0c0VmbC50eHQgYi9XZWJDb3JlL0NNYWtlTGlz dHNFZmwudHh0CmluZGV4IGI1ODk4MmQ2MmIyYzc2NzlhOWE5MzA0ZDMxY2VjOTRjYWQxMjMxZWIu LjZmMTcwYmE3MDhmYjA5ZTA0MTVjZjg0OGYxZTEzYmY5NmM1NjlmMTYgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvQ01ha2VMaXN0c0VmbC50eHQKKysrIGIvV2ViQ29yZS9DTWFrZUxpc3RzRWZsLnR4dApA QCAtMTIsNyArMTIsNiBAQCBMSVNUKEFQUEVORCBXZWJDb3JlX0lOQ0xVREVfRElSRUNUT1JJRVMK ICAgIiR7V0VCQ09SRV9ESVJ9L3BhZ2UvZWZsIgogICAiJHtXRUJDT1JFX0RJUn0vYWNjZXNzaWJp bGl0eS9lZmwiCiAgICIke1dFQktJVF9ESVJ9L2VmbC9XZWJDb3JlU3VwcG9ydCIKLSAgIiR7V0VC S0lUX0RJUn0vZWZsL2V3ayIKICkKIAogTElTVChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTCmRpZmYg LS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGE2OGQz NmM2MDU1MzZhMGVkMzNmNzUyOGEyOTM4ZGI2NzFiN2IwNmIuLjBiMjY1YzA0ZjgyOTM1MWNlMzA2 NmIxYmYxNTkyOGQwZTNmOTQ4YjUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBi L1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjkgQEAKKzIwMTAtMDgtMjcgIEx1Y2FzIERl IE1hcmNoaSAgPGx1Y2FzLmRlbWFyY2hpQHByb2Z1c2lvbi5tb2JpPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdIFdlYkNvcmUgZGVwZW5kcyBv biBzeW1ib2xzIGZyb20gV2ViS2l0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD00NDc2NworCisgICAgICAgIFJlZmFjdG9yIENvbnRleHRNZW51Q2xpZW50 IGltcGxlbWVudGF0aW9uIGluIEVGTCBwb3J0IHNvIFdlYkNvcmUgZG9lcyBub3QKKyAgICAgICAg ZGVwZW5kIG9uIGFueSBzeW1ib2wgZnJvbSBXZWJLaXQuIFRoaXMgaXMgZG9uZSBieSBtb3Zpbmcg c29tZSBtZXRob2RzCisgICAgICAgIGRlZmluZWQgaW4gQ29udGV4dE1lbnVDbGllbnRFZmwgY2xh c3MgdG8gQ29udGV4dE1lbnVDbGllbnQgKGd1YXJkZWQgYnkKKyAgICAgICAgaWZkZWYpLgorCisg ICAgICAgIEVGTCBwb3J0IGRvZXMgbm90IHN1cHBvcnQgYXV0b21hdGVkIHRlc3RzIHlldCwgc28g bm8gbmV3IHRlc3RzLgorCisgICAgICAgICogQ01ha2VMaXN0c0VmbC50eHQ6IFJlbW92ZSBuZWVk bGVzcyBpbmNsdWRlIGRpcmVjdG9yeS4KKyAgICAgICAgKiBsb2FkZXIvRW1wdHlDbGllbnRzLmg6 IEVtcHR5IGltcGxlbWVudGF0aW9ucyBvZiBuZXcgbWV0aG9kcy4KKyAgICAgICAgKFdlYkNvcmU6 OkVtcHR5Q29udGV4dE1lbnVDbGllbnQ6OmNyZWF0ZVBsYXRmb3JtRGVzY3JpcHRpb24pOgorICAg ICAgICAoV2ViQ29yZTo6RW1wdHlDb250ZXh0TWVudUNsaWVudDo6ZnJlZVBsYXRmb3JtRGVzY3Jp cHRpb24pOgorICAgICAgICAoV2ViQ29yZTo6RW1wdHlDb250ZXh0TWVudUNsaWVudDo6YXBwZW5k SXRlbSk6CisgICAgICAgIChXZWJDb3JlOjpFbXB0eUNvbnRleHRNZW51Q2xpZW50OjpzaG93KToK KyAgICAgICAgKiBwYWdlL0NvbnRleHRNZW51Q2xpZW50Lmg6IE1vdmUgbWV0aG9kcyBmcm9tIENv bnRleHRNZW51Q2xpZW50RWZsIHRvCisgICAgICAgIHRoaXMgY2xhc3MuCisgICAgICAgICogcGxh dGZvcm0vQ29udGV4dE1lbnUuaDogQ2xpZW50IG1lbWJlciBoYXMgQ29udGV4dE1lbnVDbGllbnQg dHlwZS4KKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvQ29udGV4dE1lbnVFZmwuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6Q29udGV4dE1lbnU6OkNvbnRleHRNZW51KToKKwogMjAxMC0wOC0yNyAgRGly ayBTY2h1bHplICA8a3JpdEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5pa29s YXMgWmltbWVybWFubi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvbG9hZGVyL0VtcHR5Q2xpZW50cy5o IGIvV2ViQ29yZS9sb2FkZXIvRW1wdHlDbGllbnRzLmgKaW5kZXggMjcwNzUyZGQ3ZjhmMDFmYTk0 ZjdjMjkzZDNjZmU3ZmE5NWVkMjkxZi4uOGU0YmViYzM5MjI5OGRjODU3ZDc1MzVmY2VhZGZmODRh MWNhZWNiZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9sb2FkZXIvRW1wdHlDbGllbnRzLmgKKysrIGIv V2ViQ29yZS9sb2FkZXIvRW1wdHlDbGllbnRzLmgKQEAgLTQ5MCw2ICs0OTAsMTEgQEAgcHVibGlj OgogCiAjaWYgUExBVEZPUk0oTUFDKQogICAgIHZpcnR1YWwgdm9pZCBzZWFyY2hXaXRoU3BvdGxp Z2h0KCkgeyB9CisjZWxpZiBQTEFURk9STShFRkwpCisgICAgdmlydHVhbCBQbGF0Zm9ybU1lbnVE ZXNjcmlwdGlvbiBjcmVhdGVQbGF0Zm9ybURlc2NyaXB0aW9uKENvbnRleHRNZW51KikgeyByZXR1 cm4gMDsgfQorICAgIHZpcnR1YWwgdm9pZCBmcmVlUGxhdGZvcm1EZXNjcmlwdGlvbihQbGF0Zm9y bU1lbnVEZXNjcmlwdGlvbikgeyB9CisgICAgdmlydHVhbCB2b2lkIGFwcGVuZEl0ZW0oUGxhdGZv cm1NZW51RGVzY3JpcHRpb24sIENvbnRleHRNZW51SXRlbSYpIHsgfQorICAgIHZpcnR1YWwgdm9p ZCBzaG93KFBsYXRmb3JtTWVudURlc2NyaXB0aW9uIG1lbnUpIHsgfQogI2VuZGlmCiB9OwogI2Vu ZGlmIC8vIEVOQUJMRShDT05URVhUX01FTlVTKQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdlL0Nv bnRleHRNZW51Q2xpZW50LmggYi9XZWJDb3JlL3BhZ2UvQ29udGV4dE1lbnVDbGllbnQuaAppbmRl eCBmOTE1MzZiNWM1OTk5ZmYzMTBhOGE5NjYwYTA3NTI3ODczYjMzM2MwLi44MGZkZWY1ODJhMThi MTQ3YmFlY2M2NmQ1NzhlZmI2MzEwNDgxN2JhIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BhZ2UvQ29u dGV4dE1lbnVDbGllbnQuaAorKysgYi9XZWJDb3JlL3BhZ2UvQ29udGV4dE1lbnVDbGllbnQuaApA QCAtNTMsNiArNTMsMTEgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiAjaWYgUExBVEZPUk0oTUFD KQogICAgICAgICB2aXJ0dWFsIHZvaWQgc2VhcmNoV2l0aFNwb3RsaWdodCgpID0gMDsKKyNlbGlm IFBMQVRGT1JNKEVGTCkKKyAgICAgICAgdmlydHVhbCBQbGF0Zm9ybU1lbnVEZXNjcmlwdGlvbiBj cmVhdGVQbGF0Zm9ybURlc2NyaXB0aW9uKENvbnRleHRNZW51KikgPSAwOworICAgICAgICB2aXJ0 dWFsIHZvaWQgZnJlZVBsYXRmb3JtRGVzY3JpcHRpb24oUGxhdGZvcm1NZW51RGVzY3JpcHRpb24p ID0gMDsKKyAgICAgICAgdmlydHVhbCB2b2lkIGFwcGVuZEl0ZW0oUGxhdGZvcm1NZW51RGVzY3Jp cHRpb24sIENvbnRleHRNZW51SXRlbSYpID0gMDsKKyAgICAgICAgdmlydHVhbCB2b2lkIHNob3co UGxhdGZvcm1NZW51RGVzY3JpcHRpb24gbWVudSkgPSAwOwogI2VuZGlmCiAgICAgfTsKIH0KZGlm ZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vQ29udGV4dE1lbnUuaCBiL1dlYkNvcmUvcGxhdGZv cm0vQ29udGV4dE1lbnUuaAppbmRleCBjYTIxZjI5ZGVjNTMxNDEyYWNlNDk3YTE0NjIxNDAyMGQ5 OTg5ZmJjLi5kYWYwYTI3ZWU3NDNjOGZlY2YzNzIyMzIwYzE1MTk0ZjExZGU3NGNlIDEwMDY0NAot LS0gYS9XZWJDb3JlL3BsYXRmb3JtL0NvbnRleHRNZW51LmgKKysrIGIvV2ViQ29yZS9wbGF0Zm9y bS9Db250ZXh0TWVudS5oCkBAIC00MSw5ICs0MSw3IEBACiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAK ICAgICBjbGFzcyBDb250ZXh0TWVudUNvbnRyb2xsZXI7Ci0jaWYgUExBVEZPUk0oRUZMKQotICAg IGNsYXNzIENvbnRleHRNZW51Q2xpZW50RWZsOwotI2VuZGlmCisgICAgY2xhc3MgQ29udGV4dE1l bnVDbGllbnQ7CiAKICAgICBjbGFzcyBDb250ZXh0TWVudSA6IHB1YmxpYyBOb25jb3B5YWJsZQog ICAgIHsKQEAgLTg0LDcgKzgyLDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogI2VsaWYgUExBVEZP Uk0oQ0hST01JVU0pCiAgICAgICAgIFZlY3RvcjxDb250ZXh0TWVudUl0ZW0+IG1faXRlbXM7CiAj ZWxpZiBQTEFURk9STShFRkwpCi0gICAgICAgIENvbnRleHRNZW51Q2xpZW50RWZsKiBtX2NvbnRl eHRNZW51Q2xpZW50OworICAgICAgICBDb250ZXh0TWVudUNsaWVudCogbV9jb250ZXh0TWVudUNs aWVudDsKICAgICAgICAgUGxhdGZvcm1NZW51RGVzY3JpcHRpb24gbV9wbGF0Zm9ybURlc2NyaXB0 aW9uOwogI2Vsc2UKICAgICAgICAgUGxhdGZvcm1NZW51RGVzY3JpcHRpb24gbV9wbGF0Zm9ybURl c2NyaXB0aW9uOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvQ29udGV4dE1lbnVF ZmwuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvQ29udGV4dE1lbnVFZmwuY3BwCmluZGV4IDhk ODU2MDgzYmFkNDQ5YmUyMjA0MGI5OTE4YWVjYzFhOTdiZjFjZGEuLmUyNGIzYzI4YmFkMTdiYTM4 YjQyNmQ5MGI2YjU2ZTFiNTkzNjk2NWYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZWZs L0NvbnRleHRNZW51RWZsLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2VmbC9Db250ZXh0TWVu dUVmbC5jcHAKQEAgLTIzLDcgKzIzLDYgQEAKICNpbmNsdWRlICJDb250ZXh0TWVudS5oIgogCiAj aW5jbHVkZSAiQ29udGV4dE1lbnVDbGllbnQuaCIKLSNpbmNsdWRlICJDb250ZXh0TWVudUNsaWVu dEVmbC5oIgogI2luY2x1ZGUgIkNvbnRleHRNZW51Q29udHJvbGxlci5oIgogI2luY2x1ZGUgIk5v dEltcGxlbWVudGVkLmgiCiAKQEAgLTMyLDcgKzMxLDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewog Q29udGV4dE1lbnU6OkNvbnRleHRNZW51KGNvbnN0IEhpdFRlc3RSZXN1bHQmIHJlc3VsdCkKICAg ICA6IG1faGl0VGVzdFJlc3VsdChyZXN1bHQpCiB7Ci0gICAgbV9jb250ZXh0TWVudUNsaWVudCA9 IHN0YXRpY19jYXN0PENvbnRleHRNZW51Q2xpZW50RWZsKj4oY29udHJvbGxlcigpLT5jbGllbnQo KSk7CisgICAgbV9jb250ZXh0TWVudUNsaWVudCA9IGNvbnRyb2xsZXIoKS0+Y2xpZW50KCk7CiAg ICAgbV9wbGF0Zm9ybURlc2NyaXB0aW9uID0gbV9jb250ZXh0TWVudUNsaWVudC0+Y3JlYXRlUGxh dGZvcm1EZXNjcmlwdGlvbih0aGlzKTsKIH0KIApAQCAtNDAsNyArMzksNyBAQCBDb250ZXh0TWVu dTo6Q29udGV4dE1lbnUoY29uc3QgSGl0VGVzdFJlc3VsdCYgcmVzdWx0LCBjb25zdCBQbGF0Zm9y bU1lbnVEZXNjcmlwdAogICAgIDogbV9oaXRUZXN0UmVzdWx0KHJlc3VsdCkKICAgICAsIG1fcGxh dGZvcm1EZXNjcmlwdGlvbihtZW51KQogewotICAgIG1fY29udGV4dE1lbnVDbGllbnQgPSBzdGF0 aWNfY2FzdDxDb250ZXh0TWVudUNsaWVudEVmbCo+KGNvbnRyb2xsZXIoKS0+Y2xpZW50KCkpOwor ICAgIG1fY29udGV4dE1lbnVDbGllbnQgPSBjb250cm9sbGVyKCktPmNsaWVudCgpOwogfQogCiBD b250ZXh0TWVudTo6fkNvbnRleHRNZW51KCkKZGlmZiAtLWdpdCBhL1dlYktpdC9lZmwvQ2hhbmdl TG9nIGIvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggYzE4NTQ5YjFmY2UxODliNTcwMjMxNTIz MjJkMDg2N2Y0OGM4NmUwMC4uMDJmZDgwNDE2ZmVjYWY3Njk0Y2EwNTAwZDhjZjc1MGY4YmJkMzA2 ZCAxMDA2NDQKLS0tIGEvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2VmbC9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wOC0yNyAgTHVjYXMgRGUgTWFyY2hpICA8bHVj YXMuZGVtYXJjaGlAcHJvZnVzaW9uLm1vYmk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgW0VGTF0gV2ViQ29yZSBkZXBlbmRzIG9uIHN5bWJvbHMgZnJv bSBXZWJLaXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQ0NzY3CisKKyAgICAgICAgUmVmYWN0b3IgQ29udGV4dE1lbnVDbGllbnQgaW1wbGVtZW50YXRp b24gaW4gRUZMIHBvcnQgc28gV2ViQ29yZSBkb2VzIG5vdAorICAgICAgICBkZXBlbmQgb24gYW55 IHN5bWJvbCBmcm9tIFdlYktpdC4gVGhpcyBpcyBkb25lIGJ5IG1vdmluZyBzb21lIG1ldGhvZHMK KyAgICAgICAgZGVmaW5lZCBpbiBDb250ZXh0TWVudUNsaWVudEVmbCBjbGFzcyB0byBDb250ZXh0 TWVudUNsaWVudCAoZ3VhcmRlZCBieQorICAgICAgICBpZmRlZikuCisKKyAgICAgICAgKiBXZWJD b3JlU3VwcG9ydC9Db250ZXh0TWVudUNsaWVudEVmbC5oOiBSZW1vdmUgbWV0aG9kcyB0byBtb3Zl ZCB0bworCQlXZWJDb3JlLgorCiAyMDEwLTA4LTI2ICBNaXJvc2xhdyBTenltYW5za2kgIDxtaXJv c2xhdy5zQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUg Q2hyaXN0aWFuc2VuLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9Db250 ZXh0TWVudUNsaWVudEVmbC5oIGIvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9Db250ZXh0TWVu dUNsaWVudEVmbC5oCmluZGV4IDhhMjg5YTFkY2IxM2I1Yzk1NmI3ODEzNjYxYmJiNzM0Y2RlMjgy NjQuLjkxNzk0NDMwN2NjYTIxNTU1MzMwYjIzNGViODExMGU4OGE3NzY2NDggMTAwNjQ0Ci0tLSBh L1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQ29udGV4dE1lbnVDbGllbnRFZmwuaAorKysgYi9X ZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0NvbnRleHRNZW51Q2xpZW50RWZsLmgKQEAgLTUwLDEw ICs1MCwxMCBAQCBjbGFzcyBDb250ZXh0TWVudUNsaWVudEVmbCA6IHB1YmxpYyBDb250ZXh0TWVu dUNsaWVudCB7CiAgICAgdmlydHVhbCBib29sIGlzU3BlYWtpbmcoKTsKICAgICB2aXJ0dWFsIHZv aWQgc3RvcFNwZWFraW5nKCk7CiAKLSAgICBQbGF0Zm9ybU1lbnVEZXNjcmlwdGlvbiBjcmVhdGVQ bGF0Zm9ybURlc2NyaXB0aW9uKENvbnRleHRNZW51Kik7Ci0gICAgdm9pZCBmcmVlUGxhdGZvcm1E ZXNjcmlwdGlvbihQbGF0Zm9ybU1lbnVEZXNjcmlwdGlvbik7Ci0gICAgdm9pZCBhcHBlbmRJdGVt KFBsYXRmb3JtTWVudURlc2NyaXB0aW9uLCBDb250ZXh0TWVudUl0ZW0mKTsKLSAgICB2b2lkIHNo b3coUGxhdGZvcm1NZW51RGVzY3JpcHRpb24gbWVudSk7CisgICAgdmlydHVhbCBQbGF0Zm9ybU1l bnVEZXNjcmlwdGlvbiBjcmVhdGVQbGF0Zm9ybURlc2NyaXB0aW9uKENvbnRleHRNZW51Kik7Cisg ICAgdmlydHVhbCB2b2lkIGZyZWVQbGF0Zm9ybURlc2NyaXB0aW9uKFBsYXRmb3JtTWVudURlc2Ny aXB0aW9uKTsKKyAgICB2aXJ0dWFsIHZvaWQgYXBwZW5kSXRlbShQbGF0Zm9ybU1lbnVEZXNjcmlw dGlvbiwgQ29udGV4dE1lbnVJdGVtJik7CisgICAgdmlydHVhbCB2b2lkIHNob3coUGxhdGZvcm1N ZW51RGVzY3JpcHRpb24gbWVudSk7CiAgcHJpdmF0ZToKICAgICBFdmFzX09iamVjdCogbV92aWV3 OwogfTsK 65737 2010-08-27 11:14:17 -0700 2010-08-31 19:36:44 -0700 Patch bug-44767-20100827151421.patch text/plain 7251 lucas.de.marchi ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ01ha2VMaXN0c0VmbC50eHQgYi9XZWJDb3JlL0NNYWtlTGlz dHNFZmwudHh0CmluZGV4IGI1ODk4MmQ2MmIyYzc2NzlhOWE5MzA0ZDMxY2VjOTRjYWQxMjMxZWIu LjZmMTcwYmE3MDhmYjA5ZTA0MTVjZjg0OGYxZTEzYmY5NmM1NjlmMTYgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvQ01ha2VMaXN0c0VmbC50eHQKKysrIGIvV2ViQ29yZS9DTWFrZUxpc3RzRWZsLnR4dApA QCAtMTIsNyArMTIsNiBAQCBMSVNUKEFQUEVORCBXZWJDb3JlX0lOQ0xVREVfRElSRUNUT1JJRVMK ICAgIiR7V0VCQ09SRV9ESVJ9L3BhZ2UvZWZsIgogICAiJHtXRUJDT1JFX0RJUn0vYWNjZXNzaWJp bGl0eS9lZmwiCiAgICIke1dFQktJVF9ESVJ9L2VmbC9XZWJDb3JlU3VwcG9ydCIKLSAgIiR7V0VC S0lUX0RJUn0vZWZsL2V3ayIKICkKIAogTElTVChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTCmRpZmYg LS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGE2OGQz NmM2MDU1MzZhMGVkMzNmNzUyOGEyOTM4ZGI2NzFiN2IwNmIuLjBiMjY1YzA0ZjgyOTM1MWNlMzA2 NmIxYmYxNTkyOGQwZTNmOTQ4YjUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBi L1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjkgQEAKKzIwMTAtMDgtMjcgIEx1Y2FzIERl IE1hcmNoaSAgPGx1Y2FzLmRlbWFyY2hpQHByb2Z1c2lvbi5tb2JpPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdIFdlYkNvcmUgZGVwZW5kcyBv biBzeW1ib2xzIGZyb20gV2ViS2l0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD00NDc2NworCisgICAgICAgIFJlZmFjdG9yIENvbnRleHRNZW51Q2xpZW50 IGltcGxlbWVudGF0aW9uIGluIEVGTCBwb3J0IHNvIFdlYkNvcmUgZG9lcyBub3QKKyAgICAgICAg ZGVwZW5kIG9uIGFueSBzeW1ib2wgZnJvbSBXZWJLaXQuIFRoaXMgaXMgZG9uZSBieSBtb3Zpbmcg c29tZSBtZXRob2RzCisgICAgICAgIGRlZmluZWQgaW4gQ29udGV4dE1lbnVDbGllbnRFZmwgY2xh c3MgdG8gQ29udGV4dE1lbnVDbGllbnQgKGd1YXJkZWQgYnkKKyAgICAgICAgaWZkZWYpLgorCisg ICAgICAgIEVGTCBwb3J0IGRvZXMgbm90IHN1cHBvcnQgYXV0b21hdGVkIHRlc3RzIHlldCwgc28g bm8gbmV3IHRlc3RzLgorCisgICAgICAgICogQ01ha2VMaXN0c0VmbC50eHQ6IFJlbW92ZSBuZWVk bGVzcyBpbmNsdWRlIGRpcmVjdG9yeS4KKyAgICAgICAgKiBsb2FkZXIvRW1wdHlDbGllbnRzLmg6 IEVtcHR5IGltcGxlbWVudGF0aW9ucyBvZiBuZXcgbWV0aG9kcy4KKyAgICAgICAgKFdlYkNvcmU6 OkVtcHR5Q29udGV4dE1lbnVDbGllbnQ6OmNyZWF0ZVBsYXRmb3JtRGVzY3JpcHRpb24pOgorICAg ICAgICAoV2ViQ29yZTo6RW1wdHlDb250ZXh0TWVudUNsaWVudDo6ZnJlZVBsYXRmb3JtRGVzY3Jp cHRpb24pOgorICAgICAgICAoV2ViQ29yZTo6RW1wdHlDb250ZXh0TWVudUNsaWVudDo6YXBwZW5k SXRlbSk6CisgICAgICAgIChXZWJDb3JlOjpFbXB0eUNvbnRleHRNZW51Q2xpZW50OjpzaG93KToK KyAgICAgICAgKiBwYWdlL0NvbnRleHRNZW51Q2xpZW50Lmg6IE1vdmUgbWV0aG9kcyBmcm9tIENv bnRleHRNZW51Q2xpZW50RWZsIHRvCisgICAgICAgIHRoaXMgY2xhc3MuCisgICAgICAgICogcGxh dGZvcm0vQ29udGV4dE1lbnUuaDogQ2xpZW50IG1lbWJlciBoYXMgQ29udGV4dE1lbnVDbGllbnQg dHlwZS4KKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvQ29udGV4dE1lbnVFZmwuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6Q29udGV4dE1lbnU6OkNvbnRleHRNZW51KToKKwogMjAxMC0wOC0yNyAgRGly ayBTY2h1bHplICA8a3JpdEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5pa29s YXMgWmltbWVybWFubi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvbG9hZGVyL0VtcHR5Q2xpZW50cy5o IGIvV2ViQ29yZS9sb2FkZXIvRW1wdHlDbGllbnRzLmgKaW5kZXggMjcwNzUyZGQ3ZjhmMDFmYTk0 ZjdjMjkzZDNjZmU3ZmE5NWVkMjkxZi4uOGU0YmViYzM5MjI5OGRjODU3ZDc1MzVmY2VhZGZmODRh MWNhZWNiZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9sb2FkZXIvRW1wdHlDbGllbnRzLmgKKysrIGIv V2ViQ29yZS9sb2FkZXIvRW1wdHlDbGllbnRzLmgKQEAgLTQ5MCw2ICs0OTAsMTEgQEAgcHVibGlj OgogCiAjaWYgUExBVEZPUk0oTUFDKQogICAgIHZpcnR1YWwgdm9pZCBzZWFyY2hXaXRoU3BvdGxp Z2h0KCkgeyB9CisjZWxpZiBQTEFURk9STShFRkwpCisgICAgdmlydHVhbCBQbGF0Zm9ybU1lbnVE ZXNjcmlwdGlvbiBjcmVhdGVQbGF0Zm9ybURlc2NyaXB0aW9uKENvbnRleHRNZW51KikgeyByZXR1 cm4gMDsgfQorICAgIHZpcnR1YWwgdm9pZCBmcmVlUGxhdGZvcm1EZXNjcmlwdGlvbihQbGF0Zm9y bU1lbnVEZXNjcmlwdGlvbikgeyB9CisgICAgdmlydHVhbCB2b2lkIGFwcGVuZEl0ZW0oUGxhdGZv cm1NZW51RGVzY3JpcHRpb24sIENvbnRleHRNZW51SXRlbSYpIHsgfQorICAgIHZpcnR1YWwgdm9p ZCBzaG93KFBsYXRmb3JtTWVudURlc2NyaXB0aW9uIG1lbnUpIHsgfQogI2VuZGlmCiB9OwogI2Vu ZGlmIC8vIEVOQUJMRShDT05URVhUX01FTlVTKQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdlL0Nv bnRleHRNZW51Q2xpZW50LmggYi9XZWJDb3JlL3BhZ2UvQ29udGV4dE1lbnVDbGllbnQuaAppbmRl eCBmOTE1MzZiNWM1OTk5ZmYzMTBhOGE5NjYwYTA3NTI3ODczYjMzM2MwLi44MGZkZWY1ODJhMThi MTQ3YmFlY2M2NmQ1NzhlZmI2MzEwNDgxN2JhIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BhZ2UvQ29u dGV4dE1lbnVDbGllbnQuaAorKysgYi9XZWJDb3JlL3BhZ2UvQ29udGV4dE1lbnVDbGllbnQuaApA QCAtNTMsNiArNTMsMTEgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiAjaWYgUExBVEZPUk0oTUFD KQogICAgICAgICB2aXJ0dWFsIHZvaWQgc2VhcmNoV2l0aFNwb3RsaWdodCgpID0gMDsKKyNlbGlm IFBMQVRGT1JNKEVGTCkKKyAgICAgICAgdmlydHVhbCBQbGF0Zm9ybU1lbnVEZXNjcmlwdGlvbiBj cmVhdGVQbGF0Zm9ybURlc2NyaXB0aW9uKENvbnRleHRNZW51KikgPSAwOworICAgICAgICB2aXJ0 dWFsIHZvaWQgZnJlZVBsYXRmb3JtRGVzY3JpcHRpb24oUGxhdGZvcm1NZW51RGVzY3JpcHRpb24p ID0gMDsKKyAgICAgICAgdmlydHVhbCB2b2lkIGFwcGVuZEl0ZW0oUGxhdGZvcm1NZW51RGVzY3Jp cHRpb24sIENvbnRleHRNZW51SXRlbSYpID0gMDsKKyAgICAgICAgdmlydHVhbCB2b2lkIHNob3co UGxhdGZvcm1NZW51RGVzY3JpcHRpb24gbWVudSkgPSAwOwogI2VuZGlmCiAgICAgfTsKIH0KZGlm ZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vQ29udGV4dE1lbnUuaCBiL1dlYkNvcmUvcGxhdGZv cm0vQ29udGV4dE1lbnUuaAppbmRleCBjYTIxZjI5ZGVjNTMxNDEyYWNlNDk3YTE0NjIxNDAyMGQ5 OTg5ZmJjLi5kYWYwYTI3ZWU3NDNjOGZlY2YzNzIyMzIwYzE1MTk0ZjExZGU3NGNlIDEwMDY0NAot LS0gYS9XZWJDb3JlL3BsYXRmb3JtL0NvbnRleHRNZW51LmgKKysrIGIvV2ViQ29yZS9wbGF0Zm9y bS9Db250ZXh0TWVudS5oCkBAIC00MSw5ICs0MSw3IEBACiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAK ICAgICBjbGFzcyBDb250ZXh0TWVudUNvbnRyb2xsZXI7Ci0jaWYgUExBVEZPUk0oRUZMKQotICAg IGNsYXNzIENvbnRleHRNZW51Q2xpZW50RWZsOwotI2VuZGlmCisgICAgY2xhc3MgQ29udGV4dE1l bnVDbGllbnQ7CiAKICAgICBjbGFzcyBDb250ZXh0TWVudSA6IHB1YmxpYyBOb25jb3B5YWJsZQog ICAgIHsKQEAgLTg0LDcgKzgyLDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogI2VsaWYgUExBVEZP Uk0oQ0hST01JVU0pCiAgICAgICAgIFZlY3RvcjxDb250ZXh0TWVudUl0ZW0+IG1faXRlbXM7CiAj ZWxpZiBQTEFURk9STShFRkwpCi0gICAgICAgIENvbnRleHRNZW51Q2xpZW50RWZsKiBtX2NvbnRl eHRNZW51Q2xpZW50OworICAgICAgICBDb250ZXh0TWVudUNsaWVudCogbV9jb250ZXh0TWVudUNs aWVudDsKICAgICAgICAgUGxhdGZvcm1NZW51RGVzY3JpcHRpb24gbV9wbGF0Zm9ybURlc2NyaXB0 aW9uOwogI2Vsc2UKICAgICAgICAgUGxhdGZvcm1NZW51RGVzY3JpcHRpb24gbV9wbGF0Zm9ybURl c2NyaXB0aW9uOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvQ29udGV4dE1lbnVF ZmwuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvQ29udGV4dE1lbnVFZmwuY3BwCmluZGV4IDhk ODU2MDgzYmFkNDQ5YmUyMjA0MGI5OTE4YWVjYzFhOTdiZjFjZGEuLmUyNGIzYzI4YmFkMTdiYTM4 YjQyNmQ5MGI2YjU2ZTFiNTkzNjk2NWYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZWZs L0NvbnRleHRNZW51RWZsLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2VmbC9Db250ZXh0TWVu dUVmbC5jcHAKQEAgLTIzLDcgKzIzLDYgQEAKICNpbmNsdWRlICJDb250ZXh0TWVudS5oIgogCiAj aW5jbHVkZSAiQ29udGV4dE1lbnVDbGllbnQuaCIKLSNpbmNsdWRlICJDb250ZXh0TWVudUNsaWVu dEVmbC5oIgogI2luY2x1ZGUgIkNvbnRleHRNZW51Q29udHJvbGxlci5oIgogI2luY2x1ZGUgIk5v dEltcGxlbWVudGVkLmgiCiAKQEAgLTMyLDcgKzMxLDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewog Q29udGV4dE1lbnU6OkNvbnRleHRNZW51KGNvbnN0IEhpdFRlc3RSZXN1bHQmIHJlc3VsdCkKICAg ICA6IG1faGl0VGVzdFJlc3VsdChyZXN1bHQpCiB7Ci0gICAgbV9jb250ZXh0TWVudUNsaWVudCA9 IHN0YXRpY19jYXN0PENvbnRleHRNZW51Q2xpZW50RWZsKj4oY29udHJvbGxlcigpLT5jbGllbnQo KSk7CisgICAgbV9jb250ZXh0TWVudUNsaWVudCA9IGNvbnRyb2xsZXIoKS0+Y2xpZW50KCk7CiAg ICAgbV9wbGF0Zm9ybURlc2NyaXB0aW9uID0gbV9jb250ZXh0TWVudUNsaWVudC0+Y3JlYXRlUGxh dGZvcm1EZXNjcmlwdGlvbih0aGlzKTsKIH0KIApAQCAtNDAsNyArMzksNyBAQCBDb250ZXh0TWVu dTo6Q29udGV4dE1lbnUoY29uc3QgSGl0VGVzdFJlc3VsdCYgcmVzdWx0LCBjb25zdCBQbGF0Zm9y bU1lbnVEZXNjcmlwdAogICAgIDogbV9oaXRUZXN0UmVzdWx0KHJlc3VsdCkKICAgICAsIG1fcGxh dGZvcm1EZXNjcmlwdGlvbihtZW51KQogewotICAgIG1fY29udGV4dE1lbnVDbGllbnQgPSBzdGF0 aWNfY2FzdDxDb250ZXh0TWVudUNsaWVudEVmbCo+KGNvbnRyb2xsZXIoKS0+Y2xpZW50KCkpOwor ICAgIG1fY29udGV4dE1lbnVDbGllbnQgPSBjb250cm9sbGVyKCktPmNsaWVudCgpOwogfQogCiBD b250ZXh0TWVudTo6fkNvbnRleHRNZW51KCkKZGlmZiAtLWdpdCBhL1dlYktpdC9lZmwvQ2hhbmdl TG9nIGIvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggYzE4NTQ5YjFmY2UxODliNTcwMjMxNTIz MjJkMDg2N2Y0OGM4NmUwMC4uYzIxMTE0YTdmZTljZGQwZGVhZWUyNGUwMzE1YmRjNzA5MDdjMWNh OSAxMDA2NDQKLS0tIGEvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2VmbC9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wOC0yNyAgTHVjYXMgRGUgTWFyY2hpICA8bHVj YXMuZGVtYXJjaGlAcHJvZnVzaW9uLm1vYmk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgW0VGTF0gV2ViQ29yZSBkZXBlbmRzIG9uIHN5bWJvbHMgZnJv bSBXZWJLaXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQ0NzY3CisKKyAgICAgICAgUmVmYWN0b3IgQ29udGV4dE1lbnVDbGllbnQgaW1wbGVtZW50YXRp b24gaW4gRUZMIHBvcnQgc28gV2ViQ29yZSBkb2VzIG5vdAorICAgICAgICBkZXBlbmQgb24gYW55 IHN5bWJvbCBmcm9tIFdlYktpdC4gVGhpcyBpcyBkb25lIGJ5IG1vdmluZyBzb21lIG1ldGhvZHMK KyAgICAgICAgZGVmaW5lZCBpbiBDb250ZXh0TWVudUNsaWVudEVmbCBjbGFzcyB0byBDb250ZXh0 TWVudUNsaWVudCAoZ3VhcmRlZCBieQorICAgICAgICBpZmRlZikuCisKKyAgICAgICAgKiBXZWJD b3JlU3VwcG9ydC9Db250ZXh0TWVudUNsaWVudEVmbC5oOiBSZW1vdmUgbWV0aG9kcyB0byBtb3Zl ZCB0bworICAgICAgICBXZWJDb3JlLgorCiAyMDEwLTA4LTI2ICBNaXJvc2xhdyBTenltYW5za2kg IDxtaXJvc2xhdy5zQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGgg Um9oZGUgQ2hyaXN0aWFuc2VuLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9y dC9Db250ZXh0TWVudUNsaWVudEVmbC5oIGIvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9Db250 ZXh0TWVudUNsaWVudEVmbC5oCmluZGV4IDhhMjg5YTFkY2IxM2I1Yzk1NmI3ODEzNjYxYmJiNzM0 Y2RlMjgyNjQuLjkxNzk0NDMwN2NjYTIxNTU1MzMwYjIzNGViODExMGU4OGE3NzY2NDggMTAwNjQ0 Ci0tLSBhL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQ29udGV4dE1lbnVDbGllbnRFZmwuaAor KysgYi9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0NvbnRleHRNZW51Q2xpZW50RWZsLmgKQEAg LTUwLDEwICs1MCwxMCBAQCBjbGFzcyBDb250ZXh0TWVudUNsaWVudEVmbCA6IHB1YmxpYyBDb250 ZXh0TWVudUNsaWVudCB7CiAgICAgdmlydHVhbCBib29sIGlzU3BlYWtpbmcoKTsKICAgICB2aXJ0 dWFsIHZvaWQgc3RvcFNwZWFraW5nKCk7CiAKLSAgICBQbGF0Zm9ybU1lbnVEZXNjcmlwdGlvbiBj cmVhdGVQbGF0Zm9ybURlc2NyaXB0aW9uKENvbnRleHRNZW51Kik7Ci0gICAgdm9pZCBmcmVlUGxh dGZvcm1EZXNjcmlwdGlvbihQbGF0Zm9ybU1lbnVEZXNjcmlwdGlvbik7Ci0gICAgdm9pZCBhcHBl bmRJdGVtKFBsYXRmb3JtTWVudURlc2NyaXB0aW9uLCBDb250ZXh0TWVudUl0ZW0mKTsKLSAgICB2 b2lkIHNob3coUGxhdGZvcm1NZW51RGVzY3JpcHRpb24gbWVudSk7CisgICAgdmlydHVhbCBQbGF0 Zm9ybU1lbnVEZXNjcmlwdGlvbiBjcmVhdGVQbGF0Zm9ybURlc2NyaXB0aW9uKENvbnRleHRNZW51 Kik7CisgICAgdmlydHVhbCB2b2lkIGZyZWVQbGF0Zm9ybURlc2NyaXB0aW9uKFBsYXRmb3JtTWVu dURlc2NyaXB0aW9uKTsKKyAgICB2aXJ0dWFsIHZvaWQgYXBwZW5kSXRlbShQbGF0Zm9ybU1lbnVE ZXNjcmlwdGlvbiwgQ29udGV4dE1lbnVJdGVtJik7CisgICAgdmlydHVhbCB2b2lkIHNob3coUGxh dGZvcm1NZW51RGVzY3JpcHRpb24gbWVudSk7CiAgcHJpdmF0ZToKICAgICBFdmFzX09iamVjdCog bV92aWV3OwogfTsK