44761 2010-08-27 05:21:34 -0700 [Qt] tst_QWebView::focusInputTypes() fails on MeeGo Handset with WebKit 2.1 2010-09-27 07:58:34 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other Other RESOLVED FIXED Qt, QtTriaged P2 Major --- 44675 1 benjamin benjamin ademar commit-queue oldest_to_newest 270434 0 benjamin 2010-08-27 05:21:34 -0700 The test tst_QWebView::focusInputTypes() is not reliable on Meego Handset. Output of the bot: FAIL! : tst_QWebView::focusInputTypes() 'webView->inputMethodHints() == Qt::ImhHiddenText' returned FALSE. () 270438 1 65703 benjamin 2010-08-27 05:28:00 -0700 Created attachment 65703 Make the test more robust On my hardware, this fixes the problems with webView.inputMethodHints(). However, I still have random failures out of QVERIFY(webView.testAttribute(Qt::WA_InputMethodEnabled)). Those cannot be reproduced in gdb so I suspect a race condition. The test bot has a different environment, we'll see if this patch fixes the failure. 270440 2 65703 tonikitoo 2010-08-27 05:30:53 -0700 Comment on attachment 65703 Make the test more robust Good work! 270926 3 65703 commit-queue 2010-08-27 22:18:55 -0700 Comment on attachment 65703 Make the test more robust Clearing flags on attachment: 65703 Committed r66298: <http://trac.webkit.org/changeset/66298> 270927 4 commit-queue 2010-08-27 22:18:59 -0700 All reviewed patches have been landed. Closing bug. 271501 5 ademar 2010-08-30 10:32:39 -0700 Revision r66298 cherry-picked into qtwebkit-2.1 with commit 7c8ea628dd2c7d5c05e1682059d6178b2f8bc7e6 285456 6 68911 benjamin 2010-09-27 07:53:20 -0700 Created attachment 68911 Improve the test further The test still fails on the test bots for an unknown reason. I hope to get more info from the output with this patch while still improving the test. Using QCOMPARE() instead of QVERIFY() will output the return value so will help identifying the issue. Adding the "hasFocus()" on each element will help identifying if the element got the focus at all on the device. 65703 2010-08-27 05:28:00 -0700 2010-08-27 22:18:55 -0700 Make the test more robust 44761.patch text/plain 8535 benjamin ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IDk5NjllYmQuLjBkODQyNTYgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEwLTA4LTI3ICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW4ucG91bGFpbkBub2tpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSB0c3RfUVdlYlZpZXc6OmZv Y3VzSW5wdXRUeXBlcygpIGZhaWxzIG9uIE1lZUdvIEhhbmRzZXQgd2l0aCBXZWJLaXQgMi4xCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDc2MQorCisg ICAgICAgIE1ha2UgdGhlIHRlc3QgbW9yZSByb2J1c3QgdG8gY2hhbmdlcyBpbiB0aGUgZXhlY3V0 aW9uIGVudmlyb25tZW50LiBUaGUgY2xpY2sKKyAgICAgICAgYXJlIG5vdyBjb3JyZWN0bHkgc2lt dWxhdGVkLCBhbmQgdGhlIHBvc2l0aW9uIGFyZSBkZXRlcm1pbmVkIGZyb20gdGhlIGNvbnRlbnQu CisKKyAgICAgICAgVGhlIHRlc3QgYWxzbyBjcmVhdGUgdGhlIHZpZXcgYW5kIHBhZ2Ugb24gdGhl IHN0YWNrIHRvIGF2b2lkIHRoZSBsZWFrIHdoZW4gdGhlCisgICAgICAgIHRlc3QgaXMgZmFpbGlu Zy4KKworICAgICAgICAqIHRlc3RzL3F3ZWJ2aWV3L3RzdF9xd2Vidmlldy5jcHA6CisgICAgICAg ICh0c3RfUVdlYlZpZXc6OmZvY3VzSW5wdXRUeXBlcyk6CisKIDIwMTAtMDgtMjUgIExlbyBZYW5n ICA8bGVvLnlhbmdAdG9yY2htb2JpbGUuY29tLmNuPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNp bW9uIEhhdXNtYW5uLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJ2aWV3L3RzdF9x d2Vidmlldy5jcHAgYi9XZWJLaXQvcXQvdGVzdHMvcXdlYnZpZXcvdHN0X3F3ZWJ2aWV3LmNwcApp bmRleCA1N2Y3MjZkLi5mZDQ5NzhkIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvdGVzdHMvcXdlYnZp ZXcvdHN0X3F3ZWJ2aWV3LmNwcAorKysgYi9XZWJLaXQvcXQvdGVzdHMvcXdlYnZpZXcvdHN0X3F3 ZWJ2aWV3LmNwcApAQCAtMjgsNiArMjgsNyBAQAogI2luY2x1ZGUgPHFuZXR3b3JrcmVxdWVzdC5o PgogI2luY2x1ZGUgPHFkaXJpdGVyYXRvci5oPgogI2luY2x1ZGUgPHF3ZWJraXR2ZXJzaW9uLmg+ CisjaW5jbHVkZSA8cXdlYmVsZW1lbnQuaD4KICNpbmNsdWRlIDxxd2ViZnJhbWUuaD4KIAogY2xh c3MgdHN0X1FXZWJWaWV3IDogcHVibGljIFFPYmplY3QKQEAgLTUyLDIwICs1Myw2IEBAIHByaXZh dGUgc2xvdHM6CiAgICAgdm9pZCBjcmFzaFRlc3RzKCk7CiB9OwogCi1jbGFzcyBXZWJWaWV3IDog cHVibGljIFFXZWJWaWV3Ci17Ci0gICAgUV9PQkpFQ1QKLQotcHVibGljOgotICAgIHZvaWQgZmly ZU1vdXNlQ2xpY2soUVBvaW50IHBvaW50KSB7Ci0gICAgICAgIFFNb3VzZUV2ZW50IHByZXNFdihR RXZlbnQ6Ok1vdXNlQnV0dG9uUHJlc3MsIHBvaW50LCBRdDo6TGVmdEJ1dHRvbiwgUXQ6OkxlZnRC dXR0b24sIFF0OjpOb01vZGlmaWVyKTsKLSAgICAgICAgUU1vdXNlRXZlbnQgcmVsRXYoUUV2ZW50 OjpNb3VzZUJ1dHRvblJlbGVhc2UsIHBvaW50LCBRdDo6TGVmdEJ1dHRvbiwgUXQ6OkxlZnRCdXR0 b24sIFF0OjpOb01vZGlmaWVyKTsKLSAgICAgICAgUVdlYlZpZXc6Om1vdXNlUHJlc3NFdmVudCgm cHJlc0V2KTsKLSAgICAgICAgUVdlYlZpZXc6Om1vdXNlUHJlc3NFdmVudCgmcmVsRXYpOwotICAg IH0KLQotfTsKLQogLy8gVGhpcyB3aWxsIGJlIGNhbGxlZCBiZWZvcmUgdGhlIGZpcnN0IHRlc3Qg ZnVuY3Rpb24gaXMgZXhlY3V0ZWQuCiAvLyBJdCBpcyBvbmx5IGNhbGxlZCBvbmNlLgogdm9pZCB0 c3RfUVdlYlZpZXc6OmluaXRUZXN0Q2FzZSgpCkBAIC0yNDUsNzkgKzIzMiw4NiBAQCB2b2lkIHRz dF9RV2ViVmlldzo6bWljcm9Gb2N1c0Nvb3JkaW5hdGVzKCkKIAogdm9pZCB0c3RfUVdlYlZpZXc6 OmZvY3VzSW5wdXRUeXBlcygpCiB7Ci0gICAgUVdlYlBhZ2UqIHBhZ2UgPSBuZXcgUVdlYlBhZ2U7 Ci0gICAgV2ViVmlldyogd2ViVmlldyA9IG5ldyBXZWJWaWV3OwotICAgIHdlYlZpZXctPnNldFBh Z2UoIHBhZ2UgKTsKKyAgICBRV2ViVmlldyB3ZWJWaWV3OworICAgIHdlYlZpZXcuc2hvdygpOwor ICAgIFFUZXN0OjpxV2FpdEZvcldpbmRvd1Nob3duKCZ3ZWJWaWV3KTsKIAotICAgIFFDb3JlQXBw bGljYXRpb246OnByb2Nlc3NFdmVudHMoKTsKICAgICBRVXJsIHVybCgicXJjOi8vL3Jlc291cmNl cy9pbnB1dF90eXBlcy5odG1sIik7Ci0gICAgcGFnZS0+bWFpbkZyYW1lKCktPmxvYWQodXJsKTsK LSAgICBwYWdlLT5tYWluRnJhbWUoKS0+c2V0Rm9jdXMoKTsKKyAgICBRV2ViRnJhbWUqIGNvbnN0 IG1haW5GcmFtZSA9IHdlYlZpZXcucGFnZSgpLT5tYWluRnJhbWUoKTsKKyAgICBtYWluRnJhbWUt PmxvYWQodXJsKTsKKyAgICBtYWluRnJhbWUtPnNldEZvY3VzKCk7CiAKLSAgICBRVkVSSUZZKHdh aXRGb3JTaWduYWwocGFnZSwgU0lHTkFMKGxvYWRGaW5pc2hlZChib29sKSkpKTsKKyAgICBRVkVS SUZZKHdhaXRGb3JTaWduYWwoJndlYlZpZXcsIFNJR05BTChsb2FkRmluaXNoZWQoYm9vbCkpKSk7 CiAKICAgICAvLyAndGV4dCcgdHlwZQotICAgIHdlYlZpZXctPmZpcmVNb3VzZUNsaWNrKFFQb2lu dCgyMCwgMTApKTsKKyAgICBRV2ViRWxlbWVudCBpbnB1dEVsZW1lbnQgPSBtYWluRnJhbWUtPmRv Y3VtZW50RWxlbWVudCgpLmZpbmRGaXJzdChRTGF0aW4xU3RyaW5nKCJpbnB1dFt0eXBlPXRleHRd IikpOworICAgIFFUZXN0Ojptb3VzZUNsaWNrKCZ3ZWJWaWV3LCBRdDo6TGVmdEJ1dHRvbiwgMCwg aW5wdXRFbGVtZW50Lmdlb21ldHJ5KCkuY2VudGVyKCkpOwogI2lmIGRlZmluZWQoUV9XU19NQUVN T181KSB8fCBkZWZpbmVkKFFfV1NfTUFFTU9fNikgfHwgZGVmaW5lZChRX09TX1NZTUJJQU4pCi0g ICAgUVZFUklGWSh3ZWJWaWV3LT5pbnB1dE1ldGhvZEhpbnRzKCkgJiBRdDo6SW1oTm9BdXRvVXBw ZXJjYXNlKTsKLSAgICBRVkVSSUZZKHdlYlZpZXctPmlucHV0TWV0aG9kSGludHMoKSAmIFF0OjpJ bWhOb1ByZWRpY3RpdmVUZXh0KTsKKyAgICBRVkVSSUZZKHdlYlZpZXcuaW5wdXRNZXRob2RIaW50 cygpICYgUXQ6OkltaE5vQXV0b1VwcGVyY2FzZSk7CisgICAgUVZFUklGWSh3ZWJWaWV3LmlucHV0 TWV0aG9kSGludHMoKSAmIFF0OjpJbWhOb1ByZWRpY3RpdmVUZXh0KTsKICNlbHNlCi0gICAgUVZF UklGWSh3ZWJWaWV3LT5pbnB1dE1ldGhvZEhpbnRzKCkgPT0gUXQ6OkltaE5vbmUpOworICAgIFFW RVJJRlkod2ViVmlldy5pbnB1dE1ldGhvZEhpbnRzKCkgPT0gUXQ6OkltaE5vbmUpOwogI2VuZGlm Ci0gICAgUVZFUklGWSh3ZWJWaWV3LT50ZXN0QXR0cmlidXRlKFF0OjpXQV9JbnB1dE1ldGhvZEVu YWJsZWQpKTsKKyAgICBRVkVSSUZZKHdlYlZpZXcudGVzdEF0dHJpYnV0ZShRdDo6V0FfSW5wdXRN ZXRob2RFbmFibGVkKSk7CiAKICAgICAvLyAncGFzc3dvcmQnIGZpZWxkCi0gICAgd2ViVmlldy0+ ZmlyZU1vdXNlQ2xpY2soUVBvaW50KDIwLCA2MCkpOwotICAgIFFWRVJJRlkod2ViVmlldy0+aW5w dXRNZXRob2RIaW50cygpID09IFF0OjpJbWhIaWRkZW5UZXh0KTsKLSAgICBRVkVSSUZZKHdlYlZp ZXctPnRlc3RBdHRyaWJ1dGUoUXQ6OldBX0lucHV0TWV0aG9kRW5hYmxlZCkpOworICAgIGlucHV0 RWxlbWVudCA9IG1haW5GcmFtZS0+ZG9jdW1lbnRFbGVtZW50KCkuZmluZEZpcnN0KFFMYXRpbjFT dHJpbmcoImlucHV0W3R5cGU9cGFzc3dvcmRdIikpOworICAgIFFUZXN0Ojptb3VzZUNsaWNrKCZ3 ZWJWaWV3LCBRdDo6TGVmdEJ1dHRvbiwgMCwgaW5wdXRFbGVtZW50Lmdlb21ldHJ5KCkuY2VudGVy KCkpOworICAgIFFWRVJJRlkod2ViVmlldy5pbnB1dE1ldGhvZEhpbnRzKCkgPT0gUXQ6OkltaEhp ZGRlblRleHQpOworICAgIFFWRVJJRlkod2ViVmlldy50ZXN0QXR0cmlidXRlKFF0OjpXQV9JbnB1 dE1ldGhvZEVuYWJsZWQpKTsKIAogICAgIC8vICd0ZWwnIGZpZWxkCi0gICAgd2ViVmlldy0+Zmly ZU1vdXNlQ2xpY2soUVBvaW50KDIwLCAxMTApKTsKLSAgICBRVkVSSUZZKHdlYlZpZXctPmlucHV0 TWV0aG9kSGludHMoKSA9PSBRdDo6SW1oRGlhbGFibGVDaGFyYWN0ZXJzT25seSk7Ci0gICAgUVZF UklGWSh3ZWJWaWV3LT50ZXN0QXR0cmlidXRlKFF0OjpXQV9JbnB1dE1ldGhvZEVuYWJsZWQpKTsK KyAgICBpbnB1dEVsZW1lbnQgPSBtYWluRnJhbWUtPmRvY3VtZW50RWxlbWVudCgpLmZpbmRGaXJz dChRTGF0aW4xU3RyaW5nKCJpbnB1dFt0eXBlPXRlbF0iKSk7CisgICAgUVRlc3Q6Om1vdXNlQ2xp Y2soJndlYlZpZXcsIFF0OjpMZWZ0QnV0dG9uLCAwLCBpbnB1dEVsZW1lbnQuZ2VvbWV0cnkoKS5j ZW50ZXIoKSk7CisgICAgUVZFUklGWSh3ZWJWaWV3LmlucHV0TWV0aG9kSGludHMoKSA9PSBRdDo6 SW1oRGlhbGFibGVDaGFyYWN0ZXJzT25seSk7CisgICAgUVZFUklGWSh3ZWJWaWV3LnRlc3RBdHRy aWJ1dGUoUXQ6OldBX0lucHV0TWV0aG9kRW5hYmxlZCkpOwogCiAgICAgLy8gJ251bWJlcicgZmll bGQKLSAgICB3ZWJWaWV3LT5maXJlTW91c2VDbGljayhRUG9pbnQoMjAsIDE2MCkpOwotICAgIFFW RVJJRlkod2ViVmlldy0+aW5wdXRNZXRob2RIaW50cygpID09IFF0OjpJbWhEaWdpdHNPbmx5KTsK LSAgICBRVkVSSUZZKHdlYlZpZXctPnRlc3RBdHRyaWJ1dGUoUXQ6OldBX0lucHV0TWV0aG9kRW5h YmxlZCkpOworICAgIGlucHV0RWxlbWVudCA9IG1haW5GcmFtZS0+ZG9jdW1lbnRFbGVtZW50KCku ZmluZEZpcnN0KFFMYXRpbjFTdHJpbmcoImlucHV0W3R5cGU9bnVtYmVyXSIpKTsKKyAgICBRVGVz dDo6bW91c2VDbGljaygmd2ViVmlldywgUXQ6OkxlZnRCdXR0b24sIDAsIGlucHV0RWxlbWVudC5n ZW9tZXRyeSgpLmNlbnRlcigpKTsKKyAgICBRVkVSSUZZKHdlYlZpZXcuaW5wdXRNZXRob2RIaW50 cygpID09IFF0OjpJbWhEaWdpdHNPbmx5KTsKKyAgICBRVkVSSUZZKHdlYlZpZXcudGVzdEF0dHJp YnV0ZShRdDo6V0FfSW5wdXRNZXRob2RFbmFibGVkKSk7CiAKICAgICAvLyAnZW1haWwnIGZpZWxk Ci0gICAgd2ViVmlldy0+ZmlyZU1vdXNlQ2xpY2soUVBvaW50KDIwLCAyMTApKTsKLSAgICBRVkVS SUZZKHdlYlZpZXctPmlucHV0TWV0aG9kSGludHMoKSA9PSBRdDo6SW1oRW1haWxDaGFyYWN0ZXJz T25seSk7Ci0gICAgUVZFUklGWSh3ZWJWaWV3LT50ZXN0QXR0cmlidXRlKFF0OjpXQV9JbnB1dE1l dGhvZEVuYWJsZWQpKTsKKyAgICBpbnB1dEVsZW1lbnQgPSBtYWluRnJhbWUtPmRvY3VtZW50RWxl bWVudCgpLmZpbmRGaXJzdChRTGF0aW4xU3RyaW5nKCJpbnB1dFt0eXBlPWVtYWlsXSIpKTsKKyAg ICBRVGVzdDo6bW91c2VDbGljaygmd2ViVmlldywgUXQ6OkxlZnRCdXR0b24sIDAsIGlucHV0RWxl bWVudC5nZW9tZXRyeSgpLmNlbnRlcigpKTsKKyAgICBRVkVSSUZZKHdlYlZpZXcuaW5wdXRNZXRo b2RIaW50cygpID09IFF0OjpJbWhFbWFpbENoYXJhY3RlcnNPbmx5KTsKKyAgICBRVkVSSUZZKHdl YlZpZXcudGVzdEF0dHJpYnV0ZShRdDo6V0FfSW5wdXRNZXRob2RFbmFibGVkKSk7CiAKICAgICAv LyAndXJsJyBmaWVsZAotICAgIHdlYlZpZXctPmZpcmVNb3VzZUNsaWNrKFFQb2ludCgyMCwgMjYw KSk7Ci0gICAgUVZFUklGWSh3ZWJWaWV3LT5pbnB1dE1ldGhvZEhpbnRzKCkgPT0gUXQ6OkltaFVy bENoYXJhY3RlcnNPbmx5KTsKLSAgICBRVkVSSUZZKHdlYlZpZXctPnRlc3RBdHRyaWJ1dGUoUXQ6 OldBX0lucHV0TWV0aG9kRW5hYmxlZCkpOworICAgIGlucHV0RWxlbWVudCA9IG1haW5GcmFtZS0+ ZG9jdW1lbnRFbGVtZW50KCkuZmluZEZpcnN0KFFMYXRpbjFTdHJpbmcoImlucHV0W3R5cGU9dXJs XSIpKTsKKyAgICBRVGVzdDo6bW91c2VDbGljaygmd2ViVmlldywgUXQ6OkxlZnRCdXR0b24sIDAs IGlucHV0RWxlbWVudC5nZW9tZXRyeSgpLmNlbnRlcigpKTsKKyAgICBRVkVSSUZZKHdlYlZpZXcu aW5wdXRNZXRob2RIaW50cygpID09IFF0OjpJbWhVcmxDaGFyYWN0ZXJzT25seSk7CisgICAgUVZF UklGWSh3ZWJWaWV3LnRlc3RBdHRyaWJ1dGUoUXQ6OldBX0lucHV0TWV0aG9kRW5hYmxlZCkpOwog CiAgICAgLy8gJ3Bhc3N3b3JkJyBmaWVsZAotICAgIHdlYlZpZXctPmZpcmVNb3VzZUNsaWNrKFFQ b2ludCgyMCwgNjApKTsKLSAgICBRVkVSSUZZKHdlYlZpZXctPmlucHV0TWV0aG9kSGludHMoKSA9 PSBRdDo6SW1oSGlkZGVuVGV4dCk7Ci0gICAgUVZFUklGWSh3ZWJWaWV3LT50ZXN0QXR0cmlidXRl KFF0OjpXQV9JbnB1dE1ldGhvZEVuYWJsZWQpKTsKKyAgICBpbnB1dEVsZW1lbnQgPSBtYWluRnJh bWUtPmRvY3VtZW50RWxlbWVudCgpLmZpbmRGaXJzdChRTGF0aW4xU3RyaW5nKCJpbnB1dFt0eXBl PXBhc3N3b3JkXSIpKTsKKyAgICBRVGVzdDo6bW91c2VDbGljaygmd2ViVmlldywgUXQ6OkxlZnRC dXR0b24sIDAsIGlucHV0RWxlbWVudC5nZW9tZXRyeSgpLmNlbnRlcigpKTsKKyAgICBRVkVSSUZZ KHdlYlZpZXcuaW5wdXRNZXRob2RIaW50cygpID09IFF0OjpJbWhIaWRkZW5UZXh0KTsKKyAgICBR VkVSSUZZKHdlYlZpZXcudGVzdEF0dHJpYnV0ZShRdDo6V0FfSW5wdXRNZXRob2RFbmFibGVkKSk7 CiAKICAgICAvLyAndGV4dCcgdHlwZQotICAgIHdlYlZpZXctPmZpcmVNb3VzZUNsaWNrKFFQb2lu dCgyMCwgMTApKTsKKyAgICBpbnB1dEVsZW1lbnQgPSBtYWluRnJhbWUtPmRvY3VtZW50RWxlbWVu dCgpLmZpbmRGaXJzdChRTGF0aW4xU3RyaW5nKCJpbnB1dFt0eXBlPXRleHRdIikpOworICAgIFFU ZXN0Ojptb3VzZUNsaWNrKCZ3ZWJWaWV3LCBRdDo6TGVmdEJ1dHRvbiwgMCwgaW5wdXRFbGVtZW50 Lmdlb21ldHJ5KCkuY2VudGVyKCkpOwogI2lmIGRlZmluZWQoUV9XU19NQUVNT181KSB8fCBkZWZp bmVkKFFfV1NfTUFFTU9fNikgfHwgZGVmaW5lZChRX09TX1NZTUJJQU4pCi0gICAgUVZFUklGWSh3 ZWJWaWV3LT5pbnB1dE1ldGhvZEhpbnRzKCkgJiBRdDo6SW1oTm9BdXRvVXBwZXJjYXNlKTsKLSAg ICBRVkVSSUZZKHdlYlZpZXctPmlucHV0TWV0aG9kSGludHMoKSAmIFF0OjpJbWhOb1ByZWRpY3Rp dmVUZXh0KTsKKyAgICBRVkVSSUZZKHdlYlZpZXcuaW5wdXRNZXRob2RIaW50cygpICYgUXQ6Oklt aE5vQXV0b1VwcGVyY2FzZSk7CisgICAgUVZFUklGWSh3ZWJWaWV3LmlucHV0TWV0aG9kSGludHMo KSAmIFF0OjpJbWhOb1ByZWRpY3RpdmVUZXh0KTsKICNlbHNlCi0gICAgUVZFUklGWSh3ZWJWaWV3 LT5pbnB1dE1ldGhvZEhpbnRzKCkgPT0gUXQ6OkltaE5vbmUpOworICAgIFFWRVJJRlkod2ViVmll dy5pbnB1dE1ldGhvZEhpbnRzKCkgPT0gUXQ6OkltaE5vbmUpOwogI2VuZGlmCi0gICAgUVZFUklG WSh3ZWJWaWV3LT50ZXN0QXR0cmlidXRlKFF0OjpXQV9JbnB1dE1ldGhvZEVuYWJsZWQpKTsKKyAg ICBRVkVSSUZZKHdlYlZpZXcudGVzdEF0dHJpYnV0ZShRdDo6V0FfSW5wdXRNZXRob2RFbmFibGVk KSk7CiAKICAgICAvLyAncGFzc3dvcmQnIGZpZWxkCi0gICAgd2ViVmlldy0+ZmlyZU1vdXNlQ2xp Y2soUVBvaW50KDIwLCA2MCkpOwotICAgIFFWRVJJRlkod2ViVmlldy0+aW5wdXRNZXRob2RIaW50 cygpID09IFF0OjpJbWhIaWRkZW5UZXh0KTsKLSAgICBRVkVSSUZZKHdlYlZpZXctPnRlc3RBdHRy aWJ1dGUoUXQ6OldBX0lucHV0TWV0aG9kRW5hYmxlZCkpOworICAgIGlucHV0RWxlbWVudCA9IG1h aW5GcmFtZS0+ZG9jdW1lbnRFbGVtZW50KCkuZmluZEZpcnN0KFFMYXRpbjFTdHJpbmcoImlucHV0 W3R5cGU9cGFzc3dvcmRdIikpOworICAgIFFUZXN0Ojptb3VzZUNsaWNrKCZ3ZWJWaWV3LCBRdDo6 TGVmdEJ1dHRvbiwgMCwgaW5wdXRFbGVtZW50Lmdlb21ldHJ5KCkuY2VudGVyKCkpOworICAgIFFW RVJJRlkod2ViVmlldy5pbnB1dE1ldGhvZEhpbnRzKCkgPT0gUXQ6OkltaEhpZGRlblRleHQpOwor ICAgIFFWRVJJRlkod2ViVmlldy50ZXN0QXR0cmlidXRlKFF0OjpXQV9JbnB1dE1ldGhvZEVuYWJs ZWQpKTsKIAogICAgIC8vICd0ZXh0IGFyZWEnIGZpZWxkCi0gICAgd2ViVmlldy0+ZmlyZU1vdXNl Q2xpY2soUVBvaW50KDIwLCAzMjApKTsKLSAgICBRVkVSSUZZKHdlYlZpZXctPmlucHV0TWV0aG9k SGludHMoKSA9PSBRdDo6SW1oTm9uZSk7Ci0gICAgUVZFUklGWSh3ZWJWaWV3LT50ZXN0QXR0cmli dXRlKFF0OjpXQV9JbnB1dE1ldGhvZEVuYWJsZWQpKTsKLQotICAgIGRlbGV0ZSB3ZWJWaWV3Owot CisgICAgaW5wdXRFbGVtZW50ID0gbWFpbkZyYW1lLT5kb2N1bWVudEVsZW1lbnQoKS5maW5kRmly c3QoUUxhdGluMVN0cmluZygidGV4dGFyZWEiKSk7CisgICAgUVRlc3Q6Om1vdXNlQ2xpY2soJndl YlZpZXcsIFF0OjpMZWZ0QnV0dG9uLCAwLCBpbnB1dEVsZW1lbnQuZ2VvbWV0cnkoKS5jZW50ZXIo KSk7CisgICAgUVZFUklGWSh3ZWJWaWV3LmlucHV0TWV0aG9kSGludHMoKSA9PSBRdDo6SW1oTm9u ZSk7CisgICAgUVZFUklGWSh3ZWJWaWV3LnRlc3RBdHRyaWJ1dGUoUXQ6OldBX0lucHV0TWV0aG9k RW5hYmxlZCkpOwogfQogCiBRVEVTVF9NQUlOKHRzdF9RV2ViVmlldykK 68911 2010-09-27 07:53:20 -0700 2010-09-27 07:58:34 -0700 Improve the test further 44675.patch text/plain 5937 benjamin ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IGVkYzhlMjQuLjE4ZmZhOWMgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEwLTA5LTI3ICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW4ucG91bGFpbkBub2tpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSB0c3RfUVdlYlZpZXc6OmZv Y3VzSW5wdXRUeXBlcygpIGZhaWxzIG9uIE1lZUdvIEhhbmRzZXQgd2l0aCBXZWJLaXQgMi4xCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDc2MQorCisg ICAgICAgIEltcHJvdmUgdGhlIHRlc3QgYnkgdXNpbmcgUUNPTVBBUkUoKSB3aGVuIGFwcHJvcHJp YXRlLCBhbmQgY2hlY2tpbmcgaWYKKyAgICAgICAgdGhlIGVsZW1lbnQgZ290IHRoZSBmb2N1cyB3 aGVuIGNsaWNrZWQuCisKKyAgICAgICAgKiB0ZXN0cy9xd2Vidmlldy90c3RfcXdlYnZpZXcuY3Bw OgorICAgICAgICAodHN0X1FXZWJWaWV3Ojpmb2N1c0lucHV0VHlwZXMpOgorCiAyMDEwLTA5LTIz ICBBZGVtYXIgZGUgU291emEgUmVpcyBKciAgPGFkZW1hci5yZWlzQG9wZW5ib3NzYS5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCmRpZmYgLS1n aXQgYS9XZWJLaXQvcXQvdGVzdHMvcXdlYnZpZXcvdHN0X3F3ZWJ2aWV3LmNwcCBiL1dlYktpdC9x dC90ZXN0cy9xd2Vidmlldy90c3RfcXdlYnZpZXcuY3BwCmluZGV4IGY3MjE0MGEuLjg3OWFiNDgg MTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC90ZXN0cy9xd2Vidmlldy90c3RfcXdlYnZpZXcuY3BwCisr KyBiL1dlYktpdC9xdC90ZXN0cy9xd2Vidmlldy90c3RfcXdlYnZpZXcuY3BwCkBAIC0yNDYsNzIg KzI0Niw4MiBAQCB2b2lkIHRzdF9RV2ViVmlldzo6Zm9jdXNJbnB1dFR5cGVzKCkKICAgICAvLyAn dGV4dCcgdHlwZQogICAgIFFXZWJFbGVtZW50IGlucHV0RWxlbWVudCA9IG1haW5GcmFtZS0+ZG9j dW1lbnRFbGVtZW50KCkuZmluZEZpcnN0KFFMYXRpbjFTdHJpbmcoImlucHV0W3R5cGU9dGV4dF0i KSk7CiAgICAgUVRlc3Q6Om1vdXNlQ2xpY2soJndlYlZpZXcsIFF0OjpMZWZ0QnV0dG9uLCAwLCBp bnB1dEVsZW1lbnQuZ2VvbWV0cnkoKS5jZW50ZXIoKSk7CisgICAgUVRSWV9WRVJJRlkoaW5wdXRF bGVtZW50Lmhhc0ZvY3VzKCkpOwogI2lmIGRlZmluZWQoUV9XU19NQUVNT181KSB8fCBkZWZpbmVk KFFfV1NfTUFFTU9fNikgfHwgZGVmaW5lZChRX09TX1NZTUJJQU4pCiAgICAgUVZFUklGWSh3ZWJW aWV3LmlucHV0TWV0aG9kSGludHMoKSAmIFF0OjpJbWhOb0F1dG9VcHBlcmNhc2UpOwogICAgIFFW RVJJRlkod2ViVmlldy5pbnB1dE1ldGhvZEhpbnRzKCkgJiBRdDo6SW1oTm9QcmVkaWN0aXZlVGV4 dCk7CiAjZWxzZQotICAgIFFWRVJJRlkod2ViVmlldy5pbnB1dE1ldGhvZEhpbnRzKCkgPT0gUXQ6 OkltaE5vbmUpOworICAgIFFDT01QQVJFKHdlYlZpZXcuaW5wdXRNZXRob2RIaW50cygpLCBRdDo6 SW1oTm9uZSk7CiAjZW5kaWYKICAgICBRVkVSSUZZKHdlYlZpZXcudGVzdEF0dHJpYnV0ZShRdDo6 V0FfSW5wdXRNZXRob2RFbmFibGVkKSk7CiAKICAgICAvLyAncGFzc3dvcmQnIGZpZWxkCiAgICAg aW5wdXRFbGVtZW50ID0gbWFpbkZyYW1lLT5kb2N1bWVudEVsZW1lbnQoKS5maW5kRmlyc3QoUUxh dGluMVN0cmluZygiaW5wdXRbdHlwZT1wYXNzd29yZF0iKSk7CiAgICAgUVRlc3Q6Om1vdXNlQ2xp Y2soJndlYlZpZXcsIFF0OjpMZWZ0QnV0dG9uLCAwLCBpbnB1dEVsZW1lbnQuZ2VvbWV0cnkoKS5j ZW50ZXIoKSk7Ci0gICAgUVZFUklGWSh3ZWJWaWV3LmlucHV0TWV0aG9kSGludHMoKSA9PSBRdDo6 SW1oSGlkZGVuVGV4dCk7CisgICAgUVRSWV9WRVJJRlkoaW5wdXRFbGVtZW50Lmhhc0ZvY3VzKCkp OworICAgIFFDT01QQVJFKHdlYlZpZXcuaW5wdXRNZXRob2RIaW50cygpLCBRdDo6SW1oSGlkZGVu VGV4dCk7CiAgICAgUVZFUklGWSh3ZWJWaWV3LnRlc3RBdHRyaWJ1dGUoUXQ6OldBX0lucHV0TWV0 aG9kRW5hYmxlZCkpOwogCiAgICAgLy8gJ3RlbCcgZmllbGQKICAgICBpbnB1dEVsZW1lbnQgPSBt YWluRnJhbWUtPmRvY3VtZW50RWxlbWVudCgpLmZpbmRGaXJzdChRTGF0aW4xU3RyaW5nKCJpbnB1 dFt0eXBlPXRlbF0iKSk7CiAgICAgUVRlc3Q6Om1vdXNlQ2xpY2soJndlYlZpZXcsIFF0OjpMZWZ0 QnV0dG9uLCAwLCBpbnB1dEVsZW1lbnQuZ2VvbWV0cnkoKS5jZW50ZXIoKSk7Ci0gICAgUVZFUklG WSh3ZWJWaWV3LmlucHV0TWV0aG9kSGludHMoKSA9PSBRdDo6SW1oRGlhbGFibGVDaGFyYWN0ZXJz T25seSk7CisgICAgUVRSWV9WRVJJRlkoaW5wdXRFbGVtZW50Lmhhc0ZvY3VzKCkpOworICAgIFFD T01QQVJFKHdlYlZpZXcuaW5wdXRNZXRob2RIaW50cygpLCBRdDo6SW1oRGlhbGFibGVDaGFyYWN0 ZXJzT25seSk7CiAgICAgUVZFUklGWSh3ZWJWaWV3LnRlc3RBdHRyaWJ1dGUoUXQ6OldBX0lucHV0 TWV0aG9kRW5hYmxlZCkpOwogCiAgICAgLy8gJ251bWJlcicgZmllbGQKICAgICBpbnB1dEVsZW1l bnQgPSBtYWluRnJhbWUtPmRvY3VtZW50RWxlbWVudCgpLmZpbmRGaXJzdChRTGF0aW4xU3RyaW5n KCJpbnB1dFt0eXBlPW51bWJlcl0iKSk7CiAgICAgUVRlc3Q6Om1vdXNlQ2xpY2soJndlYlZpZXcs IFF0OjpMZWZ0QnV0dG9uLCAwLCBpbnB1dEVsZW1lbnQuZ2VvbWV0cnkoKS5jZW50ZXIoKSk7Ci0g ICAgUVZFUklGWSh3ZWJWaWV3LmlucHV0TWV0aG9kSGludHMoKSA9PSBRdDo6SW1oRGlnaXRzT25s eSk7CisgICAgUVRSWV9WRVJJRlkoaW5wdXRFbGVtZW50Lmhhc0ZvY3VzKCkpOworICAgIFFDT01Q QVJFKHdlYlZpZXcuaW5wdXRNZXRob2RIaW50cygpLCBRdDo6SW1oRGlnaXRzT25seSk7CiAgICAg UVZFUklGWSh3ZWJWaWV3LnRlc3RBdHRyaWJ1dGUoUXQ6OldBX0lucHV0TWV0aG9kRW5hYmxlZCkp OwogCiAgICAgLy8gJ2VtYWlsJyBmaWVsZAogICAgIGlucHV0RWxlbWVudCA9IG1haW5GcmFtZS0+ ZG9jdW1lbnRFbGVtZW50KCkuZmluZEZpcnN0KFFMYXRpbjFTdHJpbmcoImlucHV0W3R5cGU9ZW1h aWxdIikpOwogICAgIFFUZXN0Ojptb3VzZUNsaWNrKCZ3ZWJWaWV3LCBRdDo6TGVmdEJ1dHRvbiwg MCwgaW5wdXRFbGVtZW50Lmdlb21ldHJ5KCkuY2VudGVyKCkpOwotICAgIFFWRVJJRlkod2ViVmll dy5pbnB1dE1ldGhvZEhpbnRzKCkgPT0gUXQ6OkltaEVtYWlsQ2hhcmFjdGVyc09ubHkpOworICAg IFFUUllfVkVSSUZZKGlucHV0RWxlbWVudC5oYXNGb2N1cygpKTsKKyAgICBRQ09NUEFSRSh3ZWJW aWV3LmlucHV0TWV0aG9kSGludHMoKSwgUXQ6OkltaEVtYWlsQ2hhcmFjdGVyc09ubHkpOwogICAg IFFWRVJJRlkod2ViVmlldy50ZXN0QXR0cmlidXRlKFF0OjpXQV9JbnB1dE1ldGhvZEVuYWJsZWQp KTsKIAogICAgIC8vICd1cmwnIGZpZWxkCiAgICAgaW5wdXRFbGVtZW50ID0gbWFpbkZyYW1lLT5k b2N1bWVudEVsZW1lbnQoKS5maW5kRmlyc3QoUUxhdGluMVN0cmluZygiaW5wdXRbdHlwZT11cmxd IikpOwogICAgIFFUZXN0Ojptb3VzZUNsaWNrKCZ3ZWJWaWV3LCBRdDo6TGVmdEJ1dHRvbiwgMCwg aW5wdXRFbGVtZW50Lmdlb21ldHJ5KCkuY2VudGVyKCkpOwotICAgIFFWRVJJRlkod2ViVmlldy5p bnB1dE1ldGhvZEhpbnRzKCkgPT0gUXQ6OkltaFVybENoYXJhY3RlcnNPbmx5KTsKKyAgICBRVFJZ X1ZFUklGWShpbnB1dEVsZW1lbnQuaGFzRm9jdXMoKSk7CisgICAgUUNPTVBBUkUod2ViVmlldy5p bnB1dE1ldGhvZEhpbnRzKCksIFF0OjpJbWhVcmxDaGFyYWN0ZXJzT25seSk7CiAgICAgUVZFUklG WSh3ZWJWaWV3LnRlc3RBdHRyaWJ1dGUoUXQ6OldBX0lucHV0TWV0aG9kRW5hYmxlZCkpOwogCiAg ICAgLy8gJ3Bhc3N3b3JkJyBmaWVsZAogICAgIGlucHV0RWxlbWVudCA9IG1haW5GcmFtZS0+ZG9j dW1lbnRFbGVtZW50KCkuZmluZEZpcnN0KFFMYXRpbjFTdHJpbmcoImlucHV0W3R5cGU9cGFzc3dv cmRdIikpOwogICAgIFFUZXN0Ojptb3VzZUNsaWNrKCZ3ZWJWaWV3LCBRdDo6TGVmdEJ1dHRvbiwg MCwgaW5wdXRFbGVtZW50Lmdlb21ldHJ5KCkuY2VudGVyKCkpOwotICAgIFFWRVJJRlkod2ViVmll dy5pbnB1dE1ldGhvZEhpbnRzKCkgPT0gUXQ6OkltaEhpZGRlblRleHQpOworICAgIFFUUllfVkVS SUZZKGlucHV0RWxlbWVudC5oYXNGb2N1cygpKTsKKyAgICBRQ09NUEFSRSh3ZWJWaWV3LmlucHV0 TWV0aG9kSGludHMoKSwgUXQ6OkltaEhpZGRlblRleHQpOwogICAgIFFWRVJJRlkod2ViVmlldy50 ZXN0QXR0cmlidXRlKFF0OjpXQV9JbnB1dE1ldGhvZEVuYWJsZWQpKTsKIAogICAgIC8vICd0ZXh0 JyB0eXBlCiAgICAgaW5wdXRFbGVtZW50ID0gbWFpbkZyYW1lLT5kb2N1bWVudEVsZW1lbnQoKS5m aW5kRmlyc3QoUUxhdGluMVN0cmluZygiaW5wdXRbdHlwZT10ZXh0XSIpKTsKICAgICBRVGVzdDo6 bW91c2VDbGljaygmd2ViVmlldywgUXQ6OkxlZnRCdXR0b24sIDAsIGlucHV0RWxlbWVudC5nZW9t ZXRyeSgpLmNlbnRlcigpKTsKKyAgICBRVFJZX1ZFUklGWShpbnB1dEVsZW1lbnQuaGFzRm9jdXMo KSk7CiAjaWYgZGVmaW5lZChRX1dTX01BRU1PXzUpIHx8IGRlZmluZWQoUV9XU19NQUVNT182KSB8 fCBkZWZpbmVkKFFfT1NfU1lNQklBTikKICAgICBRVkVSSUZZKHdlYlZpZXcuaW5wdXRNZXRob2RI aW50cygpICYgUXQ6OkltaE5vQXV0b1VwcGVyY2FzZSk7CiAgICAgUVZFUklGWSh3ZWJWaWV3Lmlu cHV0TWV0aG9kSGludHMoKSAmIFF0OjpJbWhOb1ByZWRpY3RpdmVUZXh0KTsKICNlbHNlCi0gICAg UVZFUklGWSh3ZWJWaWV3LmlucHV0TWV0aG9kSGludHMoKSA9PSBRdDo6SW1oTm9uZSk7CisgICAg UUNPTVBBUkUod2ViVmlldy5pbnB1dE1ldGhvZEhpbnRzKCksIFF0OjpJbWhOb25lKTsKICNlbmRp ZgogICAgIFFWRVJJRlkod2ViVmlldy50ZXN0QXR0cmlidXRlKFF0OjpXQV9JbnB1dE1ldGhvZEVu YWJsZWQpKTsKIAogICAgIC8vICdwYXNzd29yZCcgZmllbGQKICAgICBpbnB1dEVsZW1lbnQgPSBt YWluRnJhbWUtPmRvY3VtZW50RWxlbWVudCgpLmZpbmRGaXJzdChRTGF0aW4xU3RyaW5nKCJpbnB1 dFt0eXBlPXBhc3N3b3JkXSIpKTsKICAgICBRVGVzdDo6bW91c2VDbGljaygmd2ViVmlldywgUXQ6 OkxlZnRCdXR0b24sIDAsIGlucHV0RWxlbWVudC5nZW9tZXRyeSgpLmNlbnRlcigpKTsKLSAgICBR VkVSSUZZKHdlYlZpZXcuaW5wdXRNZXRob2RIaW50cygpID09IFF0OjpJbWhIaWRkZW5UZXh0KTsK KyAgICBRVFJZX1ZFUklGWShpbnB1dEVsZW1lbnQuaGFzRm9jdXMoKSk7CisgICAgUUNPTVBBUkUo d2ViVmlldy5pbnB1dE1ldGhvZEhpbnRzKCksIFF0OjpJbWhIaWRkZW5UZXh0KTsKICAgICBRVkVS SUZZKHdlYlZpZXcudGVzdEF0dHJpYnV0ZShRdDo6V0FfSW5wdXRNZXRob2RFbmFibGVkKSk7CiAK ICAgICBxV2FybmluZygiY2xpY2tpbmcgb24gdGV4dCBhcmVhIik7CiAgICAgLy8gJ3RleHQgYXJl YScgZmllbGQKICAgICBpbnB1dEVsZW1lbnQgPSBtYWluRnJhbWUtPmRvY3VtZW50RWxlbWVudCgp LmZpbmRGaXJzdChRTGF0aW4xU3RyaW5nKCJ0ZXh0YXJlYSIpKTsKICAgICBRVGVzdDo6bW91c2VD bGljaygmd2ViVmlldywgUXQ6OkxlZnRCdXR0b24sIDAsIGlucHV0RWxlbWVudC5nZW9tZXRyeSgp LmNlbnRlcigpKTsKLSAgICBRVkVSSUZZKHdlYlZpZXcuaW5wdXRNZXRob2RIaW50cygpID09IFF0 OjpJbWhOb25lKTsKKyAgICBRVFJZX1ZFUklGWShpbnB1dEVsZW1lbnQuaGFzRm9jdXMoKSk7Cisg ICAgUUNPTVBBUkUod2ViVmlldy5pbnB1dE1ldGhvZEhpbnRzKCksIFF0OjpJbWhOb25lKTsKICAg ICBRVkVSSUZZKHdlYlZpZXcudGVzdEF0dHJpYnV0ZShRdDo6V0FfSW5wdXRNZXRob2RFbmFibGVk KSk7CiB9CiAK