44742 2010-08-26 20:08:28 -0700 [GTK] ScrollbarThemeGtk should account for the trough_under_steppers property 2010-08-27 17:45:01 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P3 Normal --- 1 mrobinson webkit-unassigned oldest_to_newest 270286 0 mrobinson 2010-08-26 20:08:28 -0700 When a style specifies trough_under_steppes, ScrollbarThemeGtk should inflate the track rect when painting as well as queue repaints of the track when repainting the stepper buttons. 270287 1 65666 mrobinson 2010-08-26 20:12:54 -0700 Created attachment 65666 Patch for this issue 270642 2 65666 xan.lopez 2010-08-27 12:01:36 -0700 Comment on attachment 65666 Patch for this issue OK. Might be worth mentioning any theme that needs this fix for future reference. 270851 3 65666 mrobinson 2010-08-27 17:44:55 -0700 Comment on attachment 65666 Patch for this issue Clearing flags on attachment: 65666 Committed r66285: <http://trac.webkit.org/changeset/66285> 270852 4 mrobinson 2010-08-27 17:45:01 -0700 All reviewed patches have been landed. Closing bug. 65666 2010-08-26 20:12:54 -0700 2010-08-27 17:44:55 -0700 Patch for this issue bug-44742-20100826201249.patch text/plain 3061 mrobinson ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZjNmMjlkZGM2ZjUyMWM5NzQ2OTVhOTEzYzU2ZjE4ZDBmZWUzYzdmZi4uZDI0MTQ0NDgxZjc4ODM3 YTIwZTAwMjJiMGJlZTAzNTE3M2YwNjVmNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMSBAQAogMjAxMC0wOC0yNiAgTWFy dGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gU2Nyb2xsYmFyVGhlbWVHdGsgc2hv dWxkIGFjY291bnQgZm9yIHRoZSB0cm91Z2hfdW5kZXJfc3RlcHBlcnMgcHJvcGVydHkKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0NzQyCisKKyAgICAg ICAgTm8gbmV3IHRlc3RzIHVudGlsIHRoaXMgY29kZSBpcyBhY3RpdmF0ZWQsIGF0IHdoaWNoIHBv aW50IHBpeGVsIHRlc3RzIHdpbGwKKyAgICAgICAgdGVzdCB0aGUgc2Nyb2xsYmFyIHJlbmRlcmlu Zy4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9TY3JvbGxiYXJUaGVtZUd0ay5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpTY3JvbGxiYXJUaGVtZUd0azo6cGFpbnRUcmFja0JhY2tncm91bmQpOiBP bmx5IGluZmxhdGUgdGhlIHRyYWNrIGJhY2tncm91bmQKKyAgICAgICAgaWYgdGhlIHN0eWxlIHNw ZWNpZmllcyB0cm91Z2hfdW5kZXJfc3RlcHBlcnMuCisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxi YXJUaGVtZUd0azo6cGFpbnQpOiBJZiB0aGUgdGhlbWUgc3BlY2lmaWVzIHRyb3VnaF91bmRlcl9z dGVwcGVycywKKyAgICAgICAgYSBkaXJ0eSBzdGVwcGVyIGFsc28gdHJpZ2dlcnMgYSByZXBhaW50 IG9mIHRoZSB0cm91Z2ggcmVnaW9uLgorCisyMDEwLTA4LTI2ICBNYXJ0aW4gUm9iaW5zb24gIDxt cm9iaW5zb25AaWdhbGlhLmNvbT4KKwogICAgICAgICBCdWlsZCBmaXggZm9yIEdUSyssIGFmdGVy IGEgYmFkIG1lcmdlLgogCiAgICAgICAgICogcGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3RrLmNw cDoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1Njcm9sbGJhclRoZW1lR3RrLmNw cCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1Njcm9sbGJhclRoZW1lR3RrLmNwcAppbmRleCBhYjEw MGE5MGM2MGQ4ZjQ0ZGY0ZWU5NTZlN2Y4OTA3ZjlhYjk3Y2Y1Li5lZTZmYjM4Y2YzNGNhZDkyMWFm MTQxMjA3YzljMmUyNDgyZTdiMmMxIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9T Y3JvbGxiYXJUaGVtZUd0ay5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvU2Nyb2xsYmFy VGhlbWVHdGsuY3BwCkBAIC0xMjIsNyArMTIyLDE2IEBAIHZvaWQgU2Nyb2xsYmFyVGhlbWVHdGs6 OnBhaW50VHJhY2tCYWNrZ3JvdW5kKEdyYXBoaWNzQ29udGV4dCogY29udGV4dCwgU2Nyb2xsYmFy CiAgICAgc3RhdGUuYWN0aXZlID0gRkFMU0U7CiAgICAgc3RhdGUuaW5Ib3ZlciA9IEZBTFNFOwog Ci0gICAgSW50UmVjdCBmdWxsU2Nyb2xsYmFyUmVjdChzY3JvbGxiYXItPngoKSwgc2Nyb2xsYmFy LT55KCksIHNjcm9sbGJhci0+d2lkdGgoKSwgc2Nyb2xsYmFyLT5oZWlnaHQoKSk7CisgICAgLy8g UGFpbnQgdGhlIHRyYWNrIGJhY2tncm91bmQuIElmIHRoZSB0cm91Z2gtdW5kZXItc3RlcHBlcnMg cHJvcGVydHkgaXMgdHJ1ZSwgdGhpcworICAgIC8vIHNob3VsZCBiZSB0aGUgZnVsbCBzaXplIG9m IHRoZSBzY3JvbGxiYXIsIGJ1dCBpZiBpcyBmYWxzZSwgaXQgc2hvdWxkIG9ubHkgYmUgdGhlCisg ICAgLy8gdHJhY2sgcmVjdC4KKyAgICBNb3pHdGtTY3JvbGxiYXJNZXRyaWNzIG1ldHJpY3M7Cisg ICAgbW96X2d0a19nZXRfc2Nyb2xsYmFyX21ldHJpY3MoJm1ldHJpY3MpOworCisgICAgSW50UmVj dCBmdWxsU2Nyb2xsYmFyUmVjdCA9IHJlY3Q7CisgICAgaWYgKG1ldHJpY3MudHJvdWdoX3VuZGVy X3N0ZXBwZXJzKQorICAgICAgICBmdWxsU2Nyb2xsYmFyUmVjdCA9IEludFJlY3Qoc2Nyb2xsYmFy LT54KCksIHNjcm9sbGJhci0+eSgpLCBzY3JvbGxiYXItPndpZHRoKCksIHNjcm9sbGJhci0+aGVp Z2h0KCkpOworCiAgICAgR3RrVGhlbWVXaWRnZXRUeXBlIHR5cGUgPSBzY3JvbGxiYXItPm9yaWVu dGF0aW9uKCkgPT0gVmVydGljYWxTY3JvbGxiYXIgPyBNT1pfR1RLX1NDUk9MTEJBUl9UUkFDS19W RVJUSUNBTCA6IE1PWl9HVEtfU0NST0xMQkFSX1RSQUNLX0hPUklaT05UQUw7CiAgICAgc3RhdGlj X2Nhc3Q8UmVuZGVyVGhlbWVHdGsqPihSZW5kZXJUaGVtZTo6ZGVmYXVsdFRoZW1lKCkuZ2V0KCkp LT5wYWludE1vemlsbGFHdGtXaWRnZXQodHlwZSwgY29udGV4dCwgZnVsbFNjcm9sbGJhclJlY3Qs ICZzdGF0ZSwgMCk7CiB9CkBAIC0yMDAsNiArMjA5LDE1IEBAIGJvb2wgU2Nyb2xsYmFyVGhlbWVH dGs6OnBhaW50KFNjcm9sbGJhciogc2Nyb2xsYmFyLCBHcmFwaGljc0NvbnRleHQqIGdyYXBoaWNz Q29uCiAgICAgaWYgKGRhbWFnZVJlY3QuaW50ZXJzZWN0cyh0cmFja1BhaW50UmVjdCkpCiAgICAg ICAgIHNjcm9sbE1hc2sgfD0gVHJhY2tCR1BhcnQ7CiAKKyAgICBNb3pHdGtTY3JvbGxiYXJNZXRy aWNzIG1ldHJpY3M7CisgICAgbW96X2d0a19nZXRfc2Nyb2xsYmFyX21ldHJpY3MoJm1ldHJpY3Mp OworICAgIGlmIChtZXRyaWNzLnRyb3VnaF91bmRlcl9zdGVwcGVycworICAgICAgICAgICAgJiYg KHNjcm9sbE1hc2sgJiBCYWNrQnV0dG9uU3RhcnRQYXJ0CisgICAgICAgICAgICB8fCBzY3JvbGxN YXNrICYgQmFja0J1dHRvbkVuZFBhcnQKKyAgICAgICAgICAgIHx8IHNjcm9sbE1hc2sgJiBGb3J3 YXJkQnV0dG9uU3RhcnRQYXJ0CisgICAgICAgICAgICB8fCBzY3JvbGxNYXNrICYgRm9yd2FyZEJ1 dHRvbkVuZFBhcnQpKQorICAgICAgICBzY3JvbGxNYXNrIHw9IFRyYWNrQkdQYXJ0OworCiAgICAg Ym9vbCB0aHVtYlByZXNlbnQgPSBoYXNUaHVtYihzY3JvbGxiYXIpOwogICAgIEludFJlY3QgY3Vy cmVudFRodW1iUmVjdDsKICAgICBpZiAodGh1bWJQcmVzZW50KSB7Cg==