44738 2010-08-26 18:20:25 -0700 SWIG wants explicit destructors for C++ DOM bindings 2010-08-28 16:10:37 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED Wx P2 Normal --- 1 kevino webkit-unassigned oldest_to_newest 270257 0 kevino 2010-08-26 18:20:25 -0700 The SWIG wrapper tool I'm using to generate Python bindings from the C++ DOM bindings requires an explicit destructor to be declared in order to ensure proper destruction. Without this, SWIG will generate (lots of) memory leak warnings. 270258 1 65656 kevino 2010-08-26 18:23:09 -0700 Created attachment 65656 Add explicit destructor to C++ DOM bindings 271072 2 kevino 2010-08-28 16:07:27 -0700 Landed in r66316. 271073 3 65656 zimmermann 2010-08-28 16:10:37 -0700 Comment on attachment 65656 Add explicit destructor to C++ DOM bindings LGTM, r=me. 65656 2010-08-26 18:23:09 -0700 2010-08-28 16:10:37 -0700 Add explicit destructor to C++ DOM bindings bindings_destructor.patch text/plain 1191 kevino SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NjE2MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTAtMDgtMjYgIEtldmluIE9sbGl2aWVyICA8a2V2aW5vQHRoZW9s bGl2aWVycy5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWRkIGV4cGxpY2l0IGRlc3RydWN0b3IgZm9yIEMrKyBET00gYmluZGluZ3MgdG8gYXZv aWQgbWVtb3J5IGxlYWtzIHdoZW4gdXNpbmcgU1dJRy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvYXR0YWNobWVudC5jZ2k/YnVnaWQ9NDQ3MzgKKworICAgICAgICAqIGJpbmRpbmdz L3NjcmlwdHMvQ29kZUdlbmVyYXRvckNQUC5wbToKKwogMjAxMC0wOC0yNiAgTWFyayBSb3dlICA8 bXJvd2VAYXBwbGUuY29tPgogCiAgICAgICAgIERhcmluIHBvaW50ZWQgb3V0IHRoYXQgdGhlIGJy YWNlcyBhcmUgdW5uZWNlc3NhcnkgaW4gYW4gT2JqZWN0aXZlLUMgaW50ZXJmYWNlCkluZGV4OiBX ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckNQUC5wbQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckNQUC5wbQkocmV2aXNpb24g NjYxNjEpCisrKyBXZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckNQUC5wbQko d29ya2luZyBjb3B5KQpAQCAtMzkzLDcgKzM5Myw5IEBACiAKICAgICAjIERlc3RydWN0b3IKICAg ICBpZiAoJHBhcmVudE5hbWUgZXEgIldlYkRPTU9iamVjdCIpIHsKLSAgICAgICAgcHVzaChAaGVh ZGVyQ29udGVudCwgIiAgICB+JGNsYXNzTmFtZSgpO1xuIik7CisgICAgICAgIHB1c2goQGhlYWRl ckNvbnRlbnQsICIgICAgdmlydHVhbCB+JGNsYXNzTmFtZSgpO1xuIik7CisgICAgfSBlbHNlIHsK KyAgICAgICAgcHVzaChAaGVhZGVyQ29udGVudCwgIiAgICB2aXJ0dWFsIH4kY2xhc3NOYW1lKCkg eyB9XG4iKTsKICAgICB9CiAKICAgICBwdXNoKEBoZWFkZXJDb250ZW50LCAiXG4iKTsK