44737 2010-08-26 17:44:12 -0700 r66141 caused fast/forms/select-style.html to fail on mac: 2010-08-27 09:03:50 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser hyatt zimmermann oldest_to_newest 270245 0 simon.fraser 2010-08-26 17:44:12 -0700 r66141 seems to have caused fast/forms/select-style.html to fail on mac: 270282 1 simon.fraser 2010-08-26 19:49:43 -0700 This regressed because of the *style->backgroundLayers() != background check in RenderTheme.cpp:694, where the style contains a StylePendingImage. 270294 2 65669 simon.fraser 2010-08-26 20:38:30 -0700 Created attachment 65669 Patch 270390 3 65669 zimmermann 2010-08-27 02:23:59 -0700 Comment on attachment 65669 Patch Looks good to me, r=me. Simon, I'm going to land this, as it's blocking the mac bots to turn green. 270394 4 zimmermann 2010-08-27 02:27:24 -0700 Landed in r66195. Hope it's okay for you. I'd like to land a larger patch, and want to have all test bots green before doing that. 270525 5 simon.fraser 2010-08-27 09:03:50 -0700 Thanks for landing! 65669 2010-08-26 20:38:30 -0700 2010-08-27 02:23:59 -0700 Patch bug-44737-20100826203829.patch text/plain 2012 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZTViN2RiNmFiMTg3NTYzZGU5ZDMzZWM1ZjMxZDllOTRjNGU1N2U2MS4uODE2NTZjMGEzNGMzODQz NGMwOWI3NDU4ZWM2YzJhZDRjYjE2MmM4MiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wOC0yNiAgU2lt b24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICByNjYxNDEgY2F1c2VkIGZhc3QvZm9ybXMvc2Vs ZWN0LXN0eWxlLmh0bWwgdG8gZmFpbCBvbiBtYWM6CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDczNworCisgICAgICAgIEhhbmRsZSB0aGUgZmFjdCB0 aGF0IGEgQ1NTSW1hZ2VWYWx1ZSBtYXkgaGF2ZSBhIHZhbHVlIG9mIENTU1ZhbHVlTm9uZSwKKyAg ICAgICAgaW4gd2hpY2ggY2FzZSB3ZSBzaG91bGQgbm90IHJldHVybiBhIHBlbmRpbmcgaW1hZ2Uu CisKKyAgICAgICAgKiBjc3MvQ1NTSW1hZ2VWYWx1ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpD U1NJbWFnZVZhbHVlOjpjYWNoZWRPclBlbmRpbmdJbWFnZSk6CisgICAgICAgICogY3NzL0NTU1N0 eWxlU2VsZWN0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTU3R5bGVTZWxlY3Rvcjo6Y2Fj aGVkT3JQZW5kaW5nRnJvbVZhbHVlKToKKwogMjAxMC0wOC0yNiAgSmFtZXMgUm9iaW5zb24gIDxq YW1lc3JAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEZpeCBjaHJvbWl1bSBtYWMgYnVpbGQuIFVu cmV2aWV3ZWQuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2Nzcy9DU1NJbWFnZVZhbHVlLmNwcCBiL1dl YkNvcmUvY3NzL0NTU0ltYWdlVmFsdWUuY3BwCmluZGV4IDA1OGQwZTlkY2RlM2NiNTBkOGQ5MjE5 MGZlOWRiM2M4OGI0MGMxMjkuLmRjMmQ3MDA3ZjRhODA5ZDY0YjU5NDBhNDA1NGIxZWQ0ODFiNTIx YWUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvY3NzL0NTU0ltYWdlVmFsdWUuY3BwCisrKyBiL1dlYkNv cmUvY3NzL0NTU0ltYWdlVmFsdWUuY3BwCkBAIC01MCw2ICs1MCw5IEBAIENTU0ltYWdlVmFsdWU6 On5DU1NJbWFnZVZhbHVlKCkKIAogU3R5bGVJbWFnZSogQ1NTSW1hZ2VWYWx1ZTo6Y2FjaGVkT3JQ ZW5kaW5nSW1hZ2UoKQogeworICAgIGlmIChnZXRJZGVudCgpID09IENTU1ZhbHVlTm9uZSkKKyAg ICAgICAgcmV0dXJuIDA7CisKICAgICBpZiAoIW1faW1hZ2UpCiAgICAgICAgIG1faW1hZ2UgPSBT dHlsZVBlbmRpbmdJbWFnZTo6Y3JlYXRlKHRoaXMpOwogCmRpZmYgLS1naXQgYS9XZWJDb3JlL2Nz cy9DU1NTdHlsZVNlbGVjdG9yLmNwcCBiL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3Bw CmluZGV4IDJhYmI4ZWJhZjYxZThiZTc3MzVlODE0MmZkMTI0YmJjNmQzMTMyNDIuLjI2Y2M5ZGU5 M2Q4N2FmNmJlYTgzYTAwNTEzNDBiNmQ3MGMwNjMzNGUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvY3Nz L0NTU1N0eWxlU2VsZWN0b3IuY3BwCisrKyBiL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3Iu Y3BwCkBAIC01Nzc0LDcgKzU3NzQsNyBAQCBTdHlsZUltYWdlKiBDU1NTdHlsZVNlbGVjdG9yOjpz dHlsZUltYWdlKENTU1Byb3BlcnR5SUQgcHJvcGVydHksIENTU1ZhbHVlKiB2YWx1ZQogU3R5bGVJ bWFnZSogQ1NTU3R5bGVTZWxlY3Rvcjo6Y2FjaGVkT3JQZW5kaW5nRnJvbVZhbHVlKENTU1Byb3Bl cnR5SUQgcHJvcGVydHksIENTU0ltYWdlVmFsdWUqIHZhbHVlKQogewogICAgIFN0eWxlSW1hZ2Uq IGltYWdlID0gdmFsdWUtPmNhY2hlZE9yUGVuZGluZ0ltYWdlKCk7Ci0gICAgaWYgKGltYWdlLT5p c1BlbmRpbmdJbWFnZSgpKQorICAgIGlmIChpbWFnZSAmJiBpbWFnZS0+aXNQZW5kaW5nSW1hZ2Uo KSkKICAgICAgICAgbV9wZW5kaW5nSW1hZ2VQcm9wZXJ0aWVzLmFkZChwcm9wZXJ0eSk7CiAgICAg cmV0dXJuIGltYWdlOwogfQo=