44720 2010-08-26 14:47:49 -0700 Remove unnecessary AlphaBlend in PasteboardWin 2010-08-27 18:59:22 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 paroga webkit-unassigned aroben commit-queue oldest_to_newest 270129 0 paroga 2010-08-26 14:47:49 -0700 see patch 270133 1 65621 paroga 2010-08-26 14:52:18 -0700 Created attachment 65621 Patch 270134 2 65621 aroben 2010-08-26 14:55:12 -0700 Comment on attachment 65621 Patch I think it would be good to mention in the ChangeLog that testing showed that alpha never survives copy-and-paste on Windows in any browser, and that StretchBlt was overkill since the source and destination size were always equal. Other than that this looks great! 270139 3 65623 paroga 2010-08-26 15:00:32 -0700 Created attachment 65623 Patch 270140 4 65623 aroben 2010-08-26 15:01:54 -0700 Comment on attachment 65623 Patch > + Replacing AlphaBlend with BitBlt is save because testing showed that alpha Typo: save (should be "safe") > + never survives copy-and-paste on Windows in any browser, and StretchBlt > + was a overkill since the source and destination size are always equal. Typo: a overkill (should be "overkill") Soooo close! 270141 5 65624 paroga 2010-08-26 15:04:43 -0700 Created attachment 65624 Patch 270143 6 65624 aroben 2010-08-26 15:05:48 -0700 Comment on attachment 65624 Patch r=me 270890 7 65624 commit-queue 2010-08-27 18:59:17 -0700 Comment on attachment 65624 Patch Clearing flags on attachment: 65624 Committed r66291: <http://trac.webkit.org/changeset/66291> 270891 8 commit-queue 2010-08-27 18:59:22 -0700 All reviewed patches have been landed. Closing bug. 65621 2010-08-26 14:52:18 -0700 2010-08-26 15:00:32 -0700 Patch bug-44720.patch text/plain 1510 paroga ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZTAxZDAzZi4uMWE0NjE1NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wOC0yNiAgUGF0cmljayBHYW5z dGVyZXIgIDxwYXJvZ2FAcGFyb2dhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgdW5uZWNlc3NhcnkgQWxwaGFCbGVuZCBpbiBQYXN0 ZWJvYXJkV2luLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NDQ3MjAKKworICAgICAgICBSZW1vdmUgQWxwaGFCbGVuZCB3aXRoIEJpdEJsdC4KKworICAg ICAgICAqIHBsYXRmb3JtL3dpbi9QYXN0ZWJvYXJkV2luLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlBhc3RlYm9hcmQ6OndyaXRlSW1hZ2UpOgorCiAyMDEwLTA4LTI1ICBQYXRyaWNrIEdhbnN0ZXJl ciAgPHBhcm9nYUBwYXJvZ2EuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gUm9iZW4u CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9QYXN0ZWJvYXJkV2luLmNwcCBiL1dl YkNvcmUvcGxhdGZvcm0vd2luL1Bhc3RlYm9hcmRXaW4uY3BwCmluZGV4IDAzZWNkMzYuLmMwNjVm MDQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vd2luL1Bhc3RlYm9hcmRXaW4uY3BwCisr KyBiL1dlYkNvcmUvcGxhdGZvcm0vd2luL1Bhc3RlYm9hcmRXaW4uY3BwCkBAIC0yMzAsMTQgKzIz MCw3IEBAIHZvaWQgUGFzdGVib2FyZDo6d3JpdGVJbWFnZShOb2RlKiBub2RlLCBjb25zdCBLVVJM JiwgY29uc3QgU3RyaW5nJikKICAgICBIR0RJT0JKIG9sZFNvdXJjZSA9IFNlbGVjdE9iamVjdChz b3VyY2VEQywgY29yZUJpdG1hcCk7CiAgICAgaW1hZ2UtPmdldEhCSVRNQVAoY29yZUJpdG1hcCk7 CiAKLSNpZiAhZGVmaW5lZChOT19BTFBIQUJMRU5EKQotICAgIEJMRU5ERlVOQ1RJT04gYmYgPSB7 QUNfU1JDX09WRVIsIDAsIDI1NSwgQUNfU1JDX0FMUEhBfTsKLSAgICBBbHBoYUJsZW5kKGNvbXBh dGlibGVEQywgMCwgMCwgaW1hZ2UtPndpZHRoKCksIGltYWdlLT5oZWlnaHQoKSwKLSAgICAgICAg c291cmNlREMsIDAsIDAsIGltYWdlLT53aWR0aCgpLCBpbWFnZS0+aGVpZ2h0KCksIGJmKTsKLSNl bHNlCi0gICAgU3RyZXRjaEJsdChjb21wYXRpYmxlREMsIDAsIDAsIGltYWdlLT53aWR0aCgpLCBp bWFnZS0+aGVpZ2h0KCksCi0gICAgICAgIHNvdXJjZURDLCAwLCAwLCBpbWFnZS0+d2lkdGgoKSwg aW1hZ2UtPmhlaWdodCgpLCBTUkNDT1BZKTsKLSNlbmRpZgorICAgIEJpdEJsdChjb21wYXRpYmxl REMsIDAsIDAsIGltYWdlLT53aWR0aCgpLCBpbWFnZS0+aGVpZ2h0KCksIHNvdXJjZURDLCAwLCAw LCBTUkNDT1BZKTsKIAogICAgIFNlbGVjdE9iamVjdChzb3VyY2VEQywgb2xkU291cmNlKTsKICAg ICBEZWxldGVPYmplY3QoY29yZUJpdG1hcCk7Cg== 65623 2010-08-26 15:00:32 -0700 2010-08-26 15:04:43 -0700 Patch bug-44720.patch text/plain 1716 paroga ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZTAxZDAzZi4uMWE0NjE1NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wOC0yNiAgUGF0cmljayBHYW5z dGVyZXIgIDxwYXJvZ2FAcGFyb2dhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgdW5uZWNlc3NhcnkgQWxwaGFCbGVuZCBpbiBQYXN0 ZWJvYXJkV2luLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NDQ3MjAKKworICAgICAgICBSZXBsYWNpbmcgQWxwaGFCbGVuZCB3aXRoIEJpdEJsdCBpcyBz YXZlIGJlY2F1c2UgdGVzdGluZyBzaG93ZWQgdGhhdCBhbHBoYQorICAgICAgICBuZXZlciBzdXJ2 aXZlcyBjb3B5LWFuZC1wYXN0ZSBvbiBXaW5kb3dzIGluIGFueSBicm93c2VyLCBhbmQgU3RyZXRj aEJsdCAKKyAgICAgICAgd2FzIGEgb3ZlcmtpbGwgc2luY2UgdGhlIHNvdXJjZSBhbmQgZGVzdGlu YXRpb24gc2l6ZSBhcmUgYWx3YXlzIGVxdWFsLgorCisgICAgICAgICogcGxhdGZvcm0vd2luL1Bh c3RlYm9hcmRXaW4uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGFzdGVib2FyZDo6d3JpdGVJbWFn ZSk6CisKIDIwMTAtMDgtMjUgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHBhcm9nYS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBSb2Jlbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUv cGxhdGZvcm0vd2luL1Bhc3RlYm9hcmRXaW4uY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS93aW4vUGFz dGVib2FyZFdpbi5jcHAKaW5kZXggMDNlY2QzNi4uYzA2NWYwNCAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9wbGF0Zm9ybS93aW4vUGFzdGVib2FyZFdpbi5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS93 aW4vUGFzdGVib2FyZFdpbi5jcHAKQEAgLTIzMCwxNCArMjMwLDcgQEAgdm9pZCBQYXN0ZWJvYXJk Ojp3cml0ZUltYWdlKE5vZGUqIG5vZGUsIGNvbnN0IEtVUkwmLCBjb25zdCBTdHJpbmcmKQogICAg IEhHRElPQkogb2xkU291cmNlID0gU2VsZWN0T2JqZWN0KHNvdXJjZURDLCBjb3JlQml0bWFwKTsK ICAgICBpbWFnZS0+Z2V0SEJJVE1BUChjb3JlQml0bWFwKTsKIAotI2lmICFkZWZpbmVkKE5PX0FM UEhBQkxFTkQpCi0gICAgQkxFTkRGVU5DVElPTiBiZiA9IHtBQ19TUkNfT1ZFUiwgMCwgMjU1LCBB Q19TUkNfQUxQSEF9OwotICAgIEFscGhhQmxlbmQoY29tcGF0aWJsZURDLCAwLCAwLCBpbWFnZS0+ d2lkdGgoKSwgaW1hZ2UtPmhlaWdodCgpLAotICAgICAgICBzb3VyY2VEQywgMCwgMCwgaW1hZ2Ut PndpZHRoKCksIGltYWdlLT5oZWlnaHQoKSwgYmYpOwotI2Vsc2UKLSAgICBTdHJldGNoQmx0KGNv bXBhdGlibGVEQywgMCwgMCwgaW1hZ2UtPndpZHRoKCksIGltYWdlLT5oZWlnaHQoKSwKLSAgICAg ICAgc291cmNlREMsIDAsIDAsIGltYWdlLT53aWR0aCgpLCBpbWFnZS0+aGVpZ2h0KCksIFNSQ0NP UFkpOwotI2VuZGlmCisgICAgQml0Qmx0KGNvbXBhdGlibGVEQywgMCwgMCwgaW1hZ2UtPndpZHRo KCksIGltYWdlLT5oZWlnaHQoKSwgc291cmNlREMsIDAsIDAsIFNSQ0NPUFkpOwogCiAgICAgU2Vs ZWN0T2JqZWN0KHNvdXJjZURDLCBvbGRTb3VyY2UpOwogICAgIERlbGV0ZU9iamVjdChjb3JlQml0 bWFwKTsK 65624 2010-08-26 15:04:43 -0700 2010-08-27 18:59:17 -0700 Patch bug-44720.patch text/plain 1716 paroga ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZTAxZDAzZi4uMWE0NjE1NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wOC0yNiAgUGF0cmljayBHYW5z dGVyZXIgIDxwYXJvZ2FAcGFyb2dhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgdW5uZWNlc3NhcnkgQWxwaGFCbGVuZCBpbiBQYXN0 ZWJvYXJkV2luLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NDQ3MjAKKworICAgICAgICBSZXBsYWNpbmcgQWxwaGFCbGVuZCB3aXRoIEJpdEJsdCBpcyBz YWZlIGJlY2F1c2UgdGVzdGluZyBzaG93ZWQgdGhhdCBhbHBoYQorICAgICAgICBuZXZlciBzdXJ2 aXZlcyBjb3B5LWFuZC1wYXN0ZSBvbiBXaW5kb3dzIGluIGFueSBicm93c2VyLCBhbmQgU3RyZXRj aEJsdCAKKyAgICAgICAgd2FzIGEgb3ZlcmtpbGwgc2luY2UgdGhlIHNvdXJjZSBhbmQgZGVzdGlu YXRpb24gc2l6ZSBhcmUgYWx3YXlzIGVxdWFsLgorCisgICAgICAgICogcGxhdGZvcm0vd2luL1Bh c3RlYm9hcmRXaW4uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGFzdGVib2FyZDo6d3JpdGVJbWFn ZSk6CisKIDIwMTAtMDgtMjUgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHBhcm9nYS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBSb2Jlbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUv cGxhdGZvcm0vd2luL1Bhc3RlYm9hcmRXaW4uY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS93aW4vUGFz dGVib2FyZFdpbi5jcHAKaW5kZXggMDNlY2QzNi4uYzA2NWYwNCAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9wbGF0Zm9ybS93aW4vUGFzdGVib2FyZFdpbi5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS93 aW4vUGFzdGVib2FyZFdpbi5jcHAKQEAgLTIzMCwxNCArMjMwLDcgQEAgdm9pZCBQYXN0ZWJvYXJk Ojp3cml0ZUltYWdlKE5vZGUqIG5vZGUsIGNvbnN0IEtVUkwmLCBjb25zdCBTdHJpbmcmKQogICAg IEhHRElPQkogb2xkU291cmNlID0gU2VsZWN0T2JqZWN0KHNvdXJjZURDLCBjb3JlQml0bWFwKTsK ICAgICBpbWFnZS0+Z2V0SEJJVE1BUChjb3JlQml0bWFwKTsKIAotI2lmICFkZWZpbmVkKE5PX0FM UEhBQkxFTkQpCi0gICAgQkxFTkRGVU5DVElPTiBiZiA9IHtBQ19TUkNfT1ZFUiwgMCwgMjU1LCBB Q19TUkNfQUxQSEF9OwotICAgIEFscGhhQmxlbmQoY29tcGF0aWJsZURDLCAwLCAwLCBpbWFnZS0+ d2lkdGgoKSwgaW1hZ2UtPmhlaWdodCgpLAotICAgICAgICBzb3VyY2VEQywgMCwgMCwgaW1hZ2Ut PndpZHRoKCksIGltYWdlLT5oZWlnaHQoKSwgYmYpOwotI2Vsc2UKLSAgICBTdHJldGNoQmx0KGNv bXBhdGlibGVEQywgMCwgMCwgaW1hZ2UtPndpZHRoKCksIGltYWdlLT5oZWlnaHQoKSwKLSAgICAg ICAgc291cmNlREMsIDAsIDAsIGltYWdlLT53aWR0aCgpLCBpbWFnZS0+aGVpZ2h0KCksIFNSQ0NP UFkpOwotI2VuZGlmCisgICAgQml0Qmx0KGNvbXBhdGlibGVEQywgMCwgMCwgaW1hZ2UtPndpZHRo KCksIGltYWdlLT5oZWlnaHQoKSwgc291cmNlREMsIDAsIDAsIFNSQ0NPUFkpOwogCiAgICAgU2Vs ZWN0T2JqZWN0KHNvdXJjZURDLCBvbGRTb3VyY2UpOwogICAgIERlbGV0ZU9iamVjdChjb3JlQml0 bWFwKTsK