44708 2010-08-26 12:47:48 -0700 [chromium] WebEntities is broken 2010-08-26 13:54:35 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Major --- 1 rniwa rniwa eric jamesr ojan tony oldest_to_newest 270048 0 rniwa 2010-08-26 12:47:48 -0700 After new HTML tree builder has been enabled, /WebKit/chromium/src/WebEntities.* got broken and Chromium's "Save As" do not function as intended. http://crbug.com/53148/ 270056 1 65604 rniwa 2010-08-26 13:01:10 -0700 Created attachment 65604 fixes the bug 270062 2 65604 eric 2010-08-26 13:11:39 -0700 Comment on attachment 65604 fixes the bug Yay! It no longer needs to include the HTMLEntityTable.h header though. 270065 3 jamesr 2010-08-26 13:12:26 -0700 Do we really have to keep the 0x0027->#39 mapping? What's actually testing that? 270093 4 rniwa 2010-08-26 13:46:24 -0700 (In reply to comment #3) > Do we really have to keep the 0x0027->#39 mapping? What's actually testing that? I could fix the test to expect &apos; but I didn't want to modify that now because it might trigger some incompatibility issues. 270096 5 rniwa 2010-08-26 13:49:37 -0700 (In reply to comment #2) > (From update of attachment 65604 [details]) > Yay! It no longer needs to include the HTMLEntityTable.h header though. Will remove and commit. 270100 6 rniwa 2010-08-26 13:54:35 -0700 Committed r66131: <http://trac.webkit.org/changeset/66131> 65604 2010-08-26 13:01:10 -0700 2010-08-26 13:11:38 -0700 fixes the bug bug-44708-20100826130109.patch text/plain 3101 rniwa SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjYxMjUpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTAtMDgtMjYgIFJ5b3N1 a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBXZWJFbnRpdGllcyBpcyBicm9rZW4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0NzA4CisKKyAg ICAgICAgRm9yIHNlcmlhbGl6YXRpb24gcHVycG9zZXMsIHdlIGRvbid0IG5lZWQgdG8gY29udmVy dCBhbGwgZW50aXR5IHJlZmVyZW5jZXMuCisgICAgICAgIFRoaXMgcGF0Y2ggbW9kaWZpZXMgV2Vi RW50aXRpZXM6OldlYkVudGl0aWVzIHRvIHVzZSBoYXJkLWNvZGVkIGVudGl0eSBsaXN0cyBmb3Ig Ym90aCBIVE1MIGFuZCBYTUwsCisgICAgICAgIGFuZCBkZWxldGVzIHBvcHVsYXRlTWFwRnJvbVhN TEVudGl0aWVzIGFuZCBwb3B1bGF0ZU1hcEZyb21IVE1MRW50aXR5VGFibGUuCisKKyAgICAgICAg Tm8gdGVzdHMgYXJlIGFkZGVkIHNpbmNlIHRoZSBjb2RlIGlzIHRlc3RlZCBpbiBEb21TZXJpYWxp emVyVGVzdHMKKworICAgICAgICAqIHNyYy9XZWJFbnRpdGllcy5jcHA6CisgICAgICAgIChXZWJL aXQ6Oik6CisgICAgICAgIChXZWJLaXQ6OldlYkVudGl0aWVzOjpXZWJFbnRpdGllcyk6CisKIDIw MTAtMDgtMjYgIE1pa2hhaWwgTmFnYW5vdiAgPG1uYWdhbm92QGNocm9taXVtLm9yZz4KIAogICAg ICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpJbmRleDogV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJFbnRpdGllcy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJF bnRpdGllcy5jcHAJKHJldmlzaW9uIDY2MTE2KQorKysgV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJF bnRpdGllcy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ0LDQ5ICs0NCwxNyBAQCB1c2luZyBuYW1l c3BhY2UgV2ViQ29yZTsKIAogbmFtZXNwYWNlIFdlYktpdCB7CiAKLW5hbWVzcGFjZSB7Ci0KLXZv aWQgcG9wdWxhdGVNYXBGcm9tWE1MRW50aXRpZXMoV1RGOjpIYXNoTWFwPGludCwgV1RGOjpTdHJp bmc+JiBtYXApCi17Ci0gICAgQVNTRVJUKG1hcC5pc0VtcHR5KCkpOwotICAgIG1hcC5zZXQoMHgw MDNjLCAibHQiKTsKLSAgICBtYXAuc2V0KDB4MDAzZSwgImd0Iik7Ci0gICAgbWFwLnNldCgweDAw MjYsICJhbXAiKTsKLSAgICBtYXAuc2V0KDB4MDAyNywgImFwb3MiKTsKLSAgICBtYXAuc2V0KDB4 MDAyMiwgInF1b3QiKTsKLX0KLQotdm9pZCBwb3B1bGF0ZU1hcEZyb21IVE1MRW50aXR5VGFibGUo V1RGOjpIYXNoTWFwPGludCwgV1RGOjpTdHJpbmc+JiBtYXApCi17Ci0gICAgQVNTRVJUKG1hcC5p c0VtcHR5KCkpOwotICAgIGNvbnN0IEhUTUxFbnRpdHlUYWJsZUVudHJ5KiBlbnRyeSA9IEhUTUxF bnRpdHlUYWJsZTo6Zmlyc3RFbnRyeSgpOwotICAgIGNvbnN0IEhUTUxFbnRpdHlUYWJsZUVudHJ5 KiBlbmQgPSBIVE1MRW50aXR5VGFibGU6Omxhc3RFbnRyeSgpICsgMTsKLSAgICBmb3IgKDsgZW50 cnkgIT0gZW5kOyArK2VudHJ5KSB7Ci0gICAgICAgIFN0cmluZyBlbnRpdHkgPSBlbnRyeS0+ZW50 aXR5OwotICAgICAgICBpbnQgdmFsdWUgPSBlbnRyeS0+dmFsdWU7Ci0gICAgICAgIEFTU0VSVCh2 YWx1ZSAmJiAhZW50aXR5LmlzRW1wdHkoKSk7Ci0gICAgICAgIGlmIChlbnRpdHlbZW50aXR5Lmxl bmd0aCgpIC0gMV0gIT0gJzsnKQotICAgICAgICAgICAgY29udGludWU7IC8vIFdlIHdhbnQgdGhl IGNhbm9uaWNhbCB2ZXJzaW9uIHRoYXQgZW5kcyBpbiA7Ci0gICAgICAgIC8vIEZvciBjb25zaXN0 ZW5jeSwgdXNlIHRoZSBsb3dlciBjYXNlIGZvciBlbnRpdGllcyB0aGF0IGhhdmUgYm90aC4KLSAg ICAgICAgaWYgKG1hcC5jb250YWlucyh2YWx1ZSkgJiYgbWFwLmdldCh2YWx1ZSkgPT0gZW50aXR5 Lmxvd2VyKCkpCi0gICAgICAgICAgICBjb250aW51ZTsKLSAgICAgICAgLy8gRG9uJ3QgcmVnaXN0 ZXIgJnBlcmNudDssICZuc3VwOyBhbmQgJnN1cGw7IGZvciBzb21lIHVua25vd24gcmVhc29uLgot ICAgICAgICBpZiAodmFsdWUgPT0gJyUnIHx8IHZhbHVlID09IDB4MjI4NSB8fCB2YWx1ZSA9PSAw eDAwYjkpCi0gICAgICAgICAgICBjb250aW51ZTsKLSAgICAgICAgbWFwLnNldCh2YWx1ZSwgZW50 aXR5KTsKLSAgICB9Ci0gICAgLy8gV2UgYWRkICMzOSBmb3Igc29tZSB1bmtub3duIHJlYXNvbi4K LSAgICBtYXAuc2V0KDB4MDAyNywgU3RyaW5nKCIjMzkiKSk7Ci19Ci0KLX0KLQogV2ViRW50aXRp ZXM6OldlYkVudGl0aWVzKGJvb2wgeG1sRW50aXRpZXMpCiB7Ci0gICAgaWYgKHhtbEVudGl0aWVz KQotICAgICAgICBwb3B1bGF0ZU1hcEZyb21YTUxFbnRpdGllcyhtX2VudGl0aWVzTWFwKTsKLSAg ICBlbHNlCi0gICAgICAgIHBvcHVsYXRlTWFwRnJvbUhUTUxFbnRpdHlUYWJsZShtX2VudGl0aWVz TWFwKTsKKyAgICBBU1NFUlQobV9lbnRpdGllc01hcC5pc0VtcHR5KCkpOworICAgIG1fZW50aXRp ZXNNYXAuc2V0KDB4MDAzYywgImx0Iik7CisgICAgbV9lbnRpdGllc01hcC5zZXQoMHgwMDNlLCAi Z3QiKTsKKyAgICBtX2VudGl0aWVzTWFwLnNldCgweDAwMjYsICJhbXAiKTsKKyAgICBtX2VudGl0 aWVzTWFwLnNldCgweDAwMjcsICJhcG9zIik7CisgICAgbV9lbnRpdGllc01hcC5zZXQoMHgwMDIy LCAicXVvdCIpOworICAgIC8vIFdlIGFkZCAjMzkgZm9yIHRlc3QtY29tcGF0aWJpbGl0eSByZWFz b24uCisgICAgaWYgKCF4bWxFbnRpdGllcykKKyAgICAgICAgbV9lbnRpdGllc01hcC5zZXQoMHgw MDI3LCBTdHJpbmcoIiMzOSIpKTsKIH0KIAogU3RyaW5nIFdlYkVudGl0aWVzOjplbnRpdHlOYW1l QnlDb2RlKGludCBjb2RlKSBjb25zdAo=