44699 2010-08-26 11:18:13 -0700 [Gtk] Reduce the size of the shadow buffer in the paths using the clip region 2010-09-13 12:06:49 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 alex webkit-unassigned ariya.hidayat krit mrobinson oldest_to_newest 269972 0 alex 2010-08-26 11:18:13 -0700 Currently we are creating shadows using the complete size of the element in the page, we can use the clip information to reduce that size. 269985 1 65587 alex 2010-08-26 11:25:40 -0700 Created attachment 65587 Proposed patch 270108 2 mrobinson 2010-08-26 14:09:54 -0700 Does this patch net any performance improvements on its own? 270144 3 alex 2010-08-26 15:06:20 -0700 (In reply to comment #2) > Does this patch net any performance improvements on its own? Yep, mostly when scrolling a webpage, we blur a rect as big as the scroll movement, and also for big pages we only blur the viewport part even if the page is bigger than that, for instance identi.ca. 270584 4 mrobinson 2010-08-27 10:44:16 -0700 Is it possible to make calculateShadowBufferDimensions a non-static method and to do this there? That way we could benefit from this improvement at all call sites. 271388 5 alex 2010-08-30 04:29:07 -0700 (In reply to comment #4) > Is it possible to make calculateShadowBufferDimensions a non-static method and to do this there? That way we could benefit from this improvement at all call sites. It is, I planned this patch just to make it the rects because they are the main issue nowadays. I'll review the patch. 272009 6 65587 kenneth 2010-08-31 03:12:32 -0700 Comment on attachment 65587 Proposed patch Seems like a good optimization. Remember to add a dot at the end of comments. 272146 7 mrobinson 2010-08-31 09:45:44 -0700 Do you mind creating a static function that take a rectangle and intersects it with the current Cairo clip? It could be passed an optional minimumSize argument. I think we may want to use this optimization in other places later on. IntRect intersectRectWithCurrentCairoClip(cairo_t*, IntRect, int minimumSize=0); Thanks. 278361 8 alex 2010-09-13 11:53:38 -0700 Committing this patch after talking to martin we will leave the generalization for the contextshadow patch in the bug 45599. 278371 9 alex 2010-09-13 12:06:49 -0700 Landed r67402 65587 2010-08-26 11:25:40 -0700 2010-08-31 03:12:32 -0700 Proposed patch clipping_rect.patch text/plain 2405 alex ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZGE5M2E5Yi4uYjkyNjY5ZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wOC0yNiAgQWxlamFuZHJvIEcu IENhc3RybyAgPGFsZXhAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbR3RrXSBSZWR1Y2UgdGhlIHNpemUgb2YgdGhlIHNoYWRvdyBi dWZmZXIgaW4gdGhlIHBhdGhzIHVzaW5nIHRoZSBjbGlwIHJlZ2lvbgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDQ2OTkKKworICAgICAgICBJbnRlcnNl Y3QgdGhlIGNsaXAgYm91bmRpbmcgcmVjdCB3aXRoIHRoZSBwYXRoIHRoYXQgd2UgYXJlIGdvaW5n CisgICAgICAgIHRvIHVzZSB0byBjcmVhdGUgdGhlIHNoYWRvdyBpbiBvcmRlciB0byByZWR1Y2Ug dGhlIHJlZ2lvbiB3ZSBoYXZlCisgICAgICAgIHRvIGJsdXIuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRDYWlyby5jcHA6CisgICAgICAgIChXZWJD b3JlOjpkcmF3UGF0aFNoYWRvdyk6CisKIDIwMTAtMDgtMjUgIElseWEgVGlraG9ub3Zza3kgIDxs b2lzbG9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4u CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29u dGV4dENhaXJvLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3ND b250ZXh0Q2Fpcm8uY3BwCmluZGV4IDY4M2MxNDQuLjRjMWJiNzQgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3BwCisrKyBi L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3Bw CkBAIC0yMTMsMTMgKzIxMywyOSBAQCBzdGF0aWMgaW5saW5lIHZvaWQgZHJhd1BhdGhTaGFkb3co R3JhcGhpY3NDb250ZXh0KiBjb250ZXh0LCBHcmFwaGljc0NvbnRleHRQcml2YQogICAgIGZsb2F0 IHJhZGl1cyA9IDA7CiAgICAgR3JhcGhpY3NDb250ZXh0OjpjYWxjdWxhdGVTaGFkb3dCdWZmZXJE aW1lbnNpb25zKHNoYWRvd0J1ZmZlclNpemUsIHNoYWRvd1JlY3QsIHJhZGl1cywgcmVjdCwgc2hh ZG93T2Zmc2V0LCBzaGFkb3dCbHVyKTsKIAorICAgIGNhaXJvX2NsaXBfZXh0ZW50cyhjciwgJngw LCAmeTAsICZ4MSwgJnkxKTsKKyAgICBGbG9hdFJlY3QgY2xpcFJlY3QoeDAsIHkwLCB4MSAtIHgw LCB5MSAtIHkwKTsKKworICAgIEZsb2F0UG9pbnQgcmVjdExvY2F0aW9uID0gc2hhZG93UmVjdC5s b2NhdGlvbigpOworCisgICAgLy8gUmVkdWNlIHRoZSBzaGFkb3cgcmVjdCB1c2luZyB0aGUgY2xp cCBhcmVhCisgICAgaWYgKCFjbGlwUmVjdC5jb250YWlucyhzaGFkb3dSZWN0KSkgeworICAgICAg ICBzaGFkb3dSZWN0LmludGVyc2VjdChjbGlwUmVjdCk7CisgICAgICAgIGlmIChzaGFkb3dSZWN0 LmlzRW1wdHkoKSkKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgc2hhZG93UmVjdC5pbmZs YXRlKHJhZGl1cyk7CisgICAgICAgIHNoYWRvd0J1ZmZlclNpemUgPSBJbnRTaXplKHNoYWRvd1Jl Y3Qud2lkdGgoKSwgc2hhZG93UmVjdC5oZWlnaHQoKSk7CisgICAgfQorCisgICAgc2hhZG93T2Zm c2V0ID0gcmVjdExvY2F0aW9uIC0gc2hhZG93UmVjdC5sb2NhdGlvbigpOworCiAgICAgLy8gQ3Jl YXRlIHN1aXRhYmx5LXNpemVkIEltYWdlQnVmZmVyIHRvIGhvbGQgdGhlIHNoYWRvdy4KICAgICBP d25QdHI8SW1hZ2VCdWZmZXI+IHNoYWRvd0J1ZmZlciA9IEltYWdlQnVmZmVyOjpjcmVhdGUoc2hh ZG93QnVmZmVyU2l6ZSk7CiAKICAgICAvLyBEcmF3IHNoYWRvdyBpbnRvIGEgbmV3IEltYWdlQnVm ZmVyLgogICAgIGNhaXJvX3QqIHNoYWRvd0NvbnRleHQgPSBzaGFkb3dCdWZmZXItPmNvbnRleHQo KS0+cGxhdGZvcm1Db250ZXh0KCk7CiAgICAgY29weUNvbnRleHRQcm9wZXJ0aWVzKGNyLCBzaGFk b3dDb250ZXh0KTsKLSAgICBjYWlyb190cmFuc2xhdGUoc2hhZG93Q29udGV4dCwgLXJlY3QueCgp ICsgcmFkaXVzLCAtcmVjdC55KCkgKyByYWRpdXMpOworICAgIGNhaXJvX3RyYW5zbGF0ZShzaGFk b3dDb250ZXh0LCAtcmVjdC54KCkgKyByYWRpdXMgKyBzaGFkb3dPZmZzZXQud2lkdGgoKSwgLXJl Y3QueSgpICsgcmFkaXVzICsgc2hhZG93T2Zmc2V0LmhlaWdodCgpKTsKICAgICBjYWlyb19uZXdf cGF0aChzaGFkb3dDb250ZXh0KTsKICAgICBjYWlyb19hcHBlbmRfcGF0aChzaGFkb3dDb250ZXh0 LCBwYXRoKTsKIAo=