44697 2010-08-26 11:16:16 -0700 [Qt] tst_QWebFrame::connectAndDisconnect() fails on WebKit trunk because __qt_sender__ is never set 2010-09-09 13:52:18 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Major --- 44675 1 benjamin kent.hansen ademar benjamin jedrzej.nowacki oldest_to_newest 269969 0 benjamin 2010-08-26 11:16:16 -0700 The test tst_QWebFrame::connectAndDisconnect() fails on recent WebKit. This test does not fail on QtWebKit 2.0, but it does fail on WebKit trunk and WebKit 2.1. The outcome of the test is the following: FAIL! : tst_QWebFrame::connectAndDisconnect() Compared values are not the same Actual (evalJS("signalSender")): undefined Expected (evalJS("myObject")): Loc: [/home/ikipou/dev/webkit/qtwebkit/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp(1488)] It seems __qt_sender__ is never set in the context of the function call. 272469 1 kling 2010-08-31 16:21:25 -0700 *** Bug 41066 has been marked as a duplicate of this bug. *** 274914 2 66695 kent.hansen 2010-09-07 02:07:12 -0700 Created attachment 66695 Patch 274953 3 66695 kling 2010-09-07 04:01:20 -0700 Comment on attachment 66695 Patch r=me 274956 4 kent.hansen 2010-09-07 04:16:22 -0700 Committed r66875: <http://trac.webkit.org/changeset/66875> 276725 5 ademar 2010-09-09 13:52:18 -0700 Revision r66875 cherry-picked into qtwebkit-2.1 with commit a64f996864afde31b00d787522d47d1222a8f756 66695 2010-09-07 02:07:12 -0700 2010-09-07 04:01:20 -0700 Patch 44697.txt text/plain 3309 kent.hansen ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NzA3Zjg1NS4uYmFhYzVmMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAxMC0wOS0wNyAgS2VudCBIYW5zZW4g IDxrZW50LmhhbnNlbkBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgW1F0XSB0c3RfUVdlYkZyYW1lOjpjb25uZWN0QW5kRGlzY29ubmVj dCgpIGZhaWxzIG9uIFdlYktpdCB0cnVuayBiZWNhdXNlIF9fcXRfc2VuZGVyX18gaXMgbmV2ZXIg c2V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDY5 NworCisgICAgICAgIFdoZW4gdGhlIHNpZ25hbCBoYW5kbGVyIGlzIGEgSlMgZnVuY3Rpb24sIF9f cXRfc2VuZGVyX18gaXMgc3R1ZmZlZCBpbnRvIGEgdGVtcG9yYXJ5CisgICAgICAgIG9iamVjdCB0 aGF0J3MgcHVzaGVkIG9udG8gdGhlIGZ1bmN0aW9uJ3Mgc2NvcGUgYmVmb3JlIHRoZSBmdW5jdGlv biBpcyBpbnZva2VkLCBhbmQKKyAgICAgICAgcG9wcGVkIGFnYWluIGFmdGVyd2FyZHMuCisKKyAg ICAgICAgV2Ugd2VyZSBwdXNoaW5nIHRoaXMgbmV3IHNjb3BlIG9iamVjdCBfYWZ0ZXJfIGNhbGxp bmcgSlNGdW5jdGlvbjo6Z2V0Q2FsbERhdGEoKSwKKyAgICAgICAgYW5kIHJlbHlpbmcgb24gSlND OjpjYWxsKCkgdG8gdXNlIHRoZSBmcmVzaCBzY29wZSBjaGFpbiBmcm9tIHRoZSBmdW5jdGlvbiBv YmplY3QuCisgICAgICAgIEhvd2V2ZXIsIHRoaXMgaXMgbm8gbG9uZ2VyIHRoZSBjYXNlOyBKU0M6 OmNhbGwoKSB1c2VzIHRoZSBzY29wZSBjaGFpbiBwYXNzZWQgaW4KKyAgICAgICAgdGhlIENhbGxE YXRhIGFyZ3VtZW50LiBIZW5jZSwgd2UgbmVlZCB0byBzZXQgdXAgdGhlIHNjb3BlIGJlZm9yZSB0 aGUgZnVuY3Rpb24ncworICAgICAgICBDYWxsRGF0YSBpcyBxdWVyaWVkLgorCisgICAgICAgICog YnJpZGdlL3F0L3F0X3J1bnRpbWUuY3BwOgorICAgICAgICAoSlNDOjpCaW5kaW5nczo6UXRDb25u ZWN0aW9uT2JqZWN0OjpleGVjdXRlKToKKwogMjAxMC0wOC0zMSAgTmlrb2xhcyBaaW1tZXJtYW5u ICA8bnppbW1lcm1hbm5AcmltLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaXJrIFNjaHVs emUuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2JyaWRnZS9xdC9xdF9ydW50aW1lLmNwcCBiL1dlYkNv cmUvYnJpZGdlL3F0L3F0X3J1bnRpbWUuY3BwCmluZGV4IDYzMGZkMmYuLmNlNDU2N2EgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvYnJpZGdlL3F0L3F0X3J1bnRpbWUuY3BwCisrKyBiL1dlYkNvcmUvYnJp ZGdlL3F0L3F0X3J1bnRpbWUuY3BwCkBAIC0xNzkzLDI2ICsxNzkzLDI4IEBAIHZvaWQgUXRDb25u ZWN0aW9uT2JqZWN0OjpleGVjdXRlKHZvaWQgKiphcmd2KQogICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGwuYXBwZW5kKGpzVW5kZWZpbmVkKCkpOwogICAgICAgICAgICAgICAgICAgICAgICAg fQogICAgICAgICAgICAgICAgICAgICB9Ci0gICAgICAgICAgICAgICAgICAgIENhbGxEYXRhIGNh bGxEYXRhOwotICAgICAgICAgICAgICAgICAgICBDYWxsVHlwZSBjYWxsVHlwZSA9IG1fZnVuY09i amVjdC0+Z2V0Q2FsbERhdGEoY2FsbERhdGEpOwogICAgICAgICAgICAgICAgICAgICAvLyBTdHVm ZiBpbiB0aGUgX19xdF9zZW5kZXIgcHJvcGVydHksIGlmIHdlIGNhbgorICAgICAgICAgICAgICAg ICAgICBTY29wZUNoYWluIG9sZHNjID0gU2NvcGVDaGFpbihOb1Njb3BlQ2hhaW4oKSk7CisgICAg ICAgICAgICAgICAgICAgIEpTRnVuY3Rpb24qIGZpbXAgPSAwOwogICAgICAgICAgICAgICAgICAg ICBpZiAobV9mdW5jT2JqZWN0LT5pbmhlcml0cygmSlNGdW5jdGlvbjo6aW5mbykpIHsKLSAgICAg ICAgICAgICAgICAgICAgICAgIEpTRnVuY3Rpb24qIGZpbXAgPSBzdGF0aWNfY2FzdDxKU0Z1bmN0 aW9uKj4obV9mdW5jT2JqZWN0LmdldCgpKTsKKyAgICAgICAgICAgICAgICAgICAgICAgIGZpbXAg PSBzdGF0aWNfY2FzdDxKU0Z1bmN0aW9uKj4obV9mdW5jT2JqZWN0LmdldCgpKTsKIAogICAgICAg ICAgICAgICAgICAgICAgICAgSlNPYmplY3QqIHF0X3NlbmRlciA9IFF0SW5zdGFuY2U6OmdldFF0 SW5zdGFuY2Uoc2VuZGVyKCksIHJvLCBRU2NyaXB0RW5naW5lOjpRdE93bmVyc2hpcCktPmNyZWF0 ZVJ1bnRpbWVPYmplY3QoZXhlYyk7CiAgICAgICAgICAgICAgICAgICAgICAgICBKU09iamVjdCog d3JhcHBlciA9IG5ldyAoZXhlYykgSlNPYmplY3QoSlNPYmplY3Q6OmNyZWF0ZVN0cnVjdHVyZShq c051bGwoKSkpOwogICAgICAgICAgICAgICAgICAgICAgICAgUHV0UHJvcGVydHlTbG90IHNsb3Q7 CiAgICAgICAgICAgICAgICAgICAgICAgICB3cmFwcGVyLT5wdXQoZXhlYywgSWRlbnRpZmllcihl eGVjLCAiX19xdF9zZW5kZXJfXyIpLCBxdF9zZW5kZXIsIHNsb3QpOwotICAgICAgICAgICAgICAg ICAgICAgICAgU2NvcGVDaGFpbiBvbGRzYyA9IGZpbXAtPnNjb3BlKCk7CisgICAgICAgICAgICAg ICAgICAgICAgICBvbGRzYyA9IGZpbXAtPnNjb3BlKCk7CiAgICAgICAgICAgICAgICAgICAgICAg ICBTY29wZUNoYWluIHNjID0gb2xkc2M7CiAgICAgICAgICAgICAgICAgICAgICAgICBzYy5wdXNo KHdyYXBwZXIpOwogICAgICAgICAgICAgICAgICAgICAgICAgZmltcC0+c2V0U2NvcGUoc2MpOwor ICAgICAgICAgICAgICAgICAgICB9CisKKyAgICAgICAgICAgICAgICAgICAgQ2FsbERhdGEgY2Fs bERhdGE7CisgICAgICAgICAgICAgICAgICAgIENhbGxUeXBlIGNhbGxUeXBlID0gbV9mdW5jT2Jq ZWN0LT5nZXRDYWxsRGF0YShjYWxsRGF0YSk7CisgICAgICAgICAgICAgICAgICAgIGNhbGwoZXhl YywgbV9mdW5jT2JqZWN0LCBjYWxsVHlwZSwgY2FsbERhdGEsIG1fdGhpc09iamVjdCwgbCk7CiAK LSAgICAgICAgICAgICAgICAgICAgICAgIGNhbGwoZXhlYywgZmltcCwgY2FsbFR5cGUsIGNhbGxE YXRhLCBtX3RoaXNPYmplY3QsIGwpOworICAgICAgICAgICAgICAgICAgICBpZiAoZmltcCkKICAg ICAgICAgICAgICAgICAgICAgICAgIGZpbXAtPnNldFNjb3BlKG9sZHNjKTsKLSAgICAgICAgICAg ICAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgICAgICAgICAgICAgIGNhbGwoZXhlYywgbV9m dW5jT2JqZWN0LCBjYWxsVHlwZSwgY2FsbERhdGEsIG1fdGhpc09iamVjdCwgbCk7Ci0gICAgICAg ICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICB9CiAgICAgICAg IH0K