44693 2010-08-26 09:30:35 -0700 [WINCE] Port SoftLinking to WinCE 2010-08-27 17:55:28 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 paroga webkit-unassigned aroben commit-queue webkit.review.bot oldest_to_newest 269927 0 paroga 2010-08-26 09:30:35 -0700 WinCE provides GetProcAddressW and GetProcAddressA for softlinking. Unfortunately WinNT provides only GetProcAddress (without A or W). 270097 1 65614 paroga 2010-08-26 13:50:16 -0700 Created attachment 65614 Patch 270098 2 webkit.review.bot 2010-08-26 13:51:18 -0700 Attachment 65614 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/win/SoftLinking.h:57: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 270111 3 65614 aroben 2010-08-26 14:24:20 -0700 Comment on attachment 65614 Patch > + Add a platformdependent macro for GetProcAddress. Typo: platformdependent > +#if OS(WINCE) > +#define SOFT_LINK_GETPROCADDRESS(library, functionName) GetProcAddressW(library##Library(), L###functionName) > +#else > +#define SOFT_LINK_GETPROCADDRESS(library, functionName) GetProcAddress(library##Library(), #functionName) > +#endif Should we use GetProcAddressA on WinCE? GetProcAddress on NT is ANSI-only IIRC. r+ since the code looks fine, but you should consider the above. 270128 4 65620 paroga 2010-08-26 14:46:39 -0700 Created attachment 65620 Patch 270130 5 webkit.review.bot 2010-08-26 14:48:50 -0700 Attachment 65620 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/win/SoftLinking.h:57: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 270135 6 65620 aroben 2010-08-26 14:55:26 -0700 Comment on attachment 65620 Patch r=me 270856 7 65620 commit-queue 2010-08-27 17:55:24 -0700 Comment on attachment 65620 Patch Clearing flags on attachment: 65620 Committed r66286: <http://trac.webkit.org/changeset/66286> 270857 8 commit-queue 2010-08-27 17:55:28 -0700 All reviewed patches have been landed. Closing bug. 65614 2010-08-26 13:50:16 -0700 2010-08-26 14:46:39 -0700 Patch 0001-SoftLinking.patch text/plain 2225 paroga ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MWE0NjE1Ni4uMWU3NGVmYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wOC0yNyAgUGF0cmljayBHYW5z dGVyZXIgIDxwYXJvZ2FAcGFyb2dhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbV0lOQ0VdIFBvcnQgU29mdExpbmtpbmcgdG8gV2luQ0UKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0NjkzCisKKyAg ICAgICAgV2luQ0UgcHJvdmlkZXMgR2V0UHJvY0FkZHJlc3NXIGFuZCBHZXRQcm9jQWRkcmVzc0Eg Zm9yIHNvZnRsaW5raW5nLgorICAgICAgICBVbmZvcnR1bmF0ZWx5IFdpbk5UIHByb3ZpZGVzIG9u bHkgR2V0UHJvY0FkZHJlc3MgKHdpdGhvdXQgQSBvciBXKS4KKworICAgICAgICBBZGQgYSBwbGF0 Zm9ybWRlcGVuZGVudCBtYWNybyBmb3IgR2V0UHJvY0FkZHJlc3MuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS93aW4vU29mdExpbmtpbmcuaDoKKwogMjAxMC0wOC0yNiAgUGF0cmljayBHYW5zdGVyZXIg IDxwYXJvZ2FAcGFyb2dhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vd2luL1NvZnRMaW5raW5nLmggYi9XZWJD b3JlL3BsYXRmb3JtL3dpbi9Tb2Z0TGlua2luZy5oCmluZGV4IGE4MmZlMzUuLmMyNWU2MWUgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vd2luL1NvZnRMaW5raW5nLmgKKysrIGIvV2ViQ29y ZS9wbGF0Zm9ybS93aW4vU29mdExpbmtpbmcuaApAQCAtMzksNiArMzksMTIgQEAKICAgICAgICAg cmV0dXJuIGxpYnJhcnk7IFwKICAgICB9CiAKKyNpZiBPUyhXSU5DRSkKKyNkZWZpbmUgU09GVF9M SU5LX0dFVFBST0NBRERSRVNTKGxpYnJhcnksIGZ1bmN0aW9uTmFtZSkgR2V0UHJvY0FkZHJlc3NX KGxpYnJhcnkjI0xpYnJhcnkoKSwgTCMjI2Z1bmN0aW9uTmFtZSkKKyNlbHNlCisjZGVmaW5lIFNP RlRfTElOS19HRVRQUk9DQUREUkVTUyhsaWJyYXJ5LCBmdW5jdGlvbk5hbWUpIEdldFByb2NBZGRy ZXNzKGxpYnJhcnkjI0xpYnJhcnkoKSwgI2Z1bmN0aW9uTmFtZSkKKyNlbmRpZgorCiAjZGVmaW5l IFNPRlRfTElOS19MSUJSQVJZKGxpYikgU09GVF9MSU5LX0xJQlJBUllfSEVMUEVSKGxpYiwgTCIu ZGxsIikKICNkZWZpbmUgU09GVF9MSU5LX0RFQlVHX0xJQlJBUlkobGliKSBTT0ZUX0xJTktfTElC UkFSWV9IRUxQRVIobGliLCBMIl9kZWJ1Zy5kbGwiKQogCkBAIC00OCw3ICs1NCw3IEBACiAgICAg XAogICAgIHN0YXRpYyByZXN1bHRUeXBlIGNhbGxpbmdDb252ZW50aW9uIGluaXQjI2Z1bmN0aW9u TmFtZSBwYXJhbWV0ZXJEZWNsYXJhdGlvbnMgXAogICAgIHsgXAotICAgICAgICBzb2Z0TGluayMj ZnVuY3Rpb25OYW1lID0gcmVpbnRlcnByZXRfY2FzdDxyZXN1bHRUeXBlIChjYWxsaW5nQ29udmVu dGlvbiopIHBhcmFtZXRlckRlY2xhcmF0aW9ucz4oR2V0UHJvY0FkZHJlc3MobGlicmFyeSMjTGli cmFyeSgpLCAjZnVuY3Rpb25OYW1lKSk7IFwKKyAgICAgICAgc29mdExpbmsjI2Z1bmN0aW9uTmFt ZSA9IHJlaW50ZXJwcmV0X2Nhc3Q8cmVzdWx0VHlwZSAoY2FsbGluZ0NvbnZlbnRpb24qKSBwYXJh bWV0ZXJEZWNsYXJhdGlvbnM+KFNPRlRfTElOS19HRVRQUk9DQUREUkVTUyhsaWJyYXJ5LCBmdW5j dGlvbk5hbWUpKTsgXAogICAgICAgICBBU1NFUlQoc29mdExpbmsjI2Z1bmN0aW9uTmFtZSk7IFwK ICAgICAgICAgcmV0dXJuIHNvZnRMaW5rIyNmdW5jdGlvbk5hbWUgcGFyYW1ldGVyTmFtZXM7IFwK ICAgICB9XApAQCAtNjksNyArNzUsNyBAQAogICAgICAgICAgICAgcmV0dXJuIHB0cjsgXAogICAg ICAgICBpbml0aWFsaXplZCA9IHRydWU7IFwKICAgICAgICAgXAotICAgICAgICBwdHIgPSByZWlu dGVycHJldF9jYXN0PGZ1bmN0aW9uTmFtZSMjUHRyVHlwZT4oR2V0UHJvY0FkZHJlc3MobGlicmFy eSMjTGlicmFyeSgpLCAjZnVuY3Rpb25OYW1lKSk7IFwKKyAgICAgICAgcHRyID0gcmVpbnRlcnBy ZXRfY2FzdDxmdW5jdGlvbk5hbWUjI1B0clR5cGU+KFNPRlRfTElOS19HRVRQUk9DQUREUkVTUyhs aWJyYXJ5LCBmdW5jdGlvbk5hbWUpKTsgXAogICAgICAgICByZXR1cm4gcHRyOyBcCiAgICAgfVwK IAo= 65620 2010-08-26 14:46:39 -0700 2010-08-27 17:55:24 -0700 Patch 0001-SoftLinking.patch text/plain 2131 paroga ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MWE0NjE1Ni4uMWU3NGVmYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wOC0yNyAgUGF0cmljayBHYW5z dGVyZXIgIDxwYXJvZ2FAcGFyb2dhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbV0lOQ0VdIFBvcnQgU29mdExpbmtpbmcgdG8gV2luQ0UKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0NjkzCisKKyAg ICAgICAgV2luQ0UgcHJvdmlkZXMgR2V0UHJvY0FkZHJlc3NXIGFuZCBHZXRQcm9jQWRkcmVzc0Eg Zm9yIHNvZnRsaW5raW5nLgorICAgICAgICBVbmZvcnR1bmF0ZWx5IFdpbk5UIHByb3ZpZGVzIG9u bHkgR2V0UHJvY0FkZHJlc3MgKHdpdGhvdXQgQSBvciBXKS4KKworICAgICAgICBBZGQgYSBwbGF0 Zm9ybSBkZXBlbmRlbnQgbWFjcm8gZm9yIEdldFByb2NBZGRyZXNzLgorCisgICAgICAgICogcGxh dGZvcm0vd2luL1NvZnRMaW5raW5nLmg6CisKIDIwMTAtMDgtMjYgIFBhdHJpY2sgR2Fuc3RlcmVy ICA8cGFyb2dhQHBhcm9nYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9Tb2Z0TGlua2luZy5oIGIvV2Vi Q29yZS9wbGF0Zm9ybS93aW4vU29mdExpbmtpbmcuaAppbmRleCBhODJmZTM1Li5iNjdjYzgxIDEw MDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9Tb2Z0TGlua2luZy5oCisrKyBiL1dlYkNv cmUvcGxhdGZvcm0vd2luL1NvZnRMaW5raW5nLmgKQEAgLTM5LDYgKzM5LDEyIEBACiAgICAgICAg IHJldHVybiBsaWJyYXJ5OyBcCiAgICAgfQogCisjaWYgT1MoV0lOQ0UpCisjZGVmaW5lIFNPRlRf TElOS19HRVRQUk9DQUREUkVTUyBHZXRQcm9jQWRkcmVzc0EKKyNlbHNlCisjZGVmaW5lIFNPRlRf TElOS19HRVRQUk9DQUREUkVTUyBHZXRQcm9jQWRkcmVzcworI2VuZGlmCisKICNkZWZpbmUgU09G VF9MSU5LX0xJQlJBUlkobGliKSBTT0ZUX0xJTktfTElCUkFSWV9IRUxQRVIobGliLCBMIi5kbGwi KQogI2RlZmluZSBTT0ZUX0xJTktfREVCVUdfTElCUkFSWShsaWIpIFNPRlRfTElOS19MSUJSQVJZ X0hFTFBFUihsaWIsIEwiX2RlYnVnLmRsbCIpCiAKQEAgLTQ4LDcgKzU0LDcgQEAKICAgICBcCiAg ICAgc3RhdGljIHJlc3VsdFR5cGUgY2FsbGluZ0NvbnZlbnRpb24gaW5pdCMjZnVuY3Rpb25OYW1l IHBhcmFtZXRlckRlY2xhcmF0aW9ucyBcCiAgICAgeyBcCi0gICAgICAgIHNvZnRMaW5rIyNmdW5j dGlvbk5hbWUgPSByZWludGVycHJldF9jYXN0PHJlc3VsdFR5cGUgKGNhbGxpbmdDb252ZW50aW9u KikgcGFyYW1ldGVyRGVjbGFyYXRpb25zPihHZXRQcm9jQWRkcmVzcyhsaWJyYXJ5IyNMaWJyYXJ5 KCksICNmdW5jdGlvbk5hbWUpKTsgXAorICAgICAgICBzb2Z0TGluayMjZnVuY3Rpb25OYW1lID0g cmVpbnRlcnByZXRfY2FzdDxyZXN1bHRUeXBlIChjYWxsaW5nQ29udmVudGlvbiopIHBhcmFtZXRl ckRlY2xhcmF0aW9ucz4oU09GVF9MSU5LX0dFVFBST0NBRERSRVNTKGxpYnJhcnkjI0xpYnJhcnko KSwgI2Z1bmN0aW9uTmFtZSkpOyBcCiAgICAgICAgIEFTU0VSVChzb2Z0TGluayMjZnVuY3Rpb25O YW1lKTsgXAogICAgICAgICByZXR1cm4gc29mdExpbmsjI2Z1bmN0aW9uTmFtZSBwYXJhbWV0ZXJO YW1lczsgXAogICAgIH1cCkBAIC02OSw3ICs3NSw3IEBACiAgICAgICAgICAgICByZXR1cm4gcHRy OyBcCiAgICAgICAgIGluaXRpYWxpemVkID0gdHJ1ZTsgXAogICAgICAgICBcCi0gICAgICAgIHB0 ciA9IHJlaW50ZXJwcmV0X2Nhc3Q8ZnVuY3Rpb25OYW1lIyNQdHJUeXBlPihHZXRQcm9jQWRkcmVz cyhsaWJyYXJ5IyNMaWJyYXJ5KCksICNmdW5jdGlvbk5hbWUpKTsgXAorICAgICAgICBwdHIgPSBy ZWludGVycHJldF9jYXN0PGZ1bmN0aW9uTmFtZSMjUHRyVHlwZT4oU09GVF9MSU5LX0dFVFBST0NB RERSRVNTKGxpYnJhcnkjI0xpYnJhcnkoKSwgI2Z1bmN0aW9uTmFtZSkpOyBcCiAgICAgICAgIHJl dHVybiBwdHI7IFwKICAgICB9XAogCg==