44684 2010-08-26 06:50:05 -0700 Web Inspector: It would be better to have an explicit type check for the all arguments of InspectorBackend functions on front-end side. 2010-09-07 01:14:54 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 loislo loislo bweinstein joepeck keishi pfeldman pmuellr rik timothy yurys oldest_to_newest 269856 0 loislo 2010-08-26 06:50:05 -0700 %subj% 269862 1 65556 loislo 2010-08-26 06:56:50 -0700 Created attachment 65556 [patch] initial version. 274891 2 65556 loislo 2010-09-07 01:14:45 -0700 Comment on attachment 65556 [patch] initial version. landed 65556 2010-08-26 06:56:50 -0700 2010-09-07 01:14:45 -0700 [patch] initial version. patch text/plain 2331 loislo ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZWMzMjliOC4uYjg5MmM2OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNSBAQAogMjAxMC0wOC0yNiAgSWx5YSBUaWtob25v dnNreSAgPGxvaXNsb0BjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2ViSW5zcGVjdG9yOiBJdCB3b3VsZCBiZSBiZXR0ZXIgdG8g aGF2ZSBhbiBleHBsaWNpdCB0eXBlIGNoZWNrIGZvciB0aGUgYWxsCisgICAgICAgIGFyZ3VtZW50 cyBvZiBJbnNwZWN0b3JCYWNrZW5kIGZ1bmN0aW9ucyBvbiBmcm9udC1lbmQgc2lkZS4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0Njg0CisKKyAgICAg ICAgKiBpbnNwZWN0b3IvQ29kZUdlbmVyYXRvckluc3BlY3Rvci5wbToKKworMjAxMC0wOC0yNiAg SWx5YSBUaWtob25vdnNreSAgPGxvaXNsb0BjaHJvbWl1bS5vcmc+CisKICAgICAgICAgUmV2aWV3 ZWQgYnkgWXVyeSBTZW1pa2hhdHNreS4KIAogICAgICAgICBXZWJJbnNwZWN0b3I6IEl0IHdvdWxk IGJlIGJldHRlciB0byByZW5hbWUgc2V0Qm9vbCwgcHVzaEJvb2wgYW5kIGFzQm9vbCBhY2Nlc3Nv cnMKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL0NvZGVHZW5lcmF0b3JJbnNwZWN0b3Iu cG0gYi9XZWJDb3JlL2luc3BlY3Rvci9Db2RlR2VuZXJhdG9ySW5zcGVjdG9yLnBtCmluZGV4IDA5 YWYzMDUuLmJjNjUwYmEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL0NvZGVHZW5lcmF0 b3JJbnNwZWN0b3IucG0KKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvQ29kZUdlbmVyYXRvckluc3Bl Y3Rvci5wbQpAQCAtNTAyLDcgKzUwMiw3IEBAIHN1YiBnZW5lcmF0ZUJhY2tlbmRTdHViSlMKICAg ICBmb3JlYWNoIG15ICRmdW5jdGlvbiAoQGJhY2tlbmRGdW5jdGlvbnMpIHsKICAgICAgICAgbXkg JG5hbWUgPSAkZnVuY3Rpb24tPnNpZ25hdHVyZS0+bmFtZTsKICAgICAgICAgbXkgJGRvbWFpbiA9 ICRmdW5jdGlvbi0+c2lnbmF0dXJlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiaGFuZGxlciJ9Owot ICAgICAgICBteSAkYXJndW1lbnROYW1lcyA9IGpvaW4oIiwiLCBtYXAoIlwiIiAuICRfLT5uYW1l IC4gIlwiOiBudWxsIiwgZ3JlcCgkXy0+ZGlyZWN0aW9uIGVxICJpbiIsIEB7JGZ1bmN0aW9uLT5w YXJhbWV0ZXJzfSkpKTsKKyAgICAgICAgbXkgJGFyZ3VtZW50TmFtZXMgPSBqb2luKCIsIiwgbWFw KCJcIiIgLiAkXy0+bmFtZSAuICJcIjogXCIiIC4gbGMoJHR5cGVUcmFuc2Zvcm17JF8tPnR5cGV9 LT57IkpTT05UeXBlIn0pIC4gIlwiIiwgZ3JlcCgkXy0+ZGlyZWN0aW9uIGVxICJpbiIsIEB7JGZ1 bmN0aW9uLT5wYXJhbWV0ZXJzfSkpKTsKICAgICAgICAgcHVzaChASlNTdHVicywgIiAgICB0aGlz Ll9yZWdpc3RlckRlbGVnYXRlKCd7IiAuCiAgICAgICAgICAgICAiXCJzZXFcIjogMCwgIiAuCiAg ICAgICAgICAgICAiXCJkb21haW5cIjogXCIkZG9tYWluXCIsICIgLgpAQCAtNTMyLDggKzUzMiwx MiBAQCBXZWJJbnNwZWN0b3IuSW5zcGVjdG9yQmFja2VuZFN0dWIucHJvdG90eXBlID0gewogICAg ICAgICB2YXIgYXJncyA9IEFycmF5LnByb3RvdHlwZS5zbGljZS5jYWxsKGFyZ3VtZW50cyk7CiAg ICAgICAgIHZhciByZXF1ZXN0ID0gSlNPTi5wYXJzZShhcmdzLnNoaWZ0KCkpOwogCi0gICAgICAg IGZvciAodmFyIGtleSBpbiByZXF1ZXN0LmFyZ3VtZW50cykKLSAgICAgICAgICAgIHJlcXVlc3Qu YXJndW1lbnRzW2tleV0gPSBhcmdzLnNoaWZ0KCk7CisgICAgICAgIGZvciAodmFyIGtleSBpbiBy ZXF1ZXN0LmFyZ3VtZW50cykgeworICAgICAgICAgICAgdmFyIHZhbHVlID0gYXJncy5zaGlmdCgp OworICAgICAgICAgICAgaWYgKHR5cGVvZiB2YWx1ZSAhPT0gcmVxdWVzdC5hcmd1bWVudHNba2V5 XSkKKyAgICAgICAgICAgICAgICB0aHJvdygiSW52YWxpZCB0eXBlIG9mIHByb3BlcnR5ICIgKyBr ZXkgKyAiLiBJdCBzaG91bGQgYmUgJyIgKyByZXF1ZXN0LmFyZ3VtZW50c1trZXldICsgIicgYnV0 IGl0IGlzICciICsgdHlwZW9mIHZhbHVlICsgIicuIiApOworICAgICAgICAgICAgcmVxdWVzdC5h cmd1bWVudHNba2V5XSA9IHZhbHVlOworICAgICAgICB9CiAKICAgICAgICAgaWYgKGFyZ3MubGVu Z3RoID09PSAxICYmIHR5cGVvZiBhcmdzWzBdID09PSAiZnVuY3Rpb24iKQogICAgICAgICAgICAg cmVxdWVzdC5zZXEgPSBXZWJJbnNwZWN0b3IuQ2FsbGJhY2sud3JhcChhcmdzWzBdKTsK