44683 2010-08-26 06:49:57 -0700 [GTK] [PATCH] plugin loading invalid symlink evaluation deadlock 2010-08-26 14:34:16 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) All Linux RESOLVED FIXED P2 Critical --- 0 sbrabec webkit-unassigned mrobinson oldest_to_newest 269855 0 65554 sbrabec 2010-08-26 06:49:57 -0700 Created attachment 65554 libwebkit-plugins-gtk-load.patch PluginPackageGtk.cpp:PluginPackage::load() evaluates symlinks in a way that never worked: https://bugzilla.gnome.org/show_bug.cgi?id=627491 Attached patch fixes deadlock that happens if the plugin symlink points to ../something. For example: In openSUSE 11.3, plugindir is /usr/lib64/browser-plugins. opensc-signer.so is a link to ../opensc-signer.so. The result of current symlink resolving is /usr/lib64/browser-plugins/opensc-signer.so. Dead loop happens. 270112 1 65617 mrobinson 2010-08-26 14:25:42 -0700 Created attachment 65617 Patch with ChangeLog 270116 2 65617 mrobinson 2010-08-26 14:31:36 -0700 Comment on attachment 65617 Patch with ChangeLog I've reposted Stanislav's patch with a ChangeLog. This fix looks good to me. 270118 3 65617 mrobinson 2010-08-26 14:34:12 -0700 Comment on attachment 65617 Patch with ChangeLog Clearing flags on attachment: 65617 Committed r66138: <http://trac.webkit.org/changeset/66138> 270119 4 mrobinson 2010-08-26 14:34:16 -0700 All reviewed patches have been landed. Closing bug. 65554 2010-08-26 06:49:57 -0700 2010-08-26 14:25:39 -0700 libwebkit-plugins-gtk-load.patch libwebkit-plugins-gtk-load.patch text/plain 892 sbrabec SW5kZXg6IHdlYmtpdC0xLjIuMC9XZWJDb3JlL3BsdWdpbnMvZ3RrL1BsdWdpblBhY2thZ2VHdGsu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIHdlYmtpdC0xLjIuMC5vcmlnL1dlYkNvcmUvcGx1Z2lucy9ndGsv UGx1Z2luUGFja2FnZUd0ay5jcHAKKysrIHdlYmtpdC0xLjIuMC9XZWJDb3JlL3BsdWdpbnMvZ3Rr L1BsdWdpblBhY2thZ2VHdGsuY3BwCkBAIC0xMTAsOSArMTEwLDEwIEBAIGJvb2wgUGx1Z2luUGFj a2FnZTo6bG9hZCgpCiAgICAgR093blB0cjxnY2hhcj4gZmluYWxQYXRoKGdfc3RyZHVwKG1fcGF0 aC51dGY4KCkuZGF0YSgpKSk7CiAgICAgd2hpbGUgKGdfZmlsZV90ZXN0KGZpbmFsUGF0aC5nZXQo KSwgR19GSUxFX1RFU1RfSVNfU1lNTElOSykpIHsKICAgICAgICAgR093blB0cjxHRmlsZT4gZmls ZShnX2ZpbGVfbmV3X2Zvcl9wYXRoKGZpbmFsUGF0aC5nZXQoKSkpOworICAgICAgICBHT3duUHRy PEdGaWxlPiBkaXIoZ19maWxlX2dldF9wYXJlbnQoZmlsZS5nZXQoKSkpOwogICAgICAgICBHT3du UHRyPGdjaGFyPiBsaW5rUGF0aChnX2ZpbGVfcmVhZF9saW5rKGZpbmFsUGF0aC5nZXQoKSwgMCkp OwogCi0gICAgICAgIEdPd25QdHI8R0ZpbGU+IHJlc29sdmVkRmlsZShnX2ZpbGVfcmVzb2x2ZV9y ZWxhdGl2ZV9wYXRoKGZpbGUuZ2V0KCksIGxpbmtQYXRoLmdldCgpKSk7CisgICAgICAgIEdPd25Q dHI8R0ZpbGU+IHJlc29sdmVkRmlsZShnX2ZpbGVfcmVzb2x2ZV9yZWxhdGl2ZV9wYXRoKGRpci5n ZXQoKSwgbGlua1BhdGguZ2V0KCkpKTsKICAgICAgICAgZmluYWxQYXRoLnNldChnX2ZpbGVfZ2V0 X3BhdGgocmVzb2x2ZWRGaWxlLmdldCgpKSk7CiAgICAgfQogCg== 65617 2010-08-26 14:25:42 -0700 2010-08-26 14:34:11 -0700 Patch with ChangeLog bug-44683-20100826142539.patch text/plain 1671 mrobinson ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTJjNmFkYTI3NDk5MTUwYmJjMDU2NmViMGNmYWRkY2FlZGMxN2FlMS4uM2JmMmFjM2Q3YjVlNWNh ZDJlZDI1OGQ0MDlmNGM3ZWRlYWZiMThiYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wOC0yNiAgIFN0 YW5pc2xhdiBCcmFiZWMgIDxzYnJhYmVjQHN1c2UuY3o+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gW1BBVENIXSBwbHVnaW4gbG9hZGluZyBp bnZhbGlkIHN5bWxpbmsgZXZhbHVhdGlvbiBkZWFkbG9jaworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDQ2ODMKKworICAgICAgICBGaXggc3ltbGluayBy ZXNvbHV0aW9uIGluIFBsdWdpblBhY2thZ2VHdGsuCisKKyAgICAgICAgKiBwbHVnaW5zL2d0ay9Q bHVnaW5QYWNrYWdlR3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBsdWdpblBhY2thZ2U6Omxv YWQpOiBnX2ZpbGVfcmVzb2x2ZV9yZWxhdGl2ZV9wYXRoIG11c3QgYmUgY2FsbGVkIHdpdGggYQor ICAgICAgICBhIGRpcmVjdG9yeSwgbm90IGEgZmlsZS4KKwogMjAxMC0wOC0yNiAgVG9ueSBDaGFu ZyAgPHRvbnlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIEh5YXR0 LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbHVnaW5zL2d0ay9QbHVnaW5QYWNrYWdlR3RrLmNwcCBi L1dlYkNvcmUvcGx1Z2lucy9ndGsvUGx1Z2luUGFja2FnZUd0ay5jcHAKaW5kZXggOTc1NTNhMTA3 M2QzNDk4MDU3ZmNkYzRkZDg0YjYwOGEyODE4YzIzNS4uZDAyMThmYmFhZGIzMzNlYjY5NDY3NDBh NWY4OGYxNWFmM2ZhNDkxMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbHVnaW5zL2d0ay9QbHVnaW5Q YWNrYWdlR3RrLmNwcAorKysgYi9XZWJDb3JlL3BsdWdpbnMvZ3RrL1BsdWdpblBhY2thZ2VHdGsu Y3BwCkBAIC0xMTMsOSArMTEzLDkgQEAgYm9vbCBQbHVnaW5QYWNrYWdlOjpsb2FkKCkKICAgICBH T3duUHRyPGdjaGFyPiBmaW5hbFBhdGgoZ19zdHJkdXAobV9wYXRoLnV0ZjgoKS5kYXRhKCkpKTsK ICAgICB3aGlsZSAoZ19maWxlX3Rlc3QoZmluYWxQYXRoLmdldCgpLCBHX0ZJTEVfVEVTVF9JU19T WU1MSU5LKSkgewogICAgICAgICBHT3duUHRyPEdGaWxlPiBmaWxlKGdfZmlsZV9uZXdfZm9yX3Bh dGgoZmluYWxQYXRoLmdldCgpKSk7CisgICAgICAgIEdPd25QdHI8R0ZpbGU+IGRpcihnX2ZpbGVf Z2V0X3BhcmVudChmaWxlLmdldCgpKSk7CiAgICAgICAgIEdPd25QdHI8Z2NoYXI+IGxpbmtQYXRo KGdfZmlsZV9yZWFkX2xpbmsoZmluYWxQYXRoLmdldCgpLCAwKSk7Ci0KLSAgICAgICAgR093blB0 cjxHRmlsZT4gcmVzb2x2ZWRGaWxlKGdfZmlsZV9yZXNvbHZlX3JlbGF0aXZlX3BhdGgoZmlsZS5n ZXQoKSwgbGlua1BhdGguZ2V0KCkpKTsKKyAgICAgICAgR093blB0cjxHRmlsZT4gcmVzb2x2ZWRG aWxlKGdfZmlsZV9yZXNvbHZlX3JlbGF0aXZlX3BhdGgoZGlyLmdldCgpLCBsaW5rUGF0aC5nZXQo KSkpOwogICAgICAgICBmaW5hbFBhdGguc2V0KGdfZmlsZV9nZXRfcGF0aChyZXNvbHZlZEZpbGUu Z2V0KCkpKTsKICAgICB9CiAK