44674 2010-08-26 04:14:36 -0700 [Qt] tst_QWebFrame::popupFocus() hardcode the element position 2010-08-26 08:48:36 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other Other RESOLVED FIXED Qt, QtTriaged P2 Normal --- 44675 1 benjamin benjamin ademar commit-queue oldest_to_newest 269806 0 benjamin 2010-08-26 04:14:36 -0700 The test tst_QWebFrame::popupFocus() assume the position (25, 25) is inside the combo box. This is not true depending on the style, and the test fails on Meego. 269807 1 65544 benjamin 2010-08-26 04:18:29 -0700 Created attachment 65544 Fix the issue on Meego This patch dynamically find the position of the combo element instead of hardcoding a position to click. 269825 2 65544 commit-queue 2010-08-26 05:07:05 -0700 Comment on attachment 65544 Fix the issue on Meego Clearing flags on attachment: 65544 Committed r66096: <http://trac.webkit.org/changeset/66096> 269826 3 commit-queue 2010-08-26 05:07:11 -0700 All reviewed patches have been landed. Closing bug. 269904 4 ademar 2010-08-26 08:48:36 -0700 Revision r66096 cherry-picked into qtwebkit-2.1 with commit 5019f1f94fcf1b367ce7396acf36890a9f91c5b0 65544 2010-08-26 04:18:29 -0700 2010-08-26 05:07:05 -0700 Fix the issue on Meego 44674.patch text/plain 1468 benjamin ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IDk5NjllYmQuLmY0NTc5ZDAgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEwLTA4LTI2ICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW4ucG91bGFpbkBub2tpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSB0c3RfUVdlYkZyYW1lOjpw b3B1cEZvY3VzKCkgaGFyZGNvZGUgdGhlIGVsZW1lbnQgcG9zaXRpb24KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0Njc0CisKKyAgICAgICAgVGhpcyBw YXRjaCBkeW5hbWljYWxseSBmaW5kIHRoZSBwb3NpdGlvbiBvZiB0aGUgY29tYm8gZWxlbWVudCBp bnN0ZWFkCisgICAgICAgIG9mIGhhcmRjb2RpbmcgYSBwb3NpdGlvbiB0byBjbGljay4KKworICAg ICAgICAqIHRlc3RzL3F3ZWJmcmFtZS90c3RfcXdlYmZyYW1lLmNwcDoKKwogMjAxMC0wOC0yNSAg TGVvIFlhbmcgIDxsZW8ueWFuZ0B0b3JjaG1vYmlsZS5jb20uY24+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgU2ltb24gSGF1c21hbm4uCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvdGVzdHMvcXdlYmZy YW1lL3RzdF9xd2ViZnJhbWUuY3BwIGIvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJmcmFtZS90c3RfcXdl YmZyYW1lLmNwcAppbmRleCA4M2I4NjAwLi42NDk3MWQwIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQv dGVzdHMvcXdlYmZyYW1lL3RzdF9xd2ViZnJhbWUuY3BwCisrKyBiL1dlYktpdC9xdC90ZXN0cy9x d2ViZnJhbWUvdHN0X3F3ZWJmcmFtZS5jcHAKQEAgLTI2NzgsNyArMjY3OCw4IEBAIHZvaWQgdHN0 X1FXZWJGcmFtZTo6cG9wdXBGb2N1cygpCiAgICAgUVRSWV9WRVJJRlkodmlldy5oYXNGb2N1cygp KTsKIAogICAgIC8vIG9wZW4gdGhlIHBvcHVwIGJ5IGNsaWNraW5nLiBjaGVjayBpZiBmb2N1cyBp cyBvbiB0aGUgcG9wdXAKLSAgICBRVGVzdDo6bW91c2VDbGljaygmdmlldywgUXQ6OkxlZnRCdXR0 b24sIDAsIFFQb2ludCgyNSwgMjUpKTsKKyAgICBjb25zdCBRV2ViRWxlbWVudCB3ZWJDb21ibyA9 IHZpZXcucGFnZSgpLT5tYWluRnJhbWUoKS0+ZG9jdW1lbnRFbGVtZW50KCkuZmluZEZpcnN0KFFM YXRpbjFTdHJpbmcoInNlbGVjdFtuYW1lPXNlbGVjdF0iKSk7CisgICAgUVRlc3Q6Om1vdXNlQ2xp Y2soJnZpZXcsIFF0OjpMZWZ0QnV0dG9uLCAwLCB3ZWJDb21iby5nZW9tZXRyeSgpLmNlbnRlcigp KTsKICAgICBRT2JqZWN0KiB3ZWJwb3B1cCA9IGZpcnN0Q2hpbGRCeUNsYXNzTmFtZSgmdmlldywg IlFDb21ib0JveCIpOwogICAgIFFDb21ib0JveCogY29tYm8gPSBxb2JqZWN0X2Nhc3Q8UUNvbWJv Qm94Kj4od2VicG9wdXApOwogICAgIFFWRVJJRlkoY29tYm8gIT0gMCk7Cg==