44673 2010-08-26 03:15:57 -0700 Web Inspector: scripts are pushed to front-end before resources 2010-08-26 04:34:41 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 podivilov webkit-unassigned abarth commit-queue eric pfeldman webkit.review.bot yurys oldest_to_newest 269791 0 podivilov 2010-08-26 03:15:57 -0700 Web Inspector: scripts are pushed to front-end before resources 269796 1 65539 podivilov 2010-08-26 03:29:55 -0700 Created attachment 65539 Proposed patch. 269797 2 webkit.review.bot 2010-08-26 03:34:21 -0700 Attachment 65539 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/inspector/InspectorController.cpp:665: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 269799 3 65541 podivilov 2010-08-26 03:42:03 -0700 Created attachment 65541 Proposed patch. 269801 4 65541 pfeldman 2010-08-26 03:56:07 -0700 Comment on attachment 65541 Proposed patch. Clearing flags on attachment: 65541 Committed r66094: <http://trac.webkit.org/changeset/66094> 269802 5 pfeldman 2010-08-26 03:56:17 -0700 All reviewed patches have been landed. Closing bug. 269811 6 65541 commit-queue 2010-08-26 04:30:07 -0700 Comment on attachment 65541 Proposed patch. Rejecting patch 65541 from commit-queue. Unexpected failure when processing patch! Please file a bug against webkit-patch. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 65541, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1 Last 500 characters of output: cgi?id=65541&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=44673&ctype=xml Processing 1 patch from 1 bug. Cleaning working directory Processing patch 65541 from bug 44673. NOBODY (OOPS!) found in /Users/eseidel/Projects/CommitQueue/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /Users/eseidel/Projects/CommitQueue/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). 269814 7 webkit.review.bot 2010-08-26 04:34:41 -0700 http://trac.webkit.org/changeset/66094 might have broken GTK Linux 64-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/66093 http://trac.webkit.org/changeset/66094 65539 2010-08-26 03:29:55 -0700 2010-08-26 03:42:03 -0700 Proposed patch. fix_scripts.patch text/plain 2940 podivilov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MDk2OTBhMy4uMTI5MTk5MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wOC0yNiAgUGF2ZWwgUG9kaXZp bG92ICA8cG9kaXZpbG92QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBlbmFibGUgZGVidWdnZXIgYWZ0 ZXIgcmVzb3VyY2VzIGFyZSBwdXNoZWQgdG8gZnJvbnQtZW5kCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDY3MworCisgICAgICAgICogaW5zcGVjdG9y L0luc3BlY3RvckNvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yQ29u dHJvbGxlcjo6Y29ubmVjdEZyb250ZW5kKToKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckNv bnRyb2xsZXI6OnBvcHVsYXRlU2NyaXB0T2JqZWN0cyk6CisKIDIwMTAtMDgtMjYgIEdpcmlzaCBS YW1ha3Jpc2huYW4gIDxnaXJpc2hAZm9yd2FyZGJpYXMuaW4+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgQXJpeWEgSGlkYXlhdC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rv ckNvbnRyb2xsZXIuY3BwIGIvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5j cHAKaW5kZXggZjQ3YjMyMS4uNjZlZjE3YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3Iv SW5zcGVjdG9yQ29udHJvbGxlci5jcHAKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9y Q29udHJvbGxlci5jcHAKQEAgLTQ5MCwyNCArNDkwLDYgQEAgdm9pZCBJbnNwZWN0b3JDb250cm9s bGVyOjpjb25uZWN0RnJvbnRlbmQoKQogICAgIC8vIEluaXRpYWxpemUgV2ViIEluc3BlY3RvciB0 aXRsZS4KICAgICBtX2Zyb250ZW5kLT5pbnNwZWN0ZWRVUkxDaGFuZ2VkKG1faW5zcGVjdGVkUGFn ZS0+bWFpbkZyYW1lKCktPmxvYWRlcigpLT51cmwoKS5zdHJpbmcoKSk7CiAKLSNpZiBFTkFCTEUo SkFWQVNDUklQVF9ERUJVR0dFUikKLSAgICBpZiAoSW5zcGVjdG9yRGVidWdnZXJBZ2VudDo6aXNE ZWJ1Z2dlckFsd2F5c0VuYWJsZWQoKSkgewotICAgICAgICAvLyBGSVhNRSAoNDAzNjQpOiBUaGlz IHdpbGwgZm9yY2UgcHVzaGluZyBzY3JpcHQgc291cmNlcyB0byBmcm9udGVuZCBldmVuIGlmIHNj cmlwdAotICAgICAgICAvLyBwYW5lbCBpcyBpbmFjdGl2ZS4KLSAgICAgICAgZW5hYmxlRGVidWdn ZXJGcm9tRnJvbnRlbmQoZmFsc2UpOwotICAgIH0gZWxzZSB7Ci0gICAgICAgIFN0cmluZyBkZWJ1 Z2dlckVuYWJsZWQgPSBzZXR0aW5nKGRlYnVnZ2VyRW5hYmxlZFNldHRpbmdOYW1lKTsKLSAgICAg ICAgaWYgKGRlYnVnZ2VyRW5hYmxlZCA9PSAidHJ1ZSIgfHwgbV9hdHRhY2hEZWJ1Z2dlcldoZW5T aG93bikKLSAgICAgICAgICAgIGVuYWJsZURlYnVnZ2VyKCk7Ci0gICAgfQotICAgIG1fcHJvZmls ZXJBZ2VudC0+c2V0RnJvbnRlbmQobV9mcm9udGVuZC5nZXQoKSk7Ci0gICAgaWYgKCFTY3JpcHRQ cm9maWxlcjo6aXNQcm9maWxlckFsd2F5c0VuYWJsZWQoKSkgewotICAgICAgICBTdHJpbmcgcHJv ZmlsZXJFbmFibGVkU2V0dGluZyA9IHNldHRpbmcocHJvZmlsZXJFbmFibGVkU2V0dGluZ05hbWUp OwotICAgICAgICBpZiAocHJvZmlsZXJFbmFibGVkU2V0dGluZyA9PSAidHJ1ZSIpCi0gICAgICAg ICAgICBlbmFibGVQcm9maWxlcigpOwotICAgIH0KLSNlbmRpZgotCiAjaWYgRU5BQkxFKE9GRkxJ TkVfV0VCX0FQUExJQ0FUSU9OUykKICAgICBtX2FwcGxpY2F0aW9uQ2FjaGVBZ2VudCA9IG5ldyBJ bnNwZWN0b3JBcHBsaWNhdGlvbkNhY2hlQWdlbnQodGhpcywgbV9mcm9udGVuZC5nZXQoKSk7CiAj ZW5kaWYKQEAgLTY3Niw2ICs2NTgsMjIgQEAgdm9pZCBJbnNwZWN0b3JDb250cm9sbGVyOjpwb3B1 bGF0ZVNjcmlwdE9iamVjdHMoKQogICAgIGZvciAoVmVjdG9yPHBhaXI8bG9uZywgU3RyaW5nPiA+ OjppdGVyYXRvciBpdCA9IG1fcGVuZGluZ0V2YWx1YXRlVGVzdENvbW1hbmRzLmJlZ2luKCk7IGl0 ICE9IG1fcGVuZGluZ0V2YWx1YXRlVGVzdENvbW1hbmRzLmVuZCgpOyArK2l0KQogICAgICAgICBt X2Zyb250ZW5kLT5ldmFsdWF0ZUZvclRlc3RJbkZyb250ZW5kKCgqaXQpLmZpcnN0LCAoKml0KS5z ZWNvbmQpOwogICAgIG1fcGVuZGluZ0V2YWx1YXRlVGVzdENvbW1hbmRzLmNsZWFyKCk7CisKKyNp ZiBFTkFCTEUoSkFWQVNDUklQVF9ERUJVR0dFUikKKyAgICBpZiAoSW5zcGVjdG9yRGVidWdnZXJB Z2VudDo6aXNEZWJ1Z2dlckFsd2F5c0VuYWJsZWQoKSkgeworICAgICAgICBlbmFibGVEZWJ1Z2dl ckZyb21Gcm9udGVuZChmYWxzZSk7CisgICAgfSBlbHNlIHsKKyAgICAgICAgU3RyaW5nIGRlYnVn Z2VyRW5hYmxlZCA9IHNldHRpbmcoZGVidWdnZXJFbmFibGVkU2V0dGluZ05hbWUpOworICAgICAg ICBpZiAoZGVidWdnZXJFbmFibGVkID09ICJ0cnVlIiB8fCBtX2F0dGFjaERlYnVnZ2VyV2hlblNo b3duKQorICAgICAgICAgICAgZW5hYmxlRGVidWdnZXIoKTsKKyAgICB9CisgICAgbV9wcm9maWxl ckFnZW50LT5zZXRGcm9udGVuZChtX2Zyb250ZW5kLmdldCgpKTsKKyAgICBpZiAoIVNjcmlwdFBy b2ZpbGVyOjppc1Byb2ZpbGVyQWx3YXlzRW5hYmxlZCgpKSB7CisgICAgICAgIFN0cmluZyBwcm9m aWxlckVuYWJsZWRTZXR0aW5nID0gc2V0dGluZyhwcm9maWxlckVuYWJsZWRTZXR0aW5nTmFtZSk7 CisgICAgICAgIGlmIChwcm9maWxlckVuYWJsZWRTZXR0aW5nID09ICJ0cnVlIikKKyAgICAgICAg ICAgIGVuYWJsZVByb2ZpbGVyKCk7CisgICAgfQorI2VuZGlmCiB9CiAKIHZvaWQgSW5zcGVjdG9y Q29udHJvbGxlcjo6dW5iaW5kQWxsUmVzb3VyY2VzKCkK 65541 2010-08-26 03:42:03 -0700 2010-08-26 04:30:07 -0700 Proposed patch. fix_scripts.patch text/plain 2936 podivilov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MDk2OTBhMy4uMTI5MTk5MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wOC0yNiAgUGF2ZWwgUG9kaXZp bG92ICA8cG9kaXZpbG92QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBlbmFibGUgZGVidWdnZXIgYWZ0 ZXIgcmVzb3VyY2VzIGFyZSBwdXNoZWQgdG8gZnJvbnQtZW5kCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDY3MworCisgICAgICAgICogaW5zcGVjdG9y L0luc3BlY3RvckNvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yQ29u dHJvbGxlcjo6Y29ubmVjdEZyb250ZW5kKToKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckNv bnRyb2xsZXI6OnBvcHVsYXRlU2NyaXB0T2JqZWN0cyk6CisKIDIwMTAtMDgtMjYgIEdpcmlzaCBS YW1ha3Jpc2huYW4gIDxnaXJpc2hAZm9yd2FyZGJpYXMuaW4+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgQXJpeWEgSGlkYXlhdC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rv ckNvbnRyb2xsZXIuY3BwIGIvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5j cHAKaW5kZXggZjQ3YjMyMS4uODkwZDU5OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3Iv SW5zcGVjdG9yQ29udHJvbGxlci5jcHAKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9y Q29udHJvbGxlci5jcHAKQEAgLTQ5MCwyNCArNDkwLDYgQEAgdm9pZCBJbnNwZWN0b3JDb250cm9s bGVyOjpjb25uZWN0RnJvbnRlbmQoKQogICAgIC8vIEluaXRpYWxpemUgV2ViIEluc3BlY3RvciB0 aXRsZS4KICAgICBtX2Zyb250ZW5kLT5pbnNwZWN0ZWRVUkxDaGFuZ2VkKG1faW5zcGVjdGVkUGFn ZS0+bWFpbkZyYW1lKCktPmxvYWRlcigpLT51cmwoKS5zdHJpbmcoKSk7CiAKLSNpZiBFTkFCTEUo SkFWQVNDUklQVF9ERUJVR0dFUikKLSAgICBpZiAoSW5zcGVjdG9yRGVidWdnZXJBZ2VudDo6aXNE ZWJ1Z2dlckFsd2F5c0VuYWJsZWQoKSkgewotICAgICAgICAvLyBGSVhNRSAoNDAzNjQpOiBUaGlz IHdpbGwgZm9yY2UgcHVzaGluZyBzY3JpcHQgc291cmNlcyB0byBmcm9udGVuZCBldmVuIGlmIHNj cmlwdAotICAgICAgICAvLyBwYW5lbCBpcyBpbmFjdGl2ZS4KLSAgICAgICAgZW5hYmxlRGVidWdn ZXJGcm9tRnJvbnRlbmQoZmFsc2UpOwotICAgIH0gZWxzZSB7Ci0gICAgICAgIFN0cmluZyBkZWJ1 Z2dlckVuYWJsZWQgPSBzZXR0aW5nKGRlYnVnZ2VyRW5hYmxlZFNldHRpbmdOYW1lKTsKLSAgICAg ICAgaWYgKGRlYnVnZ2VyRW5hYmxlZCA9PSAidHJ1ZSIgfHwgbV9hdHRhY2hEZWJ1Z2dlcldoZW5T aG93bikKLSAgICAgICAgICAgIGVuYWJsZURlYnVnZ2VyKCk7Ci0gICAgfQotICAgIG1fcHJvZmls ZXJBZ2VudC0+c2V0RnJvbnRlbmQobV9mcm9udGVuZC5nZXQoKSk7Ci0gICAgaWYgKCFTY3JpcHRQ cm9maWxlcjo6aXNQcm9maWxlckFsd2F5c0VuYWJsZWQoKSkgewotICAgICAgICBTdHJpbmcgcHJv ZmlsZXJFbmFibGVkU2V0dGluZyA9IHNldHRpbmcocHJvZmlsZXJFbmFibGVkU2V0dGluZ05hbWUp OwotICAgICAgICBpZiAocHJvZmlsZXJFbmFibGVkU2V0dGluZyA9PSAidHJ1ZSIpCi0gICAgICAg ICAgICBlbmFibGVQcm9maWxlcigpOwotICAgIH0KLSNlbmRpZgotCiAjaWYgRU5BQkxFKE9GRkxJ TkVfV0VCX0FQUExJQ0FUSU9OUykKICAgICBtX2FwcGxpY2F0aW9uQ2FjaGVBZ2VudCA9IG5ldyBJ bnNwZWN0b3JBcHBsaWNhdGlvbkNhY2hlQWdlbnQodGhpcywgbV9mcm9udGVuZC5nZXQoKSk7CiAj ZW5kaWYKQEAgLTY3Niw2ICs2NTgsMjIgQEAgdm9pZCBJbnNwZWN0b3JDb250cm9sbGVyOjpwb3B1 bGF0ZVNjcmlwdE9iamVjdHMoKQogICAgIGZvciAoVmVjdG9yPHBhaXI8bG9uZywgU3RyaW5nPiA+ OjppdGVyYXRvciBpdCA9IG1fcGVuZGluZ0V2YWx1YXRlVGVzdENvbW1hbmRzLmJlZ2luKCk7IGl0 ICE9IG1fcGVuZGluZ0V2YWx1YXRlVGVzdENvbW1hbmRzLmVuZCgpOyArK2l0KQogICAgICAgICBt X2Zyb250ZW5kLT5ldmFsdWF0ZUZvclRlc3RJbkZyb250ZW5kKCgqaXQpLmZpcnN0LCAoKml0KS5z ZWNvbmQpOwogICAgIG1fcGVuZGluZ0V2YWx1YXRlVGVzdENvbW1hbmRzLmNsZWFyKCk7CisKKyNp ZiBFTkFCTEUoSkFWQVNDUklQVF9ERUJVR0dFUikKKyAgICBpZiAoSW5zcGVjdG9yRGVidWdnZXJB Z2VudDo6aXNEZWJ1Z2dlckFsd2F5c0VuYWJsZWQoKSkKKyAgICAgICAgZW5hYmxlRGVidWdnZXJG cm9tRnJvbnRlbmQoZmFsc2UpOworICAgIGVsc2UgeworICAgICAgICBTdHJpbmcgZGVidWdnZXJF bmFibGVkID0gc2V0dGluZyhkZWJ1Z2dlckVuYWJsZWRTZXR0aW5nTmFtZSk7CisgICAgICAgIGlm IChkZWJ1Z2dlckVuYWJsZWQgPT0gInRydWUiIHx8IG1fYXR0YWNoRGVidWdnZXJXaGVuU2hvd24p CisgICAgICAgICAgICBlbmFibGVEZWJ1Z2dlcigpOworICAgIH0KKyAgICBtX3Byb2ZpbGVyQWdl bnQtPnNldEZyb250ZW5kKG1fZnJvbnRlbmQuZ2V0KCkpOworICAgIGlmICghU2NyaXB0UHJvZmls ZXI6OmlzUHJvZmlsZXJBbHdheXNFbmFibGVkKCkpIHsKKyAgICAgICAgU3RyaW5nIHByb2ZpbGVy RW5hYmxlZFNldHRpbmcgPSBzZXR0aW5nKHByb2ZpbGVyRW5hYmxlZFNldHRpbmdOYW1lKTsKKyAg ICAgICAgaWYgKHByb2ZpbGVyRW5hYmxlZFNldHRpbmcgPT0gInRydWUiKQorICAgICAgICAgICAg ZW5hYmxlUHJvZmlsZXIoKTsKKyAgICB9CisjZW5kaWYKIH0KIAogdm9pZCBJbnNwZWN0b3JDb250 cm9sbGVyOjp1bmJpbmRBbGxSZXNvdXJjZXMoKQo=