44658 2010-08-25 19:39:20 -0700 [EFL] Need to check LibSoup version 2010-09-01 09:34:54 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 ryuan.choi webkit-unassigned antognolli+webkit commit-queue leandro lucas.de.marchi tonikitoo oldest_to_newest 269688 0 ryuan.choi 2010-08-25 19:39:20 -0700 FIND_PACKAGE(LibSoup2 2.28.2 REQUIRED) above command in cmake/OptionEfl.cmake looks not check 2.28.2 but we need to check version of LibSoup. When I used CMake 2.8.2 and LibSoup 2.28.1, I got a build break because of missing new feature of libSoup. but cmake passed configuration without error. 269689 1 65518 ryuan.choi 2010-08-25 19:45:02 -0700 Created attachment 65518 Patch 269859 2 antognolli+webkit 2010-08-26 06:54:41 -0700 (In reply to comment #1) > Created an attachment (id=65518) [details] > Patch Hi Ryuan, I think this is a problem in cmake/FindLibSoup2.cmake, that's probably not checking for the libsoup version correctly. I think it's better to fix it than doing this workaround, though I'm not good on cmake and couldn't find the bug on a quick look. I'm cc'ing Leandro, maybe he can help you with this. 269983 3 65586 leandro 2010-08-26 11:24:50 -0700 Created attachment 65586 patch I would like to see a patch more like this one, fixing FindLibSoup2.cmake, but if possible, checking the version without having to define a variable. 270498 4 ryuan.choi 2010-08-27 07:47:08 -0700 (In reply to comment #3) > Created an attachment (id=65586) [details] > patch > > I would like to see a patch more like this one, fixing FindLibSoup2.cmake, but if possible, checking the version without having to define a variable. It looks quite better. 272732 5 66195 ryuan.choi 2010-09-01 03:55:42 -0700 Created attachment 66195 Patch 272735 6 ryuan.choi 2010-09-01 03:57:09 -0700 (In reply to comment #5) > Created an attachment (id=66195) [details] > Patch I tried like attachment. this patch doesn't define a variable. 272793 7 tonikitoo 2010-09-01 07:19:02 -0700 (In reply to comment #6) > (In reply to comment #5) > > Created an attachment (id=66195) [details] [details] > > Patch > > I tried like attachment. > this patch doesn't define a variable. cmake guys? 272802 8 leandro 2010-09-01 08:00:08 -0700 (In reply to comment #7) > > > > I tried like attachment. > > this patch doesn't define a variable. > > cmake guys? LGTM 272831 9 66195 tonikitoo 2010-09-01 09:09:46 -0700 Comment on attachment 66195 Patch I trust you guys. 272843 10 66195 commit-queue 2010-09-01 09:34:49 -0700 Comment on attachment 66195 Patch Clearing flags on attachment: 66195 Committed r66609: <http://trac.webkit.org/changeset/66609> 272844 11 commit-queue 2010-09-01 09:34:54 -0700 All reviewed patches have been landed. Closing bug. 65518 2010-08-25 19:45:02 -0700 2010-09-01 03:55:32 -0700 Patch bug-44658-20100826114459.patch text/plain 1075 ryuan.choi SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDY2MDcz KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDgt MjUgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdIE5lZWQgdG8gY2hlY2sgTGli U291cCB2ZXJzaW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD00NDY1OAorCisgICAgICAgIEFkZCB2ZXJzaW9uIGNoZWNrIG9mIExpYlNvdXAgYmVjYXVz ZSBGSU5EX1BBQ0tBR0UgY2FuJ3QuCisKKyAgICAgICAgKiBjbWFrZS9PcHRpb25zRWZsLmNtYWtl OgorCiAyMDEwLTA4LTI1ICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBNYXJ0aW4gUm9iaW5zb24uCkluZGV4OiBjbWFrZS9PcHRpb25zRWZsLmNt YWtlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIGNtYWtlL09wdGlvbnNFZmwuY21ha2UJKHJldmlzaW9uIDY2MDY3 KQorKysgY21ha2UvT3B0aW9uc0VmbC5jbWFrZQkod29ya2luZyBjb3B5KQpAQCAtOTksNiArOTks MTAgQEAgSUYgKE5FVFdPUktfQkFDS0VORCBTVFJFUVVBTCAic291cCIpCiAgICAgTUVTU0FHRSgi Rm9yY2luZyBHbGliIHN1cHBvcnQiKQogICBFTkRJRiAoKQogICBGSU5EX1BBQ0tBR0UoTGliU291 cDIgMi4yOC4yIFJFUVVJUkVEKQorICBJRiAoTElCU09VUDI0X1ZFUlNJT04gVkVSU0lPTl9MRVNT IDIuMjguMikKKyAgICBNRVNTQUdFKEZBVEFMX0VSUk9SICJMSUJTT1VQIHJlcXVpcmVkIDIuMjgu MiBidXQgJHtMSUJTT1VQMjRfVkVSU0lPTn0hIikKKyAgRU5ESUYgKCkKKwogICBTRVQoV1RGX1VT RV9TT1VQIDEpCiAgIEFERF9ERUZJTklUSU9OUygtRFdURl9VU0VfU09VUD0xKQogCg== 65586 2010-08-26 11:24:50 -0700 2010-08-26 11:24:50 -0700 patch libsoup-check-version.patch text/plain 1978 leandro SW5kZXg6IGNtYWtlL0ZpbmRMaWJTb3VwMi5jbWFrZQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBjbWFrZS9GaW5k TGliU291cDIuY21ha2UJKHJldmlzaW9uIDY2MTExKQorKysgY21ha2UvRmluZExpYlNvdXAyLmNt YWtlCSh3b3JraW5nIGNvcHkpCkBAIC04OSwxNCArODksMTQgQEAKIEVORElGICggTElCU09VUDI0 X01JTl9WRVJTSU9OICkJCiAKICMgdHJ5IHRvIGZpbmQgYW55IHZlcnNpb24gb2YgbGlic291cDIu NCBpZiBMSUJTT1VQMjJfTUlOX1ZFUlNJT04gaXMgbm90IHNldAotSUYgKCBOT1QgTElCU09VUDI0 X0ZPVU5EIEFORCBOT1QgTElCU09VUDIyX01JTl9WRVJTSU9OICkKK0lGICggTk9UIExJQlNPVVAy NF9GT1VORCBBTkQgTk9UIExJQlNPVVAyMl9NSU5fVkVSU0lPTiBBTkQgTk9UIExJQlNPVVAyNF9N SU5fVkVSU0lPTiApCiAJUEtHX1NFQVJDSF9NT0RVTEUoIExJQlNPVVAyNCBsaWJzb3VwLTIuNCBs aWJzb3VwMiApCi1FTkRJRiAoIE5PVCBMSUJTT1VQMjRfRk9VTkQgQU5EIE5PVCBMSUJTT1VQMjJf TUlOX1ZFUlNJT04pCitFTkRJRiAoIE5PVCBMSUJTT1VQMjRfRk9VTkQgQU5EIE5PVCBMSUJTT1VQ MjJfTUlOX1ZFUlNJT04gQU5EIE5PVCBMSUJTT1VQMjRfTUlOX1ZFUlNJT04gKQogCiAjIHRyeSB0 byBmaW5kIGFueSB2ZXJzaW9uIG9mIGxpYnNvdXAyLjIgaWYgTElCU09VUDI0X01JTl9WRVJTSU9O IGlzIG5vdCBzZXQKLUlGICggTk9UIExJQlNPVVAyMl9GT1VORCBBTkQgTk9UIExJQlNPVVAyNF9N SU5fVkVSU0lPTiApCitJRiAoIE5PVCBMSUJTT1VQMjJfRk9VTkQgQU5EIE5PVCBMSUJTT1VQMjRf TUlOX1ZFUlNJT04gQU5EIE5PVCBMSUJTT1VQMjJfTUlOX1ZFUlNJT04gKQogCVBLR19TRUFSQ0hf TU9EVUxFKCBMSUJTT1VQMjIgbGlic291cC0yLjIgbGlic291cDIgKQotRU5ESUYgKCBOT1QgTElC U09VUDIyX0ZPVU5EIEFORCBOT1QgTElCU09VUDI0X01JTl9WRVJTSU9OKQorRU5ESUYgKCBOT1Qg TElCU09VUDIyX0ZPVU5EIEFORCBOT1QgTElCU09VUDI0X01JTl9WRVJTSU9OIEFORCBOT1QgTElC U09VUDIyX01JTl9WRVJTSU9OICkKIAogIyBzZXQgTElCU09VUDJfIHZhcmlhYmxlcwogSUYgKCBM SUJTT1VQMjRfRk9VTkQgKQpAQCAtMTE1LDcgKzExNSw3IEBACiBFTFNFSUYoIFBLR19DT05GSUdf Rk9VTkQgQU5EIExpYlNvdXAyX0ZJTkRfUkVRVUlSRUQgKQogCSMgcmFpc2UgYW4gZXJyb3IgaWYg Ym90aCBsaWJzIGFyZSBub3QgZm91bmQgCiAJIyBhbmQgRklORF9QQUNLQUdFKCBMaWJTb3VwMiBS RVFVSVJFRCApIHdhcyBjYWxsZWQKLQlNRVNTQUdFKCBTRU5EX0VSUk9SICJwYWNrYWdlIGxpYnNv dXAyIG5vdCBmb3VuZCIgKQorCU1FU1NBR0UoIEZBVEFMX0VSUk9SICJwYWNrYWdlIGxpYnNvdXAy IG5vdCBmb3VuZCIgKQogRU5ESUYgKCBMSUJTT1VQMjRfRk9VTkQgKQogCiBJRiggTk9UIExJQlNP VVAyX0ZPVU5EIEFORCBOT1QgUEtHX0NPTkZJR19GT1VORCApCkluZGV4OiBjbWFrZS9PcHRpb25z RWZsLmNtYWtlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIGNtYWtlL09wdGlvbnNFZmwuY21ha2UJKHJldmlzaW9u IDY2MTExKQorKysgY21ha2UvT3B0aW9uc0VmbC5jbWFrZQkod29ya2luZyBjb3B5KQpAQCAtOTgs NyArOTgsOCBAQAogICAgIFNFVChFTkFCTEVfR0xJQl9TVVBQT1JUIDEpCiAgICAgTUVTU0FHRSgi Rm9yY2luZyBHbGliIHN1cHBvcnQiKQogICBFTkRJRiAoKQotICBGSU5EX1BBQ0tBR0UoTGliU291 cDIgMi4yOC4yIFJFUVVJUkVEKQorICBTRVQoTElCU09VUDI0X01JTl9WRVJTSU9OIDIuMjguMikK KyAgRklORF9QQUNLQUdFKExpYlNvdXAyIFJFUVVJUkVEKQogICBTRVQoV1RGX1VTRV9TT1VQIDEp CiAgIEFERF9ERUZJTklUSU9OUygtRFdURl9VU0VfU09VUD0xKQogCg== 66195 2010-09-01 03:55:42 -0700 2010-09-01 09:34:49 -0700 Patch bug-44658-20100901195543.patch text/plain 2570 ryuan.choi SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDY2NTkx KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDkt MDEgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdIE5lZWQgdG8gY2hlY2sgTGli U291cCB2ZXJzaW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD00NDY1OAorCisgICAgICAgIEFkZCB2ZXJzaW9uIGNoZWNrIG9mIExpYlNvdXAuCisKKyAg ICAgICAgKiBjbWFrZS9GaW5kTGliU291cDIuY21ha2U6CisKIDIwMTAtMDgtMzEgIEd1c3Rhdm8g Tm9yb25oYSBTaWx2YSAgPGd1c3Rhdm8ubm9yb25oYUBjb2xsYWJvcmEuY28udWs+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmluc29uLgpJbmRleDogY21ha2UvRmluZExpYlNvdXAy LmNtYWtlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIGNtYWtlL0ZpbmRMaWJTb3VwMi5jbWFrZQkocmV2aXNpb24g NjY1OTEpCisrKyBjbWFrZS9GaW5kTGliU291cDIuY21ha2UJKHdvcmtpbmcgY29weSkKQEAgLTYz LDYgKzYzLDExIEBACiAKIElOQ0xVREUoIEZpbmRQa2dDb25maWcgKQogCitJRiAoIExpYlNvdXAy X0ZJTkRfVkVSU0lPTiBBTkQgTk9UIExJQlNPVVAyX01JTl9WRVJTSU9OIEFORCBOT1QgTElCU09V UDI0X01JTl9WRVJTSU9OICkKKwlTRVQoIExJQlNPVVAyX01JTl9WRVJTSU9OICIke0xpYlNvdXAy X0ZJTkRfVkVSU0lPTn0iICkKKwlTRVQoIExJQlNPVVAyNF9NSU5fVkVSU0lPTiAiJHtMaWJTb3Vw Ml9GSU5EX1ZFUlNJT059IiApCitFTkRJRiAoIExpYlNvdXAyX0ZJTkRfVkVSU0lPTiBBTkQgTk9U IExJQlNPVVAyX01JTl9WRVJTSU9OIEFORCBOT1QgTElCU09VUDI0X01JTl9WRVJTSU9OICkKKwog SUYgKCBMaWJTb3VwMl9GSU5EX1JFUVVJUkVEICkKIAlTRVQoIF9wa2djb25maWdfUkVRVUlSRUQg IlJFUVVJUkVEIiApCiBFTFNFKCBMaWJTb3VwMl9GSU5EX1JFUVVJUkVEICkKQEAgLTg5LDE0ICs5 NCwxNCBAQCBJRiAoIExJQlNPVVAyNF9NSU5fVkVSU0lPTiApCiBFTkRJRiAoIExJQlNPVVAyNF9N SU5fVkVSU0lPTiApCQogCiAjIHRyeSB0byBmaW5kIGFueSB2ZXJzaW9uIG9mIGxpYnNvdXAyLjQg aWYgTElCU09VUDIyX01JTl9WRVJTSU9OIGlzIG5vdCBzZXQKLUlGICggTk9UIExJQlNPVVAyNF9G T1VORCBBTkQgTk9UIExJQlNPVVAyMl9NSU5fVkVSU0lPTiApCitJRiAoIE5PVCBMSUJTT1VQMjRf Rk9VTkQgQU5EIE5PVCBMSUJTT1VQMjJfTUlOX1ZFUlNJT04gQU5EIE5PVCBMSUJTT1VQMjRfTUlO X1ZFUlNJT04gKQogCVBLR19TRUFSQ0hfTU9EVUxFKCBMSUJTT1VQMjQgbGlic291cC0yLjQgbGli c291cDIgKQotRU5ESUYgKCBOT1QgTElCU09VUDI0X0ZPVU5EIEFORCBOT1QgTElCU09VUDIyX01J Tl9WRVJTSU9OKQorRU5ESUYgKCBOT1QgTElCU09VUDI0X0ZPVU5EIEFORCBOT1QgTElCU09VUDIy X01JTl9WRVJTSU9OIEFORCBOT1QgTElCU09VUDI0X01JTl9WRVJTSU9OICkKIAogIyB0cnkgdG8g ZmluZCBhbnkgdmVyc2lvbiBvZiBsaWJzb3VwMi4yIGlmIExJQlNPVVAyNF9NSU5fVkVSU0lPTiBp cyBub3Qgc2V0Ci1JRiAoIE5PVCBMSUJTT1VQMjJfRk9VTkQgQU5EIE5PVCBMSUJTT1VQMjRfTUlO X1ZFUlNJT04gKQorSUYgKCBOT1QgTElCU09VUDIyX0ZPVU5EIEFORCBOT1QgTElCU09VUDI0X01J Tl9WRVJTSU9OIEFORCBOT1QgTElCU09VUDI0X01JTl9WRVJTSU9OICkKIAlQS0dfU0VBUkNIX01P RFVMRSggTElCU09VUDIyIGxpYnNvdXAtMi4yIGxpYnNvdXAyICkKLUVORElGICggTk9UIExJQlNP VVAyMl9GT1VORCBBTkQgTk9UIExJQlNPVVAyNF9NSU5fVkVSU0lPTikKK0VORElGICggTk9UIExJ QlNPVVAyMl9GT1VORCBBTkQgTk9UIExJQlNPVVAyNF9NSU5fVkVSU0lPTiBBTkQgTk9UIExJQlNP VVAyNF9NSU5fVkVSU0lPTiApCiAKICMgc2V0IExJQlNPVVAyXyB2YXJpYWJsZXMKIElGICggTElC U09VUDI0X0ZPVU5EICkKQEAgLTExNSw3ICsxMjAsNyBAQCBFTFNFSUYgKCBMSUJTT1VQMjJfRk9V TkQgKQogRUxTRUlGKCBQS0dfQ09ORklHX0ZPVU5EIEFORCBMaWJTb3VwMl9GSU5EX1JFUVVJUkVE ICkKIAkjIHJhaXNlIGFuIGVycm9yIGlmIGJvdGggbGlicyBhcmUgbm90IGZvdW5kIAogCSMgYW5k IEZJTkRfUEFDS0FHRSggTGliU291cDIgUkVRVUlSRUQgKSB3YXMgY2FsbGVkCi0JTUVTU0FHRSgg U0VORF9FUlJPUiAicGFja2FnZSBsaWJzb3VwMiBub3QgZm91bmQiICkKKwlNRVNTQUdFKCBGQVRB TF9FUlJPUiAicGFja2FnZSBsaWJzb3VwMiBub3QgZm91bmQiICkKIEVORElGICggTElCU09VUDI0 X0ZPVU5EICkKIAogSUYoIE5PVCBMSUJTT1VQMl9GT1VORCBBTkQgTk9UIFBLR19DT05GSUdfRk9V TkQgKQo=