44649 2010-08-25 16:55:03 -0700 Source data passed to TypedArray creators should be const 2010-08-25 18:00:45 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P3 Normal --- 1 kbr kbr cmarrin dglazkov simon.fraser zmo oldest_to_newest 269607 0 kbr 2010-08-25 16:55:03 -0700 In the TypedArray creators taking source data (Float32Array::create(float*, unsigned), etc.), the source data should be const. 269618 1 65502 kbr 2010-08-25 17:09:50 -0700 Created attachment 65502 Patch 269645 2 kbr 2010-08-25 18:00:45 -0700 Committed r66066: <http://trac.webkit.org/changeset/66066> 65502 2010-08-25 17:09:50 -0700 2010-08-25 17:31:20 -0700 Patch const.patch text/plain 2583 kbr SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NjA1OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDgtMjUgIEtlbm5ldGggUnVzc2VsbCAgPGtickBnb29nbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNv dXJjZSBkYXRhIHBhc3NlZCB0byBUeXBlZEFycmF5IGNyZWF0b3JzIHNob3VsZCBiZSBjb25zdAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDQ2NDkKKwor ICAgICAgICBDb21waWxlZCBhbmQgcmFuIGV4aXN0aW5nIFdlYkdMIHRlc3RzIHRvIHZlcmlmeS4K KworICAgICAgICAqIGh0bWwvY2FudmFzL0Zsb2F0MzJBcnJheS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpGbG9hdDMyQXJyYXk6OmNyZWF0ZSk6CisgICAgICAgICogaHRtbC9jYW52YXMvRmxvYXQz MkFycmF5Lmg6CisgICAgICAgICogaHRtbC9jYW52YXMvVHlwZWRBcnJheUJhc2UuaDoKKyAgICAg ICAgKFdlYkNvcmU6OlR5cGVkQXJyYXlCYXNlOjpjcmVhdGUpOgorCiAyMDEwLTA4LTI1ICBFcmlj IFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJh cnRoLgpJbmRleDogV2ViQ29yZS9odG1sL2NhbnZhcy9GbG9hdDMyQXJyYXkuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvaHRtbC9jYW52YXMvRmxvYXQzMkFycmF5LmNwcAkocmV2aXNpb24gNjYw NTUpCisrKyBXZWJDb3JlL2h0bWwvY2FudmFzL0Zsb2F0MzJBcnJheS5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTM3LDcgKzM3LDcgQEAgUGFzc1JlZlB0cjxGbG9hdDMyQXJyYXk+IEZsb2F0MzJBcnJh eTo6YwogICAgIHJldHVybiBUeXBlZEFycmF5QmFzZTxmbG9hdD46OmNyZWF0ZTxGbG9hdDMyQXJy YXk+KGxlbmd0aCk7CiB9CiAKLVBhc3NSZWZQdHI8RmxvYXQzMkFycmF5PiBGbG9hdDMyQXJyYXk6 OmNyZWF0ZShmbG9hdCogYXJyYXksIHVuc2lnbmVkIGxlbmd0aCkKK1Bhc3NSZWZQdHI8RmxvYXQz MkFycmF5PiBGbG9hdDMyQXJyYXk6OmNyZWF0ZShjb25zdCBmbG9hdCogYXJyYXksIHVuc2lnbmVk IGxlbmd0aCkKIHsKICAgICByZXR1cm4gVHlwZWRBcnJheUJhc2U8ZmxvYXQ+OjpjcmVhdGU8Rmxv YXQzMkFycmF5PihhcnJheSwgbGVuZ3RoKTsKIH0KSW5kZXg6IFdlYkNvcmUvaHRtbC9jYW52YXMv RmxvYXQzMkFycmF5LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1sL2NhbnZhcy9GbG9hdDMy QXJyYXkuaAkocmV2aXNpb24gNjYwNTUpCisrKyBXZWJDb3JlL2h0bWwvY2FudmFzL0Zsb2F0MzJB cnJheS5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNSw3ICszNSw3IEBAIG5hbWVzcGFjZSBXZWJDb3Jl IHsKIGNsYXNzIEZsb2F0MzJBcnJheSA6IHB1YmxpYyBUeXBlZEFycmF5QmFzZTxmbG9hdD4gewog ICBwdWJsaWM6CiAgICAgc3RhdGljIFBhc3NSZWZQdHI8RmxvYXQzMkFycmF5PiBjcmVhdGUodW5z aWduZWQgbGVuZ3RoKTsKLSAgICBzdGF0aWMgUGFzc1JlZlB0cjxGbG9hdDMyQXJyYXk+IGNyZWF0 ZShmbG9hdCogYXJyYXksIHVuc2lnbmVkIGxlbmd0aCk7CisgICAgc3RhdGljIFBhc3NSZWZQdHI8 RmxvYXQzMkFycmF5PiBjcmVhdGUoY29uc3QgZmxvYXQqIGFycmF5LCB1bnNpZ25lZCBsZW5ndGgp OwogICAgIHN0YXRpYyBQYXNzUmVmUHRyPEZsb2F0MzJBcnJheT4gY3JlYXRlKFBhc3NSZWZQdHI8 QXJyYXlCdWZmZXI+IGJ1ZmZlciwgdW5zaWduZWQgYnl0ZU9mZnNldCwgdW5zaWduZWQgbGVuZ3Ro KTsKIAogICAgIHVzaW5nIFR5cGVkQXJyYXlCYXNlPGZsb2F0Pjo6c2V0OwpJbmRleDogV2ViQ29y ZS9odG1sL2NhbnZhcy9UeXBlZEFycmF5QmFzZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvaHRt bC9jYW52YXMvVHlwZWRBcnJheUJhc2UuaAkocmV2aXNpb24gNjYwNTUpCisrKyBXZWJDb3JlL2h0 bWwvY2FudmFzL1R5cGVkQXJyYXlCYXNlLmgJKHdvcmtpbmcgY29weSkKQEAgLTY3LDcgKzY3LDcg QEAgY2xhc3MgVHlwZWRBcnJheUJhc2UgOiBwdWJsaWMgQXJyYXlCdWZmZQogICAgIH0KIAogICAg IHRlbXBsYXRlIDxjbGFzcyBTdWJjbGFzcz4KLSAgICBzdGF0aWMgUGFzc1JlZlB0cjxTdWJjbGFz cz4gY3JlYXRlKFQqIGFycmF5LCB1bnNpZ25lZCBsZW5ndGgpCisgICAgc3RhdGljIFBhc3NSZWZQ dHI8U3ViY2xhc3M+IGNyZWF0ZShjb25zdCBUKiBhcnJheSwgdW5zaWduZWQgbGVuZ3RoKQogICAg IHsKICAgICAgICAgUmVmUHRyPFN1YmNsYXNzPiBhID0gY3JlYXRlPFN1YmNsYXNzPihsZW5ndGgp OwogICAgICAgICBpZiAoYSkK