44644 2010-08-25 15:55:04 -0700 stop blocking commits when the bots are red 2010-08-25 18:52:51 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ojan ojan abarth eric webkit.review.bot oldest_to_newest 269566 0 ojan 2010-08-25 15:55:04 -0700 stop blocking commits when the bots are red 269570 1 65491 ojan 2010-08-25 15:57:15 -0700 Created attachment 65491 Patch 269576 2 65491 eric 2010-08-25 16:05:56 -0700 Comment on attachment 65491 Patch OK. 269617 3 ojan 2010-08-25 17:08:01 -0700 Committed r66058: <http://trac.webkit.org/changeset/66058> 269673 4 webkit.review.bot 2010-08-25 18:52:51 -0700 http://trac.webkit.org/changeset/66058 might have broken GTK Linux 64-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/66056 http://trac.webkit.org/changeset/66057 http://trac.webkit.org/changeset/66058 http://trac.webkit.org/changeset/66060 http://trac.webkit.org/changeset/66053 65491 2010-08-25 15:57:15 -0700 2010-08-25 16:05:56 -0700 Patch bug-44644-20100825155714.patch text/plain 4043 ojan ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAwMzQ3ODlmN2FkM2RmM2U0YTdkOTk0ZjMwMDkyMjQ5NjBhZjQzYmY2Li5kYzI4NTQy ZGFlOGViMDEzZjU5MDRhMDI0MmQ3YzdiMzE3NjUwMjQxIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAgQEAK IDIwMTAtMDgtMjUgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBzdG9wIGJsb2NraW5nIGNvbW1p dHMgd2hlbiB0aGUgYm90cyBhcmUgcmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00NDY0NAorCisgICAgICAgIFRoaXMgY2hlY2sgY3VycmVudGx5IGlz IGp1c3QgYW5ub3lpbmcuIEl0IGRvZXNuJ3QgYWN0dWFsbHkKKyAgICAgICAgaGVscCBrZWVwIHRo ZSB0cmVlIGdyZWVuLiBXZSBjYW4gYWx3YXlzIGFkZCBpdCBiYWNrIGxhdGVyCisgICAgICAgIGlm IHdlIGRlY2lkZSB0aGUgdHJlZSBpcyBnZW5lcmFsbHkgbW9yZSBncmVlbi4KKworICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9kb3dubG9hZF91bml0dGVzdC5weToKKyAg ICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvbW9ja3Rvb2wucHk6CisgICAgICAgICogU2Ny aXB0cy93ZWJraXRweS90b29sL3N0ZXBzL2Vuc3VyZWJ1aWxkZXJzYXJlZ3JlZW4ucHk6CisKKzIw MTAtMDgtMjUgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KKwogICAgICAgICBSZXZp ZXdlZCBieSBBZGFtIEJhcnRoLgogCiAgICAgICAgIG5ldy1ydW4td2Via2l0LXRlc3RzIHNob3Vs ZCByZXNwZWN0IHNldC13ZWJraXQtY29uZmlndXJhdGlvbgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9v bHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Rvd25sb2FkX3VuaXR0ZXN0LnB5IGIv V2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Rvd25sb2FkX3VuaXR0 ZXN0LnB5CmluZGV4IDc1Y2QwZjMwYjUzMjQwZWZhMDc3MTY2MTY1MWZlZGFmZjY3OTI1NzAuLmZh ZGRkNTA1NjM1ZjM3OWI4NzEyYzQ3ZjAwM2E5YjAyYWQwMWNjZjIgMTAwNjQ0Ci0tLSBhL1dlYktp dFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9kb3dubG9hZF91bml0dGVzdC5w eQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZG93bmxv YWRfdW5pdHRlc3QucHkKQEAgLTEwMCw2ICsxMDAsMTIgQEAgY2xhc3MgRG93bmxvYWRDb21tYW5k c1Rlc3QoQ29tbWFuZHNUZXN0KToKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChtb2NrX3Rvb2wu c2NtKCkuY3JlYXRlX3BhdGNoLmNhbGxfY291bnQsIDApCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1 YWwobW9ja190b29sLmNoZWNrb3V0KCkubW9kaWZpZWRfY2hhbmdlbG9ncy5jYWxsX2NvdW50LCAx KQogCisgICAgZGVmIHRlc3RfbGFuZF9yZWRfYnVpbGRlcnMoc2VsZik6CisgICAgICAgIGV4cGVj dGVkX3N0ZGVyciA9ICdcbldBUk5JTkc6IEJ1aWxkZXJzIFsiQnVpbGRlcjIiXSBhcmUgcmVkLCBw bGVhc2Ugd2F0Y2ggeW91ciBjb21taXQgY2FyZWZ1bGx5LlxuU2VlIGh0dHA6Ly9kdW1teV9idWls ZGJvdF9ob3N0L2NvbnNvbGU/Y2F0ZWdvcnk9Y29yZVxuXG5CdWlsZGluZyBXZWJLaXRcblJ1bm5p bmcgUHl0aG9uIHVuaXQgdGVzdHNcblJ1bm5pbmcgUGVybCB1bml0IHRlc3RzXG5SdW5uaW5nIEph dmFTY3JpcHRDb3JlIHRlc3RzXG5SdW5uaW5nIHJ1bi13ZWJraXQtdGVzdHNcblVwZGF0aW5nIGJ1 ZyA0MlxuJworICAgICAgICBtb2NrX3Rvb2wgPSBNb2NrVG9vbCgpCisgICAgICAgIG1vY2tfdG9v bC5idWlsZGJvdC5saWdodF90cmVlX29uX2ZpcmUoKQorICAgICAgICBzZWxmLmFzc2VydF9leGVj dXRlX291dHB1dHMoTGFuZCgpLCBbNDJdLCBvcHRpb25zPXNlbGYuX2RlZmF1bHRfb3B0aW9ucygp LCBleHBlY3RlZF9zdGRlcnI9ZXhwZWN0ZWRfc3RkZXJyLCB0b29sPW1vY2tfdG9vbCkKKwogICAg IGRlZiB0ZXN0X2NoZWNrX3N0eWxlKHNlbGYpOgogICAgICAgICBleHBlY3RlZF9zdGRlcnIgPSAi UHJvY2Vzc2luZyAxIHBhdGNoIGZyb20gMSBidWcuXG5VcGRhdGluZyB3b3JraW5nIGRpcmVjdG9y eVxuUHJvY2Vzc2luZyBwYXRjaCAxOTcgZnJvbSBidWcgNDIuXG5SdW5uaW5nIGNoZWNrLXdlYmtp dC1zdHlsZVxuIgogICAgICAgICBzZWxmLmFzc2VydF9leGVjdXRlX291dHB1dHMoQ2hlY2tTdHls ZSgpLCBbMTk3XSwgb3B0aW9ucz1zZWxmLl9kZWZhdWx0X29wdGlvbnMoKSwgZXhwZWN0ZWRfc3Rk ZXJyPWV4cGVjdGVkX3N0ZGVycikKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvdG9vbC9tb2NrdG9vbC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9v bC9tb2NrdG9vbC5weQppbmRleCA2MWI1ZDY2ODQ3NTllZjg5MjEwYTZiNzliZGUyOWY3MDk4ZWNl OThkLi43ZWI4ZjRjODNiYjZkNGE0MGYwYTQyMTBiMmRmOWYxYzZmOGYyOGRhIDEwMDY0NAotLS0g YS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvbW9ja3Rvb2wucHkKKysrIGIvV2Vi S2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL21vY2t0b29sLnB5CkBAIC0zNDEsNiArMzQx LDcgQEAgY2xhc3MgTW9ja0J1aWxkZXIob2JqZWN0KToKIAogCiBjbGFzcyBNb2NrQnVpbGRCb3Qo b2JqZWN0KToKKyAgICBidWlsZGJvdF9ob3N0ID0gImR1bW15X2J1aWxkYm90X2hvc3QiCiAgICAg ZGVmIF9faW5pdF9fKHNlbGYpOgogICAgICAgICBzZWxmLl9tb2NrX2J1aWxkZXIxX3N0YXR1cyA9 IHsKICAgICAgICAgICAgICJuYW1lIjogIkJ1aWxkZXIxIiwKZGlmZiAtLWdpdCBhL1dlYktpdFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9lbnN1cmVidWlsZGVyc2FyZWdyZWVuLnB5 IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL2Vuc3VyZWJ1aWxkZXJz YXJlZ3JlZW4ucHkKaW5kZXggN2I3MTdlZmI2NjVhNzkwNTRmYTg3NmJiY2U2ZWQxNGIwODFjMjJi MS4uYTRmYzE3NDcwY2E5N2ZhMWUyZDg1ZDU2Zjk4Nzc1NmFmM2FlMDFiNSAxMDA2NDQKLS0tIGEv V2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL2Vuc3VyZWJ1aWxkZXJzYXJl Z3JlZW4ucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL2Vu c3VyZWJ1aWxkZXJzYXJlZ3JlZW4ucHkKQEAgLTQ1LDYgKzQ1LDQgQEAgY2xhc3MgRW5zdXJlQnVp bGRlcnNBcmVHcmVlbihBYnN0cmFjdFN0ZXApOgogICAgICAgICBpZiBub3QgcmVkX2J1aWxkZXJz X25hbWVzOgogICAgICAgICAgICAgcmV0dXJuCiAgICAgICAgIHJlZF9idWlsZGVyc19uYW1lcyA9 IG1hcChsYW1iZGEgbmFtZTogIlwiJXNcIiIgJSBuYW1lLCByZWRfYnVpbGRlcnNfbmFtZXMpICMg QWRkIHF1b3RlcyBhcm91bmQgdGhlIG5hbWVzLgotICAgICAgICBsb2coIlxuQnVpbGRlcnMgWyVz XSBhcmUgcmVkLCBwbGVhc2UgZG8gbm90IGNvbW1pdC5cblNlZSBodHRwOi8vJXMvY29uc29sZT9j YXRlZ29yeT1jb3JlXG4iICUgKCIsICIuam9pbihyZWRfYnVpbGRlcnNfbmFtZXMpLCBzZWxmLl90 b29sLmJ1aWxkYm90LmJ1aWxkYm90X2hvc3QpKQotICAgICAgICBpZiBub3Qgc2VsZi5fdG9vbC51 c2VyLmNvbmZpcm0oIkFyZSB5b3Ugc3VyZSB5b3Ugd2FudCB0byBjb250aW51ZT8iKToKLSAgICAg ICAgICAgIGVycm9yKCJVc2VyIGFib3J0ZWQuIikKKyAgICAgICAgbG9nKCJcbldBUk5JTkc6IEJ1 aWxkZXJzIFslc10gYXJlIHJlZCwgcGxlYXNlIHdhdGNoIHlvdXIgY29tbWl0IGNhcmVmdWxseS5c blNlZSBodHRwOi8vJXMvY29uc29sZT9jYXRlZ29yeT1jb3JlXG4iICUgKCIsICIuam9pbihyZWRf YnVpbGRlcnNfbmFtZXMpLCBzZWxmLl90b29sLmJ1aWxkYm90LmJ1aWxkYm90X2hvc3QpKQo=