44633 2010-08-25 13:42:26 -0700 new-run-webkit-tests should respect set-webkit-configuration 2010-09-03 10:12:49 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 45180 1 ojan webkit-unassigned abarth dglazkov dpranke eric rniwa webkit.review.bot oldest_to_newest 269481 0 ojan 2010-08-25 13:42:26 -0700 I have set-webkit-configuration as --debug. I did: update-webkit --chromium build-webkit --chromium $new-run-webkit-tests --chromium --use-drt perf/ Defaulting to one child - see https://bugs.webkit.org/show_bug.cgi?id=38553 You are not running the most recent DumpRenderTree binary. You need to pass --debug or not to select between Debug and Release. Build, built debug. new-run-webkit-tests should have as well. 269485 1 abarth 2010-08-25 13:51:00 -0700 I thought we fixed this already. 269487 2 65470 ojan 2010-08-25 14:03:16 -0700 Created attachment 65470 Patch 269491 3 dpranke 2010-08-25 14:08:47 -0700 (In reply to comment #2) > Created an attachment (id=65470) [details] > Patch Adam: we fixed this for webkit-based ports, but the chromium port never looked at the switches. It's not clear to me that it should, but I don't feel strongly about it one way or another. Having all the tools act consistently is a good thing, though, so if build-webkit and update-webkit both work for --chromium, then new-run-webkit-tests should as well. Patch looks good to me. It would be good to actually port webkitdirs.pm over to python to consolidate code at some point ... 269493 4 65470 abarth 2010-08-25 14:12:50 -0700 Comment on attachment 65470 Patch nice 269497 5 ojan 2010-08-25 14:16:59 -0700 Committed r66041: <http://trac.webkit.org/changeset/66041> 269545 6 webkit.review.bot 2010-08-25 15:24:46 -0700 http://trac.webkit.org/changeset/66041 might have broken Qt Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/66041 http://trac.webkit.org/changeset/66042 274000 7 dglazkov 2010-09-03 10:05:04 -0700 This doesn't work on Windows though. Fix coming up. 65470 2010-08-25 14:03:16 -0700 2010-08-25 14:12:50 -0700 Patch bug-44633-20100825140315.patch text/plain 5154 ojan ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA5MTU0Zjk0YTkxZGQyMjI2YTcxMjhhNTg3NDUyODU1NjRlNzcyZjVmLi40NDc2Nzc4 ODQ4ZmVmODk2M2Q3M2Y1MTQyOWMzZmZiMjc4YjY2ZGVhIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTAtMDgtMjUgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBuZXctcnVuLXdlYmtpdC10ZXN0 cyBzaG91bGQgcmVzcGVjdCBzZXQtd2Via2l0LWNvbmZpZ3VyYXRpb24KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0NjMzCisKKyAgICAgICAgTW92ZXMg dGhlIGdldHRpbmcgb2YgdGhlIGNvbmZpZ3VyYXRpb24gaW50byB0aGUgYmFzZSBQb3J0IHNvIHRo YXQKKyAgICAgICAgY2hyb21pdW0gcG9ydHMgdXNlIGl0IGFzIHdlbGwuIEluIHRoZSBkb3duc3Ry ZWFtIGNocm9taXVtIHBvcnQsCisgICAgICAgIHRoaXMgc2hvdWxkIHN0aWxsIGp1c3QgcmV0dXJu IFJlbGVhc2UuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L2Jhc2UucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93 ZWJraXQucHk6CisKIDIwMTAtMDgtMjUgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4K IAogICAgICAgICBOb3QgcmV2aWV3ZWQsIGNoYW5naW5nIHN2biBwcm9wcyBmb3IgYSBzY3JpcHQu CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9w b3J0L2Jhc2UucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9w b3J0L2Jhc2UucHkKaW5kZXggZDIyNmU2NDhkYTgwNjEzYTFhZDVmMjA4NDM2M2NhOGI1MTUxMDJh Yi4uNGMwNDcyZDVkMDM1ZjJlZjY5ZDU2MjczM2JlOThiNDJlOGJhMWVjOSAxMDA2NDQKLS0tIGEv V2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9iYXNlLnB5Cisr KyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZS5w eQpAQCAtMzEsNiArMzEsNyBAQAogdGVzdCBpbmZyYXN0cnVjdHVyZSAodGhlIFBvcnQgYW5kIERy aXZlciBjbGFzc2VzKS4iIiIKIAogaW1wb3J0IGNnaQoraW1wb3J0IGNvZGVjcwogaW1wb3J0IGRp ZmZsaWIKIGltcG9ydCBlcnJubwogaW1wb3J0IG9zCkBAIC02MzMsOCArNjM0LDM4IEBAIGNsYXNz IFBvcnQob2JqZWN0KToKICAgICAgICAgICAgIF9sb2cuZXJyb3IoIkZhaWxlZCB0byBydW4gUHJl dHR5UGF0Y2ggKCVzKTpcbiVzIiAlIChjb21tYW5kLCBlLm1lc3NhZ2Vfd2l0aF9vdXRwdXQoKSkp CiAgICAgICAgICAgICByZXR1cm4gc2VsZi5fcHJldHR5X3BhdGNoX2Vycm9yX2h0bWwKIAorICAg IGRlZiBfd2Via2l0X2J1aWxkX2RpcmVjdG9yeShzZWxmLCBhcmdzKToKKyAgICAgICAgYXJncyA9 IFtzZWxmLnNjcmlwdF9wYXRoKCJ3ZWJraXQtYnVpbGQtZGlyZWN0b3J5IildICsgYXJncworICAg ICAgICByZXR1cm4gc2VsZi5fZXhlY3V0aXZlLnJ1bl9jb21tYW5kKGFyZ3MpLnJzdHJpcCgpCisK KyAgICBkZWYgX2NvbmZpZ3VyYXRpb25fZmlsZV9wYXRoKHNlbGYpOgorICAgICAgICBidWlsZF9y b290ID0gc2VsZi5fd2Via2l0X2J1aWxkX2RpcmVjdG9yeShbIi0tdG9wLWxldmVsIl0pCisgICAg ICAgIHJldHVybiBvcy5wYXRoLmpvaW4oYnVpbGRfcm9vdCwgIkNvbmZpZ3VyYXRpb24iKQorCisg ICAgIyBFYXN5IG92ZXJyaWRlIGZvciB1bml0IHRlc3RzCisgICAgZGVmIF9vcGVuX2NvbmZpZ3Vy YXRpb25fZmlsZShzZWxmKToKKyAgICAgICAgY29uZmlndXJhdGlvbl9wYXRoID0gc2VsZi5fY29u ZmlndXJhdGlvbl9maWxlX3BhdGgoKQorICAgICAgICByZXR1cm4gY29kZWNzLm9wZW4oY29uZmln dXJhdGlvbl9wYXRoLCAiciIsICJ1dGYtOCIpCisKKyAgICBkZWYgX3JlYWRfY29uZmlndXJhdGlv bihzZWxmKToKKyAgICAgICAgdHJ5OgorICAgICAgICAgICAgd2l0aCBzZWxmLl9vcGVuX2NvbmZp Z3VyYXRpb25fZmlsZSgpIGFzIGZpbGU6CisgICAgICAgICAgICAgICAgcmV0dXJuIGZpbGUucmVh ZGxpbmUoKS5yc3RyaXAoKQorICAgICAgICBleGNlcHQgSU9FcnJvciwgZToKKyAgICAgICAgICAg IHJldHVybiBOb25lCisKKyAgICAjIEZJWE1FOiBUaGlzIGxpc3QgbWF5IGJlIGluY29tcGxldGUg YXMgQXBwbGUgaGFzIHNvbWUgc2VrcmV0IGNvbmZpZ3MuCisgICAgX1JFQ09HTklaRURfQ09ORklH VVJBVElPTlMgPSAoIkRlYnVnIiwgIlJlbGVhc2UiKQorCiAgICAgZGVmIGRlZmF1bHRfY29uZmln dXJhdGlvbihzZWxmKToKLSAgICAgICAgcmV0dXJuICJSZWxlYXNlIgorICAgICAgICAjIEZJWE1F OiBVbmlmeSB0aGlzIHdpdGggd2Via2l0ZGlyLnBtIGNvbmZpZ3VyYXRpb24gcmVhZGluZyBjb2Rl LgorICAgICAgICBjb25maWd1cmF0aW9uID0gc2VsZi5fcmVhZF9jb25maWd1cmF0aW9uKCkKKyAg ICAgICAgaWYgbm90IGNvbmZpZ3VyYXRpb246CisgICAgICAgICAgICBjb25maWd1cmF0aW9uID0g IlJlbGVhc2UiCisgICAgICAgIGlmIGNvbmZpZ3VyYXRpb24gbm90IGluIHNlbGYuX1JFQ09HTkla RURfQ09ORklHVVJBVElPTlM6CisgICAgICAgICAgICBfbG9nLndhcm4oIkNvbmZpZ3VyYXRpb24g XCIlc1wiIGZvdW5kIGluICVzIGlzIG5vdCBhIHJlY29nbml6ZWQgdmFsdWUuXG4iICUgKGNvbmZp Z3VyYXRpb24sIHNlbGYuX2NvbmZpZ3VyYXRpb25fZmlsZV9wYXRoKCkpKQorICAgICAgICAgICAg X2xvZy53YXJuKCJTY3JpcHRzIG1heSBmYWlsLiAgU2VlICdzZXQtd2Via2l0LWNvbmZpZ3VyYXRp b24gLS1oZWxwJy4iKQorICAgICAgICByZXR1cm4gY29uZmlndXJhdGlvbgogCiAgICAgIwogICAg ICMgUFJPVEVDVEVEIFJPVVRJTkVTCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5CmluZGV4IGUxMTUxYTY1M2FmYmNk ZmEzZThhY2M5NzVhYjdhNDY5NTYzMDc0MGQuLmNlZGMwMjg2NWE1NTA1ODU5NmFkNjFlMGU3YzY5 OTE4ZGI4YTliMWEgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5CkBAIC0yOTUsMzkgKzI5NSw2IEBAIGNsYXNz IFdlYktpdFBvcnQoYmFzZS5Qb3J0KToKICAgICAgICAgcmV0dXJuIHNlbGYudGVzdF9iYXNlX3Bs YXRmb3JtX25hbWVzKCkgKyAoCiAgICAgICAgICAgICAnbWFjLXRpZ2VyJywgJ21hYy1sZW9wYXJk JywgJ21hYy1zbm93bGVvcGFyZCcpCiAKLSAgICBkZWYgX2NvbmZpZ3VyYXRpb25fZmlsZV9wYXRo KHNlbGYpOgotICAgICAgICBidWlsZF9yb290ID0gc2VsZi5fd2Via2l0X2J1aWxkX2RpcmVjdG9y eShbIi0tdG9wLWxldmVsIl0pCi0gICAgICAgIHJldHVybiBvcy5wYXRoLmpvaW4oYnVpbGRfcm9v dCwgIkNvbmZpZ3VyYXRpb24iKQotCi0gICAgIyBFYXN5IG92ZXJyaWRlIGZvciB1bml0IHRlc3Rz Ci0gICAgZGVmIF9vcGVuX2NvbmZpZ3VyYXRpb25fZmlsZShzZWxmKToKLSAgICAgICAgY29uZmln dXJhdGlvbl9wYXRoID0gc2VsZi5fY29uZmlndXJhdGlvbl9maWxlX3BhdGgoKQotICAgICAgICBy ZXR1cm4gY29kZWNzLm9wZW4oY29uZmlndXJhdGlvbl9wYXRoLCAiciIsICJ1dGYtOCIpCi0KLSAg ICBkZWYgX3JlYWRfY29uZmlndXJhdGlvbihzZWxmKToKLSAgICAgICAgdHJ5OgotICAgICAgICAg ICAgd2l0aCBzZWxmLl9vcGVuX2NvbmZpZ3VyYXRpb25fZmlsZSgpIGFzIGZpbGU6Ci0gICAgICAg ICAgICAgICAgcmV0dXJuIGZpbGUucmVhZGxpbmUoKS5yc3RyaXAoKQotICAgICAgICBleGNlcHQg SU9FcnJvciwgZToKLSAgICAgICAgICAgIHJldHVybiBOb25lCi0KLSAgICAjIEZJWE1FOiBUaGlz IGxpc3QgbWF5IGJlIGluY29tcGxldGUgYXMgQXBwbGUgaGFzIHNvbWUgc2VrcmV0IGNvbmZpZ3Mu Ci0gICAgX1JFQ09HTklaRURfQ09ORklHVVJBVElPTlMgPSAoIkRlYnVnIiwgIlJlbGVhc2UiKQot Ci0gICAgZGVmIGRlZmF1bHRfY29uZmlndXJhdGlvbihzZWxmKToKLSAgICAgICAgIyBGSVhNRTog VW5pZnkgdGhpcyB3aXRoIHdlYmtpdGRpci5wbSBjb25maWd1cmF0aW9uIHJlYWRpbmcgY29kZS4K LSAgICAgICAgY29uZmlndXJhdGlvbiA9IHNlbGYuX3JlYWRfY29uZmlndXJhdGlvbigpCi0gICAg ICAgIGlmIG5vdCBjb25maWd1cmF0aW9uOgotICAgICAgICAgICAgY29uZmlndXJhdGlvbiA9ICJS ZWxlYXNlIgotICAgICAgICBpZiBjb25maWd1cmF0aW9uIG5vdCBpbiBzZWxmLl9SRUNPR05JWkVE X0NPTkZJR1VSQVRJT05TOgotICAgICAgICAgICAgX2xvZy53YXJuKCJDb25maWd1cmF0aW9uIFwi JXNcIiBmb3VuZCBpbiAlcyBpcyBub3QgYSByZWNvZ25pemVkIHZhbHVlLlxuIiAlIChjb25maWd1 cmF0aW9uLCBzZWxmLl9jb25maWd1cmF0aW9uX2ZpbGVfcGF0aCgpKSkKLSAgICAgICAgICAgIF9s b2cud2FybigiU2NyaXB0cyBtYXkgZmFpbC4gIFNlZSAnc2V0LXdlYmtpdC1jb25maWd1cmF0aW9u IC0taGVscCcuIikKLSAgICAgICAgcmV0dXJuIGNvbmZpZ3VyYXRpb24KLQotICAgIGRlZiBfd2Vi a2l0X2J1aWxkX2RpcmVjdG9yeShzZWxmLCBhcmdzKToKLSAgICAgICAgYXJncyA9IFtzZWxmLnNj cmlwdF9wYXRoKCJ3ZWJraXQtYnVpbGQtZGlyZWN0b3J5IildICsgYXJncwotICAgICAgICByZXR1 cm4gc2VsZi5fZXhlY3V0aXZlLnJ1bl9jb21tYW5kKGFyZ3MpLnJzdHJpcCgpCi0KICAgICBkZWYg X2J1aWxkX3BhdGgoc2VsZiwgKmNvbXBzKToKICAgICAgICAgaWYgbm90IHNlbGYuX2NhY2hlZF9i dWlsZF9yb290OgogICAgICAgICAgICAgc2VsZi5fY2FjaGVkX2J1aWxkX3Jvb3QgPSBzZWxmLl93 ZWJraXRfYnVpbGRfZGlyZWN0b3J5KFsK