44619 2010-08-25 10:15:35 -0700 drawGDIGlyphs checks if the offset is empty incorrectly causing problems with the shadow 2010-08-27 02:23:44 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 alex webkit-unassigned mitz oldest_to_newest 269315 0 alex 2010-08-25 10:15:35 -0700 From the comment: https://bugs.webkit.org/show_bug.cgi?id=44603#c5 (In reply to comment #2) > After changing the names I've realized that this condition could be wrong but the old name could make it seem correct: > > + drawIntoBitmap = !offset.isEmpty() || blur; > > It is in this file: WebCore/platform/graphics/win/FontCGWin.cpp static void drawGDIGlyphs > > Could someone check if in Windows negative offsets of the text actually work, or no offsets but blurring. We could open a new bug in this case. I’ve asked someone to check, and indeed in <data:text/html,%3Cdiv%20style=%22-webkit-font-smoothing:%20none%22%3E%3Cdiv%20style=%22text-shadow:%202px%202px%20red%22%3Etest%3C/div%3E%3Cdiv%20style=%22text-shadow:%20-2px%20-2px%20red%22%3Etest%3C/div%3E%3C/div%3E> the bottom line is missing the shadow. Good catch! 269773 1 65534 alex 2010-08-26 01:39:06 -0700 Created attachment 65534 Proposed patch I can not test the patch but I guess at least it can be used as a initial point. 270389 2 alex 2010-08-27 02:23:35 -0700 landed r66192, closing bug 65534 2010-08-26 01:39:06 -0700 2010-08-26 07:11:39 -0700 Proposed patch font_shadow.patch text/plain 1282 alex ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MDk2OTBhMy4uN2Q3Y2Y5MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wOC0yNSAgQWxlamFuZHJvIEcu IENhc3RybyAgPGFsZXhAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBkcmF3R0RJR2x5cGhzIGNoZWNrcyBpZiB0aGUgb2Zmc2V0IGlz IGVtcHR5IGluY29ycmVjdGx5IGNhdXNpbmcKKyAgICAgICAgcHJvYmxlbXMgd2l0aCB0aGUgc2hh ZG93CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDYx OQorCisgICAgICAgIFJlbW92ZWQgdGhlIG9mZnNldCBlbXB0eSBjb25kaXRpb24sIG5vdyB3ZSBq dXN0IGNoZWNrIGlmIHdlIGhhdmUKKyAgICAgICAgb2Zmc2V0IG9yIGJsdXIuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy93aW4vRm9udENHV2luLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OmRyYXdHRElHbHlwaHMpOgorCiAyMDEwLTA4LTI2ICBHaXJpc2ggUmFtYWtyaXNobmFuICA8Z2ly aXNoQGZvcndhcmRiaWFzLmluPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFyaXlhIEhpZGF5YXQu CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9Gb250Q0dXaW4uY3Bw IGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vRm9udENHV2luLmNwcAppbmRleCA5ZDgx ODM4Li5jNjQzN2YyIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9G b250Q0dXaW4uY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL0ZvbnRDR1dp bi5jcHAKQEAgLTE0NCw3ICsxNDQsNyBAQCBzdGF0aWMgdm9pZCBkcmF3R0RJR2x5cGhzKEdyYXBo aWNzQ29udGV4dCogZ3JhcGhpY3NDb250ZXh0LCBjb25zdCBTaW1wbGVGb250RGF0YQogICAgICAg ICAgICAgZmxvYXQgYmx1cjsKICAgICAgICAgICAgIENvbG9yIGNvbG9yOwogICAgICAgICAgICAg Z3JhcGhpY3NDb250ZXh0LT5nZXRTaGFkb3cob2Zmc2V0LCBibHVyLCBjb2xvcik7Ci0gICAgICAg ICAgICBkcmF3SW50b0JpdG1hcCA9ICFvZmZzZXQuaXNFbXB0eSgpIHx8IGJsdXI7CisgICAgICAg ICAgICBkcmF3SW50b0JpdG1hcCA9IG9mZnNldC53aWR0aCgpIHx8IG9mZnNldC5oZWlnaHQoKSB8 fCBibHVyOwogICAgICAgICB9CiAgICAgfQogCg==