44618 2010-08-25 09:52:58 -0700 [Qt] Replace QLibrary("libgdk-x11-2.0.so.0") with QLibrary("libgdk-x11-2.0", 0) 2010-08-26 00:34:19 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Other Other RESOLVED FIXED Qt P2 Normal --- 1 girish webkit-unassigned commit-queue oldest_to_newest 269301 0 girish 2010-08-25 09:52:58 -0700 According to Harald Fernengel, this is better. 269303 1 65430 girish 2010-08-25 09:54:18 -0700 Created attachment 65430 patch 269381 2 65430 kling 2010-08-25 11:20:44 -0700 Comment on attachment 65430 patch LGTM, didn't know we had this API. :) 269426 3 65430 ariya.hidayat 2010-08-25 12:03:28 -0700 Comment on attachment 65430 patch LGTM.r+ 269551 4 65430 commit-queue 2010-08-25 15:39:37 -0700 Comment on attachment 65430 patch Rejecting patch 65430 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20928 test cases. media/video-played-collapse.html -> failed Exiting early after 1 failures. 17270 tests run. 380.72s total testing time 17269 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 33 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/3796353 269758 5 girish 2010-08-26 00:34:19 -0700 Landed manually in r66084. 65430 2010-08-25 09:54:18 -0700 2010-08-25 15:39:37 -0700 patch libcall text/plain 1564 girish Y29tbWl0IDUzNmU5ZGNiMjUxOTVlM2NlYzVkZGIyYmExYzQzZmQ1NWQ3NWJhNzgKQXV0aG9yOiBH aXJpc2ggUmFtYWtyaXNobmFuIDxnaXJpc2hAZm9yd2FyZGJpYXMuaW4+CkRhdGU6ICAgV2VkIEF1 ZyAyNSAyMjoyMjoxNSAyMDEwICswNTMwCgogICAgW1F0XSBSZXBsYWNlIFFMaWJyYXJ5KCJsaWJn ZGsteDExLTIuMC5zby4wIikgd2l0aCBRTGlicmFyeSgibGliZ2RrLXgxMS0yLjAiLCAwKQogICAg CiAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDQ2MTgKICAgIAog ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCiAgICAKICAgICogcGx1Z2lucy9xdC9QbHVn aW5WaWV3UXQuY3BwOgogICAgKFdlYkNvcmU6OmdldFBsdWdpbkRpc3BsYXkpOgoKZGlmZiAtLWdp dCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2ExNTdlOS4u MGYxN2IyNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wOC0yNSAgR2lyaXNoIFJhbWFrcmlzaG5hbiAg PGdpcmlzaEBmb3J3YXJkYmlhcy5pbj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBbUXRdIFJlcGxhY2UgUUxpYnJhcnkoImxpYmdkay14MTEtMi4wLnNv LjAiKSB3aXRoIFFMaWJyYXJ5KCJsaWJnZGsteDExLTIuMCIsIDApCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDYxOAorCisgICAgICAgICogcGx1Z2lu cy9xdC9QbHVnaW5WaWV3UXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Z2V0UGx1Z2luRGlzcGxh eSk6CisKIDIwMTAtMDgtMjUgIERhd2l0IEFsZW1heWVodSAgPGFkYXdpdEBrZGUub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEFyaXlhIEhpZGF5YXQuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3Bs dWdpbnMvcXQvUGx1Z2luVmlld1F0LmNwcCBiL1dlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5WaWV3 UXQuY3BwCmluZGV4IDVjNjgxYjguLjRlODljN2IgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGx1Z2lu cy9xdC9QbHVnaW5WaWV3UXQuY3BwCisrKyBiL1dlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5WaWV3 UXQuY3BwCkBAIC03NTUsNyArNzU1LDcgQEAgc3RhdGljIERpc3BsYXkgKmdldFBsdWdpbkRpc3Bs YXkoKQogICAgIC8vIHN1cHBvcnQgZ2RrIGJhc2VkIHBsdWdpbnMgKGxpa2UgZmxhc2gpIHRoYXQg dXNlIGEgZGlmZmVyZW50IFggY29ubmVjdGlvbi4KICAgICAvLyBUaGUgY29kZSBiZWxvdyBoYXMg dGhlIHNhbWUgZWZmZWN0IGFzIHRoaXMgb25lOgogICAgIC8vIERpc3BsYXkgKmdka0Rpc3BsYXkg PSBnZGtfeDExX2Rpc3BsYXlfZ2V0X3hkaXNwbGF5KGdka19kaXNwbGF5X2dldF9kZWZhdWx0KCkp OwotICAgIFFMaWJyYXJ5IGxpYnJhcnkoImxpYmdkay14MTEtMi4wLnNvLjAiKTsKKyAgICBRTGli cmFyeSBsaWJyYXJ5KCJsaWJnZGsteDExLTIuMCIsIDApOwogICAgIGlmICghbGlicmFyeS5sb2Fk KCkpCiAgICAgICAgIHJldHVybiAwOwogCg==