44612 2010-08-25 08:30:56 -0700 Web Inspector: support checked and disabled context menu items. 2010-08-25 09:56:00 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 269255 0 pfeldman 2010-08-25 08:30:56 -0700 Patch to follow. 269256 1 65421 pfeldman 2010-08-25 08:34:22 -0700 Created attachment 65421 [PATCH] Proposed fix. 269258 2 65421 yurys 2010-08-25 08:38:54 -0700 Comment on attachment 65421 [PATCH] Proposed fix. WebCore/platform/ContextMenu.cpp:825 + if (ContextMenuItemBaseCustomTag <= item.action() && item.action() <= ContextMenuItemLastCustomTag) Please move this above the switch. 269264 3 pfeldman 2010-08-25 08:49:14 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/platform/ContextMenu.cpp Committed r66015 269304 4 joepeck 2010-08-25 09:56:00 -0700 > WebCore/platform/ContextMenu.cpp:825 > + if (ContextMenuItemBaseCustomTag <= item.action() && item.action() <= ContextMenuItemLastCustomTag) > Please move this above the switch. Yury's, when you make review comments it would be helpful to also explain why you made your suggestion. Sometimes it is not obvious to me. Here, with a little investigation I see that was a very good review comment to prevent doing unnecessary work before an early return. Thanks! 65421 2010-08-25 08:34:22 -0700 2010-08-25 08:38:53 -0700 [PATCH] Proposed fix. check_items text/plain 1207 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTRlOTUyNS4uNDFiZDE5YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNSBAQAogMjAxMC0wOC0yNSAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBzdXBwb3J0IGNoZWNrZWQgYW5kIGRp c2FibGVkIGNvbnRleHQgbWVudSBpdGVtcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTQ0NjEyCisKKyAgICAgICAgKiBwbGF0Zm9ybS9Db250ZXh0TWVu dS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDb250ZXh0TWVudTo6Y2hlY2tPckVuYWJsZUlmTmVl ZGVkKToKKworMjAxMC0wOC0yNSAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9y Zz4KKwogICAgICAgICBSZXZpZXdlZCBieSBZdXJ5IFNlbWlraGF0c2t5LgogCiAgICAgICAgIFdl YiBJbnNwZWN0b3I6IHN1cHBvcnQgZGlzYWJsZWQgYW5kIGNoZWNrZWQgY29udGV4dCBtZW51IGl0 ZW1zLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9Db250ZXh0TWVudS5jcHAgYi9XZWJD b3JlL3BsYXRmb3JtL0NvbnRleHRNZW51LmNwcAppbmRleCA4NGEyZmZjLi43MTc0OGVjIDEwMDY0 NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL0NvbnRleHRNZW51LmNwcAorKysgYi9XZWJDb3JlL3Bs YXRmb3JtL0NvbnRleHRNZW51LmNwcApAQCAtODIxLDYgKzgyMSwxMCBAQCB2b2lkIENvbnRleHRN ZW51OjpjaGVja09yRW5hYmxlSWZOZWVkZWQoQ29udGV4dE1lbnVJdGVtJiBpdGVtKSBjb25zdAog ICAgICAgICAgICAgYnJlYWs7CiAgICAgfQogCisgICAgLy8gQ3VzdG9tIGl0ZW1zIGFscmVhZHkg aGF2ZSBwcm9wZXIgY2hlY2tlZCBhbmQgZW5hYmxlZCB2YWx1ZXMuCisgICAgaWYgKENvbnRleHRN ZW51SXRlbUJhc2VDdXN0b21UYWcgPD0gaXRlbS5hY3Rpb24oKSAmJiBpdGVtLmFjdGlvbigpIDw9 IENvbnRleHRNZW51SXRlbUxhc3RDdXN0b21UYWcpCisgICAgICAgIHJldHVybjsKKwogICAgIGl0 ZW0uc2V0Q2hlY2tlZChzaG91bGRDaGVjayk7CiAgICAgaXRlbS5zZXRFbmFibGVkKHNob3VsZEVu YWJsZSk7CiB9Cg==