44608 2010-08-25 06:43:04 -0700 [GTK] CodeGeneratorGObject not picking up FEATURE_DEFINES 2010-08-25 10:35:11 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 xan.lopez webkit-unassigned oldest_to_newest 269214 0 xan.lopez 2010-08-25 06:43:04 -0700 Stuff broke when moving things from WebCore/GNUmakefile.am to GNUmakefile.am. There's a) a typo b) FEATURE_DEFINES wasn't moved so it's not seen. 269215 1 65412 xan.lopez 2010-08-25 06:46:13 -0700 Created attachment 65412 featuredefines.diff 269323 2 65412 mrobinson 2010-08-25 10:25:08 -0700 Comment on attachment 65412 featuredefines.diff Sorry for the bustage. LGTM! 269330 3 65412 xan.lopez 2010-08-25 10:34:57 -0700 Comment on attachment 65412 featuredefines.diff Landed as r66021. 269331 4 xan.lopez 2010-08-25 10:35:11 -0700 Closing the bug. 65412 2010-08-25 06:46:13 -0700 2010-08-25 10:34:57 -0700 featuredefines.diff featuredefines.diff text/plain 3945 xan.lopez RnJvbSA1Y2UzZjFkNmFiNDI3MDBlNzQ5ODI5YjY2NzY5YTdkYTQ2Yjc2YWEwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhsb3BlekBpZ2FsaWEuY29tPgpEYXRlOiBX ZWQsIDI1IEF1ZyAyMDEwIDIyOjQ0OjU3ICswOTAwClN1YmplY3Q6IFtQQVRDSF0gMjAxMC0wOC0y NSAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CgogICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgoKICAgICAgICBbR1RLXSBDb2RlR2VuZXJhdG9yR09iamVjdCBub3QgcGlj a2luZyB1cCBGRUFUVVJFX0RFRklORVMKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDQ2MDgKCiAgICAgICAgTW92ZSBGRUFUVVJFX0RFRklORVMgZGVjbGFy YXRpb24gaGVyZSwgc2luY2UgaXQncyB1c2VkIGJ5IHRoZQogICAgICAgIGJpbmRpbmdzIGNvZGUg Z2VuZXJhdG9yLiBBbHNvLCBmaXggdHlwbyBpbiB0aGUgdmFyaWFibGUgaG9sZGluZwogICAgICAg IHRoZSBkZWZpbmVzLgoKICAgICAgICAqIEdOVW1ha2VmaWxlLmFtOgoKV2ViQ29yZToKCjIwMTAt MDgtMjUgIFhhbiBMb3BleiAgPHhsb3BlekBpZ2FsaWEuY29tPgoKICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgW0dUS10gQ29kZUdlbmVyYXRvckdPYmplY3Qgbm90 IHBpY2tpbmcgdXAgRkVBVFVSRV9ERUZJTkVTCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTQ0NjA4CgogICAgICAgIE1vdmUgRkVBVFVSRV9ERUZJTkVTIGRl Y2xhcmF0aW9uIHRvIHRoZSB0b3BsZXZlbCBHTlVtYWtlZmlsZS5hbSwKICAgICAgICBzaW5jZSBp dCdzIHVzZWQgdGhlcmUgbm93IHRvby4KCiAgICAgICAgKiBHTlVtYWtlZmlsZS5hbToKLS0tCiBD aGFuZ2VMb2cgICAgICAgICAgICAgIHwgICAxMyArKysrKysrKysrKysrCiBHTlVtYWtlZmlsZS5h bSAgICAgICAgIHwgICAgMyArKy0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgfCAgIDEyICsrKysr KysrKysrKwogV2ViQ29yZS9HTlVtYWtlZmlsZS5hbSB8ICAgIDEgLQogNCBmaWxlcyBjaGFuZ2Vk LCAyNyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL0NoYW5nZUxv ZyBiL0NoYW5nZUxvZwppbmRleCA1ZjMzNmZmLi5mYzhkMDEyIDEwMDY0NAotLS0gYS9DaGFuZ2VM b2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDgtMjUgIFhhbiBMb3Bl eiAgPHhsb3BlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFtHVEtdIENvZGVHZW5lcmF0b3JHT2JqZWN0IG5vdCBwaWNraW5nIHVw IEZFQVRVUkVfREVGSU5FUworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDQ2MDgKKworICAgICAgICBNb3ZlIEZFQVRVUkVfREVGSU5FUyBkZWNsYXJhdGlv biBoZXJlLCBzaW5jZSBpdCdzIHVzZWQgYnkgdGhlCisgICAgICAgIGJpbmRpbmdzIGNvZGUgZ2Vu ZXJhdG9yLiBBbHNvLCBmaXggdHlwbyBpbiB0aGUgdmFyaWFibGUgaG9sZGluZworICAgICAgICB0 aGUgZGVmaW5lcy4KKworICAgICAgICAqIEdOVW1ha2VmaWxlLmFtOgorCiAyMDEwLTA4LTI0ICBY YW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBCdWlsZCBmaXgsIHN0cmlr ZSAyLgpkaWZmIC0tZ2l0IGEvR05VbWFrZWZpbGUuYW0gYi9HTlVtYWtlZmlsZS5hbQppbmRleCA2 NDk2YzBjLi4xY2EzY2RmIDEwMDY0NAotLS0gYS9HTlVtYWtlZmlsZS5hbQorKysgYi9HTlVtYWtl ZmlsZS5hbQpAQCAtODE4LDkgKzgxOCwxMCBAQCAkKHRvcF9idWlsZGRpcikvRGVyaXZlZFNvdXJj ZXMvd2Via2l0L1dlYktpdERPTUV2ZW50VGFyZ2V0UHJpdmF0ZS5oOiAkKFdlYkNvcmUpLwogCSQo QU1fVl9HRU4pY3AgLWYgJDwgJEAKIAogIyBGaWx0ZXIgb3V0IFNWRyBmb3Igbm93CitGRUFUVVJF X0RFRklORVMgOj0KIGdkb21fZmVhdHVyZV9kZWZpbmVzIDo9ICQoZmlsdGVyLW91dCBFTkFCTEUt U1ZHJSwgJChGRUFUVVJFX0RFRklORVMpKQogRGVyaXZlZFNvdXJjZXMvd2Via2l0L1dlYktpdERP TSUuY3BwIERlcml2ZWRTb3VyY2VzL3dlYmtpdC9XZWJLaXRET00lLmggRGVyaXZlZFNvdXJjZXMv d2Via2l0L1dlYktpdERPTSVQcml2YXRlLmg6OiAlLmlkbCAkKFNDUklQVFNfQklORElOR1MpICQo V2ViQ29yZSkvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbQotCSQoQU1f Vl9HRU4pJChQRVJMKSAtSSQoV2ViQ29yZSkvYmluZGluZ3Mvc2NyaXB0cyAkKFdlYkNvcmUpL2Jp bmRpbmdzL3NjcmlwdHMvZ2VuZXJhdGUtYmluZGluZ3MucGwgLS1pbmNsdWRlICQoV2ViQ29yZSkv ZG9tIC0taW5jbHVkZSAkKFdlYkNvcmUpL2h0bWwgLS1pbmNsdWRlICQoV2ViQ29yZSkvY3NzIC0t aW5jbHVkZSAkKFdlYkNvcmUpL3BhZ2UgLS1pbmNsdWRlICQoV2ViQ29yZSkveG1sIC0taW5jbHVk ZSAkKFdlYkNvcmUpL3N2ZyAtLW91dHB1dERpciAiJChHRU5TT1VSQ0VTX1dFQktJVCkiIC0tZGVm aW5lcyAiTEFOR1VBR0VfR09CSkVDVD0xICQoZ2RvbV9mZWF0dXJlc19kZWZpbmVzKSIgLS1nZW5l cmF0b3IgR09iamVjdCAkPAorCSQoQU1fVl9HRU4pJChQRVJMKSAtSSQoV2ViQ29yZSkvYmluZGlu Z3Mvc2NyaXB0cyAkKFdlYkNvcmUpL2JpbmRpbmdzL3NjcmlwdHMvZ2VuZXJhdGUtYmluZGluZ3Mu cGwgLS1pbmNsdWRlICQoV2ViQ29yZSkvZG9tIC0taW5jbHVkZSAkKFdlYkNvcmUpL2h0bWwgLS1p bmNsdWRlICQoV2ViQ29yZSkvY3NzIC0taW5jbHVkZSAkKFdlYkNvcmUpL3BhZ2UgLS1pbmNsdWRl ICQoV2ViQ29yZSkveG1sIC0taW5jbHVkZSAkKFdlYkNvcmUpL3N2ZyAtLW91dHB1dERpciAiJChH RU5TT1VSQ0VTX1dFQktJVCkiIC0tZGVmaW5lcyAiTEFOR1VBR0VfR09CSkVDVD0xICQoZ2RvbV9m ZWF0dXJlX2RlZmluZXMpIiAtLWdlbmVyYXRvciBHT2JqZWN0ICQ8CiAKIHdlYmtpdGd0a19jcHBm bGFncyArPSBcCiAJLURCVUlMRElOR19XRUJLSVQgXApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFu Z2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2YWQ1Y2I4Li43OGM4ZDYzIDEwMDY0NAot LS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMiw2ICsy LDE4IEBACiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCiAKKyAgICAgICAg W0dUS10gQ29kZUdlbmVyYXRvckdPYmplY3Qgbm90IHBpY2tpbmcgdXAgRkVBVFVSRV9ERUZJTkVT CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDYwOAor CisgICAgICAgIE1vdmUgRkVBVFVSRV9ERUZJTkVTIGRlY2xhcmF0aW9uIHRvIHRoZSB0b3BsZXZl bCBHTlVtYWtlZmlsZS5hbSwKKyAgICAgICAgc2luY2UgaXQncyB1c2VkIHRoZXJlIG5vdyB0b28u CisKKyAgICAgICAgKiBHTlVtYWtlZmlsZS5hbToKKworMjAxMC0wOC0yNSAgWGFuIExvcGV6ICA8 eGxvcGV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKICAgICAgICAgW0dUS10gUmV3b3JrIGV2ZW50IGRlZmluaXRpb24gaW4gdGhlIERPTSBiaW5k aW5ncwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDQ1 OTcKIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9HTlVtYWtlZmlsZS5hbSBiL1dlYkNvcmUvR05VbWFr ZWZpbGUuYW0KaW5kZXggYzNkMjMwYS4uOGYzYjdjYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9HTlVt YWtlZmlsZS5hbQorKysgYi9XZWJDb3JlL0dOVW1ha2VmaWxlLmFtCkBAIC0xLDQgKzEsMyBAQAot RkVBVFVSRV9ERUZJTkVTIDo9CiBTVkdfRkVBVFVSRVMgOj0KIEhUTUxfRkVBVFVSRVMgOj0KIAot LSAKMS43LjIuMQoK