44598 2010-08-25 03:39:03 -0700 DOM Selection: collapseToStart() and collapseToEnd() should throw INVALID_STATE_ERR if there's no selection 2010-09-01 03:23:40 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED HTML5 P2 Normal --- 1 kling webkit-unassigned ap oldest_to_newest 269140 0 kling 2010-08-25 03:39:03 -0700 Selection.collapseToStart() and Selection.collapseToEnd() should throw INVALID_STATE_ERR if no selection is made. This would cause us to pass the following test on IE Test Center: http://samples.msdn.microsoft.com/ietestcenter/html5/selection/emptyselection_invalidStateErr.htm Spec links: http://www.whatwg.org/specs/web-apps/current-work/#dom-selection-collapsetostart http://www.whatwg.org/specs/web-apps/current-work/#dom-selection-collapsetoend 269142 1 65396 kling 2010-08-25 03:42:31 -0700 Created attachment 65396 Proposed patch 269305 2 ap 2010-08-25 09:57:03 -0700 Do these raise an exception in Firefox? Raising exceptions where we didn't use to can be a significant compatibility issue, because if any page depended on the old behavior, it often stops working completely. 269308 3 kling 2010-08-25 10:03:02 -0700 (In reply to comment #2) > Do these raise an exception in Firefox? No, only IE9 implements this behavior so far AFAIK. 272720 4 65396 kling 2010-09-01 03:23:30 -0700 Comment on attachment 65396 Proposed patch Clearing flags on attachment: 65396 Committed r66590: <http://trac.webkit.org/changeset/66590> 272721 5 kling 2010-09-01 03:23:40 -0700 All reviewed patches have been landed. Closing bug. 65396 2010-08-25 03:42:31 -0700 2010-09-01 03:23:29 -0700 Proposed patch bug-44598.diff text/plain 6742 kling ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiZWRjZGU4Li5iNzM1ZjcyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDgt MjUgIEFuZHJlYXMgS2xpbmcgIDxhbmRyZWFzLmtsaW5nQG5va2lhLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBET00gU2VsZWN0aW9uOiBjb2xs YXBzZVRvU3RhcnQoKSBhbmQgY29sbGFwc2VUb0VuZCgpIHNob3VsZCB0aHJvdyBJTlZBTElEX1NU QVRFX0VSUiBpZiB0aGVyZSdzIG5vIHNlbGVjdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDQ1OTgKKworICAgICAgICBTcGVjIGxpbmtzOgorICAg ICAgICBodHRwOi8vd3d3LndoYXR3Zy5vcmcvc3BlY3Mvd2ViLWFwcHMvY3VycmVudC13b3JrLyNk b20tc2VsZWN0aW9uLWNvbGxhcHNldG9zdGFydAorICAgICAgICBodHRwOi8vd3d3LndoYXR3Zy5v cmcvc3BlY3Mvd2ViLWFwcHMvY3VycmVudC13b3JrLyNkb20tc2VsZWN0aW9uLWNvbGxhcHNldG9l bmQKKworICAgICAgICAqIGZhc3QvZG9tL1NlbGVjdGlvbi9jb2xsYXBzZVRvWC1lbXB0eS1zZWxl Y3Rpb24tZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvbS9TZWxlY3Rpb24v Y29sbGFwc2VUb1gtZW1wdHktc2VsZWN0aW9uLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3Qv ZG9tL1NlbGVjdGlvbi9zY3JpcHQtdGVzdHMvY29sbGFwc2VUb1gtZW1wdHktc2VsZWN0aW9uLmpz OiBBZGRlZC4KKwogMjAxMC0wOC0yNSAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgVW5yZXZpZXdlZCwgc2tpcCBsaXN0IHVwZGF0ZS4KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2Zhc3QvZG9tL1NlbGVjdGlvbi9jb2xsYXBzZVRvWC1lbXB0eS1zZWxlY3Rpb24t ZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vU2VsZWN0aW9uL2NvbGxhcHNlVG9Y LWVtcHR5LXNlbGVjdGlvbi1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMC4uMWE3N2Y5MwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9t L1NlbGVjdGlvbi9jb2xsYXBzZVRvWC1lbXB0eS1zZWxlY3Rpb24tZXhwZWN0ZWQudHh0CkBAIC0w LDAgKzEsMTMgQEAKK1Rlc3QgdGhhdCBjb2xsYXBzZVRvU3RhcnQoKSBhbmQgY29sbGFwc2VUb0Vu ZCgpIHRocm93IElOVkFMSURfU1RBVEVfRVJSIGlmIG5vIHNlbGVjdGlvbiBpcyBtYWRlLgorCitP biBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xs b3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBzZWwuY29sbGFwc2VUb1N0YXJ0KCkg dGhyZXcgZXhjZXB0aW9uIEVycm9yOiBJTlZBTElEX1NUQVRFX0VSUjogRE9NIEV4Y2VwdGlvbiAx MS4KK1BBU1Mgc2VsLmNvbGxhcHNlVG9FbmQoKSB0aHJldyBleGNlcHRpb24gRXJyb3I6IElOVkFM SURfU1RBVEVfRVJSOiBET00gRXhjZXB0aW9uIDExLgorUEFTUyBzZWwuY29sbGFwc2VUb1N0YXJ0 KCkgaXMgdW5kZWZpbmVkCitQQVNTIHNlbC5jb2xsYXBzZVRvRW5kKCkgaXMgdW5kZWZpbmVkCitQ QVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vU2VsZWN0aW9uL2NvbGxhcHNlVG9YLWVtcHR5LXNl bGVjdGlvbi5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vU2VsZWN0aW9uL2NvbGxhcHNlVG9Y LWVtcHR5LXNlbGVjdGlvbi5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAu LjU0NjNmZmYKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9TZWxlY3Rp b24vY29sbGFwc2VUb1gtZW1wdHktc2VsZWN0aW9uLmh0bWwKQEAgLTAsMCArMSwxMyBAQAorPCFE T0NUWVBFIEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4iPgorPGh0bWw+Cis8aGVh ZD4KKzxsaW5rIHJlbD0ic3R5bGVzaGVldCIgaHJlZj0iLi4vLi4vanMvcmVzb3VyY2VzL2pzLXRl c3Qtc3R5bGUuY3NzIj4KKzxzY3JpcHQgc3JjPSIuLi8uLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1w cmUuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8cCBpZD0iZGVzY3JpcHRpb24iPjwv cD4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorPHNjcmlwdCBzcmM9InNjcmlwdC10ZXN0cy9j b2xsYXBzZVRvWC1lbXB0eS1zZWxlY3Rpb24uanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4u Ly4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9o dG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vU2VsZWN0aW9uL3NjcmlwdC10 ZXN0cy9jb2xsYXBzZVRvWC1lbXB0eS1zZWxlY3Rpb24uanMgYi9MYXlvdXRUZXN0cy9mYXN0L2Rv bS9TZWxlY3Rpb24vc2NyaXB0LXRlc3RzL2NvbGxhcHNlVG9YLWVtcHR5LXNlbGVjdGlvbi5qcwpu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5jMWZkNzNjCi0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vU2VsZWN0aW9uL3NjcmlwdC10ZXN0cy9jb2xsYXBz ZVRvWC1lbXB0eS1zZWxlY3Rpb24uanMKQEAgLTAsMCArMSwxNyBAQAorZGVzY3JpcHRpb24oIlRl c3QgdGhhdCBjb2xsYXBzZVRvU3RhcnQoKSBhbmQgY29sbGFwc2VUb0VuZCgpIHRocm93IElOVkFM SURfU1RBVEVfRVJSIGlmIG5vIHNlbGVjdGlvbiBpcyBtYWRlLiIpOworCit2YXIgc2VsID0gd2lu ZG93LmdldFNlbGVjdGlvbigpOwordmFyIHRleHROb2RlID0gZG9jdW1lbnQuY3JlYXRlVGV4dE5v ZGUoImFiY2RlZiIpOworZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZCh0ZXh0Tm9kZSk7CisKK3No b3VsZFRocm93KCJzZWwuY29sbGFwc2VUb1N0YXJ0KCkiLCAiJ0Vycm9yOiBJTlZBTElEX1NUQVRF X0VSUjogRE9NIEV4Y2VwdGlvbiAxMSciKTsKK3Nob3VsZFRocm93KCJzZWwuY29sbGFwc2VUb0Vu ZCgpIiwgIidFcnJvcjogSU5WQUxJRF9TVEFURV9FUlI6IERPTSBFeGNlcHRpb24gMTEnIik7CisK K3NlbC5zZWxlY3RBbGxDaGlsZHJlbih0ZXh0Tm9kZSk7CisKK3Nob3VsZEJlKCJzZWwuY29sbGFw c2VUb1N0YXJ0KCkiLCAidW5kZWZpbmVkIik7CitzaG91bGRCZSgic2VsLmNvbGxhcHNlVG9FbmQo KSIsICJ1bmRlZmluZWQiKTsKKworZG9jdW1lbnQuYm9keS5yZW1vdmVDaGlsZCh0ZXh0Tm9kZSk7 CisKK3ZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9D aGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwZjE1NmY0Li43ZDI3ZTliIDEwMDY0 NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDIyIEBACisyMDEwLTA4LTI1ICBBbmRyZWFzIEtsaW5nICA8YW5kcmVhcy5rbGluZ0Bub2tp YS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg RE9NIFNlbGVjdGlvbjogY29sbGFwc2VUb1N0YXJ0KCkgYW5kIGNvbGxhcHNlVG9FbmQoKSBzaG91 bGQgdGhyb3cgSU5WQUxJRF9TVEFURV9FUlIgaWYgdGhlcmUncyBubyBzZWxlY3Rpb24KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0NTk4CisKKyAgICAg ICAgU3BlYyBsaW5rczoKKyAgICAgICAgaHR0cDovL3d3dy53aGF0d2cub3JnL3NwZWNzL3dlYi1h cHBzL2N1cnJlbnQtd29yay8jZG9tLXNlbGVjdGlvbi1jb2xsYXBzZXRvc3RhcnQKKyAgICAgICAg aHR0cDovL3d3dy53aGF0d2cub3JnL3NwZWNzL3dlYi1hcHBzL2N1cnJlbnQtd29yay8jZG9tLXNl bGVjdGlvbi1jb2xsYXBzZXRvZW5kCisKKyAgICAgICAgVGVzdDogZmFzdC9kb20vU2VsZWN0aW9u L2NvbGxhcHNlVG9YLWVtcHR5LXNlbGVjdGlvbi5odG1sCisKKyAgICAgICAgKiBwYWdlL0RPTVNl bGVjdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpET01TZWxlY3Rpb246OmNvbGxhcHNlVG9F bmQpOgorICAgICAgICAoV2ViQ29yZTo6RE9NU2VsZWN0aW9uOjpjb2xsYXBzZVRvU3RhcnQpOgor ICAgICAgICAqIHBhZ2UvRE9NU2VsZWN0aW9uLmg6CisgICAgICAgICogcGFnZS9ET01TZWxlY3Rp b24uaWRsOgorCiAyMDEwLTA4LTI1ICBHYWJvciBMb2tpICA8bG9raUB3ZWJraXQub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEdhdmluIEJhcnJhY2xvdWdoLgpkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9wYWdlL0RPTVNlbGVjdGlvbi5jcHAgYi9XZWJDb3JlL3BhZ2UvRE9NU2VsZWN0aW9uLmNwcApp bmRleCAxMDZkZDEzLi42YzI1MTAzIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BhZ2UvRE9NU2VsZWN0 aW9uLmNwcAorKysgYi9XZWJDb3JlL3BhZ2UvRE9NU2VsZWN0aW9uLmNwcApAQCAtMjE0LDIxICsy MTQsMzMgQEAgdm9pZCBET01TZWxlY3Rpb246OmNvbGxhcHNlKE5vZGUqIG5vZGUsIGludCBvZmZz ZXQsIEV4Y2VwdGlvbkNvZGUmIGVjKQogICAgIG1fZnJhbWUtPnNlbGVjdGlvbigpLT5tb3ZlVG8o VmlzaWJsZVBvc2l0aW9uKG5vZGUsIG9mZnNldCwgRE9XTlNUUkVBTSkpOwogfQogCi12b2lkIERP TVNlbGVjdGlvbjo6Y29sbGFwc2VUb0VuZCgpCit2b2lkIERPTVNlbGVjdGlvbjo6Y29sbGFwc2VU b0VuZChFeGNlcHRpb25Db2RlJiBlYykKIHsKICAgICBpZiAoIW1fZnJhbWUpCiAgICAgICAgIHJl dHVybjsKIAogICAgIGNvbnN0IFZpc2libGVTZWxlY3Rpb24mIHNlbGVjdGlvbiA9IG1fZnJhbWUt PnNlbGVjdGlvbigpLT5zZWxlY3Rpb24oKTsKKworICAgIGlmIChzZWxlY3Rpb24uaXNOb25lKCkp IHsKKyAgICAgICAgZWMgPSBJTlZBTElEX1NUQVRFX0VSUjsKKyAgICAgICAgcmV0dXJuOworICAg IH0KKwogICAgIG1fZnJhbWUtPnNlbGVjdGlvbigpLT5tb3ZlVG8oVmlzaWJsZVBvc2l0aW9uKHNl bGVjdGlvbi5lbmQoKSwgRE9XTlNUUkVBTSkpOwogfQogCi12b2lkIERPTVNlbGVjdGlvbjo6Y29s bGFwc2VUb1N0YXJ0KCkKK3ZvaWQgRE9NU2VsZWN0aW9uOjpjb2xsYXBzZVRvU3RhcnQoRXhjZXB0 aW9uQ29kZSYgZWMpCiB7CiAgICAgaWYgKCFtX2ZyYW1lKQogICAgICAgICByZXR1cm47CiAKICAg ICBjb25zdCBWaXNpYmxlU2VsZWN0aW9uJiBzZWxlY3Rpb24gPSBtX2ZyYW1lLT5zZWxlY3Rpb24o KS0+c2VsZWN0aW9uKCk7CisKKyAgICBpZiAoc2VsZWN0aW9uLmlzTm9uZSgpKSB7CisgICAgICAg IGVjID0gSU5WQUxJRF9TVEFURV9FUlI7CisgICAgICAgIHJldHVybjsKKyAgICB9CisKICAgICBt X2ZyYW1lLT5zZWxlY3Rpb24oKS0+bW92ZVRvKFZpc2libGVQb3NpdGlvbihzZWxlY3Rpb24uc3Rh cnQoKSwgRE9XTlNUUkVBTSkpOwogfQogCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BhZ2UvRE9NU2Vs ZWN0aW9uLmggYi9XZWJDb3JlL3BhZ2UvRE9NU2VsZWN0aW9uLmgKaW5kZXggYjA0MjFjNy4uYjVm ZDE5NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL0RPTVNlbGVjdGlvbi5oCisrKyBiL1dlYkNv cmUvcGFnZS9ET01TZWxlY3Rpb24uaApAQCAtNzQsOCArNzQsOCBAQCBuYW1lc3BhY2UgV2ViQ29y ZSB7CiAgICAgICAgIGJvb2wgaXNDb2xsYXBzZWQoKSBjb25zdDsKICAgICAgICAgaW50IHJhbmdl Q291bnQoKSBjb25zdDsKICAgICAgICAgdm9pZCBjb2xsYXBzZShOb2RlKiwgaW50IG9mZnNldCwg RXhjZXB0aW9uQ29kZSYpOwotICAgICAgICB2b2lkIGNvbGxhcHNlVG9FbmQoKTsKLSAgICAgICAg dm9pZCBjb2xsYXBzZVRvU3RhcnQoKTsKKyAgICAgICAgdm9pZCBjb2xsYXBzZVRvRW5kKEV4Y2Vw dGlvbkNvZGUmKTsKKyAgICAgICAgdm9pZCBjb2xsYXBzZVRvU3RhcnQoRXhjZXB0aW9uQ29kZSYp OwogICAgICAgICB2b2lkIGV4dGVuZChOb2RlKiwgaW50IG9mZnNldCwgRXhjZXB0aW9uQ29kZSYp OwogICAgICAgICBQYXNzUmVmUHRyPFJhbmdlPiBnZXRSYW5nZUF0KGludCwgRXhjZXB0aW9uQ29k ZSYpOwogICAgICAgICB2b2lkIHJlbW92ZUFsbFJhbmdlcygpOwpkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9wYWdlL0RPTVNlbGVjdGlvbi5pZGwgYi9XZWJDb3JlL3BhZ2UvRE9NU2VsZWN0aW9uLmlkbApp bmRleCA0ZDBjOTQyLi5lZTgyODIzIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BhZ2UvRE9NU2VsZWN0 aW9uLmlkbAorKysgYi9XZWJDb3JlL3BhZ2UvRE9NU2VsZWN0aW9uLmlkbApAQCAtNDIsOCArNDIs MTAgQEAgbW9kdWxlIHdpbmRvdyB7CiAKICAgICAgICAgdm9pZCBjb2xsYXBzZShpbiBOb2RlIG5v ZGUsIGluIGxvbmcgaW5kZXgpCiAgICAgICAgICAgICByYWlzZXMoRE9NRXhjZXB0aW9uKTsKLSAg ICAgICAgdm9pZCBjb2xsYXBzZVRvRW5kKCk7Ci0gICAgICAgIHZvaWQgY29sbGFwc2VUb1N0YXJ0 KCk7CisgICAgICAgIHZvaWQgY29sbGFwc2VUb0VuZCgpCisgICAgICAgICAgICByYWlzZXMoRE9N RXhjZXB0aW9uKTsKKyAgICAgICAgdm9pZCBjb2xsYXBzZVRvU3RhcnQoKQorICAgICAgICAgICAg cmFpc2VzKERPTUV4Y2VwdGlvbik7CiAKICAgICAgICAgdm9pZCBkZWxldGVGcm9tRG9jdW1lbnQo KTsKICAgICAgICAgYm9vbGVhbiBjb250YWluc05vZGUoaW4gTm9kZSBub2RlLCBpbiBib29sZWFu IGFsbG93UGFydGlhbCk7Cg==