44597 2010-08-25 02:47:51 -0700 [GTK] Rework event definition in the DOM bindings 2010-08-26 02:00:23 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 xan.lopez webkit-unassigned oldest_to_newest 269117 0 xan.lopez 2010-08-25 02:47:51 -0700 ATM we are relying in the EventListeners defined in some of the IDL files to define the matching event signals in the GObject classes. This does not really make sense, since any event can be dispatched to any class implementing EventTarget. Rework this to just define all events in our base classes instead. 269119 1 65390 xan.lopez 2010-08-25 02:49:28 -0700 Created attachment 65390 eventdom.diff 269120 2 xan.lopez 2010-08-25 02:51:20 -0700 For the future: this is not really complete or totally correct, since we should also be able to create ad-hoc events, dispatch them and connect to them through g_signal_connect. Right now this fails in that we don't create signals for the new events at runtime, so we wouldn't be able to be notified of the dispatch. One solution would be to have a generic "event" signal that has the actual name of the event in the detail, like: g_signal_connect(node, "event::funny-name", ...). 269393 3 65390 mrobinson 2010-08-25 11:31:54 -0700 Comment on attachment 65390 eventdom.diff WebCore/bindings/scripts/CodeGeneratorGObject.pm:612 + foreach my $attribute (@eventSignalNames) { I think this temporary variable should be called something like eventSignalName instead of attribute (copy and paste issue?). r=me with this change. 269778 4 65390 xan.lopez 2010-08-26 02:00:10 -0700 Comment on attachment 65390 eventdom.diff Landed with the name change in r66090. 269779 5 xan.lopez 2010-08-26 02:00:23 -0700 Closing. 65390 2010-08-25 02:49:28 -0700 2010-08-26 02:00:10 -0700 eventdom.diff eventdom.diff text/plain 5794 xan.lopez RnJvbSBiNjA3MDc5ZjY2NGEyMjY1M2I4MmMxMWZiY2U5MzA5NzRkMDlhODNiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhsb3BlekBpZ2FsaWEuY29tPgpEYXRlOiBX ZWQsIDI1IEF1ZyAyMDEwIDE4OjQ4OjM1ICswOTAwClN1YmplY3Q6IFtQQVRDSF0gMjAxMC0wOC0y NSAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CgogICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgoKICAgICAgICBbR1RLXSBSZXdvcmsgZXZlbnQgZGVmaW5pdGlvbiBpbiB0 aGUgRE9NIGJpbmRpbmdzCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTQ0NTk3CgogICAgICAgIERlZmluZSBET00gZXZlbnRzIGluIHRoZSBiYXNlIGNsYXNz ZXMgdGhhdCBpbXBsZW1lbnQgRXZlbnRUYXJnZXQsCiAgICAgICAgc2luY2UgdGhlb3JldGljYWxs eSB5b3UgY2FuIGRpc3BhdGNoIGFueSBldmVudCB0byBhbnkgb2YgdGhvc2UKICAgICAgICBjbGFz c2VzIHdoZXRoZXIgaXQgbWFrZXMgc2Vuc2Ugc2VtYW50aWNhbGx5IG9yIG5vdC4KCiAgICAgICAg QWxsIHRoZSBleGlzdGluZyBldmVudHMgaW4gV2ViS2l0IGFyZSBub3QgbGlzdGVkIGFueXdoZXJl IGluIHRoZQogICAgICAgIElETCBmaWxlcywgc28gd2UgbmVlZCB0byBoYXZlIHRoZSBsaXN0IGlu IHRoZSBnZW5lcmF0b3Igc2NyaXB0LgoKICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdl bmVyYXRvckdPYmplY3QucG06Ci0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHwgICAxNiArKysrKysKIFdlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9D b2RlR2VuZXJhdG9yR09iamVjdC5wbSB8ICAgNjEgKysrKysrKysrKysrKysrLS0tLS0tLQogMiBm aWxlcyBjaGFuZ2VkLCA1OCBpbnNlcnRpb25zKCspLCAxOSBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGEwZGI1ZWMu LjNjMmM0YjIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDgtMjUgIFhhbiBMb3BleiAgPHhsb3BlekBp Z2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFtHVEtdIFJld29yayBldmVudCBkZWZpbml0aW9uIGluIHRoZSBET00gYmluZGluZ3MKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0NTk3CisKKyAg ICAgICAgRGVmaW5lIERPTSBldmVudHMgaW4gdGhlIGJhc2UgY2xhc3NlcyB0aGF0IGltcGxlbWVu dCBFdmVudFRhcmdldCwKKyAgICAgICAgc2luY2UgdGhlb3JldGljYWxseSB5b3UgY2FuIGRpc3Bh dGNoIGFueSBldmVudCB0byBhbnkgb2YgdGhvc2UKKyAgICAgICAgY2xhc3NlcyB3aGV0aGVyIGl0 IG1ha2VzIHNlbnNlIHNlbWFudGljYWxseSBvciBub3QuCisKKyAgICAgICAgQWxsIHRoZSBleGlz dGluZyBldmVudHMgaW4gV2ViS2l0IGFyZSBub3QgbGlzdGVkIGFueXdoZXJlIGluIHRoZQorICAg ICAgICBJREwgZmlsZXMsIHNvIHdlIG5lZWQgdG8gaGF2ZSB0aGUgbGlzdCBpbiB0aGUgZ2VuZXJh dG9yIHNjcmlwdC4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdP YmplY3QucG06CisKIDIwMTAtMDgtMjQgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUv YmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbSBiL1dlYkNvcmUvYmluZGlu Z3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbQppbmRleCA1NzAwZmY3Li41OTc3YTVl IDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmpl Y3QucG0KKysrIGIvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0 LnBtCkBAIC00NzksMjMgKzQ3OSwxMSBAQCBzdWIgRXZlbnRTaWduYWxOYW1lIHsKIH0KIAogc3Vi IEdlbmVyYXRlRXZlbnRMaXN0ZW5lciB7Ci0gICAgbXkgJGF0dHJpYnV0ZSA9IHNoaWZ0OworICAg IG15ICRuYW1lID0gc2hpZnQ7CiAgICAgbXkgJG9iamVjdCA9IHNoaWZ0OwogICAgIG15ICRpbnRl cmZhY2VOYW1lID0gc2hpZnQ7CiAKLSAgICAjIFRoaXMgbWFya3MgZXZlbnQgbGlzdGVuZXJzIGlu IHNvbWUgc3ViY2xhc3NlcyBvZiBFbGVtZW50LiBXZQotICAgICMgY2Fubm90IGFkZCB0aGVtLCBv dGhlcndpc2Ugd2UnbGwgZ2V0IHJ1bnRpbWUgZXJyb3JzIGJlY2F1c2Ugb2YKLSAgICAjIGR1cGxp Y2F0ZWQgc2lnbmFsIGRlZmluaXRpb25zIGJldHdlZW4gYSBjbGFzcyBhbmQgc29tZSBhbmNlc3Rv ci4KLQotICAgICMgRklYTUU6IGl0IHdvdWxkIGJlIHZlcnkgZ29vZCB0byBiZSBhIGxvdCBtb3Jl IHByZWNpc2UgaW4gaG93IHdlCi0gICAgIyBkbyB0aGlzLi4uCi0gICAgaWYgKCRhdHRyaWJ1dGUt PnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IldpbmRvd0V2ZW50TGlzdGVuZXIifSkg ewotICAgICAgICByZXR1cm47Ci0gICAgfQotCi0gICAgbXkgJG5hbWUgPSAkYXR0cmlidXRlLT5z aWduYXR1cmUtPm5hbWU7Ci0gICAgbXkgJGRvbVNpZ25hbE5hbWUgPSBzdWJzdHIoJG5hbWUsIDIp OwotICAgIG15ICRnb2JqZWN0U2lnbmFsTmFtZSA9IEV2ZW50U2lnbmFsTmFtZSgkZG9tU2lnbmFs TmFtZSk7CisgICAgbXkgJGdvYmplY3RTaWduYWxOYW1lID0gRXZlbnRTaWduYWxOYW1lKCRuYW1l KTsKIAogICAgIG15ICR0eHRJbnN0YWxsU2lnbmFsID0gPDwgIkVPRiI7CiAgICAgZ19zaWduYWxf bmV3KCIke2dvYmplY3RTaWduYWxOYW1lfSIsCkBAIC01MTAsMTEgKzQ5OCwxMSBAQCBzdWIgR2Vu ZXJhdGVFdmVudExpc3RlbmVyIHsKIEVPRgogICAgIHB1c2goQHR4dEluc3RhbGxTaWduYWxzLCAk dHh0SW5zdGFsbFNpZ25hbCk7CiAKLSAgICBteSAke2xpc3RlbmVyTmFtZX0gPSAkZG9tU2lnbmFs TmFtZSAuICJMaXN0ZW5lciI7CisgICAgbXkgJHtsaXN0ZW5lck5hbWV9ID0gJG5hbWUgLiAiTGlz dGVuZXIiOwogCiAgICAgbXkgJHR4dEluc3RhbGxFdmVudExpc3RlbmVyID0gPDwgIkVPRiI7CiAg ICAgUmVmUHRyPFdlYkNvcmU6OkdPYmplY3RFdmVudExpc3RlbmVyPiAke2xpc3RlbmVyTmFtZX0g PSBXZWJDb3JlOjpHT2JqZWN0RXZlbnRMaXN0ZW5lcjo6Y3JlYXRlKHJlaW50ZXJwcmV0X2Nhc3Q8 R09iamVjdCo+KG9iamVjdCksICIke2dvYmplY3RTaWduYWxOYW1lfSIpOwotICAgIGNvcmVPYmpl Y3QtPmFkZEV2ZW50TGlzdGVuZXIoIiR7ZG9tU2lnbmFsTmFtZX0iLCAke2xpc3RlbmVyTmFtZX0s IGZhbHNlKTsKKyAgICBjb3JlT2JqZWN0LT5hZGRFdmVudExpc3RlbmVyKCIke25hbWV9IiwgJHts aXN0ZW5lck5hbWV9LCBmYWxzZSk7CiBFT0YKICAgICBwdXNoKEB0eHRJbnN0YWxsRXZlbnRMaXN0 ZW5lcnMsICR0eHRJbnN0YWxsRXZlbnRMaXN0ZW5lcik7CiAKQEAgLTUyMiw2ICs1MTAsMzQgQEAg RU9GCiAgICAgJGltcGxJbmNsdWRlc3siR09iamVjdEV2ZW50TGlzdGVuZXIuaCJ9ID0gMTsKIH0K IAorbXkgQGV2ZW50U2lnbmFsTmFtZXMgPSAoCisgICAgIyBVc2VyIEludGVyZmFjZSBFdmVudCB0 eXBlcworICAgICJmb2N1cyIsICJibHVyIiwKKyAgICAjIEJhc2ljIEV2ZW50IHR5cGVzCisgICAg ImxvYWQiLCAidW5sb2FkIiwgImFib3J0IiwgImVycm9yIiwgInNlbGVjdCIsICJjaGFuZ2UiLCAi c3VibWl0IiwgInJlc2V0IiwKKyAgICAicmVzaXplIiwgInNjcm9sbCIsCisgICAgIyBNb3VzZSBF dmVudCB0eXBlcworICAgICJjbGljayIsICJkYmxjbGljayIsICJtb3VzZWRvd24iLCAibW91c2V1 cCIsCisgICAgIm1vdXNlbW92ZSIsICJtb3VzZW92ZXIiLCAibW91c2VvdXQiLAorICAgICMgTW91 c2UgV2hlZWwgRXZlbnQgdHlwZXMKKyAgICAibW91c2V3aGVlbCIsCisgICAgIyBLZXlib2FyZCBF dmVudCB0eXBlcworICAgICJrZXlkb3duIiwgImtleXByZXNzIiwgImtleXVwIiwKKyAgICAjIC0t IEV2ZW50cyBub3QgaW4gdGhlIHNwZWMgYnV0IGRlZmluZWQgaW4gV2ViS2l0CisgICAgIyBNZWRp YSBFdmVudCB0eXBlcywKKyAgICAibG9hZHN0YXJ0IiwgInByb2dyZXNzIiwgInN1c3BlbmQiLCAi ZW1wdGllZCIsICJzdGFsbGVkIiwgInBsYXkiLAorICAgICJsb2FkZWRtZXRhZGF0YSIsICJsb2Fk ZWRkYXRhIiwgIndhaXRpbmciLCAicGxheWluZyIsICJjYW5wbGF5IiwKKyAgICAiY2FucGxheXRo cm91Z2giLCAic2Vla2luZyIsICJzZWVrZWQiLCAidGltZXVwZGF0ZSIsICJlbmRlZCIsCisgICAg InJhdGVjaGFuZ2UiLCAiZHVyYXRpb25jaGFuZ2UiLCAidm9sdW1lY2hhbmdlIiwKKyAgICAjIERy YWcgYW5kIERyb3AgRXZlbnQgdHlwZXMKKyAgICAiZHJhZyIsICJkcmFnZW5kIiwgImRyYWdlbnRl ciIsICJkcmFnbGVhdmUiLCAiZHJhZ292ZXIiLCAiZHJhZ3N0YXJ0IiwgImRyb3AiLAorICAgICMg Q3V0IGFuZCBQYXN0ZSBFdmVudCB0eXBlcworICAgICJiZWZvcmVjdXQiLCAiY3V0IiwgImJlZm9y ZWNvcHkiLCAiY29weSIsICJiZWZvcmVwYXN0ZSIsICJwYXN0ZSIsCisgICAgIyBBbmltYXRpb25z CisgICAgIndlYmtpdGFuaW1hdGlvbmVuZCIsICJ3ZWJraXRhbmltYXRpb25zdGFydCIsICJ3ZWJr aXRhbmltYXRpb25pdGVyYXRpb24iLAorICAgICMgT3RoZXIKKyAgICAiY29udGV4dG1lbnUiLCAi aW5wdXQiLCAiaW52YWxpZCIsICJzZWFyY2giLCAic2VsZWN0c3RhcnQiKTsKKwogc3ViIEdlbmVy YXRlUHJvcGVydGllcyB7CiAgICAgbXkgKCRvYmplY3QsICRpbnRlcmZhY2VOYW1lLCAkZGF0YU5v ZGUpID0gQF87CiAKQEAgLTU4NCwxMyArNjAwLDIwIEBAIEVPRgogICAgIHB1c2goQHR4dFNldFBy b3BzLCAkdHh0U2V0UHJvcHMpOwogCiAgICAgZm9yZWFjaCBteSAkYXR0cmlidXRlIChAcmVhZGFi bGVQcm9wZXJ0aWVzKSB7Ci0gICAgICAgIGlmICgkYXR0cmlidXRlLT5zaWduYXR1cmUtPnR5cGUg ZXEgIkV2ZW50TGlzdGVuZXIiKSB7Ci0gICAgICAgICAgICBHZW5lcmF0ZUV2ZW50TGlzdGVuZXIo JGF0dHJpYnV0ZSwgJG9iamVjdCwgJGludGVyZmFjZU5hbWUpOwotICAgICAgICB9IGVsc2Ugewor ICAgICAgICBpZiAoJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT50eXBlIG5lICJFdmVudExpc3RlbmVy IikgewogICAgICAgICAgICAgR2VuZXJhdGVQcm9wZXJ0eSgkYXR0cmlidXRlLCAkaW50ZXJmYWNl TmFtZSwgXEB3cml0ZWFibGVQcm9wZXJ0aWVzKTsKICAgICAgICAgfQogICAgIH0KIAorICAgICMg V2UgbmVlZCB0byBkZWZpbmUgYWxsIHRoZSBldmVudHMgdGhlcmUgYXJlIGluIGFsbCBiYXNlIGNs YXNzZXMKKyAgICAjIHRoYXQgaW1wbGVtZW50IEV2ZW50VGFyZ2V0LiBGb3Igbm93IHdlIG9ubHkg Y2FyZSBhYm91dCB0aGVzZQorICAgICMgdHdvLgorICAgIGlmICgkaW50ZXJmYWNlTmFtZSBlcSAi Tm9kZSIgfHwgJGludGVyZmFjZU5hbWUgZXEgIkRPTVdpbmRvdyIpIHsKKyAgICAgICAgZm9yZWFj aCBteSAkYXR0cmlidXRlIChAZXZlbnRTaWduYWxOYW1lcykgeworICAgICAgICAgICAgR2VuZXJh dGVFdmVudExpc3RlbmVyKCRhdHRyaWJ1dGUsICRvYmplY3QsICRpbnRlcmZhY2VOYW1lKTsKKyAg ICAgICAgfQorICAgIH0KKwogICAgIHB1c2goQGNCb2R5UHJpdiwgIn07XG5cbiIpOwogCiAgICAg JHR4dEdldFByb3AgPSA8PCAiRU9GIjsKLS0gCjEuNy4yLjEKCg==