44595 2010-08-25 02:37:04 -0700 DOM Selection: collapse() and selectAllChildren() should throw WRONG_DOCUMENT_ERR if node belongs to other document 2010-09-08 13:40:21 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED LATER HTML5 P2 Normal --- 45104 1 kling webkit-unassigned abarth ap eric webkit.review.bot oldest_to_newest 269110 0 kling 2010-08-25 02:37:04 -0700 Selection.collapse() and Selection.selectAllChildren() should throw WRONG_DOCUMENT_ERR if the input node doesn't belong to the same document at the Selection. This would cause us to pass the following test on IE Test Center: http://samples.msdn.microsoft.com/ietestcenter/html5/selection/selection_wrongDocErr.htm Spec links: http://www.whatwg.org/specs/web-apps/current-work/#dom-selection-collapse http://www.whatwg.org/specs/web-apps/current-work/#dom-selection-selectallchildren 269113 1 65387 kling 2010-08-25 02:43:17 -0700 Created attachment 65387 Proposed patch 269307 2 ap 2010-08-25 09:58:00 -0700 Do these raise an exception in Firefox? Raising exceptions where we didn't use to can be a significant compatibility issue, because if any page depended on the old behavior, it often stops working completely. 269312 3 kling 2010-08-25 10:04:28 -0700 (In reply to comment #2) > Do these raise an exception in Firefox? No, only IE9 implements this behavior so far AFAIK. 269728 4 65387 tonikitoo 2010-08-25 23:05:43 -0700 Comment on attachment 65387 Proposed patch Gerally it also looks good to me. We need to find out the impact of such a change in existing web contents, witch is hard :-( 271174 5 65387 darin 2010-08-29 11:44:24 -0700 Comment on attachment 65387 Proposed patch > + const Document* selectionDocument = m_frame ? m_frame->document() : 0; > + const Document* nodeDocument = node ? node->document() : 0; The const here does no good. > + const Document* selectionDocument = m_frame ? m_frame->document() : 0; Same here. I’d like this even better if the regression test covered the null frame and null node cases. I can't tell if it does. r=me 273311 6 kling 2010-09-02 03:50:39 -0700 Committed r66655: <http://trac.webkit.org/changeset/66655> 273329 7 webkit.review.bot 2010-09-02 04:37:24 -0700 http://trac.webkit.org/changeset/66655 might have broken Leopard Intel Release (Tests) 273345 8 kling 2010-09-02 04:49:49 -0700 Reopening due to editing test breakage. 276029 9 ap 2010-09-08 13:34:50 -0700 What is the status of this bug? The patch been rolled out, correct? See also: https://bugzilla.mozilla.org/show_bug.cgi?id=418755. 276031 10 kling 2010-09-08 13:40:21 -0700 (In reply to comment #9) > What is the status of this bug? The patch been rolled out, correct? > > See also: https://bugzilla.mozilla.org/show_bug.cgi?id=418755. It was rolled out indeed (with r66661) Interesting link, I'll close this. We can revisit the issue at a later time. 65387 2010-08-25 02:43:17 -0700 2010-09-08 13:38:47 -0700 Proposed patch bug-44595.diff text/plain 5847 kling ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2YmI1ZGFhLi40NmI4Y2JjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDgt MjUgIEFuZHJlYXMgS2xpbmcgIDxhbmRyZWFzLmtsaW5nQG5va2lhLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBET00gU2VsZWN0aW9uOiBjb2xs YXBzZSgpIGFuZCBzZWxlY3RBbGxDaGlsZHJlbigpIHNob3VsZCB0aHJvdyBXUk9OR19ET0NVTUVO VF9FUlIgaWYgbm9kZSBiZWxvbmdzIHRvIG90aGVyIGRvY3VtZW50CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDU5NQorCisgICAgICAgIFNwZWMgbGlu a3M6CisgICAgICAgIGh0dHA6Ly93d3cud2hhdHdnLm9yZy9zcGVjcy93ZWItYXBwcy9jdXJyZW50 LXdvcmsvI2RvbS1zZWxlY3Rpb24tY29sbGFwc2UKKyAgICAgICAgaHR0cDovL3d3dy53aGF0d2cu b3JnL3NwZWNzL3dlYi1hcHBzL2N1cnJlbnQtd29yay8jZG9tLXNlbGVjdGlvbi1zZWxlY3RhbGxj aGlsZHJlbgorCisgICAgICAgICogZmFzdC9kb20vU2VsZWN0aW9uL3NjcmlwdC10ZXN0cy93cm9u Zy1kb2N1bWVudC1lcnIuanM6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZG9tL1NlbGVjdGlvbi93 cm9uZy1kb2N1bWVudC1lcnItZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Rv bS9TZWxlY3Rpb24vd3JvbmctZG9jdW1lbnQtZXJyLmh0bWw6IEFkZGVkLgorCiAyMDEwLTA4LTI0 ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2Vk LCB0ZXN0IGV4cGVjdGF0aW9uIHVwZGF0ZS4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qv ZG9tL1NlbGVjdGlvbi9zY3JpcHQtdGVzdHMvd3JvbmctZG9jdW1lbnQtZXJyLmpzIGIvTGF5b3V0 VGVzdHMvZmFzdC9kb20vU2VsZWN0aW9uL3NjcmlwdC10ZXN0cy93cm9uZy1kb2N1bWVudC1lcnIu anMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uNDJhMDkwNQotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL1NlbGVjdGlvbi9zY3JpcHQtdGVzdHMvd3Jv bmctZG9jdW1lbnQtZXJyLmpzCkBAIC0wLDAgKzEsMjMgQEAKK2Rlc2NyaXB0aW9uKCJUZXN0IHRo YXQgY29sbGFwc2UoKSBhbmQgc2VsZWN0QWxsQ2hpbGRyZW4oKSB0aHJvdyBXUk9OR19ET0NVTUVO VF9FUlIgaWYgdGhlIG5vZGUgaXMgaW4gYW5vdGhlciBkb2N1bWVudC4iKTsKKwordmFyIHNlbCA9 IHdpbmRvdy5nZXRTZWxlY3Rpb24oKTsKK3ZhciBpZnJhbWUgPSBkb2N1bWVudC5jcmVhdGVFbGVt ZW50KCJpZnJhbWUiKTsKK2RvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQoaWZyYW1lKTsKK3ZhciBp ZnJhbWVfZG9jID0gaWZyYW1lLmNvbnRlbnREb2N1bWVudDsKK3ZhciBkaXYgPSBpZnJhbWVfZG9j LmNyZWF0ZUVsZW1lbnQoJ2RpdicpOworaWZyYW1lX2RvYy5ib2R5LmFwcGVuZENoaWxkKGRpdik7 Cit2YXIgZXh0ZXJuYWxUZXh0Tm9kZSA9IGlmcmFtZV9kb2MuY3JlYXRlVGV4dE5vZGUoImFiY2Rl ZiIpOworZGl2LmFwcGVuZENoaWxkKGV4dGVybmFsVGV4dE5vZGUpOworCit2YXIgaW50ZXJuYWxU ZXh0Tm9kZSA9IGlmcmFtZV9kb2MuY3JlYXRlVGV4dE5vZGUoImFiY2RlZiIpOworZG9jdW1lbnQu Ym9keS5hcHBlbmRDaGlsZChpbnRlcm5hbFRleHROb2RlKTsKKworc2hvdWxkVGhyb3coInNlbC5j b2xsYXBzZShleHRlcm5hbFRleHROb2RlLCAwKSIsICInRXJyb3I6IFdST05HX0RPQ1VNRU5UX0VS UjogRE9NIEV4Y2VwdGlvbiA0JyIpOworc2hvdWxkVGhyb3coInNlbC5zZWxlY3RBbGxDaGlsZHJl bihleHRlcm5hbFRleHROb2RlKSIsICInRXJyb3I6IFdST05HX0RPQ1VNRU5UX0VSUjogRE9NIEV4 Y2VwdGlvbiA0JyIpOworc2hvdWxkQmUoInNlbC5jb2xsYXBzZShpbnRlcm5hbFRleHROb2RlLCAw KSIsICJ1bmRlZmluZWQiKTsKK3Nob3VsZEJlKCJzZWwuc2VsZWN0QWxsQ2hpbGRyZW4oaW50ZXJu YWxUZXh0Tm9kZSkiLCAidW5kZWZpbmVkIik7CisKK2RvY3VtZW50LmJvZHkucmVtb3ZlQ2hpbGQo aWZyYW1lKTsKK2RvY3VtZW50LmJvZHkucmVtb3ZlQ2hpbGQoaW50ZXJuYWxUZXh0Tm9kZSk7CisK K3ZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv ZmFzdC9kb20vU2VsZWN0aW9uL3dyb25nLWRvY3VtZW50LWVyci1leHBlY3RlZC50eHQgYi9MYXlv dXRUZXN0cy9mYXN0L2RvbS9TZWxlY3Rpb24vd3JvbmctZG9jdW1lbnQtZXJyLWV4cGVjdGVkLnR4 dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi43Nzg1MGQ4Ci0tLSAvZGV2L251 bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vU2VsZWN0aW9uL3dyb25nLWRvY3VtZW50LWVy ci1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxMyBAQAorVGVzdCB0aGF0IGNvbGxhcHNlKCkgYW5k IHNlbGVjdEFsbENoaWxkcmVuKCkgdGhyb3cgV1JPTkdfRE9DVU1FTlRfRVJSIGlmIHRoZSBub2Rl IGlzIGluIGFub3RoZXIgZG9jdW1lbnQuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNl cmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKwor CitQQVNTIHNlbC5jb2xsYXBzZShleHRlcm5hbFRleHROb2RlLCAwKSB0aHJldyBleGNlcHRpb24g RXJyb3I6IFdST05HX0RPQ1VNRU5UX0VSUjogRE9NIEV4Y2VwdGlvbiA0LgorUEFTUyBzZWwuc2Vs ZWN0QWxsQ2hpbGRyZW4oZXh0ZXJuYWxUZXh0Tm9kZSkgdGhyZXcgZXhjZXB0aW9uIEVycm9yOiBX Uk9OR19ET0NVTUVOVF9FUlI6IERPTSBFeGNlcHRpb24gNC4KK1BBU1Mgc2VsLmNvbGxhcHNlKGlu dGVybmFsVGV4dE5vZGUsIDApIGlzIHVuZGVmaW5lZAorUEFTUyBzZWwuc2VsZWN0QWxsQ2hpbGRy ZW4oaW50ZXJuYWxUZXh0Tm9kZSkgaXMgdW5kZWZpbmVkCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNl ZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFz dC9kb20vU2VsZWN0aW9uL3dyb25nLWRvY3VtZW50LWVyci5odG1sIGIvTGF5b3V0VGVzdHMvZmFz dC9kb20vU2VsZWN0aW9uL3dyb25nLWRvY3VtZW50LWVyci5odG1sCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAuLmJiZDZkNGQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2RvbS9TZWxlY3Rpb24vd3JvbmctZG9jdW1lbnQtZXJyLmh0bWwKQEAgLTAsMCArMSwx MyBAQAorPCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4iPgorPGh0 bWw+Cis8aGVhZD4KKzxsaW5rIHJlbD0ic3R5bGVzaGVldCIgaHJlZj0iLi4vLi4vanMvcmVzb3Vy Y2VzL2pzLXRlc3Qtc3R5bGUuY3NzIj4KKzxzY3JpcHQgc3JjPSIuLi8uLi9qcy9yZXNvdXJjZXMv anMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8cCBpZD0iZGVzY3Jp cHRpb24iPjwvcD4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorPHNjcmlwdCBzcmM9InNjcmlw dC10ZXN0cy93cm9uZy1kb2N1bWVudC1lcnIuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4u Ly4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9o dG1sPgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwpp bmRleCA4NmY2Nzc2Li40YjU5YTFiIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysg Yi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEwLTA4LTI1ICBBbmRyZWFz IEtsaW5nICA8YW5kcmVhcy5rbGluZ0Bub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRE9NIFNlbGVjdGlvbjogY29sbGFwc2UoKSBhbmQg c2VsZWN0QWxsQ2hpbGRyZW4oKSBzaG91bGQgdGhyb3cgV1JPTkdfRE9DVU1FTlRfRVJSIGlmIG5v ZGUgYmVsb25ncyB0byBvdGhlciBkb2N1bWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDQ1OTUKKworICAgICAgICBTcGVjIGxpbmtzOgorICAgICAg ICBodHRwOi8vd3d3LndoYXR3Zy5vcmcvc3BlY3Mvd2ViLWFwcHMvY3VycmVudC13b3JrLyNkb20t c2VsZWN0aW9uLWNvbGxhcHNlCisgICAgICAgIGh0dHA6Ly93d3cud2hhdHdnLm9yZy9zcGVjcy93 ZWItYXBwcy9jdXJyZW50LXdvcmsvI2RvbS1zZWxlY3Rpb24tc2VsZWN0YWxsY2hpbGRyZW4KKwor ICAgICAgICBUZXN0OiBmYXN0L2RvbS9TZWxlY3Rpb24vd3JvbmctZG9jdW1lbnQtZXJyLmh0bWwK KworICAgICAgICAqIHBhZ2UvRE9NU2VsZWN0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRP TVNlbGVjdGlvbjo6Y29sbGFwc2UpOgorICAgICAgICAoV2ViQ29yZTo6RE9NU2VsZWN0aW9uOjpz ZWxlY3RBbGxDaGlsZHJlbik6CisKIDIwMTAtMDgtMjQgIFhhbiBMb3BleiAgPHhsb3BlekBpZ2Fs aWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEd1c3Rhdm8gTm9yb25oYS4KZGlmZiAtLWdp dCBhL1dlYkNvcmUvcGFnZS9ET01TZWxlY3Rpb24uY3BwIGIvV2ViQ29yZS9wYWdlL0RPTVNlbGVj dGlvbi5jcHAKaW5kZXggMTA2ZGQxMy4uMDdjNmQzYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdl L0RPTVNlbGVjdGlvbi5jcHAKKysrIGIvV2ViQ29yZS9wYWdlL0RPTVNlbGVjdGlvbi5jcHAKQEAg LTIwMCwxNCArMjAwLDIyIEBAIGludCBET01TZWxlY3Rpb246OnJhbmdlQ291bnQoKSBjb25zdAog CiB2b2lkIERPTVNlbGVjdGlvbjo6Y29sbGFwc2UoTm9kZSogbm9kZSwgaW50IG9mZnNldCwgRXhj ZXB0aW9uQ29kZSYgZWMpCiB7Ci0gICAgaWYgKCFtX2ZyYW1lKQorICAgIGNvbnN0IERvY3VtZW50 KiBzZWxlY3Rpb25Eb2N1bWVudCA9IG1fZnJhbWUgPyBtX2ZyYW1lLT5kb2N1bWVudCgpIDogMDsK KyAgICBjb25zdCBEb2N1bWVudCogbm9kZURvY3VtZW50ID0gbm9kZSA/IG5vZGUtPmRvY3VtZW50 KCkgOiAwOworCisgICAgaWYgKHNlbGVjdGlvbkRvY3VtZW50ICE9IG5vZGVEb2N1bWVudCkgewor ICAgICAgICBlYyA9IFdST05HX0RPQ1VNRU5UX0VSUjsKICAgICAgICAgcmV0dXJuOworICAgIH0K IAogICAgIGlmIChvZmZzZXQgPCAwKSB7CiAgICAgICAgIGVjID0gSU5ERVhfU0laRV9FUlI7CiAg ICAgICAgIHJldHVybjsKICAgICB9CiAKKyAgICBpZiAoIW1fZnJhbWUpCisgICAgICAgIHJldHVy bjsKKwogICAgIGlmICghaXNWYWxpZEZvclBvc2l0aW9uKG5vZGUpKQogICAgICAgICByZXR1cm47 CiAKQEAgLTQ3Niw2ICs0ODQsMTMgQEAgdm9pZCBET01TZWxlY3Rpb246OnNlbGVjdEFsbENoaWxk cmVuKE5vZGUqIG4sIEV4Y2VwdGlvbkNvZGUmIGVjKQogICAgIGlmICghbikKICAgICAgICAgcmV0 dXJuOwogCisgICAgY29uc3QgRG9jdW1lbnQqIHNlbGVjdGlvbkRvY3VtZW50ID0gbV9mcmFtZSA/ IG1fZnJhbWUtPmRvY3VtZW50KCkgOiAwOworCisgICAgaWYgKHNlbGVjdGlvbkRvY3VtZW50ICE9 IG4tPmRvY3VtZW50KCkpIHsKKyAgICAgICAgZWMgPSBXUk9OR19ET0NVTUVOVF9FUlI7CisgICAg ICAgIHJldHVybjsKKyAgICB9CisKICAgICAvLyBUaGlzIGRvZXNuJ3QgKGFuZCBzaG91bGRuJ3Qp IHNlbGVjdCB0ZXh0IG5vZGUgY2hhcmFjdGVycy4KICAgICBzZXRCYXNlQW5kRXh0ZW50KG4sIDAs IG4sIG4tPmNoaWxkTm9kZUNvdW50KCksIGVjKTsKIH0K