44594 2010-08-25 01:57:07 -0700 [Qt] Add Visibility notification NPAPI for plugins 2010-08-27 16:15:16 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Other Other RESOLVED FIXED Qt P2 Normal --- 1 girish girish abarth ademar christian.webkit eric hausmann kenneth webkit.review.bot oldest_to_newest 269097 0 girish 2010-08-25 01:57:07 -0700 There is some discussion on plugin-features to implement a plugin visibility notification to NPAPI. The cases are - Plug-in instance goes out of sight after page scrolling. - Plug-in instance comes in sight after page scrolling. - Plug-in instance goes out of sight after browser window goes background. - Plug-in instance comes in sight after browser window goes foreground. See thread about it at: https://mail.mozilla.org/pipermail/plugin-futures/2010-July/000123.html Wiki entry: https://wiki.mozilla.org/NPAPI:VisibilityNotification The bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=583109 This is probably interesting to all platforms but note that the public flash player does not support it and hence this task is Qt/Maemo5 specific for now. 269121 1 girish 2010-08-25 02:52:27 -0700 The clipRect parameter of SetWindow is used different on Mac and Linux/Windows. On Mac, it is used to indicate the position of the plugin. When clipRect is set to 0, it means that it's not visible anymore. On Linux/Windows, clipRect indicates the clipping rect for the painting operation and is called before every paint(). In the plugin-features thread, Adobe person mentions that clipRect is used only on Mac (https://mail.mozilla.org/pipermail/plugin-futures/2010-July/000125.html). So, I guess Flash doesn't use this value. Currently, in Qt/WebKit, clipRect is always set to 0 on X11 in Windowless mode. In Windowed mode, we call it with the visibile rect but with a quirk (PluginQuirkDontCallSetWindowMoreThanOnce) wherein the height/width is never changed in the lifetime of the plugin. 269406 2 65453 girish 2010-08-25 11:48:03 -0700 Created attachment 65453 Set clipRect correctly on X11 269411 3 65453 kenneth 2010-08-25 11:52:17 -0700 Comment on attachment 65453 Set clipRect correctly on X11 WebCore/plugins/qt/PluginViewQt.cpp:588 + // position and clipRect is relative to the Drawable comments start with capital and ends with . Why is Drawable with a capital d? The comments could be a bit more explanatory. 269819 4 65545 girish 2010-08-26 04:44:49 -0700 Created attachment 65545 Set clipRect correctly on X11 Ok, I have a better patch now that also takes care of setting the clip rect to 0 when the plugin is scrolled out in both windowed and windowless mode. 269820 5 webkit.review.bot 2010-08-26 04:46:31 -0700 Attachment 65545 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/plugins/qt/PluginViewQt.cpp:588: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 269821 6 65546 girish 2010-08-26 04:46:32 -0700 Created attachment 65546 Set clipRect correctly on X11 Fix codings style 269823 7 girish 2010-08-26 04:57:00 -0700 Landed in r66095 269831 8 webkit.review.bot 2010-08-26 05:24:23 -0700 http://trac.webkit.org/changeset/66095 might have broken Qt Linux Release 269835 9 hausmann 2010-08-26 05:45:58 -0700 Committed r66097: <http://trac.webkit.org/changeset/66097> 269837 10 hausmann 2010-08-26 05:48:03 -0700 Committed r66095: <http://trac.webkit.org/changeset/66095> 270462 11 ademar 2010-08-27 06:36:31 -0700 Revision r66095 cherry-picked into qtwebkit-2.1 with commit 4a3c8a09303316623216e38f5dea9e0b3f215a26 Revision r66097 cherry-picked into qtwebkit-2.1 with commit fb2dbc367407000b4a1e7d741e740d8b1417946d 65453 2010-08-25 11:48:03 -0700 2010-08-26 04:44:49 -0700 Set clipRect correctly on X11 cliprect text/plain 3450 girish Y29tbWl0IGRkNjczOTY0ZmM1MzlkNDEyZTE1NTg3OWJkYWE4NGE4MzkyMjM5YjUKQXV0aG9yOiBH aXJpc2ggUmFtYWtyaXNobmFuIDxnaXJpc2hAZm9yd2FyZGJpYXMuaW4+CkRhdGU6ICAgVGh1IEF1 ZyAyNiAwMDoxNjozNCAyMDEwICswNTMwCgogICAgW1F0XSBTZXQgdGhlIGNsaXBSZWN0IGNvcnJl Y3RseSBpbiB3aW5kb3dlZCBhbmQgd2luZG93bGVzcyBtb2RlLgogICAgSW4gV2luZG93ZWQgbW9k ZSwgdGhlIHZhbHVlcyBhcmUgaW4gcGFnZSBjb29yZGluYXRlcy4gSW4gV2luZG93bGVzcwogICAg bW9kZSB0aGUgdmFsdWVzIGFyZSBpbiBkcmF3YWJsZSBjb29yZGluYXRlcy4gU2V0dGluZyB0aGVz ZSB2YWx1ZXMgaXMKICAgIHB1cmVseSBhY2FkZW1pYyBzaW5jZSB0aGV5IGFyZSBub3QgdXNlZCBi eSBGbGFzaC4gSG93ZXZlciwgdGhlcmUgaXMgYQogICAgcG9zc2liaWxpdHkgdGhhdCBwbHVnaW5z IG1pZ2h0IGluZmVyIGEgJ251bGwnIGNsaXBSZWN0IHRvIG1lYW4gJ2ludmlzaWJsZScuCiAgICAK ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDU5NAogICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCiAgICAKICAgICogcGx1Z2lucy9xdC9QbHVnaW5WaWV3 UXQuY3BwOgogICAgKFdlYkNvcmU6OlBsdWdpblZpZXc6OnNldE5QV2luZG93SWZOZWVkZWQpOgoK ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MGYxN2IyNi4uZmM4MTQzZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwyMSBAQAogCiAgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgogCisgICAgICAgIFtRdF0gU2V0IHRoZSBjbGlwUmVjdCBjb3JyZWN0bHkg aW4gd2luZG93ZWQgYW5kIHdpbmRvd2xlc3MgbW9kZS4KKyAgICAgICAgSW4gV2luZG93ZWQgbW9k ZSwgdGhlIHZhbHVlcyBhcmUgaW4gcGFnZSBjb29yZGluYXRlcy4gSW4gV2luZG93bGVzcworICAg ICAgICBtb2RlIHRoZSB2YWx1ZXMgYXJlIGluIGRyYXdhYmxlIGNvb3JkaW5hdGVzLiBTZXR0aW5n IHRoZXNlIHZhbHVlcyBpcworICAgICAgICBwdXJlbHkgYWNhZGVtaWMgc2luY2UgdGhleSBhcmUg bm90IHVzZWQgYnkgRmxhc2guIEhvd2V2ZXIsIHRoZXJlIGlzIGEKKyAgICAgICAgcG9zc2liaWxp dHkgdGhhdCBwbHVnaW5zIG1pZ2h0IGluZmVyIGEgJ251bGwnIGNsaXBSZWN0IHRvIG1lYW4gJ2lu dmlzaWJsZScuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTQ0NTk0CisKKyAgICAgICAgKiBwbHVnaW5zL3F0L1BsdWdpblZpZXdRdC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3OjpzZXROUFdpbmRvd0lmTmVlZGVkKToKKworMjAxMC0w OC0yNSAgR2lyaXNoIFJhbWFrcmlzaG5hbiAgPGdpcmlzaEBmb3J3YXJkYmlhcy5pbj4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwogICAgICAgICBbUXRdIFJlcGxhY2Ug UUxpYnJhcnkoImxpYmdkay14MTEtMi4wLnNvLjAiKSB3aXRoIFFMaWJyYXJ5KCJsaWJnZGsteDEx LTIuMCIsIDApCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD00NDYxOAogCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsdWdpbnMvcXQvUGx1Z2luVmlld1F0LmNw cCBiL1dlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5WaWV3UXQuY3BwCmluZGV4IDRlODljN2IuLjA1 ODg1NDQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5WaWV3UXQuY3BwCisr KyBiL1dlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5WaWV3UXQuY3BwCkBAIC01NzYsMjEgKzU3Niwy MyBAQCB2b2lkIFBsdWdpblZpZXc6OnNldE5QV2luZG93SWZOZWVkZWQoKQogICAgICAgICBwbGF0 Zm9ybVBsdWdpbldpZGdldCgpLT5zZXRWaXNpYmxlKCFtX2NsaXBSZWN0LmlzRW1wdHkoKSk7CiAg ICAgICAgIHBsYXRmb3JtUGx1Z2luV2lkZ2V0KCktPnNldE1hc2soUVJlZ2lvbihtX2NsaXBSZWN0 KSk7CiAKKyAgICAgICAgLy8gcG9zaXRpb24gYW5kIGNsaXBSZWN0IGlzIHJlbGF0aXZlIHRvIHRo ZSBwYWdlCiAgICAgICAgIG1fbnBXaW5kb3cueCA9IG1fd2luZG93UmVjdC54KCk7CiAgICAgICAg IG1fbnBXaW5kb3cueSA9IG1fd2luZG93UmVjdC55KCk7CiAKLSAgICAgICAgbV9ucFdpbmRvdy5j bGlwUmVjdC5sZWZ0ID0gbWF4KDAsIG1fY2xpcFJlY3QueCgpKTsKLSAgICAgICAgbV9ucFdpbmRv dy5jbGlwUmVjdC50b3AgPSBtYXgoMCwgbV9jbGlwUmVjdC55KCkpOwotICAgICAgICBtX25wV2lu ZG93LmNsaXBSZWN0LnJpZ2h0ID0gbV9jbGlwUmVjdC54KCkgKyBtX2NsaXBSZWN0LndpZHRoKCk7 Ci0gICAgICAgIG1fbnBXaW5kb3cuY2xpcFJlY3QuYm90dG9tID0gbV9jbGlwUmVjdC55KCkgKyBt X2NsaXBSZWN0LmhlaWdodCgpOworICAgICAgICBtX25wV2luZG93LmNsaXBSZWN0LmxlZnQgPSBt X3dpbmRvd1JlY3QueCgpICsgbV9jbGlwUmVjdC54KCk7CisgICAgICAgIG1fbnBXaW5kb3cuY2xp cFJlY3QudG9wID0gbV93aW5kb3dSZWN0LnkoKSArIG1fY2xpcFJlY3QueSgpOworICAgICAgICBt X25wV2luZG93LmNsaXBSZWN0LnJpZ2h0ID0gbV93aW5kb3dSZWN0LngoKSArIG1fY2xpcFJlY3Qu eCgpICsgbV9jbGlwUmVjdC53aWR0aCgpOworICAgICAgICBtX25wV2luZG93LmNsaXBSZWN0LmJv dHRvbSA9IG1fd2luZG93UmVjdC55KCkgKyBtX2NsaXBSZWN0LnkoKSArIG1fY2xpcFJlY3QuaGVp Z2h0KCk7CiAgICAgfSBlbHNlIHsKKyAgICAgICAgLy8gcG9zaXRpb24gYW5kIGNsaXBSZWN0IGlz IHJlbGF0aXZlIHRvIHRoZSBEcmF3YWJsZQogICAgICAgICBtX25wV2luZG93LnggPSAwOwogICAg ICAgICBtX25wV2luZG93LnkgPSAwOwogCi0gICAgICAgIG1fbnBXaW5kb3cuY2xpcFJlY3QubGVm dCA9IDA7Ci0gICAgICAgIG1fbnBXaW5kb3cuY2xpcFJlY3QudG9wID0gMDsKLSAgICAgICAgbV9u cFdpbmRvdy5jbGlwUmVjdC5yaWdodCA9IDA7Ci0gICAgICAgIG1fbnBXaW5kb3cuY2xpcFJlY3Qu Ym90dG9tID0gMDsKKyAgICAgICAgbV9ucFdpbmRvdy5jbGlwUmVjdC5sZWZ0ID0gbWF4KDAsIG1f Y2xpcFJlY3QueCgpKTsKKyAgICAgICAgbV9ucFdpbmRvdy5jbGlwUmVjdC50b3AgPSBtYXgoMCwg bV9jbGlwUmVjdC55KCkpOworICAgICAgICBtX25wV2luZG93LmNsaXBSZWN0LnJpZ2h0ID0gbV9j bGlwUmVjdC54KCkgKyBtX2NsaXBSZWN0LndpZHRoKCk7CisgICAgICAgIG1fbnBXaW5kb3cuY2xp cFJlY3QuYm90dG9tID0gbV9jbGlwUmVjdC55KCkgKyBtX2NsaXBSZWN0LmhlaWdodCgpOwogICAg IH0KIAogICAgIGlmIChtX3BsdWdpbi0+cXVpcmtzKCkuY29udGFpbnMoUGx1Z2luUXVpcmtEb250 Q2FsbFNldFdpbmRvd01vcmVUaGFuT25jZSkpIHsK 65545 2010-08-26 04:44:49 -0700 2010-08-26 04:46:32 -0700 Set clipRect correctly on X11 cliprect text/plain 3294 girish Y29tbWl0IDY4MGFjMmIzOGEwN2IzZDQwNWQ1YTVmYWZhNjgzZWJmYWYyZWE5N2YKQXV0aG9yOiBH aXJpc2ggUmFtYWtyaXNobmFuIDxnaXJpc2hAZm9yd2FyZGJpYXMuaW4+CkRhdGU6ICAgVGh1IEF1 ZyAyNiAwMDoxNjozNCAyMDEwICswNTMwCgogICAgW1F0XSBTZXQgdGhlIGNsaXBSZWN0IGNvcnJl Y3RseSBpbiB3aW5kb3dlZCBhbmQgd2luZG93bGVzcyBtb2RlLgogICAgSW4gV2luZG93ZWQgbW9k ZSwgdGhlIHZhbHVlcyBhcmUgaW4gcGFnZSBjb29yZGluYXRlcy4gSW4gV2luZG93bGVzcwogICAg bW9kZSB0aGUgdmFsdWVzIGFyZSBpbiBkcmF3YWJsZSBjb29yZGluYXRlcy4gU2V0dGluZyB0aGVz ZSB2YWx1ZXMgaXMKICAgIHB1cmVseSBhY2FkZW1pYyBzaW5jZSB0aGV5IGFyZSBub3QgdXNlZCBi eSBGbGFzaC4gSG93ZXZlciwgdGhlcmUgaXMgYQogICAgcG9zc2liaWxpdHkgdGhhdCBwbHVnaW5z IG1pZ2h0IGluZmVyIGEgJ251bGwnIGNsaXBSZWN0IHRvIG1lYW4gJ2ludmlzaWJsZScuCiAgICAK ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDU5NAogICAgCiAg ICBSZXZpZXdlZCBieSBLZW5uZXRoIENocmlzdGlhbnNlbi4KICAgIAogICAgKiBwbHVnaW5zL3F0 L1BsdWdpblZpZXdRdC5jcHA6CiAgICAoV2ViQ29yZTo6UGx1Z2luVmlldzo6c2V0TlBXaW5kb3dJ Zk5lZWRlZCk6CgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5n ZUxvZwppbmRleCAwOTY5MGEzLi5jNzE0ODViIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxv ZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEwLTA4LTI2ICBH aXJpc2ggUmFtYWtyaXNobmFuICA8Z2lyaXNoQGZvcndhcmRiaWFzLmluPgogCisgICAgICAgIFJl dmlld2VkIGJ5IEtlbm5ldGggQ2hyaXN0aWFuc2VuLgorCisgICAgICAgIFtRdF0gU2V0IHRoZSBj bGlwUmVjdCBjb3JyZWN0bHkgaW4gd2luZG93ZWQgYW5kIHdpbmRvd2xlc3MgbW9kZS4KKyAgICAg ICAgSW4gV2luZG93ZWQgbW9kZSwgdGhlIHZhbHVlcyBhcmUgaW4gcGFnZSBjb29yZGluYXRlcy4g SW4gV2luZG93bGVzcworICAgICAgICBtb2RlIHRoZSB2YWx1ZXMgYXJlIGluIGRyYXdhYmxlIGNv b3JkaW5hdGVzLiBTZXR0aW5nIHRoZXNlIHZhbHVlcyBpcworICAgICAgICBwdXJlbHkgYWNhZGVt aWMgc2luY2UgdGhleSBhcmUgbm90IHVzZWQgYnkgRmxhc2guIEhvd2V2ZXIsIHRoZXJlIGlzIGEK KyAgICAgICAgcG9zc2liaWxpdHkgdGhhdCBwbHVnaW5zIG1pZ2h0IGluZmVyIGEgJ251bGwnIGNs aXBSZWN0IHRvIG1lYW4gJ2ludmlzaWJsZScuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0NTk0CisKKyAgICAgICAgKiBwbHVnaW5zL3F0L1BsdWdp blZpZXdRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3OjpzZXROUFdpbmRvd0lm TmVlZGVkKToKKworMjAxMC0wOC0yNiAgR2lyaXNoIFJhbWFrcmlzaG5hbiAgPGdpcmlzaEBmb3J3 YXJkYmlhcy5pbj4KKwogICAgICAgICBSZXZpZXdlZCBieSBBcml5YSBIaWRheWF0LgogCiAgICAg ICAgIFtRdF0gUmVwbGFjZSBRTGlicmFyeSgibGliZ2RrLXgxMS0yLjAuc28uMCIpIHdpdGggUUxp YnJhcnkoImxpYmdkay14MTEtMi4wIiwgMCkKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGx1Z2lucy9x dC9QbHVnaW5WaWV3UXQuY3BwIGIvV2ViQ29yZS9wbHVnaW5zL3F0L1BsdWdpblZpZXdRdC5jcHAK aW5kZXggNGU4OWM3Yi4uNjg1YTZhMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbHVnaW5zL3F0L1Bs dWdpblZpZXdRdC5jcHAKKysrIGIvV2ViQ29yZS9wbHVnaW5zL3F0L1BsdWdpblZpZXdRdC5jcHAK QEAgLTU3OCwxOSArNTc4LDI0IEBAIHZvaWQgUGx1Z2luVmlldzo6c2V0TlBXaW5kb3dJZk5lZWRl ZCgpCiAKICAgICAgICAgbV9ucFdpbmRvdy54ID0gbV93aW5kb3dSZWN0LngoKTsKICAgICAgICAg bV9ucFdpbmRvdy55ID0gbV93aW5kb3dSZWN0LnkoKTsKLQotICAgICAgICBtX25wV2luZG93LmNs aXBSZWN0LmxlZnQgPSBtYXgoMCwgbV9jbGlwUmVjdC54KCkpOwotICAgICAgICBtX25wV2luZG93 LmNsaXBSZWN0LnRvcCA9IG1heCgwLCBtX2NsaXBSZWN0LnkoKSk7Ci0gICAgICAgIG1fbnBXaW5k b3cuY2xpcFJlY3QucmlnaHQgPSBtX2NsaXBSZWN0LngoKSArIG1fY2xpcFJlY3Qud2lkdGgoKTsK LSAgICAgICAgbV9ucFdpbmRvdy5jbGlwUmVjdC5ib3R0b20gPSBtX2NsaXBSZWN0LnkoKSArIG1f Y2xpcFJlY3QuaGVpZ2h0KCk7CiAgICAgfSBlbHNlIHsKICAgICAgICAgbV9ucFdpbmRvdy54ID0g MDsKICAgICAgICAgbV9ucFdpbmRvdy55ID0gMDsKKyAgICB9CiAKKyAgICAvLyBJZiB0aGUgd2lk dGggb3IgaGVpZ2h0IGFyZSBudWxsLCBzZXQgdGhlIGNsaXBSZWN0IHRvIG51bGwsIGluZGljYXRp bmcgdGhhdAorICAgIC8vIHRoZSBwbHVnaW4gaXMgbm90IHZpc2libGUvc2Nyb2xsZWQgb3V0Lgor ICAgIGlmIChtX2NsaXBSZWN0LndpZHRoKCkgPT0gMCB8fCBtX2NsaXBSZWN0LmhlaWdodCgpID09 IDApIHsKICAgICAgICAgbV9ucFdpbmRvdy5jbGlwUmVjdC5sZWZ0ID0gMDsKLSAgICAgICAgbV9u cFdpbmRvdy5jbGlwUmVjdC50b3AgPSAwOwogICAgICAgICBtX25wV2luZG93LmNsaXBSZWN0LnJp Z2h0ID0gMDsKKyAgICAgICAgbV9ucFdpbmRvdy5jbGlwUmVjdC50b3AgPSAwOwogICAgICAgICBt X25wV2luZG93LmNsaXBSZWN0LmJvdHRvbSA9IDA7CisgICAgfSBlbHNlIHsKKyAgICAgICAgLy8g Q2xpcHBpbmcgcmVjdGFuZ2xlIG9mIHRoZSBwbHVnLWluOyB0aGUgb3JpZ2luIGlzIHRoZSB0b3Ag bGVmdCBjb3JuZXIgb2YgdGhlIGRyYXdhYmxlIG9yIHdpbmRvdy4gCisgICAgICAgIG1fbnBXaW5k b3cuY2xpcFJlY3QubGVmdCA9IG1fbnBXaW5kb3cueCArIG1fY2xpcFJlY3QueCgpOworICAgICAg ICBtX25wV2luZG93LmNsaXBSZWN0LnRvcCA9IG1fbnBXaW5kb3cueSArIG1fY2xpcFJlY3QueSgp OworICAgICAgICBtX25wV2luZG93LmNsaXBSZWN0LnJpZ2h0ID0gbV9ucFdpbmRvdy54ICsgbV9j bGlwUmVjdC54KCkgKyBtX2NsaXBSZWN0LndpZHRoKCk7CisgICAgICAgIG1fbnBXaW5kb3cuY2xp cFJlY3QuYm90dG9tID0gbV9ucFdpbmRvdy55ICsgbV9jbGlwUmVjdC55KCkgKyBtX2NsaXBSZWN0 LmhlaWdodCgpOwogICAgIH0KIAogICAgIGlmIChtX3BsdWdpbi0+cXVpcmtzKCkuY29udGFpbnMo UGx1Z2luUXVpcmtEb250Q2FsbFNldFdpbmRvd01vcmVUaGFuT25jZSkpIHsK 65546 2010-08-26 04:46:32 -0700 2010-08-26 04:52:32 -0700 Set clipRect correctly on X11 cliprect text/plain 3286 girish Y29tbWl0IDM4ZTJlZTk4NzQ4MGM4M2U3ZmUxOTE3NWQ0MmE1YjkwMTg1NmI1OTkKQXV0aG9yOiBH aXJpc2ggUmFtYWtyaXNobmFuIDxnaXJpc2hAZm9yd2FyZGJpYXMuaW4+CkRhdGU6ICAgVGh1IEF1 ZyAyNiAwMDoxNjozNCAyMDEwICswNTMwCgogICAgW1F0XSBTZXQgdGhlIGNsaXBSZWN0IGNvcnJl Y3RseSBpbiB3aW5kb3dlZCBhbmQgd2luZG93bGVzcyBtb2RlLgogICAgSW4gV2luZG93ZWQgbW9k ZSwgdGhlIHZhbHVlcyBhcmUgaW4gcGFnZSBjb29yZGluYXRlcy4gSW4gV2luZG93bGVzcwogICAg bW9kZSB0aGUgdmFsdWVzIGFyZSBpbiBkcmF3YWJsZSBjb29yZGluYXRlcy4gU2V0dGluZyB0aGVz ZSB2YWx1ZXMgaXMKICAgIHB1cmVseSBhY2FkZW1pYyBzaW5jZSB0aGV5IGFyZSBub3QgdXNlZCBi eSBGbGFzaC4gSG93ZXZlciwgdGhlcmUgaXMgYQogICAgcG9zc2liaWxpdHkgdGhhdCBwbHVnaW5z IG1pZ2h0IGluZmVyIGEgJ251bGwnIGNsaXBSZWN0IHRvIG1lYW4gJ2ludmlzaWJsZScuCiAgICAK ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDU5NAogICAgCiAg ICBSZXZpZXdlZCBieSBLZW5uZXRoIENocmlzdGlhbnNlbi4KICAgIAogICAgKiBwbHVnaW5zL3F0 L1BsdWdpblZpZXdRdC5jcHA6CiAgICAoV2ViQ29yZTo6UGx1Z2luVmlldzo6c2V0TlBXaW5kb3dJ Zk5lZWRlZCk6CgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5n ZUxvZwppbmRleCAwOTY5MGEzLi5jNzE0ODViIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxv ZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEwLTA4LTI2ICBH aXJpc2ggUmFtYWtyaXNobmFuICA8Z2lyaXNoQGZvcndhcmRiaWFzLmluPgogCisgICAgICAgIFJl dmlld2VkIGJ5IEtlbm5ldGggQ2hyaXN0aWFuc2VuLgorCisgICAgICAgIFtRdF0gU2V0IHRoZSBj bGlwUmVjdCBjb3JyZWN0bHkgaW4gd2luZG93ZWQgYW5kIHdpbmRvd2xlc3MgbW9kZS4KKyAgICAg ICAgSW4gV2luZG93ZWQgbW9kZSwgdGhlIHZhbHVlcyBhcmUgaW4gcGFnZSBjb29yZGluYXRlcy4g SW4gV2luZG93bGVzcworICAgICAgICBtb2RlIHRoZSB2YWx1ZXMgYXJlIGluIGRyYXdhYmxlIGNv b3JkaW5hdGVzLiBTZXR0aW5nIHRoZXNlIHZhbHVlcyBpcworICAgICAgICBwdXJlbHkgYWNhZGVt aWMgc2luY2UgdGhleSBhcmUgbm90IHVzZWQgYnkgRmxhc2guIEhvd2V2ZXIsIHRoZXJlIGlzIGEK KyAgICAgICAgcG9zc2liaWxpdHkgdGhhdCBwbHVnaW5zIG1pZ2h0IGluZmVyIGEgJ251bGwnIGNs aXBSZWN0IHRvIG1lYW4gJ2ludmlzaWJsZScuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0NTk0CisKKyAgICAgICAgKiBwbHVnaW5zL3F0L1BsdWdp blZpZXdRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3OjpzZXROUFdpbmRvd0lm TmVlZGVkKToKKworMjAxMC0wOC0yNiAgR2lyaXNoIFJhbWFrcmlzaG5hbiAgPGdpcmlzaEBmb3J3 YXJkYmlhcy5pbj4KKwogICAgICAgICBSZXZpZXdlZCBieSBBcml5YSBIaWRheWF0LgogCiAgICAg ICAgIFtRdF0gUmVwbGFjZSBRTGlicmFyeSgibGliZ2RrLXgxMS0yLjAuc28uMCIpIHdpdGggUUxp YnJhcnkoImxpYmdkay14MTEtMi4wIiwgMCkKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGx1Z2lucy9x dC9QbHVnaW5WaWV3UXQuY3BwIGIvV2ViQ29yZS9wbHVnaW5zL3F0L1BsdWdpblZpZXdRdC5jcHAK aW5kZXggNGU4OWM3Yi4uNDdlMjdkOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbHVnaW5zL3F0L1Bs dWdpblZpZXdRdC5jcHAKKysrIGIvV2ViQ29yZS9wbHVnaW5zL3F0L1BsdWdpblZpZXdRdC5jcHAK QEAgLTU3OCwxOSArNTc4LDI0IEBAIHZvaWQgUGx1Z2luVmlldzo6c2V0TlBXaW5kb3dJZk5lZWRl ZCgpCiAKICAgICAgICAgbV9ucFdpbmRvdy54ID0gbV93aW5kb3dSZWN0LngoKTsKICAgICAgICAg bV9ucFdpbmRvdy55ID0gbV93aW5kb3dSZWN0LnkoKTsKLQotICAgICAgICBtX25wV2luZG93LmNs aXBSZWN0LmxlZnQgPSBtYXgoMCwgbV9jbGlwUmVjdC54KCkpOwotICAgICAgICBtX25wV2luZG93 LmNsaXBSZWN0LnRvcCA9IG1heCgwLCBtX2NsaXBSZWN0LnkoKSk7Ci0gICAgICAgIG1fbnBXaW5k b3cuY2xpcFJlY3QucmlnaHQgPSBtX2NsaXBSZWN0LngoKSArIG1fY2xpcFJlY3Qud2lkdGgoKTsK LSAgICAgICAgbV9ucFdpbmRvdy5jbGlwUmVjdC5ib3R0b20gPSBtX2NsaXBSZWN0LnkoKSArIG1f Y2xpcFJlY3QuaGVpZ2h0KCk7CiAgICAgfSBlbHNlIHsKICAgICAgICAgbV9ucFdpbmRvdy54ID0g MDsKICAgICAgICAgbV9ucFdpbmRvdy55ID0gMDsKKyAgICB9CiAKKyAgICAvLyBJZiB0aGUgd2lk dGggb3IgaGVpZ2h0IGFyZSBudWxsLCBzZXQgdGhlIGNsaXBSZWN0IHRvIG51bGwsIGluZGljYXRp bmcgdGhhdAorICAgIC8vIHRoZSBwbHVnaW4gaXMgbm90IHZpc2libGUvc2Nyb2xsZWQgb3V0Lgor ICAgIGlmICghbV9jbGlwUmVjdC53aWR0aCgpIHx8ICFtX2NsaXBSZWN0LmhlaWdodCgpKSB7CiAg ICAgICAgIG1fbnBXaW5kb3cuY2xpcFJlY3QubGVmdCA9IDA7Ci0gICAgICAgIG1fbnBXaW5kb3cu Y2xpcFJlY3QudG9wID0gMDsKICAgICAgICAgbV9ucFdpbmRvdy5jbGlwUmVjdC5yaWdodCA9IDA7 CisgICAgICAgIG1fbnBXaW5kb3cuY2xpcFJlY3QudG9wID0gMDsKICAgICAgICAgbV9ucFdpbmRv dy5jbGlwUmVjdC5ib3R0b20gPSAwOworICAgIH0gZWxzZSB7CisgICAgICAgIC8vIENsaXBwaW5n IHJlY3RhbmdsZSBvZiB0aGUgcGx1Zy1pbjsgdGhlIG9yaWdpbiBpcyB0aGUgdG9wIGxlZnQgY29y bmVyIG9mIHRoZSBkcmF3YWJsZSBvciB3aW5kb3cuIAorICAgICAgICBtX25wV2luZG93LmNsaXBS ZWN0LmxlZnQgPSBtX25wV2luZG93LnggKyBtX2NsaXBSZWN0LngoKTsKKyAgICAgICAgbV9ucFdp bmRvdy5jbGlwUmVjdC50b3AgPSBtX25wV2luZG93LnkgKyBtX2NsaXBSZWN0LnkoKTsKKyAgICAg ICAgbV9ucFdpbmRvdy5jbGlwUmVjdC5yaWdodCA9IG1fbnBXaW5kb3cueCArIG1fY2xpcFJlY3Qu eCgpICsgbV9jbGlwUmVjdC53aWR0aCgpOworICAgICAgICBtX25wV2luZG93LmNsaXBSZWN0LmJv dHRvbSA9IG1fbnBXaW5kb3cueSArIG1fY2xpcFJlY3QueSgpICsgbV9jbGlwUmVjdC5oZWlnaHQo KTsKICAgICB9CiAKICAgICBpZiAobV9wbHVnaW4tPnF1aXJrcygpLmNvbnRhaW5zKFBsdWdpblF1 aXJrRG9udENhbGxTZXRXaW5kb3dNb3JlVGhhbk9uY2UpKSB7Cg==