44585 2010-08-24 22:54:03 -0700 [DRT/Chromium] Fix fast/notifications/notifications-display-close-events.html failure 2010-08-30 17:19:34 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other All RESOLVED FIXED P2 Normal --- 1 tkent tkent dglazkov tony oldest_to_newest 269034 0 tkent 2010-08-24 22:54:03 -0700 [DRT/Chromium] Fix fast/notifications/notifications-display-close-events.html failure 269037 1 65374 tkent 2010-08-24 23:02:22 -0700 Created attachment 65374 Patch 271761 2 65374 abarth 2010-08-30 16:50:05 -0700 Comment on attachment 65374 Patch > WebKitTools/DumpRenderTree/chromium/NotificationPresenter.cpp:50 > +static void deferredDisplayDispatch(WebNotification notification) > +{ > + notification.dispatchDisplayEvent(); > +} We really would like to have RunnableMethods, huh? 271787 3 tkent 2010-08-30 17:17:58 -0700 (In reply to comment #2) > (From update of attachment 65374 [details]) > > WebKitTools/DumpRenderTree/chromium/NotificationPresenter.cpp:50 > > +static void deferredDisplayDispatch(WebNotification notification) > > +{ > > + notification.dispatchDisplayEvent(); > > +} > We really would like to have RunnableMethods, huh? Probably. Anyway, we need to revisit here to remove base/task.h dependency. 271789 4 65374 tkent 2010-08-30 17:19:26 -0700 Comment on attachment 65374 Patch Clearing flags on attachment: 65374 Committed r66430: <http://trac.webkit.org/changeset/66430> 271790 5 tkent 2010-08-30 17:19:34 -0700 All reviewed patches have been landed. Closing bug. 65374 2010-08-24 23:02:22 -0700 2010-08-30 17:19:26 -0700 Patch bug-44585-20100825150220.patch text/plain 3727 tkent ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlYWMwNTYwY2U2YmMxYWQ2MDUxMzdjY2I4MjVmNzAxMmFkYmQxMWJiLi5hNWZjMDVj Zjk0N2MzMzVmYjAyMTEyYTQwNDU5ZWQxOWNlYjdmNzliIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTAtMDgtMjUgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBmYXN0L25vdGlmaWNh dGlvbnMvbm90aWZpY2F0aW9ucy1kaXNwbGF5LWNsb3NlLWV2ZW50cy5odG1sIGZhaWx1cmUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0NTg1CisKKyAg ICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9kcnRfZXhwZWN0YXRpb25zLnR4dDoKKwogMjAxMC0w OC0yNCAgRGFuaWVsIEJhdGVzICA8ZGJhdGVzQHJpbS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1 bS9kcnRfZXhwZWN0YXRpb25zLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL2Ry dF9leHBlY3RhdGlvbnMudHh0CmluZGV4IGQ5YTE2YWVkMjZkYWU3YjdiNTE0MTdkMDdlMGE5YWI5 NjZlYzEyNTkuLmY2NGEwZDRiYTQyNDdkN2UyMmI5ZGE4MmYwNTFiZDQxNzdkMTMxN2EgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL2RydF9leHBlY3RhdGlvbnMudHh0 CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL2RydF9leHBlY3RhdGlvbnMudHh0 CkBAIC0zMjAsNyArMzIwLDYgQEAgQlVHX0RSVCBXSU4gTUFDIExJTlVYIDogZmFzdC9keW5hbWlj L3dpbmRvdy1yZXNpemUtc2Nyb2xsYmFycy10ZXN0Lmh0bWwgPSBJTUFHRSsKIEJVR19EUlQgV0lO IDogZmFzdC9ldmVudHMvc2hvdy1tb2RhbC1kaWFsb2ctb25ibHVyLW9uZm9jdXMuaHRtbCA9IFRF WFQKIEJVR19EUlQgV0lOIDogZmFzdC9oYXJuZXNzL3Nob3ctbW9kYWwtZGlhbG9nLmh0bWwgPSBU RVhUCiBCVUdfRFJUIFdJTiA6IGZhc3QvbGlzdHMvMDAxLmh0bWwgPSBDUkFTSAotQlVHX0RSVCBX SU4gTUFDIExJTlVYIDogZmFzdC9ub3RpZmljYXRpb25zL25vdGlmaWNhdGlvbnMtZGlzcGxheS1j bG9zZS1ldmVudHMuaHRtbCA9IFRJTUVPVVQKIEJVR19EUlQgV0lOIDogZmFzdC90ZXh0L3N0cmlw TnVsbEZyb21UZXh0Lmh0bWwgPSBJTUFHRStURVhUCiBCVUdfRFJUIFdJTiBNQUMgTElOVVggOiBo dHRwL3Rlc3RzL2luY3JlbWVudGFsL3Nsb3ctdXRmOC10ZXh0LnBsID0gTUlTU0lORwogQlVHX0RS VCBXSU4gOiBwbHVnaW5zL2VtYmVkLWF0dHJpYnV0ZXMtc2V0dGluZy5odG1sID0gVEVYVApkaWZm IC0tZ2l0IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmlu ZGV4IDE2ZjYwNTAxMzU0ZWYzODBiMzZkNzI0NzQxMmQ3ZWVlODY3OTZjYTYuLjNlNDY0YmI5ODU0 NDg2ODUxNWQ4YjZmZjdjOGZjNjEzODZmYTkzNWEgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0No YW5nZUxvZworKysgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAx MC0wOC0yNSAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGZhc3Qvbm90aWZpY2F0aW9u cy9ub3RpZmljYXRpb25zLWRpc3BsYXktY2xvc2UtZXZlbnRzLmh0bWwgZmFpbHVyZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDQ1ODUKKworICAgICAg ICBBcHBseSBodHRwOi8vY3JyZXYuY29tLzQ4ODkzLiBXZSBzaG91bGQgZGlzcGF0Y2ggZGlzcGxh eSBldmVudHMKKyAgICAgICAgYXN5bmNocm9ub3VzbHkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVy VHJlZS9jaHJvbWl1bS9Ob3RpZmljYXRpb25QcmVzZW50ZXIuY3BwOgorICAgICAgICAoZGVmZXJy ZWREaXNwbGF5RGlzcGF0Y2gpOgorICAgICAgICAoTm90aWZpY2F0aW9uUHJlc2VudGVyOjpzaG93 KToKKwogMjAxMC0wOC0yNCAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292LgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9v bHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vTm90aWZpY2F0aW9uUHJlc2VudGVyLmNwcCBiL1dl YktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL05vdGlmaWNhdGlvblByZXNlbnRlci5j cHAKaW5kZXggOTUzNTNhN2JlNzIzMjFmMmY1NmE4MTE0OGMwNmI2MjI4ZWViODZjZS4uMDcwZGYz MzYxNWFmMDEyNDdiYjZiYmVjZjc4YWJjODQxNTRkOGI1OSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9v bHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vTm90aWZpY2F0aW9uUHJlc2VudGVyLmNwcAorKysg Yi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9Ob3RpZmljYXRpb25QcmVzZW50 ZXIuY3BwCkBAIC0zMSwxOCArMzEsMjQgQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRl ICJOb3RpZmljYXRpb25QcmVzZW50ZXIuaCIKIAotI2luY2x1ZGUgPHd0Zi90ZXh0L0NTdHJpbmcu aD4KLSNpbmNsdWRlIDx3dGYvdGV4dC9XVEZTdHJpbmcuaD4KLQorI2luY2x1ZGUgImJhc2UvdGFz ay5oIiAvLyBGSVhNRTogUmVtb3ZlIHRoaXMKICNpbmNsdWRlICJnb29nbGV1cmwvc3JjL2d1cmwu aCIKICNpbmNsdWRlICJwdWJsaWMvV2ViTm90aWZpY2F0aW9uLmgiCiAjaW5jbHVkZSAicHVibGlj L1dlYk5vdGlmaWNhdGlvblBlcm1pc3Npb25DYWxsYmFjay5oIgogI2luY2x1ZGUgInB1YmxpYy9X ZWJTZWN1cml0eU9yaWdpbi5oIgogI2luY2x1ZGUgInB1YmxpYy9XZWJTdHJpbmcuaCIKICNpbmNs dWRlICJwdWJsaWMvV2ViVVJMLmgiCisjaW5jbHVkZSAid2Via2l0L3N1cHBvcnQvd2Via2l0X3N1 cHBvcnQuaCIKKyNpbmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5nLmg+CisjaW5jbHVkZSA8d3RmL3Rl eHQvV1RGU3RyaW5nLmg+CiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7CiAKK3N0YXRpYyB2b2lk IGRlZmVycmVkRGlzcGxheURpc3BhdGNoKFdlYk5vdGlmaWNhdGlvbiBub3RpZmljYXRpb24pCit7 CisgICAgbm90aWZpY2F0aW9uLmRpc3BhdGNoRGlzcGxheUV2ZW50KCk7Cit9CisKIHZvaWQgTm90 aWZpY2F0aW9uUHJlc2VudGVyOjpncmFudFBlcm1pc3Npb24oY29uc3QgV2ViU3RyaW5nJiBvcmln aW4pCiB7CiAgICAgLy8gTWFrZSBzdXJlIGl0J3MgaW4gdGhlIGZvcm0gb2YgYW4gb3JpZ2luLgpA QCAtNzksNyArODUsNyBAQCBib29sIE5vdGlmaWNhdGlvblByZXNlbnRlcjo6c2hvdyhjb25zdCBX ZWJOb3RpZmljYXRpb24mIG5vdGlmaWNhdGlvbikKICAgICB9CiAKICAgICBXZWJOb3RpZmljYXRp b24gZXZlbnRUYXJnZXQobm90aWZpY2F0aW9uKTsKLSAgICBldmVudFRhcmdldC5kaXNwYXRjaERp c3BsYXlFdmVudCgpOworICAgIHdlYmtpdF9zdXBwb3J0OjpQb3N0VGFza0Zyb21IZXJlKE5ld1J1 bm5hYmxlRnVuY3Rpb24oJmRlZmVycmVkRGlzcGxheURpc3BhdGNoLCBldmVudFRhcmdldCkpOwog ICAgIHJldHVybiB0cnVlOwogfQogCg==