44572 2010-08-24 18:28:58 -0700 [Chromium] Hulu popups are blocked 2010-08-24 19:29:32 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth abarth dglazkov eric webkit.review.bot oldest_to_newest 268958 0 abarth 2010-08-24 18:28:58 -0700 [Chromium] Hulu popups are blocked 268959 1 65355 abarth 2010-08-24 18:32:25 -0700 Created attachment 65355 Patch 268960 2 65355 dglazkov 2010-08-24 18:40:35 -0700 Comment on attachment 65355 Patch WebKit/chromium/ChangeLog:9 + setting the UserGestureIndictor for events. Most WebKit ports handle Indicator WebKit/chromium/ChangeLog:16 + the ability to run the Chromium LayoutTests on this machine. :( Why not? 268961 3 abarth 2010-08-24 18:46:10 -0700 > + the ability to run the Chromium LayoutTests on this machine. :( > Why not? I almost never build Chrome and build-webkit --chromium can't run the tests, AFAIK. 268962 4 abarth 2010-08-24 18:49:39 -0700 Committed r65964: <http://trac.webkit.org/changeset/65964> 268964 5 dglazkov 2010-08-24 18:50:39 -0700 (In reply to comment #3) > > + the ability to run the Chromium LayoutTests on this machine. :( > > Why not? > > I almost never build Chrome and build-webkit --chromium can't run the tests, AFAIK. Yes we can! http://build.webkit.org/builders/Chromium%20Mac%20Release%20(Tests)/builds/1602/steps/layout-test/logs/stdio 268968 6 abarth 2010-08-24 19:12:26 -0700 That's exciting. I'll try that next time. 268978 7 webkit.review.bot 2010-08-24 19:29:32 -0700 http://trac.webkit.org/changeset/65964 might have broken SnowLeopard Intel Release (Tests) The following changes are on the blame list: http://trac.webkit.org/changeset/65960 http://trac.webkit.org/changeset/65961 http://trac.webkit.org/changeset/65962 http://trac.webkit.org/changeset/65963 http://trac.webkit.org/changeset/65964 http://trac.webkit.org/changeset/65965 65355 2010-08-24 18:32:25 -0700 2010-08-24 18:40:35 -0700 Patch bug-44572-20100824183224.patch text/plain 1926 abarth SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjU5NjIpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTAtMDgtMjQgIEFkYW0g QmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbQ2hyb21pdW1dIEh1bHUgcG9wdXBzIGFyZSBibG9ja2VkCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDU3MgorCisg ICAgICAgIFdlIHdlcmUgYmxvY2tpbmcgcG9wdXBzIGNyZWF0ZWQgYnkgRmxhc2ggUGxheWVyIGJl Y2F1c2Ugd2Ugd2VyZSBuZXZlcgorICAgICAgICBzZXR0aW5nIHRoZSBVc2VyR2VzdHVyZUluZGlj dG9yIGZvciBldmVudHMuICBNb3N0IFdlYktpdCBwb3J0cyBoYW5kbGUKKyAgICAgICAgZXZlbnRz IHRocm91Z2ggRXZlbnRIYW5kbGVyLCBidXQgQ2hyb21pdW0gaXMgc3BlY2lhbCAoZm9yIHNvbWUg dW5rbm93bgorICAgICAgICByZWFzb24pIGFuZCBkaXNwYXRjaGVzIGV2ZW50cyBkaXJlY3RseS4g IFRoYXQgbWVhbnMgQ2hyb21pdW0gbWlzc2VzIG91dAorICAgICAgICBvbiBzb21lIG9mIHRoZSB3 b3JrIGRvbmUgYnkgRXZlbnRIYW5kbGVyLCBpbmNsdWRpbmcgc2V0dGluZyB0aGUKKyAgICAgICAg VXNlckdlc3R1cmVJbmRpY2F0b3IuCisKKyAgICAgICAgSSBzdXNwZWN0IHRoaXMgaXMgY292ZXJl ZCBieSBhbiBleGlzdGluZyBMYXlvdXRUZXN0LCBidXQgSSBkb24ndCBoYXZlCisgICAgICAgIHRo ZSBhYmlsaXR5IHRvIHJ1biB0aGUgQ2hyb21pdW0gTGF5b3V0VGVzdHMgb24gdGhpcyBtYWNoaW5l LiAgOigKKworICAgICAgICAqIHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6 OldlYlZpZXdJbXBsOjpoYW5kbGVJbnB1dEV2ZW50KToKKwogMjAxMC0wOC0yNCAgSmlhbiBMaSAg PGppYW5saUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gRmlzaGVy LgpJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAJKHJldmlzaW9uIDY1OTMzKQor KysgV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTg4LDYgKzg4LDcgQEAKICNpbmNsdWRlICJTZXR0aW5ncy5oIgogI2luY2x1ZGUgIlRpbWVyLmgi CiAjaW5jbHVkZSAiVHlwaW5nQ29tbWFuZC5oIgorI2luY2x1ZGUgIlVzZXJHZXN0dXJlSW5kaWNh dG9yLmgiCiAjaW5jbHVkZSAiVmVjdG9yLmgiCiAjaW5jbHVkZSAiV2ViQWNjZXNzaWJpbGl0eU9i amVjdC5oIgogI2luY2x1ZGUgIldlYkRldlRvb2xzQWdlbnRQcml2YXRlLmgiCkBAIC05ODAsNiAr OTgxLDggQEAgY29uc3QgV2ViSW5wdXRFdmVudCogV2ViVmlld0ltcGw6Om1fY3VycgogCiBib29s IFdlYlZpZXdJbXBsOjpoYW5kbGVJbnB1dEV2ZW50KGNvbnN0IFdlYklucHV0RXZlbnQmIGlucHV0 RXZlbnQpCiB7CisgICAgVXNlckdlc3R1cmVJbmRpY2F0b3IgZ2VzdHVyZUluZGljYXRvcihEZWZp bml0ZWx5UHJvY2Vzc2luZ1VzZXJHZXN0dXJlKTsKKwogICAgIC8vIElmIHdlJ3ZlIHN0YXJ0ZWQg YSBkcmFnIGFuZCBkcm9wIG9wZXJhdGlvbiwgaWdub3JlIGlucHV0IGV2ZW50cyB1bnRpbAogICAg IC8vIHdlJ3JlIGRvbmUuCiAgICAgaWYgKG1fZG9pbmdEcmFnQW5kRHJvcCkK