44565 2010-08-24 17:02:08 -0700 [GTK] WebKitGTK+ needs proper introspection annotation for most types and methods 2014-04-08 18:40:20 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Gtk P2 Normal --- 1 gustavo webkit-unassigned alan mrobinson xan.lopez oldest_to_newest 268905 0 gustavo 2010-08-24 17:02:08 -0700 That's about it. Code such as this makes programs written using Introspection crash: from gi.repository import WebKit wv = WebKit.WebView() settings = wv.get_settings() settings = wv.get_settings() Because the introspection information that is generated naively assumes that get_settings returns a new ref, and unrefs it. Assuming ownership and transfer information is just dumb IMO, but not really important for this bug - I'll use this bug to drop many patches implementing proper annotations. 268908 1 65345 gustavo 2010-08-24 17:04:29 -0700 Created attachment 65345 first smallish set of annotations 269352 2 65345 mrobinson 2010-08-25 11:03:59 -0700 Comment on attachment 65345 first smallish set of annotations Great documentation improvements too. LGTM. 269844 3 65345 gustavo 2010-08-26 06:12:15 -0700 Comment on attachment 65345 first smallish set of annotations Clearing flags on attachment: 65345 Committed r66099: <http://trac.webkit.org/changeset/66099> 269845 4 gustavo 2010-08-26 06:12:24 -0700 All reviewed patches have been landed. Closing bug. 269846 5 gustavo 2010-08-26 06:15:54 -0700 I'll keep this bug open to drop the other patches in it when I'm through with them! 343833 6 alan 2011-02-01 21:36:53 -0800 *** Bug 40460 has been marked as a duplicate of this bug. *** 998998 7 mrobinson 2014-04-08 18:40:20 -0700 Pretty sure we can close this now. 65345 2010-08-24 17:04:29 -0700 2010-08-26 06:12:14 -0700 first smallish set of annotations 0001-get-set-settings-get_inspector-and-get_window_featur.patch text/plain 3623 gustavo RnJvbSA4YzY4NmRiMTU2ZGQ3ZDg5ZDIwZDNjYTMzZTAwMTViNDZmNjBiMWZiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGduc0Bnbm9tZS5vcmc+ CkRhdGU6IFR1ZSwgMjQgQXVnIDIwMTAgMjE6MDM6MzMgLTAzMDAKU3ViamVjdDogW1BBVENIXSBn ZXQvc2V0IHNldHRpbmdzLCBnZXRfaW5zcGVjdG9yIGFuZCBnZXRfd2luZG93X2ZlYXR1cmVzCgot LS0KIFdlYktpdC9ndGsvQ2hhbmdlTG9nICAgICAgICAgICAgICAgIHwgICAxMiArKysrKysrKysr KysKIFdlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwIHwgICAzMSArKysrKysrKysr KysrKysrKysrKysrKysrKystLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDM5IGluc2VydGlvbnMoKyks IDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cgYi9XZWJL aXQvZ3RrL0NoYW5nZUxvZwppbmRleCBlYzA4MDFjLi45ZTA0YTI5IDEwMDY0NAotLS0gYS9XZWJL aXQvZ3RrL0NoYW5nZUxvZworKysgYi9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEwLTA4LTI0ICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxnbnNAZ25vbWUub3JnPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIFdl YktpdEdUSysgbmVlZHMgcHJvcGVyIGludHJvc3BlY3Rpb24gYW5ub3RhdGlvbiBmb3IgbW9zdCB0 eXBlcyBhbmQgbWV0aG9kcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDQ1NjUKKworICAgICAgICBBZGQgZG9jdW1lbnRhdGlvbiBhbmQgaW50cm9zcGVj dGlvbiBzcGVjaWZpYyBpbmZvcm1hdGlvbiB0byBhIGZldworICAgICAgICBnZXR0ZXIgYW5kIHNl dHRlciBtZXRob2RzLgorCisgICAgICAgICogd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwOgorCiAy MDEwLTA4LTI0ICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxndXN0YXZvLm5vcm9uaGFAY29sbGFi b3JhLmNvLnVrPgogCiAgICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5IFhhbiBMb3Blei4KZGlmZiAt LWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwIGIvV2ViS2l0L2d0ay93 ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKaW5kZXggNzVlZGQzNS4uNWFhM2Q1MSAxMDA2NDQKLS0t IGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKKysrIGIvV2ViS2l0L2d0ay93 ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKQEAgLTMxOTksNiArMzE5OSwxOCBAQCBib29sIHdlYmtp dF93ZWJfdmlld191c2VfcHJpbWFyeV9mb3JfcGFzdGUoV2ViS2l0V2ViVmlldyogd2ViVmlldykK ICAgICByZXR1cm4gd2ViVmlldy0+cHJpdi0+dXNlUHJpbWFyeUZvclBhc3RlOwogfQogCisvKioK KyAqIHdlYmtpdF93ZWJfdmlld19zZXRfc2V0dGluZ3M6CisgKiBAd2ViX3ZpZXc6IGEgI1dlYktp dFdlYlZpZXcKKyAqIEBzZXR0aW5nczogKHRyYW5zZmVyIG5vbmUpOiB0aGUgI1dlYktpdFdlYlNl dHRpbmdzIHRvIGJlIHNldAorICoKKyAqIFJlcGxhY2VzIHRoZSAjV2ViS2l0V2ViU2V0dGluZ3Mg aW5zdGFuY2UgdGhhdCBpcyBjdXJyZW50bHkgYXR0YWNoZWQKKyAqIHRvIEB3ZWJfdmlldyB3aXRo IEBzZXR0aW5ncy4gVGhlIHJlZmVyZW5jZSBoZWxkIGJ5IHRoZSBAd2ViX3ZpZXcgb24KKyAqIHRo ZSBvbGQgI1dlYktpdFdlYlNldHRpbmdzIGluc3RhbmNlIGlzIGRyb3BwZWQsIGFuZCB0aGUgcmVm ZXJlbmNlCisgKiBjb3VudCBvZiBAc2V0dGluZ3MgaXMgaW5zY3JlYXNlZC4KKyAqCisgKiBUaGUg c2V0dGluZ3MgYXJlIGF1dG9tYXRpY2FsbHkgYXBwbGllZCB0byBAd2ViX3ZpZXcuCisgKi8KIHZv aWQgd2Via2l0X3dlYl92aWV3X3NldF9zZXR0aW5ncyhXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3LCBX ZWJLaXRXZWJTZXR0aW5ncyogd2ViU2V0dGluZ3MpCiB7CiAgICAgZ19yZXR1cm5faWZfZmFpbChX RUJLSVRfSVNfV0VCX1ZJRVcod2ViVmlldykpOwpAQCAtMzIxNCw2ICszMjI2LDE5IEBAIHZvaWQg d2Via2l0X3dlYl92aWV3X3NldF9zZXR0aW5ncyhXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3LCBXZWJL aXRXZWJTZXR0aW5ncyogd2ViCiAgICAgZ19vYmplY3Rfbm90aWZ5KEdfT0JKRUNUKHdlYlZpZXcp LCAic2V0dGluZ3MiKTsKIH0KIAorLyoqCisgKiB3ZWJraXRfd2ViX3ZpZXdfZ2V0X3NldHRpbmdz OgorICogQHdlYl92aWV3OiBhICNXZWJLaXRXZWJWaWV3CisgKgorICogT2J0YWlucyB0aGUgI1dl YktpdFdlYlNldHRpbmdzIGFzc29jaWF0ZWQgd2l0aCB0aGUKKyAqICNXZWJLaXRXZWJWaWV3LiBU aGUgI1dlYktpdFdlYlZpZXcgYWx3YXlzIGhhcyBhbiBhc3NvY2lhdGVkCisgKiBpbnN0YW5jZSBv ZiAjV2ViS2l0V2ViU2V0dGluZ3MuIFRoZSByZWZlcmVuY2UgdGhhdCBpcyByZXR1cm5lZCBieQor ICogdGhpcyBjYWxsIGlzIG93bmVkIGJ5IHRoZSAjV2ViS2l0V2ViVmlldy4gWW91IG1heSBuZWVk IHRvIGluY3JlYXNlCisgKiBpdHMgcmVmZXJlbmNlIGNvdW50IGlmIHlvdSBpbnRlbmQgdG8ga2Vl cCBpdCBhbGl2ZSBmb3IgbG9uZ2VyIHRoYW4KKyAqIHRoZSAjV2ViS2l0V2ViVmlldy4KKyAqCisg KiBSZXR1cm4gdmFsdWU6ICh0cmFuc2ZlciBub25lKTogdGhlICNXZWJLaXRXZWJTZXR0aW5ncyBp bnN0YW5jZQorICovCiBXZWJLaXRXZWJTZXR0aW5ncyogd2Via2l0X3dlYl92aWV3X2dldF9zZXR0 aW5ncyhXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3KQogewogICAgIGdfcmV0dXJuX3ZhbF9pZl9mYWls KFdFQktJVF9JU19XRUJfVklFVyh3ZWJWaWV3KSwgTlVMTCk7CkBAIC0zMjMyLDkgKzMyNTcsNyBA QCBXZWJLaXRXZWJTZXR0aW5ncyogd2Via2l0X3dlYl92aWV3X2dldF9zZXR0aW5ncyhXZWJLaXRX ZWJWaWV3KiB3ZWJWaWV3KQogICogc28gdGhpcyBmdW5jdGlvbiB3aWxsIG9ubHkgcmV0dXJuIE5V TEwgaWYgdGhlIGFyZ3VtZW50IGlzIG5vdCBhCiAgKiB2YWxpZCAjV2ViS2l0V2ViVmlldy4KICAq Ci0gKiBSZXR1cm5zOiB0aGUgI1dlYktpdFdlYkluc3BlY3RvciBpbnN0YW5jZSBhc3NvY2lhdGVk IHdpdGggdGhlCi0gKiAjV2ViS2l0V2ViVmlldzsgJU5VTEwgaXMgb25seSByZXR1cm5lZCBpZiB0 aGUgYXJndW1lbnQgaXMgbm90IGEKLSAqIHZhbGlkICNXZWJLaXRXZWJWaWV3LgorICogUmV0dXJu IHZhbHVlOiAodHJhbnNmZXIgbm9uZSk6IHRoZSAjV2ViS2l0V2ViSW5zcGVjdG9yIGluc3RhbmNl LgogICoKICAqIFNpbmNlOiAxLjAuMwogICovCkBAIC0zMjY5LDcgKzMyOTIsNyBAQCBzdGF0aWMg dm9pZCB3ZWJraXRfd2ViX3ZpZXdfc2V0X3dpbmRvd19mZWF0dXJlcyhXZWJLaXRXZWJWaWV3KiB3 ZWJWaWV3LCBXZWJLaXRXZQogICogUmV0dXJucyB0aGUgaW5zdGFuY2Ugb2YgI1dlYktpdFdlYldp bmRvd0ZlYXR1cmVzIGhlbGQgYnkgdGhlIGdpdmVuCiAgKiAjV2ViS2l0V2ViVmlldy4KICAqCi0g KiBSZXR1cm4gdmFsdWU6IHRoZSAjV2ViS2l0V2ViV2luZG93RmVhdHVyZXMKKyAqIFJldHVybiB2 YWx1ZTogKHRyYW5zZmVyIG5vbmUpOiB0aGUgI1dlYktpdFdlYldpbmRvd0ZlYXR1cmVzCiAgKgog ICogU2luY2U6IDEuMC4zCiAgKi8KLS0gCjEuNy4xCgo=