44564 2010-08-24 16:46:15 -0700 Null dereference possible in WebView::canShowMIMEType 2010-08-24 17:10:23 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 adachan adachan oldest_to_newest 268896 0 adachan 2010-08-24 16:46:15 -0700 This is a snippet from WebView::canShowMIMEType(): *canShow = MIMETypeRegistry::isSupportedImageMIMEType(mimeTypeStr) || MIMETypeRegistry::isSupportedNonImageMIMEType(mimeTypeStr) || (m_page && m_page->pluginData()->supportsMimeType(mimeTypeStr)) || shouldUseEmbeddedView(mimeTypeStr); m_page->pluginData() can return null if plugins are disabled on the user's system and we'd crash in that case. We should null check m_page->pluginData(). 268899 1 adachan 2010-08-24 16:47:24 -0700 <rdar://problem/8185379> 268910 2 65346 adachan 2010-08-24 17:05:22 -0700 Created attachment 65346 Patch Null check return value of m_page->pluginData() before accessing it. 268912 3 adachan 2010-08-24 17:10:23 -0700 Committed fix: r65952 65346 2010-08-24 17:05:22 -0700 2010-08-24 17:08:31 -0700 Patch 20100824-1.patch.txt text/plain 1301 adachan SW5kZXg6IFdlYktpdC93aW4vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93aW4vQ2hh bmdlTG9nCShyZXZpc2lvbiA2NTk1MCkKKysrIFdlYktpdC93aW4vQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDgtMjQgIEFkYSBDaGFuICA8YWRhY2hhbkBh cHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzgxODUzNzk+IFBvc3NpYmxlIG51bGwgZGVyZWZlcmVuY2UgaW4g V2ViVmlldzo6Y2FuU2hvd01JTUVUeXBlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NDQ1NjQKKworICAgICAgICAqIFdlYlZpZXcuY3BwOgorICAgICAg ICAoV2ViVmlldzo6Y2FuU2hvd01JTUVUeXBlKTogTnVsbCBjaGVjayBtX3BhZ2UtPnBsdWdpbkRh dGEoKSBzaW5jZSB0aGF0IGNhbiByZXR1cm4gTlVMTAorICAgICAgICBpZiBwbHVnaW5zIGFyZSBk aXNhYmxlZC4KKwogMjAxMC0wOC0yMiAgRGFuaWVsIEJhdGVzICA8ZGJhdGVzQHJpbS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBXZWJLaXQvd2luL1dlYlZp ZXcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93aW4vV2ViVmlldy5jcHAJKHJldmlzaW9uIDY1 OTQ4KQorKysgV2ViS2l0L3dpbi9XZWJWaWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjQzMiw3 ICsyNDMyLDcgQEAgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBXZWJWaWV3OjpjYW5TaAogCiAg ICAgKmNhblNob3cgPSBNSU1FVHlwZVJlZ2lzdHJ5Ojppc1N1cHBvcnRlZEltYWdlTUlNRVR5cGUo bWltZVR5cGVTdHIpIHx8CiAgICAgICAgIE1JTUVUeXBlUmVnaXN0cnk6OmlzU3VwcG9ydGVkTm9u SW1hZ2VNSU1FVHlwZShtaW1lVHlwZVN0cikgfHwKLSAgICAgICAgKG1fcGFnZSAmJiBtX3BhZ2Ut PnBsdWdpbkRhdGEoKS0+c3VwcG9ydHNNaW1lVHlwZShtaW1lVHlwZVN0cikpIHx8CisgICAgICAg IChtX3BhZ2UgJiYgbV9wYWdlLT5wbHVnaW5EYXRhKCkgJiYgbV9wYWdlLT5wbHVnaW5EYXRhKCkt PnN1cHBvcnRzTWltZVR5cGUobWltZVR5cGVTdHIpKSB8fAogICAgICAgICBzaG91bGRVc2VFbWJl ZGRlZFZpZXcobWltZVR5cGVTdHIpOwogICAgIAogICAgIHJldHVybiBTX09LOwo=