44561 2010-08-24 16:14:46 -0700 [Cairo][REGRESSION] Overzealous Use of Gtk-Specific Smart Pointers Breaks other Builds 2010-08-25 09:21:22 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Windows XP RESOLVED DUPLICATE 44354 P2 Normal --- 1 bfulgham webkit-unassigned mrobinson oldest_to_newest 268885 0 bfulgham 2010-08-24 16:14:46 -0700 Changes to the ImageCairo.cpp class (see @r65530) involved changes that used smart pointers on various Cairo data types. While I applaud this concept, the implementor made the unfortunate decision to use a GPtr-based implementation, rather than building on existing platform-agnostic WebKit smart pointer types. Since the ImageCairo class is not a Gtk-specific class, this violation of API separation creates build problems. As far as I can tell, the specific instances in ImageCairo.cpp where GPtr-based smart pointers are used could be replaced with a non-Gtk-specific implementation. This issue will make this change to resolve this build regression. 269068 1 mrobinson 2010-08-25 00:51:36 -0700 *** This bug has been marked as a duplicate of bug 44354 *** 269070 2 mrobinson 2010-08-25 00:52:05 -0700 I have a patch for this issue here: https://bugs.webkit.org/show_bug.cgi?id=44354 It is simply waiting on a review. 269279 3 65428 bfulgham 2010-08-25 09:21:22 -0700 Created attachment 65428 Create cairo specializations for PassRefPtr/RefPtr use A proposed update that provides Cairo-specific specializations for the [Pass]RefPtr templates. 65428 2010-08-25 09:21:22 -0700 2010-08-25 09:21:22 -0700 Create cairo specializations for PassRefPtr/RefPtr use cairo_ptrs.patch text/plain 3150 bfulgham SW5kZXg6IEltYWdlQ2Fpcm8uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEltYWdlQ2Fpcm8uY3BwCShyZXZp c2lvbiA2NTkzMykKKysrIEltYWdlQ2Fpcm8uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMyw3ICsz Myw3IEBACiAjaW5jbHVkZSAiQWZmaW5lVHJhbnNmb3JtLmgiCiAjaW5jbHVkZSAiQ29sb3IuaCIK ICNpbmNsdWRlICJGbG9hdFJlY3QuaCIKLSNpbmNsdWRlICJHUmVmUHRyQ2Fpcm8uaCIKKyNpbmNs dWRlICJSZWZQdHJDYWlyby5oIgogI2luY2x1ZGUgIkdyYXBoaWNzQ29udGV4dC5oIgogI2luY2x1 ZGUgIkltYWdlQnVmZmVyLmgiCiAjaW5jbHVkZSAiSW1hZ2VPYnNlcnZlci5oIgpAQCAtMTg1LDEx ICsxODUsMTEgQEAKICAgICBjYWlyb190KiBjciA9IGNvbnRleHQtPnBsYXRmb3JtQ29udGV4dCgp OwogICAgIGNvbnRleHQtPnNhdmUoKTsKIAotICAgIEdSZWZQdHI8Y2Fpcm9fc3VyZmFjZV90PiBj bGlwcGVkSW1hZ2VTdXJmYWNlID0gMDsKKyAgICBSZWZQdHI8Y2Fpcm9fc3VyZmFjZV90PiBjbGlw cGVkSW1hZ2VTdXJmYWNlID0gMDsKICAgICBpZiAodGlsZVJlY3Quc2l6ZSgpICE9IHNpemUoKSkg ewogICAgICAgICBJbnRSZWN0IGltYWdlU2l6ZSA9IGVuY2xvc2luZ0ludFJlY3QodGlsZVJlY3Qp OwotICAgICAgICBjbGlwcGVkSW1hZ2VTdXJmYWNlID0gYWRvcHRHUmVmKGNhaXJvX2ltYWdlX3N1 cmZhY2VfY3JlYXRlKENBSVJPX0ZPUk1BVF9BUkdCMzIsIGltYWdlU2l6ZS53aWR0aCgpLCBpbWFn ZVNpemUuaGVpZ2h0KCkpKTsKLSAgICAgICAgR1JlZlB0cjxjYWlyb190PiBjbGlwcGVkSW1hZ2VD b250ZXh0KGNhaXJvX2NyZWF0ZShjbGlwcGVkSW1hZ2VTdXJmYWNlLmdldCgpKSk7CisgICAgICAg IGNsaXBwZWRJbWFnZVN1cmZhY2UgPSBhZG9wdFJlZihjYWlyb19pbWFnZV9zdXJmYWNlX2NyZWF0 ZShDQUlST19GT1JNQVRfQVJHQjMyLCBpbWFnZVNpemUud2lkdGgoKSwgaW1hZ2VTaXplLmhlaWdo dCgpKSk7CisgICAgICAgIFJlZlB0cjxjYWlyb190PiBjbGlwcGVkSW1hZ2VDb250ZXh0KGNhaXJv X2NyZWF0ZShjbGlwcGVkSW1hZ2VTdXJmYWNlLmdldCgpKSk7CiAgICAgICAgIGNhaXJvX3NldF9z b3VyY2Vfc3VyZmFjZShjbGlwcGVkSW1hZ2VDb250ZXh0LmdldCgpLCBpbWFnZSwgLXRpbGVSZWN0 LngoKSwgLXRpbGVSZWN0LnkoKSk7CiAgICAgICAgIGNhaXJvX3BhaW50KGNsaXBwZWRJbWFnZUNv bnRleHQuZ2V0KCkpOwogICAgICAgICBpbWFnZSA9IGNsaXBwZWRJbWFnZVN1cmZhY2UuZ2V0KCk7 CkluZGV4OiBSZWZQdHJDYWlyby5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFJlZlB0ckNhaXJvLmgJKHJldmlz aW9uIDApCisrKyBSZWZQdHJDYWlyby5oCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDU2IEBACisv KgorICogIENvcHlyaWdodCAoQykgMjAxMCBCcmVudCBGdWxnaGFtIDxiZnVsZ2hhbUB3ZWJraXQu b3JnPi4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqCisgKiAgVGhpcyBsaWJyYXJ5IGlzIGZyZWUg c29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vcgorICogIG1vZGlmeSBpdCB1 bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBMaWJyYXJ5IEdlbmVyYWwgUHVibGljCisgKiAgTGlj ZW5zZSBhcyBwdWJsaXNoZWQgYnkgdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbjsgZWl0aGVy CisgKiAgdmVyc2lvbiAyIG9mIHRoZSBMaWNlbnNlLCBvciAoYXQgeW91ciBvcHRpb24pIGFueSBs YXRlciB2ZXJzaW9uLgorICoKKyAqICBUaGlzIGxpYnJhcnkgaXMgZGlzdHJpYnV0ZWQgaW4gdGhl IGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwKKyAqICBidXQgV0lUSE9VVCBBTlkgV0FSUkFO VFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBvZgorICogIE1FUkNIQU5UQUJJ TElUWSBvciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUgR05VCisg KiAgTGlicmFyeSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuCisgKgor ICogIFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkgb2YgdGhlIEdOVSBMaWJyYXJ5IEdl bmVyYWwgUHVibGljIExpY2Vuc2UKKyAqICBhbG9uZyB3aXRoIHRoaXMgbGlicmFyeTsgc2VlIHRo ZSBmaWxlIENPUFlJTkcuTElCLiAgSWYgbm90LCB3cml0ZSB0bworICogIHRoZSBGcmVlIFNvZnR3 YXJlIEZvdW5kYXRpb24sIEluYy4sIDUxIEZyYW5rbGluIFN0cmVldCwgRmlmdGggRmxvb3IsCisg KiAgQm9zdG9uLCBNQSAwMjExMC0xMzAxLCBVU0EuCisgKgorICovCisjaWZuZGVmIFJlZlB0ckNh aXJvX2gKKyNkZWZpbmUgUmVmUHRyQ2Fpcm9faAorCisjaW5jbHVkZSA8d3RmL1JlZlB0ci5oPgor Cit0eXBlZGVmIHN0cnVjdCBfY2Fpcm8gY2Fpcm9fdDsKK3R5cGVkZWYgc3RydWN0IF9jYWlyb19z dXJmYWNlIGNhaXJvX3N1cmZhY2VfdDsKKworbmFtZXNwYWNlIFdURiB7CisKKyAgIHRlbXBsYXRl PD4gQUxXQVlTX0lOTElORSB2b2lkIHJlZklmTm90TnVsbChjYWlyb190KiBwdHIpCisgICB7Cisg ICAgICBpZiAoVU5MSUtFTFkocHRyICE9IDApKQorICAgICAgICAgY2Fpcm9fcmVmZXJlbmNlKHB0 cik7CisgICB9CisKKyAgIHRlbXBsYXRlPD4gQUxXQVlTX0lOTElORSB2b2lkIGRlcmVmSWZOb3RO dWxsKGNhaXJvX3QqIHB0cikKKyAgIHsKKyAgICAgIGlmIChVTkxJS0VMWShwdHIgIT0gMCkpCisg ICAgICAgICBjYWlyb19kZXN0cm95KHB0cik7CisgICB9CisKKyAgIHRlbXBsYXRlPD4gQUxXQVlT X0lOTElORSB2b2lkIHJlZklmTm90TnVsbChjYWlyb19zdXJmYWNlX3QqIHB0cikKKyAgIHsKKyAg ICAgIGlmIChVTkxJS0VMWShwdHIgIT0gMCkpCisgICAgICAgICBjYWlyb19zdXJmYWNlX3JlZmVy ZW5jZShwdHIpOworICAgfQorCisgICB0ZW1wbGF0ZTw+IEFMV0FZU19JTkxJTkUgdm9pZCBkZXJl ZklmTm90TnVsbChjYWlyb19zdXJmYWNlX3QqIHB0cikKKyAgIHsKKyAgICAgIGlmIChVTkxJS0VM WShwdHIgIT0gMCkpCisgICAgICAgICBjYWlyb19zdXJmYWNlX2Rlc3Ryb3kocHRyKTsKKyAgIH0K K30KKworI2VuZGlmCisK