44553 2010-08-24 14:42:00 -0700 speed up new-run-webkit-tests unit tests 2010-08-24 16:45:40 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth cjerdonek eric levin ojan tony oldest_to_newest 268806 0 dpranke 2010-08-24 14:42:00 -0700 speed up new-run-webkit-tests unit tests 268811 1 65327 dpranke 2010-08-24 14:44:17 -0700 Created attachment 65327 Patch 268860 2 65327 eric 2010-08-24 15:36:52 -0700 Comment on attachment 65327 Patch Looks good. I think the behavior of trying to pull down json results from the bots is broken. At least for non-chromium ports it makes no sense. 268871 3 ojan 2010-08-24 15:48:08 -0700 (In reply to comment #2) > I think the behavior of trying to pull down json results from the bots is broken. At least for non-chromium ports it makes no sense. I disagree. We're moving the storing of JSON results over to test-results.appspot.com. So we should be able to do it just as well for the non-chromium ports, which will mean that http://test-results.appspot.com/dashboards/flakiness_dashboard.html can be made to work for all ports. In either case, this patch look good. 268895 4 dpranke 2010-08-24 16:45:40 -0700 Committed r65949: <http://trac.webkit.org/changeset/65949> 65327 2010-08-24 14:44:17 -0700 2010-08-24 15:36:52 -0700 Patch bug-44553-20100824144415.patch text/plain 6261 dpranke ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAwMTc3ZDM0M2U1YzhlNGU4MGFjYTAwNTkzNzc3Y2MyY2I5NDZkMzFkLi40ZjM3NjA1 NWY2ZjFhMDQ2YTRiNzhiZThiZmYyZjFmYjgxYmE0YjY5IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAK KzIwMTAtMDgtMjQgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgc3BlZWQgdXAgbmV3LXJ1 bi13ZWJraXQtdGVzdHMgdW5pdCB0ZXN0cworCisgICAgICAgIEFkZCBhIC0tbm8tcmVjb3JkLXJl c3VsdHMgZmxhZyB0aGF0IHR1cm5zIG9mZiBnZW5lcmF0aW5nIHRoZSBKU09OCisgICAgICAgIHJl c3VsdHMgZmlsZSBvbiBldmVyeSB0ZXN0IHJ1bi4gR2VuZXJhdGluZyB0aGUgZmlsZSByZXF1aXJl cyB1cyB0bworICAgICAgICBmZXRjaCB0aGUgb2xkIHJlc3VsdHMgZG93biBmcm9tIHRoZSBib3Rz LCB3aGljaCBjYW4gYmUgc2xvdy4gVGhpcworICAgICAgICBmbGFnIGlzIG9mZiBieSBkZWZhdWx0 LgorICAgIAorICAgICAgICBSZWR1Y2UgdGhlIHNsZWVwIHRpbWUgaW4gd2FpdF9mb3JfdGhyZWFk c190b19maW5pc2ggZnJvbSAwLjFzIHRvIDAuMDFzLgorICAgIAorICAgICAgICBUaGVzZSBjaGFu Z2VzIHRvZ2V0aGVyIHNob3J0ZW4gdGhlIHRlc3QgY3ljbGUgZnJvbSB+NC41cyB0byB+MS41cwor ICAgICAgICAtIGEgM3ggc3BlZWR1cC4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NDQ1NTMKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0c191bml0dGVzdC5weToKKwogMjAxMC0wOC0y MyAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgR3VzdGF2byBOb3JvbmhhIFNpbHZhLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMv U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weSBiL1dlYktp dFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkK aW5kZXggYjI2YmM2YzY4ODljNGQ3N2ZhY2IyNzg5NmQyYWJkNjM0NjNiMTVlMS4uNzE2M2UxYmM1 NjkxNWQ1NWEwYzQwNjlhZGU5ZGRmY2M5ZGUyYjYxMCAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMv U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQorKysgYi9X ZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3Rz LnB5CkBAIC02ODcsNyArNjg3LDcgQEAgY2xhc3MgVGVzdFJ1bm5lcjoKICAgICAgICAgICAgICAg ICBzZWxmLnVwZGF0ZV9zdW1tYXJ5KHJlc3VsdF9zdW1tYXJ5KQogCiAgICAgICAgICAgICAgICAg aWYgc29tZV90aHJlYWRfaXNfYWxpdmU6Ci0gICAgICAgICAgICAgICAgICAgIHRpbWUuc2xlZXAo MC4xKQorICAgICAgICAgICAgICAgICAgICB0aW1lLnNsZWVwKDAuMDEpCiAKICAgICAgICAgZXhj ZXB0IEtleWJvYXJkSW50ZXJydXB0OgogICAgICAgICAgICAga2V5Ym9hcmRfaW50ZXJydXB0ZWQg PSBUcnVlCkBAIC03NzksMTIgKzc3OSwxMyBAQCBjbGFzcyBUZXN0UnVubmVyOgogICAgICAgICAg ICAgc2VsZi5fZXhwZWN0YXRpb25zLCByZXN1bHRfc3VtbWFyeSwgcmV0cnlfc3VtbWFyeSkKICAg ICAgICAgc2VsZi5fcHJpbnRlci5wcmludF91bmV4cGVjdGVkX3Jlc3VsdHModW5leHBlY3RlZF9y ZXN1bHRzKQogCi0gICAgICAgICMgV3JpdGUgdGhlIHNhbWUgZGF0YSB0byBsb2cgZmlsZXMuCi0g ICAgICAgIHNlbGYuX3dyaXRlX2pzb25fZmlsZXModW5leHBlY3RlZF9yZXN1bHRzLCByZXN1bHRf c3VtbWFyeSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW5kaXZpZHVhbF90ZXN0X3Rp bWluZ3MpCisgICAgICAgIGlmIHNlbGYuX29wdGlvbnMucmVjb3JkX3Jlc3VsdHM6CisgICAgICAg ICAgICAjIFdyaXRlIHRoZSBzYW1lIGRhdGEgdG8gbG9nIGZpbGVzLgorICAgICAgICAgICAgc2Vs Zi5fd3JpdGVfanNvbl9maWxlcyh1bmV4cGVjdGVkX3Jlc3VsdHMsIHJlc3VsdF9zdW1tYXJ5LAor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbmRpdmlkdWFsX3Rlc3RfdGltaW5n cykKIAotICAgICAgICAjIFVwbG9hZCBnZW5lcmF0ZWQgSlNPTiBmaWxlcyB0byBhcHBlbmdpbmUg c2VydmVyLgotICAgICAgICBzZWxmLl91cGxvYWRfanNvbl9maWxlcygpCisgICAgICAgICAgICAj IFVwbG9hZCBnZW5lcmF0ZWQgSlNPTiBmaWxlcyB0byBhcHBlbmdpbmUgc2VydmVyLgorICAgICAg ICAgICAgc2VsZi5fdXBsb2FkX2pzb25fZmlsZXMoKQogCiAgICAgICAgICMgV3JpdGUgdGhlIHN1 bW1hcnkgdG8gZGlzayAocmVzdWx0cy5odG1sKSBhbmQgZGlzcGxheSBpdCBpZiByZXF1ZXN0ZWQu CiAgICAgICAgIHdyb3RlX3Jlc3VsdHMgPSBzZWxmLl93cml0ZV9yZXN1bHRzX2h0bWxfZmlsZShy ZXN1bHRfc3VtbWFyeSkKQEAgLTE1NDUsNiArMTU0Niw5IEBAIGRlZiBwYXJzZV9hcmdzKGFyZ3M9 Tm9uZSk6CiAgICAgICAgICAgICBkZWZhdWx0PUZhbHNlLCBoZWxwPSJDbG9iYmVycyB0ZXN0IHJl c3VsdHMgZnJvbSBwcmV2aW91cyBydW5zLiIpLAogICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlv bigiLS1wbGF0Zm9ybSIsCiAgICAgICAgICAgICBoZWxwPSJPdmVycmlkZSB0aGUgcGxhdGZvcm0g Zm9yIGV4cGVjdGVkIHJlc3VsdHMiKSwKKyAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRpb24oIi0t bm8tcmVjb3JkLXJlc3VsdHMiLCBhY3Rpb249InN0b3JlX2ZhbHNlIiwKKyAgICAgICAgICAgIGRl ZmF1bHQ9VHJ1ZSwgZGVzdD0icmVjb3JkX3Jlc3VsdHMiLAorICAgICAgICAgICAgaGVscD0iRG9u J3QgcmVjb3JkIHRoZSByZXN1bHRzLiIpLAogICAgICAgICAjIG9sZC1ydW4td2Via2l0LXRlc3Rz IGFsc28gaGFzIEhUVFAgdG9nZ2xlIG9wdGlvbnM6CiAgICAgICAgICMgLS1bbm8tXWh0dHAgICAg ICAgICAgICAgICAgICAgICBSdW4gKG9yIGRvIG5vdCBydW4pIGh0dHAgdGVzdHMKICAgICAgICAg IyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChkZWZhdWx0OiBydW4pCmRpZmYgLS1n aXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0 X3Rlc3RzX3VuaXR0ZXN0LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcnVuX3dlYmtpdF90ZXN0c191bml0dGVzdC5weQppbmRleCBlMWIzNzQ2M2U5NmVlMjFm MTAzMGQ5ZDAwZDY1YjkwMmVlZGY1MDE4Li5hZGJhMWZmZjUwOTQzNGNjY2UzMmIxZjY0ZDEwOTgy ZThjNzMwYTY0IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzX3VuaXR0ZXN0LnB5CisrKyBiL1dlYktpdFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHNfdW5pdHRlc3QucHkK QEAgLTQ4LDkgKzQ4LDEwIEBAIGZyb20gd2Via2l0cHkubGF5b3V0X3Rlc3RzLmxheW91dF9wYWNr YWdlIGltcG9ydCBkdW1wX3JlbmRlcl90cmVlX3RocmVhZAogZnJvbSB3ZWJraXRweS50aGlyZHBh cnR5Lm1vY2sgaW1wb3J0IE1vY2sKIAogCi1kZWYgcGFzc2luZ19ydW4oYXJncywgcG9ydF9vYmo9 Tm9uZSwgbG9nZ2luZ19pbmNsdWRlZD1GYWxzZSk6Ci0gICAgaWYgbm90IGxvZ2dpbmdfaW5jbHVk ZWQ6Ci0gICAgICAgIGFyZ3MuZXh0ZW5kKFsnLS1wcmludCcsICdub3RoaW5nJ10pCitkZWYgcGFz c2luZ19ydW4oYXJncywgcG9ydF9vYmo9Tm9uZSwgcmVjb3JkX3Jlc3VsdHM9RmFsc2UpOgorICAg IGFyZ3MuZXh0ZW5kKFsnLS1wcmludCcsICdub3RoaW5nJ10pCisgICAgaWYgbm90IHJlY29yZF9y ZXN1bHRzOgorICAgICAgICBhcmdzLmFwcGVuZCgnLS1uby1yZWNvcmQtcmVzdWx0cycpCiAgICAg b3B0aW9ucywgYXJncyA9IHJ1bl93ZWJraXRfdGVzdHMucGFyc2VfYXJncyhhcmdzKQogICAgIGlm IHBvcnRfb2JqIGlzIE5vbmU6CiAgICAgICAgIHBvcnRfb2JqID0gcG9ydC5nZXQob3B0aW9ucy5w bGF0Zm9ybSwgb3B0aW9ucykKQEAgLTU4LDYgKzU5LDcgQEAgZGVmIHBhc3NpbmdfcnVuKGFyZ3Ms IHBvcnRfb2JqPU5vbmUsIGxvZ2dpbmdfaW5jbHVkZWQ9RmFsc2UpOgogICAgIHJldHVybiByZXMg PT0gMAogCiBkZWYgbG9nZ2luZ19ydW4oYXJncyk6CisgICAgYXJncy5leHRlbmQoWyctLW5vLXJl Y29yZC1yZXN1bHRzJ10pCiAgICAgb3B0aW9ucywgYXJncyA9IHJ1bl93ZWJraXRfdGVzdHMucGFy c2VfYXJncyhhcmdzKQogICAgIHBvcnRfb2JqID0gcG9ydC5nZXQob3B0aW9ucy5wbGF0Zm9ybSwg b3B0aW9ucykKICAgICBidWlsZGJvdF9vdXRwdXQgPSBhcnJheV9zdHJlYW0uQXJyYXlTdHJlYW0o KQpAQCAtNzQsMTcgKzc2LDE1IEBAIGNsYXNzIE1haW5UZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToK ICAgICAgICAgc2VsZi5hc3NlcnRUcnVlKHBhc3NpbmdfcnVuKFsnLS1wbGF0Zm9ybScsICd0ZXN0 JywgJy0tcnVuLXNpbmdseSddKSkKICAgICAgICAgc2VsZi5hc3NlcnRUcnVlKHBhc3NpbmdfcnVu KFsnLS1wbGF0Zm9ybScsICd0ZXN0JywKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAndGV4dC9hcnRpY2xlLWVsZW1lbnQuaHRtbCddKSkKLSAgICAgICAgc2VsZi5hc3NlcnRU cnVlKHBhc3NpbmdfcnVuKFsnLS1wbGF0Zm9ybScsICd0ZXN0JywKLSAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICctLWNoaWxkLXByb2Nlc3NlcycsICcxJywKLSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAnLS1wcmludCcsICd1bmV4cGVjdGVkJ10pKQogCi0g ICAgZGVmIHRlc3RfY2hpbGRfcHJvY2Vzc2VzKHNlbGYpOgorICAgIGRlZiB0ZXN0X29uZV9jaGls ZF9wcm9jZXNzKHNlbGYpOgogICAgICAgICAocmVzLCBidWlsZGJvdF9vdXRwdXQsIHJlZ3VsYXJf b3V0cHV0KSA9IGxvZ2dpbmdfcnVuKAogICAgICAgICAgICAgIFsnLS1wbGF0Zm9ybScsICd0ZXN0 JywgJy0tcHJpbnQnLCAnY29uZmlnJywgJy0tY2hpbGQtcHJvY2Vzc2VzJywKICAgICAgICAgICAg ICAgJzEnXSkKICAgICAgICAgc2VsZi5hc3NlcnRUcnVlKCdSdW5uaW5nIG9uZSBEdW1wUmVuZGVy VHJlZVxuJwogICAgICAgICAgICAgICAgICAgICAgICAgaW4gcmVndWxhcl9vdXRwdXQuZ2V0KCkp CiAKKyAgICBkZWYgdGVzdF90d29fY2hpbGRfcHJvY2Vzc2VzKHNlbGYpOgogICAgICAgICAocmVz LCBidWlsZGJvdF9vdXRwdXQsIHJlZ3VsYXJfb3V0cHV0KSA9IGxvZ2dpbmdfcnVuKAogICAgICAg ICAgICAgIFsnLS1wbGF0Zm9ybScsICd0ZXN0JywgJy0tcHJpbnQnLCAnY29uZmlnJywgJy0tY2hp bGQtcHJvY2Vzc2VzJywKICAgICAgICAgICAgICAgJzInXSkKQEAgLTkyLDE0ICs5MiwxMyBAQCBj bGFzcyBNYWluVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgICAgICAgICAgICAgICAgICAg ICBpbiByZWd1bGFyX291dHB1dC5nZXQoKSkKIAogICAgIGRlZiB0ZXN0X2xhc3RfcmVzdWx0cyhz ZWxmKToKLSAgICAgICAgcGFzc2luZ19ydW4oWyctLXBsYXRmb3JtJywgJ3Rlc3QnXSkKKyAgICAg ICAgcGFzc2luZ19ydW4oWyctLXBsYXRmb3JtJywgJ3Rlc3QnXSwgcmVjb3JkX3Jlc3VsdHM9VHJ1 ZSkKICAgICAgICAgKHJlcywgYnVpbGRib3Rfb3V0cHV0LCByZWd1bGFyX291dHB1dCkgPSBsb2dn aW5nX3J1bigKICAgICAgICAgICAgIFsnLS1wbGF0Zm9ybScsICd0ZXN0JywgJy0tcHJpbnQtbGFz dC1mYWlsdXJlcyddKQogICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHJlZ3VsYXJfb3V0cHV0Lmdl dCgpLCBbJ1xuXG4nXSkKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChidWlsZGJvdF9vdXRwdXQu Z2V0KCksIFtdKQogCiAKLQogZGVmIF9tb2NrZWRfb3BlbihvcmlnaW5hbF9vcGVuLCBmaWxlX2xp c3QpOgogICAgIGRlZiBfd3JhcHBlcihuYW1lLCBtb2RlLCBlbmNvZGluZyk6CiAgICAgICAgIGlm IG5hbWUuZmluZCgiLWV4cGVjdGVkLiIpICE9IC0xIGFuZCBtb2RlID09ICJ3IjoK