44550 2010-08-24 14:11:46 -0700 [CHROMIUM] Failing layout tests on Chromium/Linux 2010-08-24 14:54:00 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 senorblanco senorblanco dumi jamesr kbr oldest_to_newest 268783 0 senorblanco 2010-08-24 14:11:46 -0700 LayoutTests/fast/canvas/arc-crash.html = CRASH LayoutTests/fast/canvas/canvas-state-intact-after-putImageData.html = CRASH LayoutTests/fast/canvas/toDataURL-supportedTypes.html = CRASH 268794 1 65324 senorblanco 2010-08-24 14:24:23 -0700 Created attachment 65324 Patch 268799 2 jamesr 2010-08-24 14:32:39 -0700 Fix looks correct and needed in general. I'm pretty curious why we can't repro this locally. 268802 3 65324 dumi 2010-08-24 14:34:56 -0700 Comment on attachment 65324 Patch rs=me. 268826 4 senorblanco 2010-08-24 14:52:16 -0700 Committed r65938: <http://trac.webkit.org/changeset/65938> 268829 5 senorblanco 2010-08-24 14:54:00 -0700 BTW, I did manage to repro, in the end, and confirmed that this fix ameliorates the crashes. Just had to run all the tests, instead of just the failing ones. 65324 2010-08-24 14:24:23 -0700 2010-08-24 14:34:55 -0700 Patch bug-44550-20100824172421.patch text/plain 1428 senorblanco SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NTkzNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDgtMjQgIFN0ZXBoZW4gV2hpdGUgIDxzZW5vcmJsYW5jb0Bj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgU3BlY3VsYXRpdmUgZml4IGZvciBsYXlvdXQgdGVzdCBmYWlsdXJlcyBvbiBDaHJvbWUv TGludXguCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 NDU1MAorCisgICAgICAgIFRlc3RzIGZhc3QvY2FudmFzL2FyYy1jcmFzaC5odG1sLCBmYXN0L2Nh bnZhcy9jYW52YXMtc3RhdGUtaW50YWN0LWFmdGVyLXB1dEltYWdlRGF0YS5odG1sLCBhbmQgZmFz dC9jYW52YXMvdG9EYXRhVVJMLXN1cHBvcnRlZFR5cGVzLmh0bWwgYXJlIGZhaWxpbmcgb24gQ2hy b21lL0xpbnV4LiAgQ2FuJ3QgcmVwcm8gdGhlIGZhaWx1cmUgbG9jYWxseSwgYnV0IHRoaXMgZml4 IGNhbid0IGh1cnQuCisKKyAgICAgICAgKiBodG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250 ZXh0MkQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2FudmFzUmVuZGVyaW5nQ29udGV4dDJEOjpw YWludFJlbmRlcmluZ1Jlc3VsdHNUb0NhbnZhcyk6CisKIDIwMTAtMDgtMjQgIFNpbW9uIEZyYXNl ciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgVG9ueSBD aGFuZy4KSW5kZXg6IFdlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJE LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0Nv bnRleHQyRC5jcHAJKHJldmlzaW9uIDY1OTM0KQorKysgV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52 YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xODc0LDcgKzE4NzQs OCBAQCBjb25zdCBGb250JiBDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6OmFjCiB2b2lkIENhbnZh c1JlbmRlcmluZ0NvbnRleHQyRDo6cGFpbnRSZW5kZXJpbmdSZXN1bHRzVG9DYW52YXMoKQogewog I2lmIEVOQUJMRShBQ0NFTEVSQVRFRF8yRF9DQU5WQVMpCi0gICAgZHJhd2luZ0NvbnRleHQoKS0+ c3luY1NvZnR3YXJlQ2FudmFzKCk7CisgICAgaWYgKEdyYXBoaWNzQ29udGV4dCogYyA9IGRyYXdp bmdDb250ZXh0KCkpCisgICAgICAgIGMtPnN5bmNTb2Z0d2FyZUNhbnZhcygpOwogI2VuZGlmCiB9 CiAK