44549 2010-08-24 13:53:17 -0700 crash when rendering scrollbar gradient 2010-08-26 14:32:03 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tony tony commit-queue hyatt oldest_to_newest 268769 0 tony 2010-08-24 13:53:17 -0700 crash when rendering scrollbar gradient 268772 1 65316 tony 2010-08-24 13:55:17 -0700 Created attachment 65316 Patch 268774 2 65317 tony 2010-08-24 13:55:56 -0700 Created attachment 65317 test case 268775 3 tony 2010-08-24 13:58:40 -0700 Hyatt, can you review this? The test case crashes Chrome and Safari Win. It doesn't crash on Safari Mac, I think because on Safari Mac, the main scrollbars can't be styled. 269967 4 65316 hyatt 2010-08-26 11:11:59 -0700 Comment on attachment 65316 Patch r=me 270039 5 65316 commit-queue 2010-08-26 12:39:24 -0700 Comment on attachment 65316 Patch Rejecting patch 65316 from commit-queue. Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1 Last 500 characters of output: Core/ChangeLog M WebCore/css/CSSImageGeneratorValue.cpp A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output: The following files contain tab characters: trunk/LayoutTests/scrollbars/scrollbar-gradient-crash.html Please use spaces instead to indent. If you must commit a file with tabs, use svn propset to set the "allow-tabs" property. at /usr/local/git/libexec/git-core/git-svn line 572 Full output: http://queues.webkit.org/results/3732627 270117 6 tony 2010-08-26 14:31:50 -0700 http://trac.webkit.org/changeset/66133 65316 2010-08-24 13:55:17 -0700 2010-08-26 14:32:03 -0700 Patch bug-44549-20100824135515.patch text/plain 3507 tony ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyYWI5OTg0N2IxOWE3OTZkYjE3MjQ3MGI4YTIxMTg1ZjE4YjE4OWFjLi5jNmEzYTVk NzYzNzY4ZGFjZDMyODY0MmIzNmUyYzNjMTg1OGY5ZmNkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMDgtMjQgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBjcmFzaCB3aGVuIHJlbmRlcmlu ZyBzY3JvbGxiYXIgZ3JhZGllbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTQ0NTQ5CisKKyAgICAgICAgKiBzY3JvbGxiYXJzL3Njcm9sbGJhci1ncmFk aWVudC1jcmFzaC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHNjcm9sbGJhcnMvc2Ny b2xsYmFyLWdyYWRpZW50LWNyYXNoLmh0bWw6IEFkZGVkLgorCiAyMDEwLTA4LTI0ICBTaW1vbiBG cmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNh bSBXZWluaWcuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zY3JvbGxiYXJzL3Njcm9sbGJhci1n cmFkaWVudC1jcmFzaC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9zY3JvbGxiYXJzL3Njcm9s bGJhci1ncmFkaWVudC1jcmFzaC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNjU0ZGRmN2YxN2Vm YWI1OGU0MmZhYmUzODUyNTc5NjRhZTJjNWQ0MQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRl c3RzL3Njcm9sbGJhcnMvc2Nyb2xsYmFyLWdyYWRpZW50LWNyYXNoLWV4cGVjdGVkLnR4dApAQCAt MCwwICsxIEBACitUaGlzIHRlc3QgcGFzc2VzIGlmIGl0IGRvZXMgbm90IGNyYXNoLgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvc2Nyb2xsYmFycy9zY3JvbGxiYXItZ3JhZGllbnQtY3Jhc2guaHRt bCBiL0xheW91dFRlc3RzL3Njcm9sbGJhcnMvc2Nyb2xsYmFyLWdyYWRpZW50LWNyYXNoLmh0bWwK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMC4uYWRjOGQzMTljNWRlMmM5YThkZjI4OTgwMWRlZTQ1ZjIxZmJhMDQ0YwotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3Njcm9sbGJhcnMvc2Nyb2xsYmFyLWdyYWRpZW50 LWNyYXNoLmh0bWwKQEAgLTAsMCArMSwzMCBAQAorPHN0eWxlIHR5cGU9InRleHQvY3NzIj4KKzo6 LXdlYmtpdC1zY3JvbGxiYXIgeworCXdpZHRoOiAwLjhlbTsKKwloZWlnaHQ6IDAuOGVtOworfQor Ojotd2Via2l0LXNjcm9sbGJhci10aHVtYiB7CisJYmFja2dyb3VuZDogIzY2NiAtd2Via2l0LWdy YWRpZW50KGxpbmVhciwgbGVmdCB0b3AsIHJpZ2h0IHRvcCwgZnJvbShyZ2JhKDI1NSwyNTUsMjU1 LDAuNSkpLCBjb2xvci1zdG9wKDAuNSwgcmdiYSgyNTUsMjU1LDI1NSwwLjEpKSwgY29sb3Itc3Rv cCgwLjUsIHJnYmEoMCwwLDAsMCkpLCB0byhyZ2JhKDAsMCwwLDAuMDEpKSk7Cit9Cis8L3N0eWxl PgorCis8Ym9keT4KKzxzY3JpcHQ+CitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQor ICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKworZnVuY3Rpb24gdGVzdCgp Cit7CisgICAgLy8gRm9yY2UgYSBsYXlvdXQuCisgICAgd2luZG93LnggPSBkb2N1bWVudC5ib2R5 Lm9mZnNldFRvcDsKKworICAgIHZhciBzdHlsZXMgPSBkb2N1bWVudC5nZXRFbGVtZW50c0J5VGFn TmFtZSgic3R5bGUiKTsKKyAgICBmb3IgKHZhciBpID0gMDsgaSA8IHN0eWxlcy5sZW5ndGg7ICsr aSkKKyAgICAgICAgZG9jdW1lbnQuaGVhZC5hcHBlbmRDaGlsZChzdHlsZXNbaV0pOworfQorZG9j dW1lbnQuYWRkRXZlbnRMaXN0ZW5lcignRE9NQ29udGVudExvYWRlZCcsIHRlc3QsIGZhbHNlKTsK Kzwvc2NyaXB0PgorPGRpdiBzdHlsZT0iaGVpZ2h0OiAxMDAwcHg7Ij4KK1RoaXMgdGVzdCBwYXNz ZXMgaWYgaXQgZG9lcyBub3QgY3Jhc2guCis8L2Rpdj4KKzwvYm9keT4KZGlmZiAtLWdpdCBhL1dl YkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjFiOTExNjRlYWU1YmQ0 NTJiY2U4N2Q0YjhkZGQyMWU2YWViZjBhZS4uYmFkZDgwZjVmOGM1YTNhZDgyYWZkOTQzYWZkZjli ZGVmM2NiYTM3MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wOC0yNCAgVG9ueSBDaGFuZyAgPHRvbnlA Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIGNyYXNoIHdoZW4gcmVuZGVyaW5nIHNjcm9sbGJhciBncmFkaWVudAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDQ1NDkKKworICAgICAgICBU ZXN0OiBzY3JvbGxiYXJzL3Njcm9sbGJhci1ncmFkaWVudC1jcmFzaC5odG1sCisKKyAgICAgICAg KiBjc3MvQ1NTSW1hZ2VHZW5lcmF0b3JWYWx1ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NJ bWFnZUdlbmVyYXRvclZhbHVlOjpnZXRJbWFnZSk6IEtlZXAgdGhpcyBhbGl2ZS4KKwogMjAxMC0w OC0yNCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9jc3MvQ1NTSW1hZ2VHZW5lcmF0 b3JWYWx1ZS5jcHAgYi9XZWJDb3JlL2Nzcy9DU1NJbWFnZUdlbmVyYXRvclZhbHVlLmNwcAppbmRl eCA0Y2YwODczYWQ0ZWYwOGJlYWNhNjYzOTkxZTQ2MmYwOTY1YTQwM2UyLi43ODRmNDM4ZDBiNDJh Y2U5OWNmYTIxMzdjYWEwMzcwYWY3MDMyODQ2IDEwMDY0NAotLS0gYS9XZWJDb3JlL2Nzcy9DU1NJ bWFnZUdlbmVyYXRvclZhbHVlLmNwcAorKysgYi9XZWJDb3JlL2Nzcy9DU1NJbWFnZUdlbmVyYXRv clZhbHVlLmNwcApAQCAtODYsNiArODYsOCBAQCBJbWFnZSogQ1NTSW1hZ2VHZW5lcmF0b3JWYWx1 ZTo6Z2V0SW1hZ2UoUmVuZGVyT2JqZWN0KiByZW5kZXJlciwgY29uc3QgSW50U2l6ZSYgcwogICAg IFNpemVDb3VudFBhaXImIHNpemVDb3VudCA9IGl0LT5zZWNvbmQ7CiAgICAgSW50U2l6ZSBvbGRT aXplID0gc2l6ZUNvdW50LmZpcnN0OwogICAgIGlmIChvbGRTaXplICE9IHNpemUpIHsKKyAgICAg ICAgLy8gSWYgcmVuZGVyZXIgaXMgdGhlIG9ubHkgY2xpZW50LCBtYWtlIHN1cmUgd2UgZG9uJ3Qg ZGVsZXRlIHRoaXMuCisgICAgICAgIFJlZlB0cjxDU1NJbWFnZUdlbmVyYXRvclZhbHVlPiBwcm90 ZWN0KHRoaXMpOwogICAgICAgICByZW1vdmVDbGllbnQocmVuZGVyZXIpOwogICAgICAgICBhZGRD bGllbnQocmVuZGVyZXIsIHNpemUpOwogICAgIH0K 65317 2010-08-24 13:55:56 -0700 2010-08-24 13:55:56 -0700 test case scrollbar-gradient-crash.html text/html 781 tony PHN0eWxlIHR5cGU9InRleHQvY3NzIj4KOjotd2Via2l0LXNjcm9sbGJhciB7Cgl3aWR0aDogMC44 ZW07CgloZWlnaHQ6IDAuOGVtOwp9Cjo6LXdlYmtpdC1zY3JvbGxiYXItdGh1bWIgewoJYmFja2dy b3VuZDogIzY2NiAtd2Via2l0LWdyYWRpZW50KGxpbmVhciwgbGVmdCB0b3AsIHJpZ2h0IHRvcCwg ZnJvbShyZ2JhKDI1NSwyNTUsMjU1LDAuNSkpLCBjb2xvci1zdG9wKDAuNSwgcmdiYSgyNTUsMjU1 LDI1NSwwLjEpKSwgY29sb3Itc3RvcCgwLjUsIHJnYmEoMCwwLDAsMCkpLCB0byhyZ2JhKDAsMCww LDAuMDEpKSk7Cn0KPC9zdHlsZT4KCjxib2R5Pgo8c2NyaXB0PgppZiAod2luZG93LmxheW91dFRl c3RDb250cm9sbGVyKQogICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOwoKZnVu Y3Rpb24gdGVzdCgpCnsKICAgIC8vIEZvcmNlIGEgbGF5b3V0LgogICAgd2luZG93LnggPSBkb2N1 bWVudC5ib2R5Lm9mZnNldFRvcDsKCiAgICB2YXIgc3R5bGVzID0gZG9jdW1lbnQuZ2V0RWxlbWVu dHNCeVRhZ05hbWUoInN0eWxlIik7CiAgICBmb3IgKHZhciBpID0gMDsgaSA8IHN0eWxlcy5sZW5n dGg7ICsraSkKICAgICAgICBkb2N1bWVudC5oZWFkLmFwcGVuZENoaWxkKHN0eWxlc1tpXSk7Cn0K ZG9jdW1lbnQuYWRkRXZlbnRMaXN0ZW5lcignRE9NQ29udGVudExvYWRlZCcsIHRlc3QsIGZhbHNl KTsKPC9zY3JpcHQ+CjxkaXYgc3R5bGU9ImhlaWdodDogMTAwMHB4OyI+ClRoaXMgdGVzdCBwYXNz ZXMgaWYgaXQgZG9lcyBub3QgY3Jhc2guCjwvZGl2Pgo8L2JvZHk+Cg==