44545 2010-08-24 12:54:22 -0700 [PATCH] Assert that WebKit chromium is not re-initialized 2010-08-25 04:53:00 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC All RESOLVED FIXED P2 Minor --- 0 phajdan.jr webkit-unassigned commit-queue oldest_to_newest 268729 0 phajdan.jr 2010-08-24 12:54:22 -0700 We should assert that WebKit chromium is not re-initialized to prevent crashes like these: http://code.google.com/p/chromium/issues/detail?id=52731 http://code.google.com/p/chromium/issues/detail?id=52643 Please note: the attached patch can not be committed yet, because it will break the chromium tree. I'm just submiting early to get the review done. I will update this bug when the chromium tree is ready to land this patch. 268730 1 65309 phajdan.jr 2010-08-24 12:55:16 -0700 Created attachment 65309 assertion.patch Not ready for commit yet, would break the chromium tree if rolled in. 268731 2 65309 fishd 2010-08-24 12:56:59 -0700 Comment on attachment 65309 assertion.patch WebKit/chromium/ChangeLog:5 + Add an assertion to prevent re-initializing WebKit. please add a link here to the webkit bug for this change otherwise, LGTM 268732 3 65310 phajdan.jr 2010-08-24 12:59:31 -0700 Created attachment 65310 assertion.patch Fixed review comment. Still not ready for commit. 269157 4 65310 commit-queue 2010-08-25 04:52:55 -0700 Comment on attachment 65310 assertion.patch Clearing flags on attachment: 65310 Committed r66006: <http://trac.webkit.org/changeset/66006> 269158 5 commit-queue 2010-08-25 04:53:00 -0700 All reviewed patches have been landed. Closing bug. 65309 2010-08-24 12:55:16 -0700 2010-08-24 12:59:31 -0700 assertion.patch patch text/plain 1413 phajdan.jr SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjU5MjMpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDgtMjQgIFBhd2Vs IEhhamRhbiAgPHBoYWpkYW4uanJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhbiBhc3NlcnRpb24gdG8gcHJldmVudCBy ZS1pbml0aWFsaXppbmcgV2ViS2l0LgorICAgICAgICAKKyAgICAgICAgVGhpcyB3aWxsIGhlbHAg cHJldmVudCBjcmFzaGVzIGxpa2U6CisgICAgICAgIC0gaHR0cDovL2NvZGUuZ29vZ2xlLmNvbS9w L2Nocm9taXVtL2lzc3Vlcy9kZXRhaWw/aWQ9NTI3MzEKKyAgICAgICAgLSBodHRwOi8vY29kZS5n b29nbGUuY29tL3AvY2hyb21pdW0vaXNzdWVzL2RldGFpbD9pZD01MjY0MworCisgICAgICAgICog c3JjL1dlYktpdC5jcHA6CisgICAgICAgIChXZWJLaXQ6OmluaXRpYWxpemUpOgorCiAyMDEwLTA4 LTI0ICBNYXJjdXMgQnVsYWNoICA8YnVsYWNoQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBKZXJlbXkgT3Jsb3cuCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYktpdC5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJLaXQuY3BwCShyZXZpc2lv biA2NTkxNSkKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViS2l0LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNDYsMTEgKzQ2LDE4IEBACiAKIG5hbWVzcGFjZSBXZWJLaXQgewogCisvLyBNYWtlIHN1 cmUgd2UgYXJlIG5vdCByZS1pbml0aWFsaXplZCBpbiB0aGUgc2FtZSBhZGRyZXNzIHNwYWNlLgor Ly8gRG9pbmcgc28gbWF5IGNhdXNlIGhhcmQgdG8gcmVwcm9kdWNlIGNyYXNoZXMuCitzdGF0aWMg Ym9vbCBzX3dlYktpdEluaXRpYWxpemVkID0gZmFsc2U7CisKIHN0YXRpYyBXZWJLaXRDbGllbnQq IHNfd2ViS2l0Q2xpZW50ID0gMDsKIHN0YXRpYyBib29sIHNfbGF5b3V0VGVzdE1vZGUgPSBmYWxz ZTsKIAogdm9pZCBpbml0aWFsaXplKFdlYktpdENsaWVudCogd2ViS2l0Q2xpZW50KQogeworICAg IEFTU0VSVCghc193ZWJLaXRJbml0aWFsaXplZCk7CisgICAgc193ZWJLaXRJbml0aWFsaXplZCA9 IHRydWU7CisKICAgICBBU1NFUlQod2ViS2l0Q2xpZW50KTsKICAgICBBU1NFUlQoIXNfd2ViS2l0 Q2xpZW50KTsKICAgICBzX3dlYktpdENsaWVudCA9IHdlYktpdENsaWVudDsK 65310 2010-08-24 12:59:31 -0700 2010-08-25 04:52:55 -0700 assertion.patch patch text/plain 1468 phajdan.jr SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjU5MjMpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDgtMjQgIFBhd2Vs IEhhamRhbiAgPHBoYWpkYW4uanJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhbiBhc3NlcnRpb24gdG8gcHJldmVudCBy ZS1pbml0aWFsaXppbmcgV2ViS2l0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDQ1NDUKKyAgICAgICAgCisgICAgICAgIFRoaXMgd2lsbCBoZWxwIHBy ZXZlbnQgY3Jhc2hlcyBsaWtlOgorICAgICAgICAtIGh0dHA6Ly9jb2RlLmdvb2dsZS5jb20vcC9j aHJvbWl1bS9pc3N1ZXMvZGV0YWlsP2lkPTUyNzMxCisgICAgICAgIC0gaHR0cDovL2NvZGUuZ29v Z2xlLmNvbS9wL2Nocm9taXVtL2lzc3Vlcy9kZXRhaWw/aWQ9NTI2NDMKKworICAgICAgICAqIHNy Yy9XZWJLaXQuY3BwOgorICAgICAgICAoV2ViS2l0Ojppbml0aWFsaXplKToKKwogMjAxMC0wOC0y NCAgTWFyY3VzIEJ1bGFjaCAgPGJ1bGFjaEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgSmVyZW15IE9ybG93LgpJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJLaXQuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViS2l0LmNwcAkocmV2aXNpb24g NjU5MTUpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYktpdC5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTQ2LDExICs0NiwxOCBAQAogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAorLy8gTWFrZSBzdXJl IHdlIGFyZSBub3QgcmUtaW5pdGlhbGl6ZWQgaW4gdGhlIHNhbWUgYWRkcmVzcyBzcGFjZS4KKy8v IERvaW5nIHNvIG1heSBjYXVzZSBoYXJkIHRvIHJlcHJvZHVjZSBjcmFzaGVzLgorc3RhdGljIGJv b2wgc193ZWJLaXRJbml0aWFsaXplZCA9IGZhbHNlOworCiBzdGF0aWMgV2ViS2l0Q2xpZW50KiBz X3dlYktpdENsaWVudCA9IDA7CiBzdGF0aWMgYm9vbCBzX2xheW91dFRlc3RNb2RlID0gZmFsc2U7 CiAKIHZvaWQgaW5pdGlhbGl6ZShXZWJLaXRDbGllbnQqIHdlYktpdENsaWVudCkKIHsKKyAgICBB U1NFUlQoIXNfd2ViS2l0SW5pdGlhbGl6ZWQpOworICAgIHNfd2ViS2l0SW5pdGlhbGl6ZWQgPSB0 cnVlOworCiAgICAgQVNTRVJUKHdlYktpdENsaWVudCk7CiAgICAgQVNTRVJUKCFzX3dlYktpdENs aWVudCk7CiAgICAgc193ZWJLaXRDbGllbnQgPSB3ZWJLaXRDbGllbnQ7Cg==