44542 2010-08-24 12:06:33 -0700 [Chromium] The V8 NodeFilter wrapper needs to be fixed 2010-08-24 14:42:58 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dumi dumi abarth oldest_to_newest 268696 0 dumi 2010-08-24 12:06:33 -0700 V8DOMWrapper::wrapNativeNodeFilter() returns NULL if the argument is not a function. At the same time, Traversal::acceptNode() accepts all NULL filters. So if we pass in a filter that's not a function, we end up accepting it, instead of throwing an exception. After http://trac.webkit.org/changeset/65853 the expectation is that only functions and objects with an acceptNode() method should be accepted. Everything else should be rejected. So we should change V8DOMWrapper::wrapNativeNodeFilter() to always create a filter, and update V8NodeFilterCondition::acceptNode() to check for these conditions, like JSNodeFilterCondition::acceptNode() does. 268722 1 65308 dumi 2010-08-24 12:43:08 -0700 Created attachment 65308 patch 268740 2 65308 dglazkov 2010-08-24 13:09:03 -0700 Comment on attachment 65308 patch ok. 268808 3 dumi 2010-08-24 14:42:58 -0700 landed: r65937. 65308 2010-08-24 12:43:08 -0700 2010-08-24 13:09:03 -0700 patch patch text/plain 4199 dumi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NTkyMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDgtMjQgIER1bWl0cnUgRGFuaWxpdWMgIDxkdW1pQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBGaXggdGhlIE5vZGVGaWx0ZXIgd3JhcHBlciBhbmQgdGhlIGJpbmRpbmcgZm9yIGFjY2VwdE5v ZGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDU0 MgorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlY4RE9NV3JhcHBlcjo6d3JhcE5hdGl2ZU5vZGVGaWx0ZXIpOiBUaGlzIGZ1bmN0aW9u CisgICAgICAgIHNob3VsZCBhbHdheXMgY3JlYXRlIGEgZmlsdGVyLiBWOE5vZGVGaWx0ZXJDb25k aXRpb246OmFjY2VwdE5vZGUoKQorICAgICAgICB3aWxsIGNoZWNrIGlmIHRoZSBnaXZlbiBvYmpl Y3QgY2FuIGJlIHVzZWQgYXMgYSBmaWx0ZXIsIGFuZCB0aHJvdworICAgICAgICBhbiBleGNlcHRp b24gaWYgaXQgY2FuJ3QuCisgICAgICAgICogYmluZGluZ3MvdjgvVjhOb2RlRmlsdGVyQ29uZGl0 aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4Tm9kZUZpbHRlckNvbmRpdGlvbjo6YWNjZXB0 Tm9kZSk6IFVwZGF0ZSB0aGlzIGJpbmRpbmcKKyAgICAgICAgdG8gZG8gdGhlIHNhbWUgdGhpbmcg dGhhdCB0aGUgSlMgYmluZGluZyBkb2VzLgorCiAyMDEwLTA4LTI0ICBTdGVwaGVuIFdoaXRlICA8 c2Vub3JibGFuY29AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGgg UnVzc2VsbC4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHAJKHJldmlzaW9u IDY1OTIxKQorKysgV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0yMjIsOSArMjIyLDYgQEAgUGFzc1JlZlB0cjxOb2RlRmlsdGVyPiBWOERPTVdy YXBwZXI6OndyYQogICAgIC8vIHRvIE5vZGVGaWx0ZXIuIE5vZGVGaWx0ZXIgaGFzIGEgcmVmIGNv dW50ZWQgcG9pbnRlciB0byBOb2RlRmlsdGVyQ29uZGl0aW9uLgogICAgIC8vIEluIE5vZGVGaWx0 ZXJDb25kaXRpb24sIGZpbHRlciBvYmplY3QgaXMgcGVyc2lzdGVkIGluIGl0cyBjb25zdHJ1Y3Rv ciwKICAgICAvLyBhbmQgZGlzcG9zZWQgaW4gaXRzIGRlc3RydWN0b3IuCi0gICAgaWYgKCFmaWx0 ZXItPklzRnVuY3Rpb24oKSkKLSAgICAgICAgcmV0dXJuIDA7Ci0KICAgICByZXR1cm4gTm9kZUZp bHRlcjo6Y3JlYXRlKFY4Tm9kZUZpbHRlckNvbmRpdGlvbjo6Y3JlYXRlKGZpbHRlcikpOwogfQog CkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4Tm9kZUZpbHRlckNvbmRpdGlvbi5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy92OC9WOE5vZGVGaWx0ZXJDb25kaXRpb24uY3Bw CShyZXZpc2lvbiA2NTkyMSkKKysrIFdlYkNvcmUvYmluZGluZ3MvdjgvVjhOb2RlRmlsdGVyQ29u ZGl0aW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjIsMTMgKzYyLDI0IEBAIHNob3J0IFY4Tm9k ZUZpbHRlckNvbmRpdGlvbjo6YWNjZXB0Tm9kZSgKIHsKICAgICBBU1NFUlQodjg6OkNvbnRleHQ6 OkluQ29udGV4dCgpKTsKIAotICAgIGlmICghbV9maWx0ZXItPklzRnVuY3Rpb24oKSkKKyAgICBp ZiAoIW1fZmlsdGVyLT5Jc09iamVjdCgpKQogICAgICAgICByZXR1cm4gTm9kZUZpbHRlcjo6RklM VEVSX0FDQ0VQVDsKIAogICAgIHY4OjpUcnlDYXRjaCBleGNlcHRpb25DYXRjaGVyOwogCisgICAg djg6OkhhbmRsZTx2ODo6RnVuY3Rpb24+IGNhbGxiYWNrOworICAgIGlmIChtX2ZpbHRlci0+SXNG dW5jdGlvbigpKQorICAgICAgICBjYWxsYmFjayA9IHY4OjpIYW5kbGU8djg6OkZ1bmN0aW9uPjo6 Q2FzdChtX2ZpbHRlcik7CisgICAgZWxzZSB7CisgICAgICAgIHY4OjpMb2NhbDx2ODo6VmFsdWU+ IHZhbHVlID0gbV9maWx0ZXItPlRvT2JqZWN0KCktPkdldCh2ODo6U3RyaW5nOjpOZXcoImFjY2Vw dE5vZGUiKSk7CisgICAgICAgIGlmICghdmFsdWUtPklzRnVuY3Rpb24oKSkgeworICAgICAgICAg ICAgVjhQcm94eTo6dGhyb3dFcnJvcihWOFByb3h5OjpUeXBlRXJyb3IsICJOb2RlRmlsdGVyIG9i amVjdCBkb2VzIG5vdCBoYXZlIGFuIGFjY2VwdE5vZGUgZnVuY3Rpb24iKTsKKyAgICAgICAgICAg IHJldHVybiBOb2RlRmlsdGVyOjpGSUxURVJfUkVKRUNUOworICAgICAgICB9CisgICAgICAgIGNh bGxiYWNrID0gdjg6OkhhbmRsZTx2ODo6RnVuY3Rpb24+OjpDYXN0KHZhbHVlKTsKKyAgICB9CisK ICAgICB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IG9iamVjdCA9IHY4OjpDb250ZXh0OjpHZXRDdXJy ZW50KCktPkdsb2JhbCgpOwotICAgIHY4OjpIYW5kbGU8djg6OkZ1bmN0aW9uPiBjYWxsYmFjayA9 IHY4OjpIYW5kbGU8djg6OkZ1bmN0aW9uPjo6Q2FzdChtX2ZpbHRlcik7CiAgICAgT3duQXJyYXlQ dHI8djg6OkhhbmRsZTx2ODo6VmFsdWU+ID4gYXJncyhuZXcgdjg6OkhhbmRsZTx2ODo6VmFsdWU+ WzFdKTsKICAgICBhcmdzWzBdID0gdG9WOChub2RlKTsKIApJbmRleDogTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNjU5 MjEpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwx MiBAQAorMjAxMC0wOC0yNCAgRHVtaXRydSBEYW5pbGl1YyAgPGR1bWlAY2hyb21pdW0ub3JnPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGFjY2VwdE5v ZGUtZmlsdGVyLmh0bWwgc2hvdWxkIHBhc3MgYWZ0ZXIgdGhpcyBwYXRjaC4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0NTQyCisKKyAgICAgICAgKiBw bGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQ6CisKIDIwMTAtMDgtMjQgIFNp bW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgU2FtIFdlaW5pZy4KSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3Rf ZXhwZWN0YXRpb25zLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJv bWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQJKHJldmlzaW9uIDY1OTIxKQorKysgTGF5b3V0VGVz dHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CSh3b3JraW5nIGNvcHkp CkBAIC0zMjM4LDkgKzMyMzgsNiBAQCBCVUdXSzQ0MzQxIFdJTiBMSU5VWCA6IHN2Zy9jbGlwLXBh dGgvY2xpCiAvLyBGbGFreSBvbiBMaW51eAogQlVHNTMxMzEgTElOVVggOiBmYXN0L2pzL2FycmF5 LWl0ZXJhdGUtYmFja3dhcmRzLmh0bWwgPSBDUkFTSCBQQVNTCiAKLS8vIGh0dHA6Ly90cmFjLndl YmtpdC5vcmcvY2hhbmdlc2V0LzY1ODI0IGRpZG4ndCBhZGQgVjggYmluZGluZ3MgZm9yIHRoaXMg dGVzdAotQlVHNTMxNDQgOiBmYXN0L2RvbS9UcmVlV2Fsa2VyL2FjY2VwdE5vZGUtZmlsdGVyLmh0 bWwgPSBURVhUCi0KIC8vIG5ldyBvciBmYWlsaW5nIHNpbmNlIFdlYktpdCByZXYuIDY1NzQwOjY1 ODAwCiBCVUcyMTg1MiBNQUMgOiBmYXN0L2NhbnZhcy93ZWJnbC90ZXgtaW1hZ2UtYW5kLXN1Yi1p bWFnZS0yZC13aXRoLXZpZGVvLmh0bWwgPSBURVhUCiBCVUc1MzA3MyBXSU4gOiBmYXN0L3JlcGFp bnQvbXVsdGljb2wtcmVwYWludC5odG1sID0gSU1BR0UrVEVYVAo=