44537 2010-08-24 10:53:25 -0700 WebKit2 should launch the WebProcess in 32-bit mode if the UIProcess is in 32-bit mode 2010-08-24 20:11:20 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 sam webkit-unassigned oldest_to_newest 268646 0 sam 2010-08-24 10:53:25 -0700 WebKit2 should launch the WebProcess in 32-bit mode if the UIProcess is in 32-bit mode 268647 1 sam 2010-08-24 10:53:59 -0700 <rdar://problem/8348100> 268982 2 65362 sam 2010-08-24 19:47:18 -0700 Created attachment 65362 Patch 268988 3 65362 mrowe 2010-08-24 20:05:20 -0700 Comment on attachment 65362 Patch > + > + posix_spawnattr_t attr; > + posix_spawnattr_init(&attr); > + > +#if CPU(X86) > + // We spawn a 32-bit child process if the host is 32-bit. This allows checking > + // the "Open in 32-bit mode" check box in the finder and getting a 32-bit WebProcess. I don’t like the way this comment is worded. It would be better to say something about having the child process run as the same architecture as the parent process. The Finder in particular isn’t all that interesting here. > + cpu_type_t cpuTypes[] = { CPU_TYPE_X86 }; > +#else > + cpu_type_t cpuTypes[] = { CPU_TYPE_ANY }; > +#endif > + size_t outCount = 0; > + posix_spawnattr_setbinpref_np(&attr, 1, cpuTypes, &outCount); You could move this call in to the #if and drop the #else completely. r=me 268991 4 sam 2010-08-24 20:11:20 -0700 Landed in 65968. 65362 2010-08-24 19:47:18 -0700 2010-08-24 20:05:20 -0700 Patch patch.diff text/plain 2674 sam SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NTk2NSkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDgtMjQgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJLaXQy IHNob3VsZCBsYXVuY2ggdGhlIFdlYlByb2Nlc3MgaW4gMzItYml0IG1vZGUgaWYgdGhlIFVJUHJv Y2VzcyBpcyBpbiAzMi1iaXQgbW9kZQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vODM0ODEwMD4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0NTM3CisK KyAgICAgICAgKiBVSVByb2Nlc3MvTGF1bmNoZXIvbWFjL1Byb2Nlc3NMYXVuY2hlck1hYy5tbToK KyAgICAgICAgKFdlYktpdDo6UHJvY2Vzc0xhdW5jaGVyOjpsYXVuY2hQcm9jZXNzKTogVXNlIHBv c2l4X3NwYXduYXR0cl9zZXRiaW5wcmVmX25wCisgICAgICAgIHRvIHRlbGwgcG9zaXhfc3Bhd24g dG8gbGF1bmNoIHRoZSBXZWJQcm9jZXNzIGluIDMyLWJpdCBtb2RlIHdoZW4gdGhlIFVJUHJvY2Vz cworICAgICAgICBpcyBydW5uaW5nIGluIDMyLWJpdCBtb2RlLgorCiAyMDEwLTA4LTI0ICBNYXJr IFJvd2UgIDxtcm93ZUBhcHBsZS5jb20+CiAKICAgICAgICAgUnViYmVyLXN0YW1wZWQgYnkgU2Ft IFdlaW5pZy4KSW5kZXg6IFdlYktpdDIvVUlQcm9jZXNzL0xhdW5jaGVyL21hYy9Qcm9jZXNzTGF1 bmNoZXJNYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0Mi9VSVByb2Nlc3MvTGF1bmNoZXIvbWFj L1Byb2Nlc3NMYXVuY2hlck1hYy5tbQkocmV2aXNpb24gNjU5MzUpCisrKyBXZWJLaXQyL1VJUHJv Y2Vzcy9MYXVuY2hlci9tYWMvUHJvY2Vzc0xhdW5jaGVyTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBA IC0yOSw2ICsyOSw3IEBACiAjaW5jbHVkZSAiV2ViUHJvY2Vzcy5oIgogI2luY2x1ZGUgIldlYlN5 c3RlbUludGVyZmFjZS5oIgogI2luY2x1ZGUgPGNydF9leHRlcm5zLmg+CisjaW5jbHVkZSA8bWFj aC9tYWNoaW5lLmg+CiAjaW5jbHVkZSA8cnVudGltZS9Jbml0aWFsaXplVGhyZWFkaW5nLmg+CiAj aW5jbHVkZSA8c2VydmVycy9ib290c3RyYXAuaD4KICNpbmNsdWRlIDxzcGF3bi5oPgpAQCAtNjYs OSArNjcsMjUgQEAgdm9pZCBQcm9jZXNzTGF1bmNoZXI6OmxhdW5jaFByb2Nlc3MoKQogICAgIGtl cm5fcmV0dXJuX3Qga3IgPSBib290c3RyYXBfcmVnaXN0ZXIyKGJvb3RzdHJhcF9wb3J0LCBjb25z dF9jYXN0PGNoYXIqPihzZXJ2aWNlTmFtZS5kYXRhKCkpLCBsaXN0ZW5pbmdQb3J0LCAwKTsKICAg ICBpZiAoa3IpCiAgICAgICAgIE5TTG9nKEAiYm9vdHN0cmFwX3JlZ2lzdGVyMiByZXN1bHQ6ICV4 Iiwga3IpOwotICAgIAorCisgICAgcG9zaXhfc3Bhd25hdHRyX3QgYXR0cjsKKyAgICBwb3NpeF9z cGF3bmF0dHJfaW5pdCgmYXR0cik7CisKKyNpZiBDUFUoWDg2KQorICAgIC8vIFdlIHNwYXduIGEg MzItYml0IGNoaWxkIHByb2Nlc3MgaWYgdGhlIGhvc3QgaXMgMzItYml0LiBUaGlzIGFsbG93cyBj aGVja2luZworICAgIC8vIHRoZSAiT3BlbiBpbiAzMi1iaXQgbW9kZSIgY2hlY2sgYm94IGluIHRo ZSBmaW5kZXIgYW5kIGdldHRpbmcgYSAzMi1iaXQgV2ViUHJvY2Vzcy4KKyAgICBjcHVfdHlwZV90 IGNwdVR5cGVzW10gPSB7IENQVV9UWVBFX1g4NiB9OyAgICAKKyNlbHNlCisgICAgY3B1X3R5cGVf dCBjcHVUeXBlc1tdID0geyBDUFVfVFlQRV9BTlkgfTsKKyNlbmRpZgorICAgIHNpemVfdCBvdXRD b3VudCA9IDA7CisgICAgcG9zaXhfc3Bhd25hdHRyX3NldGJpbnByZWZfbnAoJmF0dHIsIDEsIGNw dVR5cGVzLCAmb3V0Q291bnQpOworCiAgICAgcGlkX3QgcHJvY2Vzc0lkZW50aWZpZXI7Ci0gICAg aW50IHJlc3VsdCA9IHBvc2l4X3NwYXduKCZwcm9jZXNzSWRlbnRpZmllciwgcGF0aCwgMCwgMCwg KGNoYXIgKmNvbnN0KilhcmdzLCAqX05TR2V0RW52aXJvbigpKTsKKyAgICBpbnQgcmVzdWx0ID0g cG9zaXhfc3Bhd24oJnByb2Nlc3NJZGVudGlmaWVyLCBwYXRoLCAwLCAmYXR0ciwgKGNoYXIgKmNv bnN0KilhcmdzLCAqX05TR2V0RW52aXJvbigpKTsKKworICAgIHBvc2l4X3NwYXduYXR0cl9kZXN0 cm95KCZhdHRyKTsKKwogICAgIGlmIChyZXN1bHQpCiAgICAgICAgIE5TTG9nKEAicG9zaXhfc3Bh d24gcmVzdWx0OiAlZCIsIHJlc3VsdCk7CiAKQEAgLTg3LDcgKzEwNCw3IEBAIHZvaWQgUHJvY2Vz c0xhdW5jaGVyOjp0ZXJtaW5hdGVQcm9jZXNzKCkKIHN0YXRpYyB2b2lkKiB3ZWJUaHJlYWRCb2R5 KHZvaWQqIGNvbnRleHQpCiB7CiAgICAgbWFjaF9wb3J0X3Qgc2VydmVyUG9ydCA9IHN0YXRpY19j YXN0PG1hY2hfcG9ydF90PihyZWludGVycHJldF9jYXN0PHVpbnRwdHJfdD4oY29udGV4dCkpOwot ICAgIAorCiAgICAgTlNBdXRvcmVsZWFzZVBvb2wgKnBvb2wgPSBbW05TQXV0b3JlbGVhc2VQb29s IGFsbG9jXSBpbml0XTsKIAogICAgIEluaXRXZWJDb3JlU3lzdGVtSW50ZXJmYWNlKCk7Cg==