<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>44508</bug_id>
          
          <creation_ts>2010-08-24 02:48:20 -0700</creation_ts>
          <short_desc>[EFL] Add PlatformVideoWindowEfl.cpp for WebKit EFL</short_desc>
          <delta_ts>2010-08-31 23:05:20 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit EFL</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>44590</dependson>
          <blocked>44098</blocked>
          <everconfirmed>0</everconfirmed>
          <reporter name="Gyuyoung Kim">gyuyoung.kim</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>antognolli+webkit</cc>
    
    <cc>commit-queue</cc>
    
    <cc>lucas.de.marchi</cc>
    
    <cc>mrobinson</cc>
    
    <cc>pnormand</cc>
    
    <cc>tonikitoo</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>268453</commentid>
    <comment_count>0</comment_count>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2010-08-24 02:48:20 -0700</bug_when>
    <thetext>It seems to me that WebKit EFL also needs to have PlatformVideoWindowEfl.cpp in order to use gstreamer as it&apos;s video framework.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>268455</commentid>
    <comment_count>1</comment_count>
      <attachid>65250</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2010-08-24 03:05:55 -0700</bug_when>
    <thetext>Created attachment 65250
Patch

I modify PlatformVideoWindow.h and create PlatformVideoWindowEfl.cpp.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>268460</commentid>
    <comment_count>2</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-08-24 03:14:24 -0700</bug_when>
    <thetext>This is needed only for fullscreen video display. You should already be able to use the gst webkitvideo sink. For painting Cairo is used, see ImageGStreamerCairo.cpp ... For EFL you might need a new ImageGStreamer implementation, dunno.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>268478</commentid>
    <comment_count>3</comment_count>
      <attachid>65250</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-08-24 04:28:33 -0700</bug_when>
    <thetext>Comment on attachment 65250
Patch


&gt;+#if PLATFORM(EFL)
&gt;+#if ENABLE(GLIB_SUPPORT)
&gt;+#include &lt;glib.h&gt;
&gt;+#endif
&gt;+#endif
&gt;+

I think the guards can be removed because glib.h is required for the use of gulong below anyway.
The only reason why it works currently is that gtk.h includes glib.h

&gt; namespace WebCore {
&gt; 
&gt; class PlatformVideoWindow : public RefCounted&lt;PlatformVideoWindow&gt; {
&gt;@@ -39,12 +45,16 @@ class PlatformVideoWindow : public RefCounted&lt;PlatformVideoWindow&gt; {
&gt;         PlatformVideoWindow();
&gt;         ~PlatformVideoWindow();
&gt; 
&gt;+#if PLATFORM(GTK)
&gt;         PlatformWindowType* window() const { return m_window; }
&gt;+#endif

&gt;         gulong videoWindowId() const { return m_videoWindowId; }
&gt; 
&gt;     private:
&gt;         gulong m_videoWindowId;
&gt;+#if PLATFORM(GTK)
&gt;         PlatformWindowType* m_videoWindow;
&gt;+#endif

This is wrong. You need to add a typedef for your platform so PlatformWindowType is valid.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>268488</commentid>
    <comment_count>4</comment_count>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2010-08-24 05:15:58 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; (From update of attachment 65250 [details])
&gt; 
&gt; &gt;+#if PLATFORM(EFL)
&gt; &gt;+#if ENABLE(GLIB_SUPPORT)
&gt; &gt;+#include &lt;glib.h&gt;
&gt; &gt;+#endif
&gt; &gt;+#endif
&gt; &gt;+
&gt; 
&gt; I think the guards can be removed because glib.h is required for the use of gulong below anyway.
&gt; The only reason why it works currently is that gtk.h includes glib.h
&gt; 
&gt; &gt; namespace WebCore {
&gt; &gt; 
&gt; &gt; class PlatformVideoWindow : public RefCounted&lt;PlatformVideoWindow&gt; {
&gt; &gt;@@ -39,12 +45,16 @@ class PlatformVideoWindow : public RefCounted&lt;PlatformVideoWindow&gt; {
&gt; &gt;         PlatformVideoWindow();
&gt; &gt;         ~PlatformVideoWindow();
&gt; &gt; 
&gt; &gt;+#if PLATFORM(GTK)
&gt; &gt;         PlatformWindowType* window() const { return m_window; }
&gt; &gt;+#endif
&gt; 
&gt; &gt;         gulong videoWindowId() const { return m_videoWindowId; }
&gt; &gt; 
&gt; &gt;     private:
&gt; &gt;         gulong m_videoWindowId;
&gt; &gt;+#if PLATFORM(GTK)
&gt; &gt;         PlatformWindowType* m_videoWindow;
&gt; &gt;+#endif
&gt; 
&gt; This is wrong. You need to add a typedef for your platform so PlatformWindowType is valid.

I agree with your opinion. I am going to consider your guidance.

Thank you.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>268568</commentid>
    <comment_count>5</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-08-24 08:40:44 -0700</bug_when>
    <thetext>BTW fullscreen video display shouldn&apos;t be blocker for an initial HTML5 video support in WebKit EFL.

You just need to avoid painting the fullscreen button in your media controls and make the webkitSupportsFullscreen method of the gst player return false in your case.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>269013</commentid>
    <comment_count>6</comment_count>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2010-08-24 22:00:55 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; (From update of attachment 65250 [details])
&gt; 
&gt; &gt;+#if PLATFORM(EFL)
&gt; &gt;+#if ENABLE(GLIB_SUPPORT)
&gt; &gt;+#include &lt;glib.h&gt;
&gt; &gt;+#endif
&gt; &gt;+#endif
&gt; &gt;+
&gt; 
&gt; I think the guards can be removed because glib.h is required for the use of gulong below anyway.
&gt; The only reason why it works currently is that gtk.h includes glib.h

WebKit EFL doesn&apos;t use gtk. So, I include glib.h for EFL. Is this wrong ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>269040</commentid>
    <comment_count>7</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-08-24 23:13:07 -0700</bug_when>
    <thetext>(In reply to comment #6)
&gt; (In reply to comment #3)
&gt; &gt; (From update of attachment 65250 [details] [details])
&gt; &gt; 
&gt; &gt; &gt;+#if PLATFORM(EFL)
&gt; &gt; &gt;+#if ENABLE(GLIB_SUPPORT)
&gt; &gt; &gt;+#include &lt;glib.h&gt;
&gt; &gt; &gt;+#endif
&gt; &gt; &gt;+#endif
&gt; &gt; &gt;+
&gt; &gt; 
&gt; &gt; I think the guards can be removed because glib.h is required for the use of gulong below anyway.
&gt; &gt; The only reason why it works currently is that gtk.h includes glib.h
&gt; 
&gt; WebKit EFL doesn&apos;t use gtk. So, I include glib.h for EFL. Is this wrong ?

It is totally right, I was just asking to remove the #ifs</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>269064</commentid>
    <comment_count>8</comment_count>
      <attachid>65381</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2010-08-25 00:45:09 -0700</bug_when>
    <thetext>Created attachment 65381
Patch

I define PlatformWindowType for EFL.

Thank you.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>269072</commentid>
    <comment_count>9</comment_count>
      <attachid>65381</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-08-25 00:55:49 -0700</bug_when>
    <thetext>Comment on attachment 65381
Patch

&gt;--- a/WebCore/platform/graphics/gstreamer/PlatformVideoWindow.h
&gt;+++ b/WebCore/platform/graphics/gstreamer/PlatformVideoWindow.h
&gt;@@ -28,6 +28,15 @@
&gt; #if PLATFORM(GTK)
&gt; #include &lt;gtk/gtk.h&gt;
&gt; typedef GtkWidget PlatformWindowType;
&gt;+#elif PLATFORM(EFL)
&gt;+#include &quot;Widget.h&quot;
&gt;+typedef PlatformWidget PlatformWindowType;
&gt;+#endif
&gt;+

Oh nice I didn&apos;t know about Widget.h
So we duplicated efforts here. I think it&apos;d make sense to remove PlatformWindowType and use PlatformWidget directly.

&gt;+#if PLATFORM(EFL)
&gt;+#if ENABLE(GLIB_SUPPORT)
&gt;+#include &lt;glib.h&gt;
&gt;+#endif
&gt; #endif
&gt; 

I said in previous comment that the #ifs are not necessary.

The rest of the patch looks ok to me!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>269074</commentid>
    <comment_count>10</comment_count>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2010-08-25 01:03:31 -0700</bug_when>
    <thetext>(In reply to comment #9)
&gt; (From update of attachment 65381 [details])
&gt; &gt;--- a/WebCore/platform/graphics/gstreamer/PlatformVideoWindow.h
&gt; &gt;+++ b/WebCore/platform/graphics/gstreamer/PlatformVideoWindow.h
&gt; &gt;@@ -28,6 +28,15 @@
&gt; &gt; #if PLATFORM(GTK)
&gt; &gt; #include &lt;gtk/gtk.h&gt;
&gt; &gt; typedef GtkWidget PlatformWindowType;
&gt; &gt;+#elif PLATFORM(EFL)
&gt; &gt;+#include &quot;Widget.h&quot;
&gt; &gt;+typedef PlatformWidget PlatformWindowType;
&gt; &gt;+#endif
&gt; &gt;+
&gt; 
&gt; Oh nice I didn&apos;t know about Widget.h
&gt; So we duplicated efforts here. I think it&apos;d make sense to remove PlatformWindowType and use PlatformWidget directly.
&gt; 

I wonder how to use PlatformWidget directly. In order to use the PlatformformWidget directly, I think we need to modify code as below,

 48 #if PLATFORM(GTK)
 49         PlatformWindowType* window() const { return m_window; }
 50 #elif PLATFORM(EFL)
 51         PlatformWidget* window() const { return m_window; }
 52 #endif


&gt; &gt;+#if PLATFORM(EFL)
&gt; &gt;+#if ENABLE(GLIB_SUPPORT)
&gt; &gt;+#include &lt;glib.h&gt;
&gt; &gt;+#endif
&gt; &gt; #endif
&gt; &gt; 
&gt; 
&gt; I said in previous comment that the #ifs are not necessary.
&gt; 
&gt; The rest of the patch looks ok to me!

I modify above code as below,

 31 #elif PLATFORM(EFL)
 32 #if ENABLE(GLIB_SUPPORT)
 33 #include &lt;glib.h&gt;
 34 #endif
 35 #include &quot;Widget.h&quot;
 36 typedef PlatformWidget PlatformWindowType;
 37 #endif

Is this ok ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>269078</commentid>
    <comment_count>11</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-08-25 01:13:27 -0700</bug_when>
    <thetext>(In reply to comment #10)

&gt; I wonder how to use PlatformWidget directly. In order to use the PlatformformWidget directly, I think we need to modify code as below,
&gt; 
&gt;  48 #if PLATFORM(GTK)
&gt;  49         PlatformWindowType* window() const { return m_window; }
&gt;  50 #elif PLATFORM(EFL)
&gt;  51         PlatformWidget* window() const { return m_window; }
&gt;  52 #endif
&gt; 
&gt; 

No, it would be best to make the GTK port use PlatformWidget as well, it will all be more coherent and readable.

&gt; I modify above code as below,
&gt; 
&gt;  31 #elif PLATFORM(EFL)
&gt;  32 #if ENABLE(GLIB_SUPPORT)
&gt;  33 #include &lt;glib.h&gt;
&gt;  34 #endif
&gt;  35 #include &quot;Widget.h&quot;
&gt;  36 typedef PlatformWidget PlatformWindowType;
&gt;  37 #endif
&gt; 
&gt; Is this ok ?

No. I thought I was clear, but it seems not :)
glib.h can safely be included *outside* any #ifs like this:

#include &lt;glib.h&gt;

If you make use of PlatformWidget no #if at all should be needed in this file.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>269089</commentid>
    <comment_count>12</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-08-25 01:27:24 -0700</bug_when>
    <thetext>(In reply to comment #11)
&gt; 
&gt; &gt; I modify above code as below,
&gt; &gt; 
&gt; &gt;  31 #elif PLATFORM(EFL)
&gt; &gt;  32 #if ENABLE(GLIB_SUPPORT)
&gt; &gt;  33 #include &lt;glib.h&gt;
&gt; &gt;  34 #endif
&gt; &gt;  35 #include &quot;Widget.h&quot;
&gt; &gt;  36 typedef PlatformWidget PlatformWindowType;
&gt; &gt;  37 #endif
&gt; &gt; 
&gt; &gt; Is this ok ?
&gt; 

Well I understand your port doesn&apos;t have a hard dependency on GLib, so yeah you need guards, maybe like:

#if PLATFORM(GTK) || ENABLE(GLIB_SUPPORT)
#include &lt;glib.h&gt;
#endif

?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>269095</commentid>
    <comment_count>13</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-08-25 01:43:52 -0700</bug_when>
    <thetext>
Or even:

#if !PLATFORM(EFL) || ENABLE(GLIB_SUPPORT)
#include &lt;glib.h&gt;
#endif</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>269098</commentid>
    <comment_count>14</comment_count>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2010-08-25 02:01:32 -0700</bug_when>
    <thetext>Yes, WebKit EFL doesn&apos;t have hard dependency with glib. WebKit EFL should enable ENABLE_GLIB_SUPPORT macro to use glib. If you are ok, I will upload new patch again.

+#include &quot;Widget.h&quot;
+
 #if PLATFORM(GTK)
 #include &lt;gtk/gtk.h&gt;
 typedef GtkWidget PlatformWindowType;
+#elif PLATFORM(EFL)
+#include &quot;Widget.h&quot;
+typedef PlatformWidget PlatformWindowType;
+#endif
+
+#if !PLATFORM(EFL) || ENABLE(GLIB_SUPPORT)
+#include &lt;glib.h&gt;
 #endif</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>269101</commentid>
    <comment_count>15</comment_count>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2010-08-25 02:02:43 -0700</bug_when>
    <thetext>(In reply to comment #14)
&gt; Yes, WebKit EFL doesn&apos;t have hard dependency with glib. WebKit EFL should enable ENABLE_GLIB_SUPPORT macro to use glib. If you are ok, I will upload new patch again.
&gt; 
&gt; +#include &quot;Widget.h&quot;
&gt; +
&gt;  #if PLATFORM(GTK)
&gt;  #include &lt;gtk/gtk.h&gt;
&gt;  typedef GtkWidget PlatformWindowType;
&gt; +#elif PLATFORM(EFL)
&gt; +#include &quot;Widget.h&quot;
&gt; +typedef PlatformWidget PlatformWindowType;
&gt; +#endif
&gt; +
&gt; +#if !PLATFORM(EFL) || ENABLE(GLIB_SUPPORT)
&gt; +#include &lt;glib.h&gt;
&gt;  #endif

Sorry, please remove &quot;#include &quot;Widget.h&quot;

&gt; +#include &quot;Widget.h&quot;
&gt; +</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>269104</commentid>
    <comment_count>16</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-08-25 02:17:48 -0700</bug_when>
    <thetext>(In reply to comment #15)
&gt; &gt;  #if PLATFORM(GTK)
&gt; &gt;  #include &lt;gtk/gtk.h&gt;
&gt; &gt;  typedef GtkWidget PlatformWindowType;
&gt; &gt; +#elif PLATFORM(EFL)
&gt; &gt; +#include &quot;Widget.h&quot;
&gt; &gt; +typedef PlatformWidget PlatformWindowType;
&gt; &gt; +#endif
&gt; &gt; +
&gt; &gt; +#if !PLATFORM(EFL) || ENABLE(GLIB_SUPPORT)
&gt; &gt; +#include &lt;glib.h&gt;
&gt; &gt;  #endif
&gt; 

Ok much better, what about PlatformWidget use for the GTK port too? I would be willing to test such patch :)

Also PlatformWidget is a pointer already. So you need to update the declarations of ::window(), m_videoWindow and m_window accordingly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>269114</commentid>
    <comment_count>17</comment_count>
      <attachid>65388</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2010-08-25 02:43:54 -0700</bug_when>
    <thetext>Created attachment 65388
Patch

I modify this patch according to your guidance. 

I built WebKit GTK based on this patch as well. There was no build breaks.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>269122</commentid>
    <comment_count>18</comment_count>
      <attachid>65388</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-08-25 02:58:32 -0700</bug_when>
    <thetext>Comment on attachment 65388
Patch

Nice, thanks :)
One last thing (from my side, at least):

&gt; #if PLATFORM(GTK)
&gt; #include &lt;gtk/gtk.h&gt;
&gt;-typedef GtkWidget PlatformWindowType;
&gt;+#endif

That #if can be removed all together. We no longer require to include gtk.h there but then we should move it to PlatformVideoWindowGtk.cpp I think. But as this patch is EFL-specific I can make that change myself in a separate patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>269127</commentid>
    <comment_count>19</comment_count>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2010-08-25 03:04:19 -0700</bug_when>
    <thetext>(In reply to comment #18)
&gt; (From update of attachment 65388 [details])
&gt; Nice, thanks :)
&gt; One last thing (from my side, at least):
&gt; 
&gt; &gt; #if PLATFORM(GTK)
&gt; &gt; #include &lt;gtk/gtk.h&gt;
&gt; &gt;-typedef GtkWidget PlatformWindowType;
&gt; &gt;+#endif
&gt; 
&gt; That #if can be removed all together. We no longer require to include gtk.h there but then we should move it to PlatformVideoWindowGtk.cpp I think. But as this patch is EFL-specific I can make that change myself in a separate patch.

I couldn&apos;t remove &quot;#include &lt;gtk/gtk.h&gt;&quot; because of build error in PlatformVideoWindowGtk.cpp. If you want to move &quot;#include &lt;gtk/gtk.h&gt;&quot; to PlatformVideoWindowGtk.cpp, I can do it new patch. Do you want ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>269130</commentid>
    <comment_count>20</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-08-25 03:13:42 -0700</bug_when>
    <thetext>(In reply to comment #19)
&gt; (In reply to comment #18)
&gt; &gt; (From update of attachment 65388 [details] [details])
&gt; &gt; Nice, thanks :)
&gt; &gt; One last thing (from my side, at least):
&gt; &gt; 
&gt; &gt; &gt; #if PLATFORM(GTK)
&gt; &gt; &gt; #include &lt;gtk/gtk.h&gt;
&gt; &gt; &gt;-typedef GtkWidget PlatformWindowType;
&gt; &gt; &gt;+#endif
&gt; &gt; 
&gt; &gt; That #if can be removed all together. We no longer require to include gtk.h there but then we should move it to PlatformVideoWindowGtk.cpp I think. But as this patch is EFL-specific I can make that change myself in a separate patch.
&gt; 
&gt; I couldn&apos;t remove &quot;#include &lt;gtk/gtk.h&gt;&quot; because of build error in PlatformVideoWindowGtk.cpp. If you want to move &quot;#include &lt;gtk/gtk.h&gt;&quot; to PlatformVideoWindowGtk.cpp, I can do it new patch. Do you want ?

In comment 19 I was thinking about yes. Sure, if you want file a new bug and patch after this one lands :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>269131</commentid>
    <comment_count>21</comment_count>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2010-08-25 03:15:39 -0700</bug_when>
    <thetext>(In reply to comment #20)
&gt; (In reply to comment #19)
&gt; &gt; (In reply to comment #18)
&gt; &gt; &gt; (From update of attachment 65388 [details] [details] [details])
&gt; &gt; &gt; Nice, thanks :)
&gt; &gt; &gt; One last thing (from my side, at least):
&gt; &gt; &gt; 
&gt; &gt; &gt; &gt; #if PLATFORM(GTK)
&gt; &gt; &gt; &gt; #include &lt;gtk/gtk.h&gt;
&gt; &gt; &gt; &gt;-typedef GtkWidget PlatformWindowType;
&gt; &gt; &gt; &gt;+#endif
&gt; &gt; &gt; 
&gt; &gt; &gt; That #if can be removed all together. We no longer require to include gtk.h there but then we should move it to PlatformVideoWindowGtk.cpp I think. But as this patch is EFL-specific I can make that change myself in a separate patch.
&gt; &gt; 
&gt; &gt; I couldn&apos;t remove &quot;#include &lt;gtk/gtk.h&gt;&quot; because of build error in PlatformVideoWindowGtk.cpp. If you want to move &quot;#include &lt;gtk/gtk.h&gt;&quot; to PlatformVideoWindowGtk.cpp, I can do it new patch. Do you want ?
&gt; 
&gt; In comment 19 I was thinking about yes. Sure, if you want file a new bug and patch after this one lands :)

Sure, I will do that after landing this patch. :) 

Thanks.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>269236</commentid>
    <comment_count>22</comment_count>
    <who name="Rafael Antognolli">antognolli+webkit</who>
    <bug_when>2010-08-25 07:24:22 -0700</bug_when>
    <thetext>(In reply to comment #12)
&gt; (In reply to comment #11)
&gt; &gt; 
&gt; &gt; &gt; I modify above code as below,
&gt; &gt; &gt; 
&gt; &gt; &gt;  31 #elif PLATFORM(EFL)
&gt; &gt; &gt;  32 #if ENABLE(GLIB_SUPPORT)
&gt; &gt; &gt;  33 #include &lt;glib.h&gt;
&gt; &gt; &gt;  34 #endif
&gt; &gt; &gt;  35 #include &quot;Widget.h&quot;
&gt; &gt; &gt;  36 typedef PlatformWidget PlatformWindowType;
&gt; &gt; &gt;  37 #endif
&gt; &gt; &gt; 
&gt; &gt; &gt; Is this ok ?
&gt; &gt; 
&gt; 
&gt; Well I understand your port doesn&apos;t have a hard dependency on GLib, so yeah you need guards, maybe like:
&gt; 
&gt; #if PLATFORM(GTK) || ENABLE(GLIB_SUPPORT)
&gt; #include &lt;glib.h&gt;
&gt; #endif
&gt; 
&gt; ?

Actually, no guards are needed since Gyuyoung&apos;s patch is for gstreamer video backend, and gstreamer needs glib anyway. We even force ENABLE_GLIB_SUPPORT if ENABLE_VIDEO_SUPPORT is true.

Maybe if later another video implementation that doesn&apos;t use gstreamer is available, the yes, we could make this optional. And I think the following line (unless changed to something else with ifdefs too) wouldn&apos;t compile without #include &lt;glib.h&gt;:
         gulong videoWindowId() const { return m_videoWindowId; }</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>270251</commentid>
    <comment_count>23</comment_count>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2010-08-26 18:07:02 -0700</bug_when>
    <thetext>Hello  Philippe Normand,

Who can review this patch ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>270320</commentid>
    <comment_count>24</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-08-26 22:58:26 -0700</bug_when>
    <thetext>(In reply to comment #23)
&gt; Hello  Philippe Normand,
&gt; 
&gt; Who can review this patch ?

Well Rafael is right about including glib.h without guards.

Then either Xan, Martin or Gustavo could review it maybe</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>270326</commentid>
    <comment_count>25</comment_count>
      <attachid>65388</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2010-08-26 23:14:05 -0700</bug_when>
    <thetext>Comment on attachment 65388
Patch


&gt; +#include &quot;Widget.h&quot;
&gt; +
&gt;  #include &lt;wtf/PassRefPtr.h&gt;

Please remove this extra line. There is no need to separate the include styles.

&gt;  #if PLATFORM(GTK)
&gt;  #include &lt;gtk/gtk.h&gt;
&gt; -typedef GtkWidget PlatformWindowType;
&gt; +#endif
&gt; +
&gt; +#if !PLATFORM(EFL) || ENABLE(GLIB_SUPPORT)
&gt; +#include &lt;glib.h&gt;
&gt;  #endif

Is the only reason for these #ifdefs and #includes gulong? Having
GLib and/or GTK+ includes in a header files can increase the compilation
time unecessarily. If possible, please just use unsigned long instead of
gulong and remove all the #ifdefs and #includes. Thanks!
  
&gt; diff --git a/WebCore/platform/graphics/gstreamer/PlatformVideoWindowEfl.cpp b/WebCore/platform/graphics/gstreamer/PlatformVideoWindowEfl.cpp

Should this also be added to the CMake build scripts?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>270345</commentid>
    <comment_count>26</comment_count>
      <attachid>65682</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2010-08-26 23:58:49 -0700</bug_when>
    <thetext>Created attachment 65682
Patch

Thanks, I fix this patch according to your comment.
I move the &quot;#include &lt;gtk/gtk.h&gt;&quot; to PlatformVideoWindowGtk.cpp.

BTW, I add the PlatformVideoWindowEfl.cpp to CMakeListEfl.txt in Bug 44098.
(Bug 44098 is blocked by this bug.)
Because, I want to add this file together with other files regarding gstreamer. So, the PlatformVideoWindowEfl.cpp will be added after landing this patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>271263</commentid>
    <comment_count>27</comment_count>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2010-08-29 19:27:31 -0700</bug_when>
    <thetext>Hello Martin Robinson,

Please review again. :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>272579</commentid>
    <comment_count>28</comment_count>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2010-08-31 19:30:56 -0700</bug_when>
    <thetext>Hello Martin Robinson,

I am looking forward to land this patch in mainline.
I&apos;d like to get your opinion regarding your patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>272633</commentid>
    <comment_count>29</comment_count>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2010-08-31 22:01:40 -0700</bug_when>
    <thetext>wrong expression : &quot;your patch&quot; =&gt; &quot;my patch&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>272641</commentid>
    <comment_count>30</comment_count>
      <attachid>65682</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2010-08-31 22:23:42 -0700</bug_when>
    <thetext>Comment on attachment 65682
Patch

LGTM.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>272651</commentid>
    <comment_count>31</comment_count>
      <attachid>65682</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-08-31 23:05:14 -0700</bug_when>
    <thetext>Comment on attachment 65682
Patch

Clearing flags on attachment: 65682

Committed r66578: &lt;http://trac.webkit.org/changeset/66578&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>272652</commentid>
    <comment_count>32</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-08-31 23:05:20 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>65250</attachid>
            <date>2010-08-24 03:05:55 -0700</date>
            <delta_ts>2010-08-25 00:45:09 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>patch-platform-video.txt</filename>
            <type>text/plain</type>
            <size>3234</size>
            <attacher name="Gyuyoung Kim">gyuyoung.kim</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
ZDI5ODhmMi4uMmUyNDkxYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wOC0yNCAgR3l1eW91bmcgS2lt
ICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdIEFkZCBQbGF0Zm9ybVZpZGVvV2luZG93RWZsLmNw
cCBmb3IgV2ViS2l0IEVGTAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9NDQ1MDgKKworICAgICAgICBBZGQgUGxhdGZvcm1WaWRlb1dpbmRvd0VmbC5jcHAg
aW4gb3JkZXIgdG8gdXNlIGdzdHJlYW1lciBieSAKKyAgICAgICAgV2ViS2l0IEVGTC4KKworICAg
ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9QbGF0Zm9ybVZpZGVvV2luZG93Lmg6
CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1BsYXRmb3JtVmlkZW9XaW5k
b3dFZmwuY3BwOiBBZGRlZC4KKyAgICAgICAgKFBsYXRmb3JtVmlkZW9XaW5kb3c6OlBsYXRmb3Jt
VmlkZW9XaW5kb3cpOgorICAgICAgICAoUGxhdGZvcm1WaWRlb1dpbmRvdzo6flBsYXRmb3JtVmlk
ZW9XaW5kb3cpOgorCiAyMDEwLTA4LTI0ICBBcml5YSBIaWRheWF0ICA8YXJpeWFAc2VuY2hhLmNv
bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KZGlmZiAtLWdpdCBhL1dl
YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1BsYXRmb3JtVmlkZW9XaW5kb3cuaCBi
L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1BsYXRmb3JtVmlkZW9XaW5kb3cu
aAppbmRleCA4M2RjNWRkLi4xN2NlNDI5IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dy
YXBoaWNzL2dzdHJlYW1lci9QbGF0Zm9ybVZpZGVvV2luZG93LmgKKysrIGIvV2ViQ29yZS9wbGF0
Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvUGxhdGZvcm1WaWRlb1dpbmRvdy5oCkBAIC0zMCw2ICsz
MCwxMiBAQAogdHlwZWRlZiBHdGtXaWRnZXQgUGxhdGZvcm1XaW5kb3dUeXBlOwogI2VuZGlmCiAK
KyNpZiBQTEFURk9STShFRkwpCisjaWYgRU5BQkxFKEdMSUJfU1VQUE9SVCkKKyNpbmNsdWRlIDxn
bGliLmg+CisjZW5kaWYKKyNlbmRpZgorCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIGNsYXNzIFBs
YXRmb3JtVmlkZW9XaW5kb3cgOiBwdWJsaWMgUmVmQ291bnRlZDxQbGF0Zm9ybVZpZGVvV2luZG93
PiB7CkBAIC0zOSwxMiArNDUsMTYgQEAgY2xhc3MgUGxhdGZvcm1WaWRlb1dpbmRvdyA6IHB1Ymxp
YyBSZWZDb3VudGVkPFBsYXRmb3JtVmlkZW9XaW5kb3c+IHsKICAgICAgICAgUGxhdGZvcm1WaWRl
b1dpbmRvdygpOwogICAgICAgICB+UGxhdGZvcm1WaWRlb1dpbmRvdygpOwogCisjaWYgUExBVEZP
Uk0oR1RLKQogICAgICAgICBQbGF0Zm9ybVdpbmRvd1R5cGUqIHdpbmRvdygpIGNvbnN0IHsgcmV0
dXJuIG1fd2luZG93OyB9CisjZW5kaWYKICAgICAgICAgZ3Vsb25nIHZpZGVvV2luZG93SWQoKSBj
b25zdCB7IHJldHVybiBtX3ZpZGVvV2luZG93SWQ7IH0KIAogICAgIHByaXZhdGU6CiAgICAgICAg
IGd1bG9uZyBtX3ZpZGVvV2luZG93SWQ7CisjaWYgUExBVEZPUk0oR1RLKQogICAgICAgICBQbGF0
Zm9ybVdpbmRvd1R5cGUqIG1fdmlkZW9XaW5kb3c7CisjZW5kaWYKICAgICAgICAgUGxhdGZvcm1X
aW5kb3dUeXBlKiBtX3dpbmRvdzsKICAgICB9OwogfQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0
Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvUGxhdGZvcm1WaWRlb1dpbmRvd0VmbC5jcHAgYi9XZWJD
b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9QbGF0Zm9ybVZpZGVvV2luZG93RWZsLmNw
cAppbmRleCBlNjlkZTI5Li41YzBlNmVhIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dy
YXBoaWNzL2dzdHJlYW1lci9QbGF0Zm9ybVZpZGVvV2luZG93RWZsLmNwcAorKysgYi9XZWJDb3Jl
L3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9QbGF0Zm9ybVZpZGVvV2luZG93RWZsLmNwcApA
QCAtMCwwICsxLDM1IEBACisvKgorICogQ29weXJpZ2h0IChDKSAyMDEwIFNhbXN1bmcgRWxlY3Ry
b25pY3MKKyAqCisgKiBUaGlzIGxpYnJhcnkgaXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRp
c3RyaWJ1dGUgaXQgYW5kL29yCisgKiBtb2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBH
TlUgTGlicmFyeSBHZW5lcmFsIFB1YmxpYworICogTGljZW5zZSBhcyBwdWJsaXNoZWQgYnkgdGhl
IEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbjsgZWl0aGVyCisgKiB2ZXJzaW9uIDIgb2YgdGhlIExp
Y2Vuc2UsIG9yIChhdCB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24uCisgKgorICogVGhp
cyBsaWJyYXJ5IGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1c2Vm
dWwsCisgKiBidXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1wbGll
ZCB3YXJyYW50eSBvZgorICogTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElD
VUxBUiBQVVJQT1NFLiAgU2VlIHRoZSBHTlUKKyAqIExpYnJhcnkgR2VuZXJhbCBQdWJsaWMgTGlj
ZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgorICoKKyAqIFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBh
IGNvcHkgb2YgdGhlIEdOVSBMaWJyYXJ5IEdlbmVyYWwgUHVibGljIExpY2Vuc2UKKyAqIGFsb25n
IHdpdGggdGhpcyBsaWJyYXJ5OyBzZWUgdGhlIGZpbGUgQ09QWUlORy5MSUIuICBJZiBub3QsIHdy
aXRlIHRvCisgKiB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMuLCA1MSBGcmFua2xp
biBTdHJlZXQsIEZpZnRoIEZsb29yLAorICogQm9zdG9uLCBNQSAwMjExMC0xMzAxLCBVU0EuCisg
Ki8KKworI2luY2x1ZGUgImNvbmZpZy5oIgorI2luY2x1ZGUgIlBsYXRmb3JtVmlkZW9XaW5kb3cu
aCIKKworI2luY2x1ZGUgIk5vdEltcGxlbWVudGVkLmgiCisKK3VzaW5nIG5hbWVzcGFjZSBXZWJD
b3JlOworCitQbGF0Zm9ybVZpZGVvV2luZG93OjpQbGF0Zm9ybVZpZGVvV2luZG93KCkKK3sKKyAg
ICBub3RJbXBsZW1lbnRlZCgpOworfQorCitQbGF0Zm9ybVZpZGVvV2luZG93Ojp+UGxhdGZvcm1W
aWRlb1dpbmRvdygpCit7CisgICAgbm90SW1wbGVtZW50ZWQoKTsKK30K
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>65381</attachid>
            <date>2010-08-25 00:45:09 -0700</date>
            <delta_ts>2010-08-25 02:43:54 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>patch-platform-video.txt</filename>
            <type>text/plain</type>
            <size>2805</size>
            <attacher name="Gyuyoung Kim">gyuyoung.kim</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
ZDI5ODhmMi4uMmUyNDkxYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wOC0yNCAgR3l1eW91bmcgS2lt
ICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdIEFkZCBQbGF0Zm9ybVZpZGVvV2luZG93RWZsLmNw
cCBmb3IgV2ViS2l0IEVGTAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9NDQ1MDgKKworICAgICAgICBBZGQgUGxhdGZvcm1WaWRlb1dpbmRvd0VmbC5jcHAg
aW4gb3JkZXIgdG8gdXNlIGdzdHJlYW1lciBieSAKKyAgICAgICAgV2ViS2l0IEVGTC4KKworICAg
ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9QbGF0Zm9ybVZpZGVvV2luZG93Lmg6
CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1BsYXRmb3JtVmlkZW9XaW5k
b3dFZmwuY3BwOiBBZGRlZC4KKyAgICAgICAgKFBsYXRmb3JtVmlkZW9XaW5kb3c6OlBsYXRmb3Jt
VmlkZW9XaW5kb3cpOgorICAgICAgICAoUGxhdGZvcm1WaWRlb1dpbmRvdzo6flBsYXRmb3JtVmlk
ZW9XaW5kb3cpOgorCiAyMDEwLTA4LTI0ICBBcml5YSBIaWRheWF0ICA8YXJpeWFAc2VuY2hhLmNv
bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KZGlmZiAtLWdpdCBhL1dl
YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1BsYXRmb3JtVmlkZW9XaW5kb3cuaCBi
L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1BsYXRmb3JtVmlkZW9XaW5kb3cu
aAppbmRleCA4M2RjNWRkLi41NDJmMWM5IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dy
YXBoaWNzL2dzdHJlYW1lci9QbGF0Zm9ybVZpZGVvV2luZG93LmgKKysrIGIvV2ViQ29yZS9wbGF0
Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvUGxhdGZvcm1WaWRlb1dpbmRvdy5oCkBAIC0yOCw2ICsy
OCwxNSBAQAogI2lmIFBMQVRGT1JNKEdUSykKICNpbmNsdWRlIDxndGsvZ3RrLmg+CiB0eXBlZGVm
IEd0a1dpZGdldCBQbGF0Zm9ybVdpbmRvd1R5cGU7CisjZWxpZiBQTEFURk9STShFRkwpCisjaW5j
bHVkZSAiV2lkZ2V0LmgiCit0eXBlZGVmIFBsYXRmb3JtV2lkZ2V0IFBsYXRmb3JtV2luZG93VHlw
ZTsKKyNlbmRpZgorCisjaWYgUExBVEZPUk0oRUZMKQorI2lmIEVOQUJMRShHTElCX1NVUFBPUlQp
CisjaW5jbHVkZSA8Z2xpYi5oPgorI2VuZGlmCiAjZW5kaWYKIAogbmFtZXNwYWNlIFdlYkNvcmUg
ewpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvUGxhdGZv
cm1WaWRlb1dpbmRvd0VmbC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1l
ci9QbGF0Zm9ybVZpZGVvV2luZG93RWZsLmNwcAppbmRleCBlNjlkZTI5Li41YzBlNmVhIDEwMDY0
NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9QbGF0Zm9ybVZpZGVv
V2luZG93RWZsLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9Q
bGF0Zm9ybVZpZGVvV2luZG93RWZsLmNwcApAQCAtMCwwICsxLDM1IEBACisvKgorICogQ29weXJp
Z2h0IChDKSAyMDEwIFNhbXN1bmcgRWxlY3Ryb25pY3MKKyAqCisgKiBUaGlzIGxpYnJhcnkgaXMg
ZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yCisgKiBtb2RpZnkg
aXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgTGlicmFyeSBHZW5lcmFsIFB1YmxpYworICog
TGljZW5zZSBhcyBwdWJsaXNoZWQgYnkgdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbjsgZWl0
aGVyCisgKiB2ZXJzaW9uIDIgb2YgdGhlIExpY2Vuc2UsIG9yIChhdCB5b3VyIG9wdGlvbikgYW55
IGxhdGVyIHZlcnNpb24uCisgKgorICogVGhpcyBsaWJyYXJ5IGlzIGRpc3RyaWJ1dGVkIGluIHRo
ZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsCisgKiBidXQgV0lUSE9VVCBBTlkgV0FSUkFO
VFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBvZgorICogTUVSQ0hBTlRBQklM
SVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZSBHTlUKKyAq
IExpYnJhcnkgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgorICoKKyAq
IFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkgb2YgdGhlIEdOVSBMaWJyYXJ5IEdlbmVy
YWwgUHVibGljIExpY2Vuc2UKKyAqIGFsb25nIHdpdGggdGhpcyBsaWJyYXJ5OyBzZWUgdGhlIGZp
bGUgQ09QWUlORy5MSUIuICBJZiBub3QsIHdyaXRlIHRvCisgKiB0aGUgRnJlZSBTb2Z0d2FyZSBG
b3VuZGF0aW9uLCBJbmMuLCA1MSBGcmFua2xpbiBTdHJlZXQsIEZpZnRoIEZsb29yLAorICogQm9z
dG9uLCBNQSAwMjExMC0xMzAxLCBVU0EuCisgKi8KKworI2luY2x1ZGUgImNvbmZpZy5oIgorI2lu
Y2x1ZGUgIlBsYXRmb3JtVmlkZW9XaW5kb3cuaCIKKworI2luY2x1ZGUgIk5vdEltcGxlbWVudGVk
LmgiCisKK3VzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOworCitQbGF0Zm9ybVZpZGVvV2luZG93OjpQ
bGF0Zm9ybVZpZGVvV2luZG93KCkKK3sKKyAgICBub3RJbXBsZW1lbnRlZCgpOworfQorCitQbGF0
Zm9ybVZpZGVvV2luZG93Ojp+UGxhdGZvcm1WaWRlb1dpbmRvdygpCit7CisgICAgbm90SW1wbGVt
ZW50ZWQoKTsKK30K
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>65388</attachid>
            <date>2010-08-25 02:43:54 -0700</date>
            <delta_ts>2010-08-26 23:58:49 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>patch-platform-video.txt</filename>
            <type>text/plain</type>
            <size>3382</size>
            <attacher name="Gyuyoung Kim">gyuyoung.kim</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
ZDI5ODhmMi4uMmUyNDkxYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wOC0yNCAgR3l1eW91bmcgS2lt
ICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdIEFkZCBQbGF0Zm9ybVZpZGVvV2luZG93RWZsLmNw
cCBmb3IgV2ViS2l0IEVGTAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9NDQ1MDgKKworICAgICAgICBBZGQgUGxhdGZvcm1WaWRlb1dpbmRvd0VmbC5jcHAg
aW4gb3JkZXIgdG8gdXNlIGdzdHJlYW1lciBieSAKKyAgICAgICAgV2ViS2l0IEVGTC4KKworICAg
ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9QbGF0Zm9ybVZpZGVvV2luZG93Lmg6
CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1BsYXRmb3JtVmlkZW9XaW5k
b3dFZmwuY3BwOiBBZGRlZC4KKyAgICAgICAgKFBsYXRmb3JtVmlkZW9XaW5kb3c6OlBsYXRmb3Jt
VmlkZW9XaW5kb3cpOgorICAgICAgICAoUGxhdGZvcm1WaWRlb1dpbmRvdzo6flBsYXRmb3JtVmlk
ZW9XaW5kb3cpOgorCiAyMDEwLTA4LTI0ICBBcml5YSBIaWRheWF0ICA8YXJpeWFAc2VuY2hhLmNv
bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KZGlmZiAtLWdpdCBhL1dl
YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1BsYXRmb3JtVmlkZW9XaW5kb3cuaCBi
L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1BsYXRmb3JtVmlkZW9XaW5kb3cu
aAppbmRleCA4M2RjNWRkLi44NjFjNTk2IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dy
YXBoaWNzL2dzdHJlYW1lci9QbGF0Zm9ybVZpZGVvV2luZG93LmgKKysrIGIvV2ViQ29yZS9wbGF0
Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvUGxhdGZvcm1WaWRlb1dpbmRvdy5oCkBAIC0yMiwxMiAr
MjIsMTcgQEAKIAogI2lmIEVOQUJMRShWSURFTykKIAorI2luY2x1ZGUgIldpZGdldC5oIgorCiAj
aW5jbHVkZSA8d3RmL1Bhc3NSZWZQdHIuaD4KICNpbmNsdWRlIDx3dGYvUmVmQ291bnRlZC5oPgog
CiAjaWYgUExBVEZPUk0oR1RLKQogI2luY2x1ZGUgPGd0ay9ndGsuaD4KLXR5cGVkZWYgR3RrV2lk
Z2V0IFBsYXRmb3JtV2luZG93VHlwZTsKKyNlbmRpZgorCisjaWYgIVBMQVRGT1JNKEVGTCkgfHwg
RU5BQkxFKEdMSUJfU1VQUE9SVCkKKyNpbmNsdWRlIDxnbGliLmg+CiAjZW5kaWYKIAogbmFtZXNw
YWNlIFdlYkNvcmUgewpAQCAtMzksMTMgKzQ0LDEzIEBAIGNsYXNzIFBsYXRmb3JtVmlkZW9XaW5k
b3cgOiBwdWJsaWMgUmVmQ291bnRlZDxQbGF0Zm9ybVZpZGVvV2luZG93PiB7CiAgICAgICAgIFBs
YXRmb3JtVmlkZW9XaW5kb3coKTsKICAgICAgICAgflBsYXRmb3JtVmlkZW9XaW5kb3coKTsKIAot
ICAgICAgICBQbGF0Zm9ybVdpbmRvd1R5cGUqIHdpbmRvdygpIGNvbnN0IHsgcmV0dXJuIG1fd2lu
ZG93OyB9CisgICAgICAgIFBsYXRmb3JtV2lkZ2V0IHdpbmRvdygpIGNvbnN0IHsgcmV0dXJuIG1f
d2luZG93OyB9CiAgICAgICAgIGd1bG9uZyB2aWRlb1dpbmRvd0lkKCkgY29uc3QgeyByZXR1cm4g
bV92aWRlb1dpbmRvd0lkOyB9CiAKICAgICBwcml2YXRlOgogICAgICAgICBndWxvbmcgbV92aWRl
b1dpbmRvd0lkOwotICAgICAgICBQbGF0Zm9ybVdpbmRvd1R5cGUqIG1fdmlkZW9XaW5kb3c7Ci0g
ICAgICAgIFBsYXRmb3JtV2luZG93VHlwZSogbV93aW5kb3c7CisgICAgICAgIFBsYXRmb3JtV2lk
Z2V0IG1fdmlkZW9XaW5kb3c7CisgICAgICAgIFBsYXRmb3JtV2lkZ2V0IG1fd2luZG93OwogICAg
IH07CiB9CiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVy
L1BsYXRmb3JtVmlkZW9XaW5kb3dFZmwuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9n
c3RyZWFtZXIvUGxhdGZvcm1WaWRlb1dpbmRvd0VmbC5jcHAKaW5kZXggZTY5ZGUyOS4uNWMwZTZl
YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvUGxhdGZv
cm1WaWRlb1dpbmRvd0VmbC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3Ry
ZWFtZXIvUGxhdGZvcm1WaWRlb1dpbmRvd0VmbC5jcHAKQEAgLTAsMCArMSwzNSBAQAorLyoKKyAq
IENvcHlyaWdodCAoQykgMjAxMCBTYW1zdW5nIEVsZWN0cm9uaWNzCisgKgorICogVGhpcyBsaWJy
YXJ5IGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vcgorICog
bW9kaWZ5IGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIExpYnJhcnkgR2VuZXJhbCBQdWJs
aWMKKyAqIExpY2Vuc2UgYXMgcHVibGlzaGVkIGJ5IHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRp
b247IGVpdGhlcgorICogdmVyc2lvbiAyIG9mIHRoZSBMaWNlbnNlLCBvciAoYXQgeW91ciBvcHRp
b24pIGFueSBsYXRlciB2ZXJzaW9uLgorICoKKyAqIFRoaXMgbGlicmFyeSBpcyBkaXN0cmlidXRl
ZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNlZnVsLAorICogYnV0IFdJVEhPVVQgQU5Z
IFdBUlJBTlRZOyB3aXRob3V0IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YKKyAqIE1FUkNI
QU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUg
R05VCisgKiBMaWJyYXJ5IEdlbmVyYWwgUHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4K
KyAqCisgKiBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgTGlicmFy
eSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlCisgKiBhbG9uZyB3aXRoIHRoaXMgbGlicmFyeTsgc2Vl
IHRoZSBmaWxlIENPUFlJTkcuTElCLiAgSWYgbm90LCB3cml0ZSB0bworICogdGhlIEZyZWUgU29m
dHdhcmUgRm91bmRhdGlvbiwgSW5jLiwgNTEgRnJhbmtsaW4gU3RyZWV0LCBGaWZ0aCBGbG9vciwK
KyAqIEJvc3RvbiwgTUEgMDIxMTAtMTMwMSwgVVNBLgorICovCisKKyNpbmNsdWRlICJjb25maWcu
aCIKKyNpbmNsdWRlICJQbGF0Zm9ybVZpZGVvV2luZG93LmgiCisKKyNpbmNsdWRlICJOb3RJbXBs
ZW1lbnRlZC5oIgorCit1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKKworUGxhdGZvcm1WaWRlb1dp
bmRvdzo6UGxhdGZvcm1WaWRlb1dpbmRvdygpCit7CisgICAgbm90SW1wbGVtZW50ZWQoKTsKK30K
KworUGxhdGZvcm1WaWRlb1dpbmRvdzo6flBsYXRmb3JtVmlkZW9XaW5kb3coKQoreworICAgIG5v
dEltcGxlbWVudGVkKCk7Cit9Cg==
</data>
<flag name="review"
          id="54161"
          type_id="1"
          status="-"
          setter="mrobinson"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>65682</attachid>
            <date>2010-08-26 23:58:49 -0700</date>
            <delta_ts>2010-08-31 23:05:14 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>patch-video.txt</filename>
            <type>text/plain</type>
            <size>4177</size>
            <attacher name="Gyuyoung Kim">gyuyoung.kim</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
M2MwNGZiNy4uOGQzNTA3OCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMC0wOC0yNiAgR3l1eW91bmcgS2lt
ICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdIEFkZCBQbGF0Zm9ybVZpZGVvV2luZG93RWZsLmNw
cCBmb3IgV2ViS2l0IEVGTAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9NDQ1MDgKKworICAgICAgICBBZGQgUGxhdGZvcm1WaWRlb1dpbmRvd0VmbC5jcHAg
aW4gb3JkZXIgdG8gdXNlIGdzdHJlYW1lciBieSAKKyAgICAgICAgV2ViS2l0IEVGTC4KKworICAg
ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9QbGF0Zm9ybVZpZGVvV2luZG93Lmg6
CisgICAgICAgIChXZWJDb3JlOjpQbGF0Zm9ybVZpZGVvV2luZG93Ojp3aW5kb3cpOgorICAgICAg
ICAoV2ViQ29yZTo6UGxhdGZvcm1WaWRlb1dpbmRvdzo6dmlkZW9XaW5kb3dJZCk6CisgICAgICAg
ICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1BsYXRmb3JtVmlkZW9XaW5kb3dFZmwuY3Bw
OiBBZGRlZC4KKyAgICAgICAgKFBsYXRmb3JtVmlkZW9XaW5kb3c6OlBsYXRmb3JtVmlkZW9XaW5k
b3cpOgorICAgICAgICAoUGxhdGZvcm1WaWRlb1dpbmRvdzo6flBsYXRmb3JtVmlkZW9XaW5kb3cp
OgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9QbGF0Zm9ybVZpZGVvV2lu
ZG93R3RrLmNwcDogSW5jbHVkZSA8Z3RrL2d0ay5oPiBkaXJlY3RseS4KKwogMjAxMC0wOC0yNSAg
WGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFy
dGluIFJvYmluc29uLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3Ry
ZWFtZXIvUGxhdGZvcm1WaWRlb1dpbmRvdy5oIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9n
c3RyZWFtZXIvUGxhdGZvcm1WaWRlb1dpbmRvdy5oCmluZGV4IDgzZGM1ZGQuLjhkOTlmMDUgMTAw
NjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1BsYXRmb3JtVmlk
ZW9XaW5kb3cuaAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9QbGF0
Zm9ybVZpZGVvV2luZG93LmgKQEAgLTIyLDE0ICsyMiwxMCBAQAogCiAjaWYgRU5BQkxFKFZJREVP
KQogCisjaW5jbHVkZSAiV2lkZ2V0LmgiCiAjaW5jbHVkZSA8d3RmL1Bhc3NSZWZQdHIuaD4KICNp
bmNsdWRlIDx3dGYvUmVmQ291bnRlZC5oPgogCi0jaWYgUExBVEZPUk0oR1RLKQotI2luY2x1ZGUg
PGd0ay9ndGsuaD4KLXR5cGVkZWYgR3RrV2lkZ2V0IFBsYXRmb3JtV2luZG93VHlwZTsKLSNlbmRp
ZgotCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIGNsYXNzIFBsYXRmb3JtVmlkZW9XaW5kb3cgOiBw
dWJsaWMgUmVmQ291bnRlZDxQbGF0Zm9ybVZpZGVvV2luZG93PiB7CkBAIC0zOSwxMyArMzUsMTMg
QEAgY2xhc3MgUGxhdGZvcm1WaWRlb1dpbmRvdyA6IHB1YmxpYyBSZWZDb3VudGVkPFBsYXRmb3Jt
VmlkZW9XaW5kb3c+IHsKICAgICAgICAgUGxhdGZvcm1WaWRlb1dpbmRvdygpOwogICAgICAgICB+
UGxhdGZvcm1WaWRlb1dpbmRvdygpOwogCi0gICAgICAgIFBsYXRmb3JtV2luZG93VHlwZSogd2lu
ZG93KCkgY29uc3QgeyByZXR1cm4gbV93aW5kb3c7IH0KLSAgICAgICAgZ3Vsb25nIHZpZGVvV2lu
ZG93SWQoKSBjb25zdCB7IHJldHVybiBtX3ZpZGVvV2luZG93SWQ7IH0KKyAgICAgICAgUGxhdGZv
cm1XaWRnZXQgd2luZG93KCkgY29uc3QgeyByZXR1cm4gbV93aW5kb3c7IH0KKyAgICAgICAgdW5z
aWduZWQgbG9uZyB2aWRlb1dpbmRvd0lkKCkgY29uc3QgeyByZXR1cm4gbV92aWRlb1dpbmRvd0lk
OyB9CiAKICAgICBwcml2YXRlOgotICAgICAgICBndWxvbmcgbV92aWRlb1dpbmRvd0lkOwotICAg
ICAgICBQbGF0Zm9ybVdpbmRvd1R5cGUqIG1fdmlkZW9XaW5kb3c7Ci0gICAgICAgIFBsYXRmb3Jt
V2luZG93VHlwZSogbV93aW5kb3c7CisgICAgICAgIHVuc2lnbmVkIGxvbmcgbV92aWRlb1dpbmRv
d0lkOworICAgICAgICBQbGF0Zm9ybVdpZGdldCBtX3ZpZGVvV2luZG93OworICAgICAgICBQbGF0
Zm9ybVdpZGdldCBtX3dpbmRvdzsKICAgICB9OwogfQogCmRpZmYgLS1naXQgYS9XZWJDb3JlL3Bs
YXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9QbGF0Zm9ybVZpZGVvV2luZG93RWZsLmNwcCBiL1dl
YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1BsYXRmb3JtVmlkZW9XaW5kb3dFZmwu
Y3BwCmluZGV4IGU2OWRlMjkuLjVjMGU2ZWEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0v
Z3JhcGhpY3MvZ3N0cmVhbWVyL1BsYXRmb3JtVmlkZW9XaW5kb3dFZmwuY3BwCisrKyBiL1dlYkNv
cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1BsYXRmb3JtVmlkZW9XaW5kb3dFZmwuY3Bw
CkBAIC0wLDAgKzEsMzUgQEAKKy8qCisgKiBDb3B5cmlnaHQgKEMpIDIwMTAgU2Ftc3VuZyBFbGVj
dHJvbmljcworICoKKyAqIFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJl
ZGlzdHJpYnV0ZSBpdCBhbmQvb3IKKyAqIG1vZGlmeSBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhl
IEdOVSBMaWJyYXJ5IEdlbmVyYWwgUHVibGljCisgKiBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieSB0
aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uOyBlaXRoZXIKKyAqIHZlcnNpb24gMiBvZiB0aGUg
TGljZW5zZSwgb3IgKGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4KKyAqCisgKiBU
aGlzIGxpYnJhcnkgaXMgZGlzdHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVz
ZWZ1bCwKKyAqIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBs
aWVkIHdhcnJhbnR5IG9mCisgKiBNRVJDSEFOVEFCSUxJVFkgb3IgRklUTkVTUyBGT1IgQSBQQVJU
SUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlIEdOVQorICogTGlicmFyeSBHZW5lcmFsIFB1YmxpYyBM
aWNlbnNlIGZvciBtb3JlIGRldGFpbHMuCisgKgorICogWW91IHNob3VsZCBoYXZlIHJlY2VpdmVk
IGEgY29weSBvZiB0aGUgR05VIExpYnJhcnkgR2VuZXJhbCBQdWJsaWMgTGljZW5zZQorICogYWxv
bmcgd2l0aCB0aGlzIGxpYnJhcnk7IHNlZSB0aGUgZmlsZSBDT1BZSU5HLkxJQi4gIElmIG5vdCwg
d3JpdGUgdG8KKyAqIHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4sIDUxIEZyYW5r
bGluIFN0cmVldCwgRmlmdGggRmxvb3IsCisgKiBCb3N0b24sIE1BIDAyMTEwLTEzMDEsIFVTQS4K
KyAqLworCisjaW5jbHVkZSAiY29uZmlnLmgiCisjaW5jbHVkZSAiUGxhdGZvcm1WaWRlb1dpbmRv
dy5oIgorCisjaW5jbHVkZSAiTm90SW1wbGVtZW50ZWQuaCIKKwordXNpbmcgbmFtZXNwYWNlIFdl
YkNvcmU7CisKK1BsYXRmb3JtVmlkZW9XaW5kb3c6OlBsYXRmb3JtVmlkZW9XaW5kb3coKQorewor
ICAgIG5vdEltcGxlbWVudGVkKCk7Cit9CisKK1BsYXRmb3JtVmlkZW9XaW5kb3c6On5QbGF0Zm9y
bVZpZGVvV2luZG93KCkKK3sKKyAgICBub3RJbXBsZW1lbnRlZCgpOworfQpkaWZmIC0tZ2l0IGEv
V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvUGxhdGZvcm1WaWRlb1dpbmRvd0d0
ay5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9QbGF0Zm9ybVZpZGVv
V2luZG93R3RrLmNwcAppbmRleCAxODVmNTM1Li5jNWY4MzVjIDEwMDY0NAotLS0gYS9XZWJDb3Jl
L3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9QbGF0Zm9ybVZpZGVvV2luZG93R3RrLmNwcAor
KysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9QbGF0Zm9ybVZpZGVvV2lu
ZG93R3RrLmNwcApAQCAtMjAsNiArMjAsNyBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1
ZGUgIlBsYXRmb3JtVmlkZW9XaW5kb3cuaCIKIAorI2luY2x1ZGUgPGd0ay9ndGsuaD4KICNpZmRl
ZiBHREtfV0lORE9XSU5HX1gxMQogI2luY2x1ZGUgPGdkay9nZGt4Lmg+IC8vIGZvciBHREtfV0lO
RE9XX1hJRAogI2VuZGlmCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>