44504 2010-08-24 01:56:52 -0700 Remove null-checks from DeviceOrientationController 2010-08-24 12:53:10 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 hans webkit-unassigned commit-queue steveblock oldest_to_newest 268418 0 hans 2010-08-24 01:56:52 -0700 Remove null-checks from DeviceOrientationController 268423 1 65242 hans 2010-08-24 02:02:19 -0700 Created attachment 65242 Patch 268429 2 65242 steveblock 2010-08-24 02:14:59 -0700 Comment on attachment 65242 Patch r=me 268727 3 65242 commit-queue 2010-08-24 12:53:06 -0700 Comment on attachment 65242 Patch Clearing flags on attachment: 65242 Committed r65924: <http://trac.webkit.org/changeset/65924> 268728 4 commit-queue 2010-08-24 12:53:10 -0700 All reviewed patches have been landed. Closing bug. 65242 2010-08-24 02:02:19 -0700 2010-08-24 12:53:06 -0700 Patch bug-44504-20100824100217.patch text/plain 3741 hans ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDE1YTAxNTk4YTcyMzFlZDE4ZjRlZTQ0ZjYxZWNkZDg4MGJjMTg2Ni4uNDUxMWU0MWYzYTViMGNm MTVkNDFjNzQwYWYzODZlYWYyNjdhZWNlYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMC0wOC0yNCAgSGFu cyBXZW5uYm9yZyAgPGhhbnNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBudWxsLWNoZWNrcyBmcm9tIERldmljZU9y aWVudGF0aW9uQ29udHJvbGxlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDQ1MDQKKworICAgICAgICBSZW1vdmUgY2hlY2tzIGZvciBtX2NsaWVudCBi ZWluZyBOVUxMIGZyb20gRGV2aWNlT3JpZW50YXRpb25Db250cm9sbGVyLgorICAgICAgICBJdCB3 aWxsIG5ldmVyIGJlIE5VTEwsIGFuZCB0aGlzIGlzIGNoZWNrZWQgYnkgYW4gQVNTRVJUIG9uIGNv bnN0cnVjdGlvbi4KKworICAgICAgICBXaWxsIGJlIGNvdmVyZWQgYnkgbGF5b3V0IHRlc3RzIGZv ciBkZXZpY2Ugb3JpZW50YXRpb24uCisKKyAgICAgICAgKiBkb20vRGV2aWNlT3JpZW50YXRpb25D b250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRldmljZU9yaWVudGF0aW9uQ29udHJv bGxlcjo6dGltZXJGaXJlZCk6CisgICAgICAgIChXZWJDb3JlOjpEZXZpY2VPcmllbnRhdGlvbkNv bnRyb2xsZXI6OmFkZExpc3RlbmVyKToKKyAgICAgICAgKFdlYkNvcmU6OkRldmljZU9yaWVudGF0 aW9uQ29udHJvbGxlcjo6cmVtb3ZlTGlzdGVuZXIpOgorICAgICAgICAoV2ViQ29yZTo6RGV2aWNl T3JpZW50YXRpb25Db250cm9sbGVyOjpyZW1vdmVBbGxMaXN0ZW5lcnMpOgorCiAyMDEwLTA4LTIz ICBBbmRyZWFzIEtsaW5nICA8YW5kcmVhcy5rbGluZ0Bub2tpYS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgVG9yIEFybmUgVmVzdGLDuC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvZG9tL0Rldmlj ZU9yaWVudGF0aW9uQ29udHJvbGxlci5jcHAgYi9XZWJDb3JlL2RvbS9EZXZpY2VPcmllbnRhdGlv bkNvbnRyb2xsZXIuY3BwCmluZGV4IDExMTU3N2YzMWQyMDA1ZmUxYWY0MWEzY2EyMGQ3MGViYzYz NzY1MjIuLmE3NDQzNjZkMGE1YWZhMDUzMjA3NGI0MjVkZDgyNTMyNWIyNjY2ZTIgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvZG9tL0RldmljZU9yaWVudGF0aW9uQ29udHJvbGxlci5jcHAKKysrIGIvV2Vi Q29yZS9kb20vRGV2aWNlT3JpZW50YXRpb25Db250cm9sbGVyLmNwcApAQCAtNDQsOSArNDQsOSBA QCBEZXZpY2VPcmllbnRhdGlvbkNvbnRyb2xsZXI6OkRldmljZU9yaWVudGF0aW9uQ29udHJvbGxl cihQYWdlKiBwYWdlLCBEZXZpY2VPcmllbgogdm9pZCBEZXZpY2VPcmllbnRhdGlvbkNvbnRyb2xs ZXI6OnRpbWVyRmlyZWQoVGltZXI8RGV2aWNlT3JpZW50YXRpb25Db250cm9sbGVyPiogdGltZXIp CiB7CiAgICAgQVNTRVJUX1VOVVNFRCh0aW1lciwgdGltZXIgPT0gJm1fdGltZXIpOwotICAgIEFT U0VSVCghbV9jbGllbnQgfHwgbV9jbGllbnQtPmxhc3RPcmllbnRhdGlvbigpKTsKKyAgICBBU1NF UlQobV9jbGllbnQtPmxhc3RPcmllbnRhdGlvbigpKTsKIAotICAgIFJlZlB0cjxEZXZpY2VPcmll bnRhdGlvbj4gb3JpZW50YXRpb24gPSBtX2NsaWVudCA/ICBtX2NsaWVudC0+bGFzdE9yaWVudGF0 aW9uKCkgOiBEZXZpY2VPcmllbnRhdGlvbjo6Y3JlYXRlKCk7CisgICAgUmVmUHRyPERldmljZU9y aWVudGF0aW9uPiBvcmllbnRhdGlvbiA9IG1fY2xpZW50LT5sYXN0T3JpZW50YXRpb24oKTsKICAg ICBSZWZQdHI8RGV2aWNlT3JpZW50YXRpb25FdmVudD4gZXZlbnQgPSBEZXZpY2VPcmllbnRhdGlv bkV2ZW50OjpjcmVhdGUoZXZlbnROYW1lcygpLmRldmljZW9yaWVudGF0aW9uRXZlbnQsIG9yaWVu dGF0aW9uLmdldCgpKTsKIAogICAgIFZlY3RvcjxET01XaW5kb3cqPiBsaXN0ZW5lcnNWZWN0b3I7 CkBAIC01OCwxMSArNTgsMTAgQEAgdm9pZCBEZXZpY2VPcmllbnRhdGlvbkNvbnRyb2xsZXI6OnRp bWVyRmlyZWQoVGltZXI8RGV2aWNlT3JpZW50YXRpb25Db250cm9sbGVyPioKIAogdm9pZCBEZXZp Y2VPcmllbnRhdGlvbkNvbnRyb2xsZXI6OmFkZExpc3RlbmVyKERPTVdpbmRvdyogd2luZG93KQog ewotICAgIC8vIElmIG5vIGNsaWVudCBpcyBwcmVzZW50LCB3ZSBzaG91bGQgZmlyZSBhbiBldmVu dCB3aXRoIGFsbCBwYXJhbWV0ZXJzIG51bGwuIElmCi0gICAgLy8gdGhlIGNsaWVudCBhbHJlYWR5 IGhhcyBhbiBvcmllbnRhdGlvbiwgd2Ugc2hvdWxkIGZpcmUgYW4gZXZlbnQgd2l0aCB0aGF0Ci0g ICAgLy8gb3JpZW50YXRpb24uIEluIGJvdGggY2FzZXMsIHRoZSBldmVudCBpcyBmaXJlZCBhc3lu Y2hyb25vdXNseSwgYnV0IHdpdGhvdXQKKyAgICAvLyBJZiB0aGUgY2xpZW50IGFscmVhZHkgaGFz IGFuIG9yaWVudGF0aW9uLCB3ZSBzaG91bGQgZmlyZSBhbiBldmVudCB3aXRoIHRoYXQKKyAgICAv LyBvcmllbnRhdGlvbi4gVGhlIGV2ZW50IGlzIGZpcmVkIGFzeW5jaHJvbm91c2x5LCBidXQgd2l0 aG91dAogICAgIC8vIHdhaXRpbmcgZm9yIHRoZSBjbGllbnQgdG8gZ2V0IGEgbmV3IG9yaWVudGF0 aW9uLgotICAgIGlmICghbV9jbGllbnQgfHwgbV9jbGllbnQtPmxhc3RPcmllbnRhdGlvbigpKSB7 CisgICAgaWYgKG1fY2xpZW50LT5sYXN0T3JpZW50YXRpb24oKSkgewogICAgICAgICBtX25ld0xp c3RlbmVycy5hZGQod2luZG93KTsKICAgICAgICAgaWYgKCFtX3RpbWVyLmlzQWN0aXZlKCkpCiAg ICAgICAgICAgICBtX3RpbWVyLnN0YXJ0T25lU2hvdCgwKTsKQEAgLTcxLDcgKzcwLDcgQEAgdm9p ZCBEZXZpY2VPcmllbnRhdGlvbkNvbnRyb2xsZXI6OmFkZExpc3RlbmVyKERPTVdpbmRvdyogd2lu ZG93KQogICAgIC8vIFRoZSBjbGllbnQgbXVzdCBub3QgY2FsbCBiYWNrIHN5bmNocm9ub3VzbHku CiAgICAgYm9vbCB3YXNFbXB0eSA9IG1fbGlzdGVuZXJzLmlzRW1wdHkoKTsKICAgICBtX2xpc3Rl bmVycy5hZGQod2luZG93KTsKLSAgICBpZiAod2FzRW1wdHkgJiYgbV9jbGllbnQpCisgICAgaWYg KHdhc0VtcHR5KQogICAgICAgICBtX2NsaWVudC0+c3RhcnRVcGRhdGluZygpOwogfQogCkBAIC03 OSw3ICs3OCw3IEBAIHZvaWQgRGV2aWNlT3JpZW50YXRpb25Db250cm9sbGVyOjpyZW1vdmVMaXN0 ZW5lcihET01XaW5kb3cqIHdpbmRvdykKIHsKICAgICBtX2xpc3RlbmVycy5yZW1vdmUod2luZG93 KTsKICAgICBtX25ld0xpc3RlbmVycy5yZW1vdmUod2luZG93KTsKLSAgICBpZiAobV9saXN0ZW5l cnMuaXNFbXB0eSgpICYmIG1fY2xpZW50KQorICAgIGlmIChtX2xpc3RlbmVycy5pc0VtcHR5KCkp CiAgICAgICAgIG1fY2xpZW50LT5zdG9wVXBkYXRpbmcoKTsKIH0KIApAQCAtOTEsNyArOTAsNyBA QCB2b2lkIERldmljZU9yaWVudGF0aW9uQ29udHJvbGxlcjo6cmVtb3ZlQWxsTGlzdGVuZXJzKERP TVdpbmRvdyogd2luZG93KQogCiAgICAgbV9saXN0ZW5lcnMucmVtb3ZlQWxsKHdpbmRvdyk7CiAg ICAgbV9uZXdMaXN0ZW5lcnMucmVtb3ZlKHdpbmRvdyk7Ci0gICAgaWYgKG1fbGlzdGVuZXJzLmlz RW1wdHkoKSAmJiBtX2NsaWVudCkKKyAgICBpZiAobV9saXN0ZW5lcnMuaXNFbXB0eSgpKQogICAg ICAgICBtX2NsaWVudC0+c3RvcFVwZGF0aW5nKCk7CiB9CiAK