44501 2010-08-24 01:45:46 -0700 Deploy adoptPtr in WebCore/editing 2010-08-24 13:31:10 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth commit-queue darin eric oldest_to_newest 268403 0 abarth 2010-08-24 01:45:46 -0700 Deploy adoptPtr in WebCore/editing 268404 1 65237 abarth 2010-08-24 01:47:19 -0700 Created attachment 65237 Patch 268678 2 65237 abarth 2010-08-24 11:37:42 -0700 Comment on attachment 65237 Patch Clearing flags on attachment: 65237 Committed r65919: <http://trac.webkit.org/changeset/65919> 268679 3 abarth 2010-08-24 11:37:47 -0700 All reviewed patches have been landed. Closing bug. 268683 4 65237 commit-queue 2010-08-24 11:41:03 -0700 Comment on attachment 65237 Patch Rejecting patch 65237 from commit-queue. Unexpected failure when processing patch! Please file a bug against webkit-patch. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 65237, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1 Last 500 characters of output: cgi?id=65237&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=44501&ctype=xml Processing 1 patch from 1 bug. Cleaning working directory Processing patch 65237 from bug 44501. NOBODY (OOPS!) found in /Users/eseidel/Projects/CommitQueue/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /Users/eseidel/Projects/CommitQueue/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). 268716 5 darin 2010-08-24 12:30:16 -0700 The call to clear() seems unneeded. 268750 6 abarth 2010-08-24 13:31:10 -0700 (In reply to comment #5) > The call to clear() seems unneeded. Bug 44548. 65237 2010-08-24 01:47:19 -0700 2010-08-24 11:41:03 -0700 Patch bug-44501-20100824014718.patch text/plain 3148 abarth ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg M2FhMjRjZGFkNWY3YzAzY2ZhZjUwMGRkZDg2YjBiMmRmNGYyN2FjNi4uNDY1M2ZkMmEyMzUxM2Jj NDU5ZDFjNDUxNTY0YzE0ZmI4ZmJlMDZlOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNyBAQAogMjAxMC0wOC0yNCAgQWRh bSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIERlcGxveSBhZG9wdFB0ciBpbiBXZWJDb3JlL2VkaXRpbmcK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0NTAxCisK KyAgICAgICAgKiBlZGl0aW5nL0VkaXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFZGl0b3I6 OkVkaXRvcik6CisgICAgICAgICogZWRpdGluZy9UZXh0SXRlcmF0b3IuY3BwOgorICAgICAgICAo V2ViQ29yZTo6cGxhaW5UZXh0VG9NYWxsb2NBbGxvY2F0ZWRCdWZmZXIpOgorCisyMDEwLTA4LTI0 ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKICAgICAgICAgQnVpbGQgZml4LiAg bGVha1B0ciBkb2Vzbid0IGV4aXN0LCBjb250cmFyeSB0byBteSBkcmVhbXMuCiAKICAgICAgICAg KiBzdG9yYWdlL0lEQktleVRyZWUuaDoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvZWRpdGluZy9FZGl0 b3IuY3BwIGIvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAKaW5kZXggMDA1MmE1NTQzMmEyZDI4 YzlmYTc1NjMzZTY5YzU3NjA3NDZmNmZkNC4uYThhMzZmYzRiNDZmZTIxNDI2MjE1ZWM2ZGU1YjM4 NmM1ZWFlZWU0ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAKKysrIGIv V2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAKQEAgLTk5MiwxMiArOTkyLDEyIEBAIHZvaWQgRWRp dG9yOjpyZWFwcGxpZWRFZGl0aW5nKFBhc3NSZWZQdHI8RWRpdENvbW1hbmQ+IGNtZCkKIAogRWRp dG9yOjpFZGl0b3IoRnJhbWUqIGZyYW1lKQogICAgIDogbV9mcmFtZShmcmFtZSkKLSAgICAsIG1f ZGVsZXRlQnV0dG9uQ29udHJvbGxlcihuZXcgRGVsZXRlQnV0dG9uQ29udHJvbGxlcihmcmFtZSkp CisgICAgLCBtX2RlbGV0ZUJ1dHRvbkNvbnRyb2xsZXIoYWRvcHRQdHIobmV3IERlbGV0ZUJ1dHRv bkNvbnRyb2xsZXIoZnJhbWUpKSkKICAgICAsIG1faWdub3JlQ29tcG9zaXRpb25TZWxlY3Rpb25D aGFuZ2UoZmFsc2UpCiAgICAgLCBtX3Nob3VsZFN0YXJ0TmV3S2lsbFJpbmdTZXF1ZW5jZShmYWxz ZSkKICAgICAvLyBUaGlzIGlzIG9mZiBieSBkZWZhdWx0LCBzaW5jZSBtb3N0IGVkaXRvcnMgd2Fu dCB0aGlzIGJlaGF2aW9yICh0aGlzIG1hdGNoZXMgSUUgYnV0IG5vdCBGRikuCiAgICAgLCBtX3No b3VsZFN0eWxlV2l0aENTUyhmYWxzZSkKLSAgICAsIG1fa2lsbFJpbmcobmV3IEtpbGxSaW5nKQor ICAgICwgbV9raWxsUmluZyhhZG9wdFB0cihuZXcgS2lsbFJpbmcpKQogeyAKIH0KIApkaWZmIC0t Z2l0IGEvV2ViQ29yZS9lZGl0aW5nL1RleHRJdGVyYXRvci5jcHAgYi9XZWJDb3JlL2VkaXRpbmcv VGV4dEl0ZXJhdG9yLmNwcAppbmRleCAzOTAxM2MxZDM2MDgwOGEyNjBjMThmN2QyOGZmMWUxNzJi ZGFjYTliLi41ZGM0M2E0ZWQ0NTQzNDk4ZjhhNWU5Y2E4NmU5NmQ5ZjE2ODUwZGU5IDEwMDY0NAot LS0gYS9XZWJDb3JlL2VkaXRpbmcvVGV4dEl0ZXJhdG9yLmNwcAorKysgYi9XZWJDb3JlL2VkaXRp bmcvVGV4dEl0ZXJhdG9yLmNwcApAQCAtMjIyMyw3ICsyMjIzLDcgQEAgVUNoYXIqIHBsYWluVGV4 dFRvTWFsbG9jQWxsb2NhdGVkQnVmZmVyKGNvbnN0IFJhbmdlKiByLCB1bnNpZ25lZCYgYnVmZmVy TGVuZ3RoLAogICAgIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBjTWF4U2VnbWVudFNpemUgPSAxIDw8 IDE2OwogICAgIGJ1ZmZlckxlbmd0aCA9IDA7CiAgICAgdHlwZWRlZiBwYWlyPFVDaGFyKiwgdW5z aWduZWQ+IFRleHRTZWdtZW50OwotICAgIFZlY3RvcjxUZXh0U2VnbWVudD4qIHRleHRTZWdtZW50 cyA9IDA7CisgICAgT3duUHRyPFZlY3RvcjxUZXh0U2VnbWVudD4gPiB0ZXh0U2VnbWVudHM7CiAg ICAgVmVjdG9yPFVDaGFyPiB0ZXh0QnVmZmVyOwogICAgIHRleHRCdWZmZXIucmVzZXJ2ZUluaXRp YWxDYXBhY2l0eShjTWF4U2VnbWVudFNpemUpOwogICAgIGZvciAoVGV4dEl0ZXJhdG9yIGl0KHIs IGlzRGlzcGxheVN0cmluZyA/IFRleHRJdGVyYXRvckRlZmF1bHRCZWhhdmlvciA6IFRleHRJdGVy YXRvckVtaXRzVGV4dHNXaXRob3V0VHJhbnNjb2RpbmcpOyAhaXQuYXRFbmQoKTsgaXQuYWR2YW5j ZSgpKSB7CkBAIC0yMjMzLDcgKzIyMzMsNyBAQCBVQ2hhciogcGxhaW5UZXh0VG9NYWxsb2NBbGxv Y2F0ZWRCdWZmZXIoY29uc3QgUmFuZ2UqIHIsIHVuc2lnbmVkJiBidWZmZXJMZW5ndGgsCiAgICAg ICAgICAgICAgICAgZ290byBleGl0OwogICAgICAgICAgICAgbWVtY3B5KG5ld1NlZ21lbnRCdWZm ZXIsIHRleHRCdWZmZXIuZGF0YSgpLCB0ZXh0QnVmZmVyLnNpemUoKSAqIHNpemVvZihVQ2hhcikp OwogICAgICAgICAgICAgaWYgKCF0ZXh0U2VnbWVudHMpCi0gICAgICAgICAgICAgICAgdGV4dFNl Z21lbnRzID0gbmV3IFZlY3RvcjxUZXh0U2VnbWVudD47CisgICAgICAgICAgICAgICAgdGV4dFNl Z21lbnRzID0gYWRvcHRQdHIobmV3IFZlY3RvcjxUZXh0U2VnbWVudD4pOwogICAgICAgICAgICAg dGV4dFNlZ21lbnRzLT5hcHBlbmQobWFrZV9wYWlyKG5ld1NlZ21lbnRCdWZmZXIsICh1bnNpZ25l ZCl0ZXh0QnVmZmVyLnNpemUoKSkpOwogICAgICAgICAgICAgdGV4dEJ1ZmZlci5jbGVhcigpOwog ICAgICAgICB9CkBAIC0yMjY3LDcgKzIyNjcsNyBAQCBleGl0OgogICAgICAgICB1bnNpZ25lZCBz aXplID0gdGV4dFNlZ21lbnRzLT5zaXplKCk7CiAgICAgICAgIGZvciAodW5zaWduZWQgaSA9IDA7 IGkgPCBzaXplOyArK2kpCiAgICAgICAgICAgICBmcmVlKHRleHRTZWdtZW50cy0+YXQoaSkuZmly c3QpOwotICAgICAgICBkZWxldGUgdGV4dFNlZ21lbnRzOworICAgICAgICB0ZXh0U2VnbWVudHMu Y2xlYXIoKTsKICAgICB9CiAgICAgCiAgICAgaWYgKGlzRGlzcGxheVN0cmluZyAmJiByLT5vd25l ckRvY3VtZW50KCkpCg==