44497 2010-08-24 00:13:11 -0700 [EFL] Crash while hiding popup 2010-08-25 15:24:55 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 43324 0 k.czech webkit-unassigned abarth commit-queue eric gyuyoung.kim kenneth lucas.de.marchi luiz tonikitoo webkit.review.bot oldest_to_newest 268360 0 65221 k.czech 2010-08-24 00:13:11 -0700 Created attachment 65221 Patch corrects a crash while calling PopupMenuEfl destructor The attached patch prevents crash when PopupMenuEfl's destructor is called. It was noticed that in some circumstances popup menu is not shown and while destroying it, destructor tries to use undefined view to hide popup 268374 1 gyuyoung.kim 2010-08-24 00:42:27 -0700 You have to write bug's title, url and summary in Changelog as below, 2010-08-22 Rafael Antognolli <antognolli@profusion.mobi> 2 3 Reviewed by Antonio Gomes. 4 5 [EFL] Remove duplicated include entry from default theme. 6 https://bugs.webkit.org/show_bug.cgi?id=44345 7 8 This used to create the group webkit/widget/entry twice in 9 the theme. It's leading to a bug with the newer versions of 10 EFL. 11 12 * DefaultTheme/default.edc: Please add "[EFL]" prefix to this bug's title. 268388 2 65230 k.czech 2010-08-24 01:21:47 -0700 Created attachment 65230 This patch corrects crash while hiding popup 269242 3 lucas.de.marchi 2010-08-25 07:35:35 -0700 (In reply to comment #2) > Created an attachment (id=65230) [details] > This patch corrects crash while hiding popup As far as I remember, there's no way to destroy the Popup with no view defined (or the behavior changed in WebCore since its implementation). Could you provide a stack trace when it crashes? 269252 4 k.czech 2010-08-25 08:01:58 -0700 The trace is as follows: 1. Load www.wikipedia.org 2. Input text in search box (it was emphasized that "test" should be written), but it happens in any other 3. press "->" button next to the search This is a part of debug backtrace: #0 0x4069b90c in WebCore::PopupMenu::hide() () from /usr/lib/libewebkit.so.0 #1 0x4069b938 in WebCore::PopupMenu::~PopupMenu() () from /usr/lib/libewebkit.so.0 #2 0x4065ab18 in WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine() () from /usr/lib/libewebkit.so.0 #3 0x406339d0 in WebCore::RenderObject::arenaDelete(WebCore::RenderArena*, void*) () from /usr/lib/libewebkit.so.0 #4 0x403195e0 in WebCore::Node::detach() () from /usr/lib/libewebkit.so.0 #5 0x40305208 in WebCore::Element::detach() () from /usr/lib/libewebkit.so.0 ... 269445 5 lucas.de.marchi 2010-08-25 12:49:59 -0700 (In reply to comment #4) > The trace is as follows: > 1. Load www.wikipedia.org > 2. Input text in search box (it was emphasized that "test" should be written), but it happens in any other > 3. press "->" button next to the search > > This is a part of debug backtrace: > #0 0x4069b90c in WebCore::PopupMenu::hide() () from /usr/lib/libewebkit.so.0 > #1 0x4069b938 in WebCore::PopupMenu::~PopupMenu() () > from /usr/lib/libewebkit.so.0 > #2 0x4065ab18 in WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine() () from /usr/lib/libewebkit.so.0 > #3 0x406339d0 in WebCore::RenderObject::arenaDelete(WebCore::RenderArena*, void*) () from /usr/lib/libewebkit.so.0 > #4 0x403195e0 in WebCore::Node::detach() () from /usr/lib/libewebkit.so.0 > #5 0x40305208 in WebCore::Element::detach() () from /usr/lib/libewebkit.so.0 > ... Humn... maybe it's something related to bug 43324. I'm not a reviewer, just a informal r+. I'm CCing some reviewers. 269507 6 65230 commit-queue 2010-08-25 14:28:09 -0700 Comment on attachment 65230 This patch corrects crash while hiding popup Clearing flags on attachment: 65230 Committed r66042: <http://trac.webkit.org/changeset/66042> 269508 7 commit-queue 2010-08-25 14:28:14 -0700 All reviewed patches have been landed. Closing bug. 269546 8 webkit.review.bot 2010-08-25 15:24:55 -0700 http://trac.webkit.org/changeset/66042 might have broken Qt Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/66041 http://trac.webkit.org/changeset/66042 65221 2010-08-24 00:13:11 -0700 2010-08-24 00:13:11 -0700 Patch corrects a crash while calling PopupMenuEfl destructor PopupMenuEfl.patch text/plain 1001 k.czech ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTkzNGZiZi4uNTRhZTUxZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wOC0yMyAgS3J6eXN6dG9mIEN6 ZWNoICA8ay5jemVjaEBzYW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBDb25kaXRpb24gY2hlY2tzIGlmIG1fdmlldyBpcyBkZWZpbmVk CisgICAgICAgIGJlZm9yZSBwb3B1cCBpcyBoaWRlCisKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwv UG9wdXBNZW51RWZsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBvcHVwTWVudUVmbDo6flBvcHVw TWVudUVmbCk6CisKIDIwMTAtMDgtMTkgIEFuZHJlYXMgS2xpbmcgIDxhbmRyZWFzLmtsaW5nQG5v a2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNl bi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1BvcHVwTWVudUVmbC5jcHAgYi9X ZWJDb3JlL3BsYXRmb3JtL2VmbC9Qb3B1cE1lbnVFZmwuY3BwCmluZGV4IDQwMWYyNGYuLmE2Zjdh NTMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1BvcHVwTWVudUVmbC5jcHAKKysr IGIvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvUG9wdXBNZW51RWZsLmNwcApAQCAtNDMsNyArNDMsOCBA QCBQb3B1cE1lbnVFZmw6On5Qb3B1cE1lbnVFZmwoKQogewogICAgIC8vIFRlbGwgY2xpZW50IHRv IGRlc3Ryb3kgZGF0YSByZWxhdGVkIHRvIHRoaXMgcG9wdXAgc2luY2UgdGhpcyBvYmplY3QgaXMK ICAgICAvLyBnb2luZyBhd2F5LgotICAgIGhpZGUoKTsKKyAgICBpZiAobV92aWV3KQorICAgICAg ICBoaWRlKCk7CiB9CiAKIHZvaWQgUG9wdXBNZW51RWZsOjpzaG93KGNvbnN0IEludFJlY3QmIHJl Y3QsIEZyYW1lVmlldyogdmlldywgaW50IGluZGV4KQo= 65230 2010-08-24 01:21:47 -0700 2010-08-25 14:28:09 -0700 This patch corrects crash while hiding popup PopupMenuEfl.patch text/plain 1117 k.czech ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTkzNGZiZi4uMTQxYjA2NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wOC0yMyAgS3J6eXN6dG9mIEN6 ZWNoICA8ay5jemVjaEBzYW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbRUZMXSBDcmFzaCB3aGlsZSBjYWxsaW5nIFBvcHVwTWVudUVm bCBkZXN0cnVjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD00NDQ5NworCisgICAgICAgIENvbmRpdGlvbiBjaGVja3MgaWYgbV92aWV3IGlzIGRlZmlu ZWQKKyAgICAgICAgYmVmb3JlIHBvcHVwIGlzIGhpZGUKKworICAgICAgICAqIHBsYXRmb3JtL2Vm bC9Qb3B1cE1lbnVFZmwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UG9wdXBNZW51RWZsOjp+UG9w dXBNZW51RWZsKToKKwogMjAxMC0wOC0xOSAgQW5kcmVhcyBLbGluZyAgPGFuZHJlYXMua2xpbmdA bm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFu c2VuLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvUG9wdXBNZW51RWZsLmNwcCBi L1dlYkNvcmUvcGxhdGZvcm0vZWZsL1BvcHVwTWVudUVmbC5jcHAKaW5kZXggNDAxZjI0Zi4uYTZm N2E1MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvUG9wdXBNZW51RWZsLmNwcAor KysgYi9XZWJDb3JlL3BsYXRmb3JtL2VmbC9Qb3B1cE1lbnVFZmwuY3BwCkBAIC00Myw3ICs0Myw4 IEBAIFBvcHVwTWVudUVmbDo6flBvcHVwTWVudUVmbCgpCiB7CiAgICAgLy8gVGVsbCBjbGllbnQg dG8gZGVzdHJveSBkYXRhIHJlbGF0ZWQgdG8gdGhpcyBwb3B1cCBzaW5jZSB0aGlzIG9iamVjdCBp cwogICAgIC8vIGdvaW5nIGF3YXkuCi0gICAgaGlkZSgpOworICAgIGlmIChtX3ZpZXcpCisgICAg ICAgIGhpZGUoKTsKIH0KIAogdm9pZCBQb3B1cE1lbnVFZmw6OnNob3coY29uc3QgSW50UmVjdCYg cmVjdCwgRnJhbWVWaWV3KiB2aWV3LCBpbnQgaW5kZXgpCg==