44495 2010-08-24 00:12:03 -0700 [EFL] Url of HistoryItem was broken for special character like korean 2010-08-30 21:42:14 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 ryuan.choi webkit-unassigned antognolli+webkit commit-queue lucas.de.marchi oldest_to_newest 268357 0 ryuan.choi 2010-08-24 00:12:03 -0700 visiting any site after entered below site, url of history item was broken. http://ko.wikipedia.org/wiki/%EC%9C%84%ED%82%A4%EB%B0%B1%EA%B3%BC:%EB%8C%80%EB%AC%B8 (http://ko.wikipedia.org/wiki/위키백과:대문) It's because of simple implementation of ewk_fram_view_state_save. but I think that we can remove setTitle and setURLString in ewk_frame_view_state_save. I checked like below. and I found that before and after was same. void ewk_frame_view_state_save(Evas_Object *o, WebCore::HistoryItem* item) { const char *title = ewk_frame_title_get(o); const char *uri = ewk_frame_uri_get(o); printf("%s\n", item->title().utf8().data()); printf("=>%s\n", title); printf("%s\n", item->urlString().utf8().data()); printf("=>%s\n", uri); item->setTitle(WTF::String::fromUTF8(title)); item->setURLString(WTF::String::fromUTF8(uri)); evas_object_smart_callback_call(o, "state,save", 0); } 268370 1 65225 ryuan.choi 2010-08-24 00:35:58 -0700 Created attachment 65225 Patch 269947 2 antognolli+webkit 2010-08-26 10:31:27 -0700 Hi Ryuan, Can you detail more this problem? I just checked the url of this site on history (using Eve as test application), and it seems to work fine. Is the url of this korean site that is broken? Or other urls? (actually, everything seems to be ok here) 270489 3 ryuan.choi 2010-08-27 07:33:00 -0700 (In reply to comment #2) > Hi Ryuan, > > Can you detail more this problem? I just checked the url of this site on history (using Eve as test application), and it seems to work fine. > > Is the url of this korean site that is broken? Or other urls? (actually, everything seems to be ok here) yes. It's hard to reproduce. below is reproduce step. 1. launch like below EWeblauncher http://www.wikipedia.org 2. click link '한국어' and then you can see some korean site which is http://ko.wikipedia.org/wiki/위키백과:대문 3. click a one of link to move other page(I use English in left menu) 4. press F1 to move back. I found that latest webkit crashes and previous version just print different page which explain broken link as korean. I'll investigate why crash. but we'd better to remove this code. It looks not required and buggy. 271747 4 65225 abarth 2010-08-30 16:32:40 -0700 Comment on attachment 65225 Patch ok 271919 5 65225 commit-queue 2010-08-30 21:42:09 -0700 Comment on attachment 65225 Patch Clearing flags on attachment: 65225 Committed r66451: <http://trac.webkit.org/changeset/66451> 271920 6 commit-queue 2010-08-30 21:42:14 -0700 All reviewed patches have been landed. Closing bug. 65225 2010-08-24 00:35:58 -0700 2010-08-30 21:42:09 -0700 Patch bug-44495-20100824163556.patch text/plain 1316 ryuan.choi SW5kZXg6IFdlYktpdC9lZmwvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9lZmwvQ2hh bmdlTG9nCShyZXZpc2lvbiA2NTg2OSkKKysrIFdlYktpdC9lZmwvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDgtMjQgIFJ5dWFuIENob2kgIDxyeXVhbi5j aG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFtFRkxdVXJsIG9mIEhpc3RvcnlJdGVtIHdhcyBicm9rZW4gZm9yIHNwZWNpYWwg Y2hhcmFjdGVyIGxpa2Uga29yZWFuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD00NDQ5NQorCisgICAgICAgIFJlbW92ZSB1bm5lY2Vzc2FyeSBjb2RlLiBU aGlzIG1ha2VzIGEgYnVnIHdpdGggY29tcGxpY2F0ZWQgVVJMLgorCisgICAgICAgICogZXdrL2V3 a19mcmFtZS5jcHA6CisgICAgICAgIChld2tfZnJhbWVfdmlld19zdGF0ZV9zYXZlKToKKwogMjAx MC0wOC0yMyAgTGVhbmRybyBQZXJlaXJhICA8bGVhbmRyb0Bwcm9mdXNpb24ubW9iaT4KIAogICAg ICAgICBbRUZMXSBCdWlsZCBmaXggZm9yIHBsYXRmb3JtcyB0aGF0IGRvIG5vdCByZXF1aXJlIGxp bmtpbmcgd2l0aCAiZGwiLgpJbmRleDogV2ViS2l0L2VmbC9ld2svZXdrX2ZyYW1lLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJLaXQvZWZsL2V3ay9ld2tfZnJhbWUuY3BwCShyZXZpc2lvbiA2NTg2OCkK KysrIFdlYktpdC9lZmwvZXdrL2V3a19mcmFtZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE2ODcs MTIgKzE2ODcsNiBAQCB2b2lkIGV3a19mcmFtZV9kaWRfcGVyZm9ybV9maXJzdF9uYXZpZ2F0CiAg Ki8KIHZvaWQgZXdrX2ZyYW1lX3ZpZXdfc3RhdGVfc2F2ZShFdmFzX09iamVjdCAqbywgV2ViQ29y ZTo6SGlzdG9yeUl0ZW0qIGl0ZW0pCiB7Ci0gICAgY29uc3QgY2hhciAqdGl0bGUgPSBld2tfZnJh bWVfdGl0bGVfZ2V0KG8pOwotICAgIGNvbnN0IGNoYXIgKnVyaSA9IGV3a19mcmFtZV91cmlfZ2V0 KG8pOwotCi0gICAgaXRlbS0+c2V0VGl0bGUoV1RGOjpTdHJpbmc6OmZyb21VVEY4KHRpdGxlKSk7 Ci0gICAgaXRlbS0+c2V0VVJMU3RyaW5nKFdURjo6U3RyaW5nOjpmcm9tVVRGOCh1cmkpKTsKLQog ICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxiYWNrX2NhbGwobywgInN0YXRlLHNhdmUiLCAwKTsK IH0KIAo=