44493 2010-08-23 23:59:19 -0700 Web Inspector: setAttachedWindow was modified at r65809 but should be implemented another way. 2010-08-24 02:23:23 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 loislo loislo bweinstein joepeck keishi pfeldman pmuellr rik timothy yurys oldest_to_newest 268350 0 loislo 2010-08-23 23:59:19 -0700 %subj% 268361 1 65222 loislo 2010-08-24 00:20:40 -0700 Created attachment 65222 [patch] initial version. 268366 2 loislo 2010-08-24 00:33:03 -0700 Committed r65870 M WebCore/ChangeLog M WebCore/inspector/InspectorController.cpp M WebCore/inspector/InspectorFrontendClientLocal.cpp M WebCore/inspector/Inspector.idl M WebCore/inspector/InspectorController.h r65870 = a179adf1b79bc49e6ceaa98d8fc9428280e86557 (refs/remotes/trunk) 268436 3 65222 loislo 2010-08-24 02:22:57 -0700 Comment on attachment 65222 [patch] initial version. just for trybots 65222 2010-08-24 00:20:40 -0700 2010-08-24 02:23:23 -0700 [patch] initial version. patch text/plain 3486 loislo ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MGY3NTZmNC4uNjZhZTg3MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wOC0yNCAgSWx5YSBUaWtob25v dnNreSAgPGxvaXNsb0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2ViSW5zcGVjdG9yOiBzZXRBdHRhY2hlZFdpbmRvdyB3YXMg bW9kaWZpZWQgYXQgcjY1ODA5IGJ1dCBpdCBzaG91bGQgYmUgaW1wbGVtZW50ZWQgYW5vdGhlciB3 YXkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDQ5 MworCisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3Rvci5pZGw6CisgICAgICAgICogaW5zcGVj dG9yL0luc3BlY3RvckNvbnRyb2xsZXIuY3BwOgorICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0 b3JDb250cm9sbGVyLmg6CisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kQ2xp ZW50TG9jYWwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yRnJvbnRlbmRDbGllbnRM b2NhbDo6c2V0QXR0YWNoZWRXaW5kb3cpOgorCiAyMDEwLTA4LTIzICBBZGFtIEJhcnRoICA8YWJh cnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYg LS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3IuaWRsIGIvV2ViQ29yZS9pbnNwZWN0 b3IvSW5zcGVjdG9yLmlkbAppbmRleCAyMDM2MzZhLi4zOTJkMWRmIDEwMDY0NAotLS0gYS9XZWJD b3JlL2luc3BlY3Rvci9JbnNwZWN0b3IuaWRsCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL0luc3Bl Y3Rvci5pZGwKQEAgLTU3LDcgKzU3LDYgQEAgbW9kdWxlIGNvcmUgewogICAgICAgICBbbm90aWZ5 XSB2b2lkIHJlc291cmNlVHJhY2tpbmdXYXNEaXNhYmxlZCgpOwogICAgICAgICBbbm90aWZ5XSB2 b2lkIHNlYXJjaGluZ0Zvck5vZGVXYXNFbmFibGVkKCk7CiAgICAgICAgIFtub3RpZnldIHZvaWQg c2VhcmNoaW5nRm9yTm9kZVdhc0Rpc2FibGVkKCk7Ci0gICAgICAgIFtub3RpZnldIHZvaWQgc2V0 QXR0YWNoZWRXaW5kb3cob3V0IGJvb2xlYW4gYXR0YWNoZWQpOwogICAgICAgICBbbm90aWZ5XSB2 b2lkIHNldENoaWxkTm9kZXMob3V0IGxvbmcgcGFyZW50SWQsIG91dCBBcnJheSBub2Rlcyk7CiAg ICAgICAgIFtub3RpZnldIHZvaWQgc2V0RGV0YWNoZWRSb290KG91dCBPYmplY3Qgcm9vdCk7CiAg ICAgICAgIFtub3RpZnldIHZvaWQgc2V0RG9jdW1lbnQob3V0IFZhbHVlIHJvb3QpOwpkaWZmIC0t Z2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHAgYi9XZWJDb3Jl L2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcAppbmRleCBkNWY5YTNiLi44OWM5MTMy IDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcAor KysgYi9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcApAQCAtNDIwLDE1 ICs0MjAsNiBAQCB2b2lkIEluc3BlY3RvckNvbnRyb2xsZXI6OnNldEluc3BlY3RvckZyb250ZW5k Q2xpZW50KFBhc3NPd25QdHI8SW5zcGVjdG9yRnJvbnRlbgogICAgIG1faW5zcGVjdG9yRnJvbnRl bmRDbGllbnQgPSBjbGllbnQ7CiB9CiAKLXZvaWQgSW5zcGVjdG9yQ29udHJvbGxlcjo6c2V0QXR0 YWNoZWRXaW5kb3coYm9vbCBhdHRhY2hlZCkKLXsKLSAgICBpZiAoIW1fcmVtb3RlRnJvbnRlbmQp IHsKLSAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7Ci0gICAgICAgIHJldHVybjsKLSAgICB9 Ci0gICAgbV9yZW1vdGVGcm9udGVuZC0+c2V0QXR0YWNoZWRXaW5kb3coYXR0YWNoZWQpOwotfQot CiB2b2lkIEluc3BlY3RvckNvbnRyb2xsZXI6Omluc3BlY3RlZFdpbmRvd1NjcmlwdE9iamVjdENs ZWFyZWQoRnJhbWUqIGZyYW1lKQogewogICAgIC8vIElmIHRoZSBwYWdlIGlzIHN1cHBvc2VkIHRv IHNlcnZlIGFzIEluc3BlY3RvckZyb250ZW5kIG5vdGlmeSBpbnNwZXRvciBmcm9udGVuZApkaWZm IC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5oIGIvV2ViQ29y ZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5oCmluZGV4IGJkYjdiMjkuLjRmZTY3Y2Ug MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuaAorKysg Yi9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmgKQEAgLTE0Nyw3ICsxNDcs NiBAQCBwdWJsaWM6CiAKICAgICB2b2lkIHNldEluc3BlY3RvckZyb250ZW5kQ2xpZW50KFBhc3NP d25QdHI8SW5zcGVjdG9yRnJvbnRlbmRDbGllbnQ+IGNsaWVudCk7CiAgICAgYm9vbCBoYXNJbnNw ZWN0b3JGcm9udGVuZENsaWVudCgpIGNvbnN0IHsgcmV0dXJuIG1faW5zcGVjdG9yRnJvbnRlbmRD bGllbnQ7IH0KLSAgICB2b2lkIHNldEF0dGFjaGVkV2luZG93KGJvb2wgYXR0YWNoZWQpOwogCiAg ICAgdm9pZCBpbnNwZWN0ZWRXaW5kb3dTY3JpcHRPYmplY3RDbGVhcmVkKEZyYW1lKik7CiAKZGlm ZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kQ2xpZW50TG9jYWwu Y3BwIGIvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRDbGllbnRMb2NhbC5jcHAK aW5kZXggMGVlMDk4NS4uNzc2MTZkYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvSW5z cGVjdG9yRnJvbnRlbmRDbGllbnRMb2NhbC5jcHAKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvSW5z cGVjdG9yRnJvbnRlbmRDbGllbnRMb2NhbC5jcHAKQEAgLTEyMSw3ICsxMjEsMTQgQEAgdm9pZCBJ bnNwZWN0b3JGcm9udGVuZENsaWVudExvY2FsOjptb3ZlV2luZG93QnkoZmxvYXQgeCwgZmxvYXQg eSkKIAogdm9pZCBJbnNwZWN0b3JGcm9udGVuZENsaWVudExvY2FsOjpzZXRBdHRhY2hlZFdpbmRv dyhib29sIGF0dGFjaGVkKQogewotICAgIG1faW5zcGVjdG9yQ29udHJvbGxlci0+c2V0QXR0YWNo ZWRXaW5kb3coYXR0YWNoZWQpOworICAgIFNjcmlwdE9iamVjdCB3ZWJJbnNwZWN0b3JPYmo7Cisg ICAgaWYgKCFTY3JpcHRHbG9iYWxPYmplY3Q6OmdldChtX2Zyb250ZW5kU2NyaXB0U3RhdGUsICJX ZWJJbnNwZWN0b3IiLCB3ZWJJbnNwZWN0b3JPYmopKSB7CisgICAgICAgIEFTU0VSVF9OT1RfUkVB Q0hFRCgpOworICAgICAgICByZXR1cm47CisgICAgfQorICAgIFNjcmlwdEZ1bmN0aW9uQ2FsbCBm dW5jdGlvbih3ZWJJbnNwZWN0b3JPYmosICJzZXRBdHRhY2hlZFdpbmRvdyIpOworICAgIGZ1bmN0 aW9uLmFwcGVuZEFyZ3VtZW50KGF0dGFjaGVkKTsKKyAgICBmdW5jdGlvbi5jYWxsKCk7CiB9CiAK IHZvaWQgSW5zcGVjdG9yRnJvbnRlbmRDbGllbnRMb2NhbDo6cmVzdG9yZUF0dGFjaGVkV2luZG93 SGVpZ2h0KCkK