44466 2010-08-23 16:29:44 -0700 Fix gcc warning introduced in 65731 2010-08-24 04:02:30 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 43191 1 ossy webkit-unassigned podivilov yurys oldest_to_newest 268159 0 ossy 2010-08-23 16:29:44 -0700 This warning introduced in http://trac.webkit.org/changeset/65731 gcc warning: ../../../WebCore/inspector/InspectorDOMAgent.cpp:1064: warning: control reaches end of non-void function 1055 bool InspectorDOMAgent::pauseOnBreakpoint() 1056 { 1057 #if ENABLE(JAVASCRIPT_DEBUGGER) 1058 s_domAgentOnBreakpoint = this; 1059 ScriptDebugServer::shared().breakProgram(); 1060 bool deleted = !s_domAgentOnBreakpoint; 1061 s_domAgentOnBreakpoint = 0; 1062 return !deleted; 1063 #endif 1064 } InspectorDOMAgent::pauseOnBreakpoint() should return a default value when ENABLE(JAVASCRIPT_DEBUGGER) is false. Could you fix it, please? 268392 1 65232 podivilov 2010-08-24 01:35:27 -0700 Created attachment 65232 Fix both warnings. 268394 2 65233 podivilov 2010-08-24 01:36:17 -0700 Created attachment 65233 Fix both warnings. 268417 3 ossy 2010-08-24 01:55:57 -0700 - mask = mask | (mask >> domBreakpointDerivedTypeShift) & ((1 << domBreakpointDerivedTypeShift) - 1); + mask = (mask | (mask >> domBreakpointDerivedTypeShift)) & ((1 << domBreakpointDerivedTypeShift) - 1); I don't understand what should this code do, but adding parantheses like this, will change the behaviour of the code. Which one is wrong? The original or the modified? a | b & c is equal to a | (b & c) , because & has higher precedence than | 268419 4 yurys 2010-08-24 01:59:10 -0700 (In reply to comment #3) > - mask = mask | (mask >> domBreakpointDerivedTypeShift) & ((1 << domBreakpointDerivedTypeShift) - 1); > + mask = (mask | (mask >> domBreakpointDerivedTypeShift)) & ((1 << domBreakpointDerivedTypeShift) - 1); > > I don't understand what should this code do, but adding > parantheses like this, will change the behaviour of the code. > Which one is wrong? The original or the modified? > > a | b & c is equal to a | (b & c) , because & has higher precedence than | The latter version is correct, original one had a bug since we want new mask to fit into domBreakpointDerivedTypeShift bits. Thanks for pointing this out. 268421 5 ossy 2010-08-24 02:01:43 -0700 *** Bug 44468 has been marked as a duplicate of this bug. *** 268471 6 ossy 2010-08-24 04:02:16 -0700 Landed in http://trac.webkit.org/changeset/65887 65232 2010-08-24 01:35:27 -0700 2010-08-24 01:36:17 -0700 Fix both warnings. fix_warning.patch text/plain 1788 podivilov ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDgxODA3YzIuLmZiM2ZhY2UgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE0IEBACisyMDEwLTA3LTE1ICBQYXZlbCBQb2Rpdmlsb3YgIDxwb2Rpdmlsb3ZAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZp eCBtYWMgY29tcGlsYXRpb24gZmFpbHVyZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NDIzNDQKKworICAgICAgICAqIHNyYy9BdXRvRmlsbFBvcHVwTWVu dUNsaWVudC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkF1dG9GaWxsUG9wdXBNZW51Q2xpZW50Ojpy ZW1vdmVTdWdnZXN0aW9uQXRJbmRleCk6CisgICAgICAgIChXZWJLaXQ6OkF1dG9GaWxsUG9wdXBN ZW51Q2xpZW50OjpjYW5SZW1vdmVTdWdnZXN0aW9uQXRJbmRleCk6CisKIDIwMTAtMDctMTQgIEdl b3JnZSBZYWtvdmxldiAgPGdlb3JnZXlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IERhcmluIEZpc2hlci4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9zcmMvQXV0b0Zp bGxQb3B1cE1lbnVDbGllbnQuY3BwIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9BdXRvRmlsbFBvcHVw TWVudUNsaWVudC5jcHAKaW5kZXggZGIyMTRjNy4uNmI3NGY2MCAxMDA2NDQKLS0tIGEvV2ViS2l0 L2Nocm9taXVtL3NyYy9BdXRvRmlsbFBvcHVwTWVudUNsaWVudC5jcHAKKysrIGIvV2ViS2l0L2No cm9taXVtL3NyYy9BdXRvRmlsbFBvcHVwTWVudUNsaWVudC5jcHAKQEAgLTkxLDcgKzkxLDcgQEAg dm9pZCBBdXRvRmlsbFBvcHVwTWVudUNsaWVudDo6cmVtb3ZlU3VnZ2VzdGlvbkF0SW5kZXgodW5z aWduZWQgbGlzdEluZGV4KQogCiAgICAgaW50IGluZGV4ID0gY29udmVydExpc3RJbmRleFRvSW50 ZXJuYWxJbmRleChsaXN0SW5kZXgpOwogCi0gICAgQVNTRVJUKGluZGV4IDwgbV9uYW1lcy5zaXpl KCkpOworICAgIEFTU0VSVChzdGF0aWNfY2FzdDx1bnNpZ25lZD4oaW5kZXgpIDwgbV9uYW1lcy5z aXplKCkpOwogCiAgICAgbV9uYW1lcy5yZW1vdmUoaW5kZXgpOwogICAgIG1fbGFiZWxzLnJlbW92 ZShpbmRleCk7CkBAIC0xMDYsNyArMTA2LDcgQEAgYm9vbCBBdXRvRmlsbFBvcHVwTWVudUNsaWVu dDo6Y2FuUmVtb3ZlU3VnZ2VzdGlvbkF0SW5kZXgodW5zaWduZWQgbGlzdEluZGV4KQogICAgIC8v IE9ubHkgYWxsb3cgZGVsZXRpb24gb2YgaXRlbXMgYmVmb3JlIHRoZSBzZXBhcmF0b3IgYW5kIHRo b3NlIHRoYXQgZG9uJ3QKICAgICAvLyBoYXZlIGEgbGFiZWwgKGF1dG9jb21wbGV0ZSkuCiAgICAg aW50IGluZGV4ID0gY29udmVydExpc3RJbmRleFRvSW50ZXJuYWxJbmRleChsaXN0SW5kZXgpOwot ICAgIHJldHVybiBtX2xhYmVsc1tpbmRleF0uaXNFbXB0eSgpICYmIChtX3NlcGFyYXRvckluZGV4 ID09IC0xIHx8IGxpc3RJbmRleCA8IG1fc2VwYXJhdG9ySW5kZXgpOworICAgIHJldHVybiBtX2xh YmVsc1tpbmRleF0uaXNFbXB0eSgpICYmIChtX3NlcGFyYXRvckluZGV4ID09IC0xIHx8IGxpc3RJ bmRleCA8IHN0YXRpY19jYXN0PHVuc2lnbmVkPihtX3NlcGFyYXRvckluZGV4KSk7CiB9CiAKIHZv aWQgQXV0b0ZpbGxQb3B1cE1lbnVDbGllbnQ6OnZhbHVlQ2hhbmdlZCh1bnNpZ25lZCBsaXN0SW5k ZXgsIGJvb2wgZmlyZUV2ZW50cykK 65233 2010-08-24 01:36:17 -0700 2010-08-24 04:02:30 -0700 Fix both warnings. fix_warnings.patch text/plain 1499 podivilov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg M2FhMjRjZC4uMDJhNDFkZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wOC0yNCAgUGF2ZWwgUG9kaXZp bG92ICA8cG9kaXZpbG92QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBmaXggZ2NjIHdhcm5pbmdzIGlu dHJvZHVjZWQgaW4gNjU3MzEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTQ0NDY4CisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yRE9NQWdlbnQ6OmRpZEluc2VydERPTU5v ZGUpOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yRE9NQWdlbnQ6OnBhdXNlT25CcmVha3Bv aW50KToKKwogMjAxMC0wOC0yNCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAg ICAgICAgIEJ1aWxkIGZpeC4gIGxlYWtQdHIgZG9lc24ndCBleGlzdCwgY29udHJhcnkgdG8gbXkg ZHJlYW1zLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQu Y3BwIGIvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuY3BwCmluZGV4IDlkZTYy MGQuLjAwYzhiYWQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFn ZW50LmNwcAorKysgYi9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHAKQEAg LTk3MSw3ICs5NzEsNyBAQCB2b2lkIEluc3BlY3RvckRPTUFnZW50OjpkaWRJbnNlcnRET01Ob2Rl KE5vZGUqIG5vZGUpCiAgICAgICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAgICAgICAg IHVpbnQzMl90IG1hc2sgPSBtX2JyZWFrcG9pbnRzLmdldChwYXJlbnQpOwotICAgICAgICBtYXNr ID0gbWFzayB8IChtYXNrID4+IGRvbUJyZWFrcG9pbnREZXJpdmVkVHlwZVNoaWZ0KSAmICgoMSA8 PCBkb21CcmVha3BvaW50RGVyaXZlZFR5cGVTaGlmdCkgLSAxKTsKKyAgICAgICAgbWFzayA9ICht YXNrIHwgKG1hc2sgPj4gZG9tQnJlYWtwb2ludERlcml2ZWRUeXBlU2hpZnQpKSAmICgoMSA8PCBk b21CcmVha3BvaW50RGVyaXZlZFR5cGVTaGlmdCkgLSAxKTsKICAgICAgICAgdXBkYXRlU3VidHJl ZUJyZWFrcG9pbnRzKG5vZGUsIG1hc2ssIHRydWUpOwogICAgIH0KIApAQCAtMTA2MCw2ICsxMDYw LDggQEAgYm9vbCBJbnNwZWN0b3JET01BZ2VudDo6cGF1c2VPbkJyZWFrcG9pbnQoKQogICAgIGJv b2wgZGVsZXRlZCA9ICFzX2RvbUFnZW50T25CcmVha3BvaW50OwogICAgIHNfZG9tQWdlbnRPbkJy ZWFrcG9pbnQgPSAwOwogICAgIHJldHVybiAhZGVsZXRlZDsKKyNlbHNlCisgICAgcmV0dXJuIHRy dWU7CiAjZW5kaWYKIH0KIAo=