44460 2010-08-23 15:42:19 -0700 REGRESSION(r65703): "Causing lots of crashes on Snow Leopard when running the layout tests" (Requested by eseidel2 on #webkit). 2010-08-23 16:00:05 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 44270 1 webkit.review.bot webkit.review.bot aroben eric sam oldest_to_newest 268128 0 webkit.review.bot 2010-08-23 15:42:19 -0700 http://trac.webkit.org/changeset/65703 broke the build: "Causing lots of crashes on Snow Leopard when running the layout tests" (Requested by eseidel2 on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 268129 1 65167 webkit.review.bot 2010-08-23 15:42:31 -0700 Created attachment 65167 ROLLOUT of r65703 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID --ignore-builders where ATTACHMENT_ID is the ID of this attachment. 268130 2 eric 2010-08-23 15:43:33 -0700 See https://lists.webkit.org/pipermail/webkit-dev/2010-August/013985.html for further discussion. 268132 3 eric 2010-08-23 15:44:38 -0700 jamesr suggests that bug 44298 may have been masking this (and other) Snow Leopard failure(s). 268133 4 eric 2010-08-23 15:45:54 -0700 A rollout here is not the right fix. But this code is blocking several people from development, so rolling it out until Adam can roll it back in w/o SL crashes. :( 268138 5 65167 eric 2010-08-23 15:59:59 -0700 Comment on attachment 65167 ROLLOUT of r65703 Clearing flags on attachment: 65167 Committed r65838: <http://trac.webkit.org/changeset/65838> 268139 6 eric 2010-08-23 16:00:05 -0700 All reviewed patches have been landed. Closing bug. 65167 2010-08-23 15:42:31 -0700 2010-08-23 15:59:59 -0700 ROLLOUT of r65703 bug-44460-20100823224229.patch text/plain 4537 webkit.review.bot ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg Y2RlYzlhZDlmZTZiMDE2NDg3OWI1NTAzZDc0M2U1ZTEwNThlNGRiMi4uMWUyOTU2MzUxN2FkYTE1 ZDE1Y2RkMzQyOWZkZjIxOGEzZDJkN2Q4MiAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wOC0yMyAgU2hl cmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CisKKyAgICAgICAgVW5yZXZp ZXdlZCwgcm9sbGluZyBvdXQgcjY1NzAzLgorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3Jn L2NoYW5nZXNldC82NTcwMworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDQ0NjAKKworICAgICAgICAiQ2F1c2luZyBsb3RzIG9mIGNyYXNoZXMgb24gU25v dyBMZW9wYXJkIHdoZW4gcnVubmluZyB0aGUKKyAgICAgICAgbGF5b3V0IHRlc3RzIiAoUmVxdWVz dGVkIGJ5IGVzZWlkZWwyIG9uICN3ZWJraXQpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9QbHVn aW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2luTW9kdWxlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6 TmV0c2NhcGVQbHVnaW5Nb2R1bGU6OnRyeUxvYWQpOgorCiAyMDEwLTA4LTIzICBKb24gSG9uZXlj dXR0ICA8amhvbmV5Y3V0dEBhcHBsZS5jb20+CiAKICAgICAgICAgTGF5b3V0IHRlc3RzIGRvIG5v dCBydW4gd2hlbiB1c2luZyBXZWJLaXRUZXN0UnVubmVyIGluIGEgRGVidWcgYnVpbGQuCmRpZmYg LS1naXQgYS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZVBsdWdp bk1vZHVsZS5jcHAgYi9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2Fw ZVBsdWdpbk1vZHVsZS5jcHAKaW5kZXggYjdkNGE4ZWNjZTljOTY5Zjk2YjM1OTkwMjA5MWUzOGNl MjRiZDRmMi4uYTNiODc4OGQ2NTRmNjM3ZGE3NDI0NzVlMzE1OGU1OTQ2YjQ3YzA2YiAxMDA2NDQK LS0tIGEvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVQbHVnaW5N b2R1bGUuY3BwCisrKyBiL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05ldHNj YXBlUGx1Z2luTW9kdWxlLmNwcApAQCAtMTI5LDE5ICsxMjksMTMgQEAgYm9vbCBOZXRzY2FwZVBs dWdpbk1vZHVsZTo6dHJ5TG9hZCgpCiAgICAgaWYgKCFtX3NodXRkb3duUHJvY1B0cikKICAgICAg ICAgcmV0dXJuIGZhbHNlOwogCisgICAgaWYgKGluaXRpYWxpemVGdW5jUHRyKG5ldHNjYXBlQnJv d3NlckZ1bmNzKCkpICE9IE5QRVJSX05PX0VSUk9SKQorICAgICAgICByZXR1cm4gZmFsc2U7CisK ICAgICBtX3BsdWdpbkZ1bmNzLnNpemUgPSBzaXplb2YoTlBQbHVnaW5GdW5jcyk7CiAgICAgbV9w bHVnaW5GdW5jcy52ZXJzaW9uID0gKE5QX1ZFUlNJT05fTUFKT1IgPDwgOCkgfCBOUF9WRVJTSU9O X01JTk9SOwotCi0gICAgLy8gT24gTWFjLCBOUF9Jbml0aWFsaXplIG11c3QgYmUgY2FsbGVkIGZp cnN0LCB0aGVuIE5QX0dldEVudHJ5UG9pbnRzLiBPbiBXaW5kb3dzLCB0aGUgb3JkZXIgaXMKLSAg ICAvLyByZXZlcnNlZC4gRmFpbGluZyB0byBmb2xsb3cgdGhpcyBvcmRlciByZXN1bHRzIGluIGNy YXNoZXMgKGUuZy4sIGluIFNpbHZlcmxpZ2h0IG9uIE1hYyBhbmQKLSAgICAvLyBpbiBGbGFzaCBh bmQgUXVpY2tUaW1lIG9uIFdpbmRvd3MpLgotI2lmIFBMQVRGT1JNKE1BQykKLSAgICBpZiAoaW5p dGlhbGl6ZUZ1bmNQdHIobmV0c2NhcGVCcm93c2VyRnVuY3MoKSkgIT0gTlBFUlJfTk9fRVJST1Ig fHwgZ2V0RW50cnlQb2ludHNGdW5jUHRyKCZtX3BsdWdpbkZ1bmNzKSAhPSBOUEVSUl9OT19FUlJP UikKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotI2VsaWYgUExBVEZPUk0oV0lOKQotICAgIGlmIChn ZXRFbnRyeVBvaW50c0Z1bmNQdHIoJm1fcGx1Z2luRnVuY3MpICE9IE5QRVJSX05PX0VSUk9SIHx8 IGluaXRpYWxpemVGdW5jUHRyKG5ldHNjYXBlQnJvd3NlckZ1bmNzKCkpICE9IE5QRVJSX05PX0VS Uk9SKQorICAgIGlmIChnZXRFbnRyeVBvaW50c0Z1bmNQdHIoJm1fcGx1Z2luRnVuY3MpICE9IE5Q RVJSX05PX0VSUk9SKQogICAgICAgICByZXR1cm4gZmFsc2U7Ci0jZW5kaWYKIAogICAgIHJldHVy biB0cnVlOwogfQpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9v bHMvQ2hhbmdlTG9nCmluZGV4IGM1YmEyYmJlNDAwMGViMzliYjE3YjlmZDAyOWI2YjdjNGE5MTVl MDAuLjYzMjNhNGY5ZDE0NGIwNmYwNTY0NmQ0YzhiNjgwMTc3Njg1YjgzZjggMTAwNjQ0Ci0tLSBh L1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxMC0wOC0yMyAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBn bWFpbC5jb20+CisKKyAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjY1NzAzLgorICAg ICAgICBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC82NTcwMworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDQ0NjAKKworICAgICAgICAiQ2F1 c2luZyBsb3RzIG9mIGNyYXNoZXMgb24gU25vdyBMZW9wYXJkIHdoZW4gcnVubmluZyB0aGUKKyAg ICAgICAgbGF5b3V0IHRlc3RzIiAoUmVxdWVzdGVkIGJ5IGVzZWlkZWwyIG9uICN3ZWJraXQpLgor CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luL21haW4uY3BwOgor ICAgICAgICAoTlBfSW5pdGlhbGl6ZSk6CisgICAgICAgIChOUF9HZXRFbnRyeVBvaW50cyk6CisK IDIwMTAtMDgtMjMgIEpvbiBIb25leWN1dHQgIDxqaG9uZXljdXR0QGFwcGxlLmNvbT4KIAogICAg ICAgICBMYXlvdXQgdGVzdHMgZG8gbm90IHJ1biB3aGVuIHVzaW5nIFdlYktpdFRlc3RSdW5uZXIg aW4gYSBEZWJ1ZyBidWlsZC4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVl L1Rlc3ROZXRzY2FwZVBsdWdJbi9tYWluLmNwcCBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVl L1Rlc3ROZXRzY2FwZVBsdWdJbi9tYWluLmNwcAppbmRleCA2MDg4ZDViYmVjMDNiM2U0OTViNzFk ZGQxOTllZTJlM2VlMjIwMDg0Li5mY2RhNTBiYzdkN2ZlODUzZmI5YWYzMjgzYWU0YzQ1NDk4NGI5 Mjk0IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQ bHVnSW4vbWFpbi5jcHAKKysrIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNj YXBlUGx1Z0luL21haW4uY3BwCkBAIC0zMSwxMyArMzEsNiBAQAogCiB1c2luZyBuYW1lc3BhY2Ug c3RkOwogCi0jZGVmaW5lIENSQVNIKCkgZG8geyBcCi0gICAgKihpbnQgKikodWludHB0cl90KTB4 YmJhZGJlZWYgPSAwOyBcCi0gICAgKCh2b2lkKCopKCkpMCkoKTsgLyogTW9yZSByZWxpYWJsZSwg YnV0IGRvZXNuJ3Qgc2F5IEJCQURCRUVGICovIFwKLX0gd2hpbGUoZmFsc2UpCi0KLXN0YXRpYyBi b29sIGdldEVudHJ5UG9pbnRzV2FzQ2FsbGVkOwotCiAjaWYgWFBfV0lOCiAjZGVmaW5lIFNURENB TEwgX19zdGRjYWxsCiAKQEAgLTU0LDE2ICs0Nyw2IEBAIHN0YXRpYyBpbmxpbmUgaW50IHN0cmNh c2VjbXAoY29uc3QgY2hhciogczEsIGNvbnN0IGNoYXIqIHMyKQogZXh0ZXJuICJDIgogTlBFcnJv ciBTVERDQUxMIE5QX0luaXRpYWxpemUoTlBOZXRzY2FwZUZ1bmNzICpicm93c2VyRnVuY3MpCiB7 Ci0jaWYgWFBfV0lOCi0gICAgLy8gU2ltdWxhdGUgRmxhc2ggYW5kIFF1aWNrVGltZSdzIGJlaGF2 aW9yIG9mIGNyYXNoaW5nIHdoZW4gTlBfSW5pdGlhbGl6ZSBpcyBjYWxsZWQgYmVmb3JlIE5QX0dl dEVudHJ5UG9pbnRzLgotICAgIGlmICghZ2V0RW50cnlQb2ludHNXYXNDYWxsZWQpCi0gICAgICAg IENSQVNIKCk7Ci0jZWxpZiBYUF9NQUNPU1gKLSAgICAvLyBTaW11bGF0ZSBTaWx2ZXJsaWdodCdz IGJlaGF2aW9yIG9mIGNyYXNoaW5nIHdoZW4gTlBfR2V0RW50cnlQb2ludHMgaXMgY2FsbGVkIGJl Zm9yZSBOUF9Jbml0aWFsaXplLgotICAgIGlmIChnZXRFbnRyeVBvaW50c1dhc0NhbGxlZCkKLSAg ICAgICAgQ1JBU0goKTsKLSNlbmRpZgotCiAgICAgYnJvd3NlciA9IGJyb3dzZXJGdW5jczsKICAg ICByZXR1cm4gTlBFUlJfTk9fRVJST1I7CiB9CkBAIC03MSw4ICs1NCw2IEBAIE5QRXJyb3IgU1RE Q0FMTCBOUF9Jbml0aWFsaXplKE5QTmV0c2NhcGVGdW5jcyAqYnJvd3NlckZ1bmNzKQogZXh0ZXJu ICJDIgogTlBFcnJvciBTVERDQUxMIE5QX0dldEVudHJ5UG9pbnRzKE5QUGx1Z2luRnVuY3MgKnBs dWdpbkZ1bmNzKQogewotICAgIGdldEVudHJ5UG9pbnRzV2FzQ2FsbGVkID0gdHJ1ZTsKLQogICAg IHBsdWdpbkZ1bmNzLT52ZXJzaW9uID0gKE5QX1ZFUlNJT05fTUFKT1IgPDwgOCkgfCBOUF9WRVJT SU9OX01JTk9SOwogICAgIHBsdWdpbkZ1bmNzLT5zaXplID0gc2l6ZW9mKHBsdWdpbkZ1bmNzKTsK ICAgICBwbHVnaW5GdW5jcy0+bmV3cCA9IE5QUF9OZXc7Cg==