44453 2010-08-23 13:13:57 -0700 Add missing methods at ResourceHandleWin 2010-08-25 01:07:25 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 43712 0 paroga webkit-unassigned aroben commit-queue oldest_to_newest 268081 0 paroga 2010-08-23 13:13:57 -0700 see patch 268082 1 65158 paroga 2010-08-23 13:16:35 -0700 Created attachment 65158 Patch 268523 2 65158 aroben 2010-08-24 06:40:06 -0700 Comment on attachment 65158 Patch > +bool ResourceHandle::willLoadFromCache(ResourceRequest& req, Frame*) Unused (and strangely abbreviated) parameter name here. r=me 268527 3 65267 paroga 2010-08-24 06:42:49 -0700 Created attachment 65267 Patch 268535 4 65267 aroben 2010-08-24 06:56:02 -0700 Comment on attachment 65267 Patch r=me 268541 5 65272 paroga 2010-08-24 07:12:07 -0700 Created attachment 65272 Patch Once again, sorry for the typo. 269076 6 65272 commit-queue 2010-08-25 01:07:21 -0700 Comment on attachment 65272 Patch Clearing flags on attachment: 65272 Committed r65994: <http://trac.webkit.org/changeset/65994> 269077 7 commit-queue 2010-08-25 01:07:25 -0700 All reviewed patches have been landed. Closing bug. 65158 2010-08-23 13:16:35 -0700 2010-08-24 06:42:49 -0700 Patch bug-44453.patch text/plain 1760 paroga SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NTgyNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDgtMjMgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHBh cm9nYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQWRkIG1pc3NpbmcgbWV0aG9kcyBhdCBSZXNzb3VyY2VIYW5kbGVXaW4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0NDUzCisKKyAgICAgICAgKiBw bGF0Zm9ybS9uZXR3b3JrL3dpbi9SZXNvdXJjZUhhbmRsZVdpbi5jcHA6CisgICAgICAgIChXZWJD b3JlOjpSZXNvdXJjZUhhbmRsZTo6d2lsbExvYWRGcm9tQ2FjaGUpOgorICAgICAgICAoV2ViQ29y ZTo6cHJlZmV0Y2hETlMpOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGU6OmJ1ZmZl cmVkRGF0YSk6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZTo6c3VwcG9ydHNCdWZm ZXJlZERhdGEpOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGU6OmxvYWRzQmxvY2tl ZCk6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZTo6cGxhdGZvcm1TZXREZWZlcnNM b2FkaW5nKToKKwogMjAxMC0wOC0yMyAgQWJoaXNoZWsgQXJ5YSAgPGluZmVybm9AY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KSW5kZXg6IFdlYkNv cmUvcGxhdGZvcm0vbmV0d29yay93aW4vUmVzb3VyY2VIYW5kbGVXaW4uY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay93aW4vUmVzb3VyY2VIYW5kbGVXaW4uY3BwCShy ZXZpc2lvbiA2NTgxMykKKysrIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay93aW4vUmVzb3VyY2VI YW5kbGVXaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NTksNCArNDU5LDM2IEBAIGJvb2wgUmVz b3VyY2VIYW5kbGU6Omhhc1JlY2VpdmVkUmVzcG9uc2UKICAgICByZXR1cm4gZC0+bV9oYXNSZWNl aXZlZFJlc3BvbnNlOwogfQogCitib29sIFJlc291cmNlSGFuZGxlOjp3aWxsTG9hZEZyb21DYWNo ZShSZXNvdXJjZVJlcXVlc3QmIHJlcSwgRnJhbWUqKQoreworICAgIG5vdEltcGxlbWVudGVkKCk7 CisgICAgcmV0dXJuIGZhbHNlOworfQorCit2b2lkIHByZWZldGNoRE5TKGNvbnN0IFN0cmluZyYg aG9zdG5hbWUpCit7CisgICAgbm90SW1wbGVtZW50ZWQoKTsKK30KKworUGFzc1JlZlB0cjxTaGFy ZWRCdWZmZXI+IFJlc291cmNlSGFuZGxlOjpidWZmZXJlZERhdGEoKQoreworICAgIEFTU0VSVF9O T1RfUkVBQ0hFRCgpOworICAgIHJldHVybiAwOworfQorCitib29sIFJlc291cmNlSGFuZGxlOjpz dXBwb3J0c0J1ZmZlcmVkRGF0YSgpCit7CisgICAgcmV0dXJuIGZhbHNlOworfQorCitib29sIFJl c291cmNlSGFuZGxlOjpsb2Fkc0Jsb2NrZWQoKQoreworICAgIHJldHVybiBmYWxzZTsKK30KKwor dm9pZCBSZXNvdXJjZUhhbmRsZTo6cGxhdGZvcm1TZXREZWZlcnNMb2FkaW5nKGJvb2wpCit7Cisg ICAgbm90SW1wbGVtZW50ZWQoKTsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo= 65267 2010-08-24 06:42:49 -0700 2010-08-24 07:12:07 -0700 Patch bug-44453b.patch text/plain 1747 paroga SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NTgyNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDgtMjMgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHBh cm9nYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQWRkIG1pc3NpbmcgbWV0aG9kcyBhdCBSZXNzb3VyY2VIYW5kbGVXaW4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0NDUzCisKKyAgICAgICAgKiBw bGF0Zm9ybS9uZXR3b3JrL3dpbi9SZXNvdXJjZUhhbmRsZVdpbi5jcHA6CisgICAgICAgIChXZWJD b3JlOjpSZXNvdXJjZUhhbmRsZTo6d2lsbExvYWRGcm9tQ2FjaGUpOgorICAgICAgICAoV2ViQ29y ZTo6cHJlZmV0Y2hETlMpOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGU6OmJ1ZmZl cmVkRGF0YSk6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZTo6c3VwcG9ydHNCdWZm ZXJlZERhdGEpOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGU6OmxvYWRzQmxvY2tl ZCk6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZTo6cGxhdGZvcm1TZXREZWZlcnNM b2FkaW5nKToKKwogMjAxMC0wOC0yMyAgQWJoaXNoZWsgQXJ5YSAgPGluZmVybm9AY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KSW5kZXg6IFdlYkNv cmUvcGxhdGZvcm0vbmV0d29yay93aW4vUmVzb3VyY2VIYW5kbGVXaW4uY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay93aW4vUmVzb3VyY2VIYW5kbGVXaW4uY3BwCShy ZXZpc2lvbiA2NTgxMykKKysrIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay93aW4vUmVzb3VyY2VI YW5kbGVXaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NTksNCArNDU5LDM2IEBAIGJvb2wgUmVz b3VyY2VIYW5kbGU6Omhhc1JlY2VpdmVkUmVzcG9uc2UKICAgICByZXR1cm4gZC0+bV9oYXNSZWNl aXZlZFJlc3BvbnNlOwogfQogCitib29sIFJlc291cmNlSGFuZGxlOjp3aWxsTG9hZEZyb21DYWNo ZShSZXNvdXJjZVJlcXVlc3QmLCBGcmFtZSopCit7CisgICAgbm90SW1wbGVtZW50ZWQoKTsKKyAg ICByZXR1cm4gZmFsc2U7Cit9CisKK3ZvaWQgcHJlZmV0Y2hETlMoY29uc3QgU3RyaW5nJikKK3sK KyAgICBub3RJbXBsZW1lbnRlZCgpOworfQorCitQYXNzUmVmUHRyPFNoYXJlZEJ1ZmZlcj4gUmVz b3VyY2VIYW5kbGU6OmJ1ZmZlcmVkRGF0YSgpCit7CisgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7 CisgICAgcmV0dXJuIDA7Cit9CisKK2Jvb2wgUmVzb3VyY2VIYW5kbGU6OnN1cHBvcnRzQnVmZmVy ZWREYXRhKCkKK3sKKyAgICByZXR1cm4gZmFsc2U7Cit9CisKK2Jvb2wgUmVzb3VyY2VIYW5kbGU6 OmxvYWRzQmxvY2tlZCgpCit7CisgICAgcmV0dXJuIGZhbHNlOworfQorCit2b2lkIFJlc291cmNl SGFuZGxlOjpwbGF0Zm9ybVNldERlZmVyc0xvYWRpbmcoYm9vbCkKK3sKKyAgICBub3RJbXBsZW1l bnRlZCgpOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg== 65272 2010-08-24 07:12:07 -0700 2010-08-25 01:07:21 -0700 Patch bug-44453c.patch text/plain 1746 paroga SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NTgyNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDgtMjMgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHBh cm9nYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQWRkIG1pc3NpbmcgbWV0aG9kcyBhdCBSZXNvdXJjZUhhbmRsZVdpbgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDQ0NTMKKworICAgICAgICAqIHBs YXRmb3JtL25ldHdvcmsvd2luL1Jlc291cmNlSGFuZGxlV2luLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlJlc291cmNlSGFuZGxlOjp3aWxsTG9hZEZyb21DYWNoZSk6CisgICAgICAgIChXZWJDb3Jl OjpwcmVmZXRjaEROUyk6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZTo6YnVmZmVy ZWREYXRhKToKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlSGFuZGxlOjpzdXBwb3J0c0J1ZmZl cmVkRGF0YSk6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZTo6bG9hZHNCbG9ja2Vk KToKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlSGFuZGxlOjpwbGF0Zm9ybVNldERlZmVyc0xv YWRpbmcpOgorCiAyMDEwLTA4LTIzICBBYmhpc2hlayBBcnlhICA8aW5mZXJub0BjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292LgpJbmRleDogV2ViQ29y ZS9wbGF0Zm9ybS9uZXR3b3JrL3dpbi9SZXNvdXJjZUhhbmRsZVdpbi5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3dpbi9SZXNvdXJjZUhhbmRsZVdpbi5jcHAJKHJl dmlzaW9uIDY1ODEzKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3dpbi9SZXNvdXJjZUhh bmRsZVdpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ1OSw0ICs0NTksMzYgQEAgYm9vbCBSZXNv dXJjZUhhbmRsZTo6aGFzUmVjZWl2ZWRSZXNwb25zZQogICAgIHJldHVybiBkLT5tX2hhc1JlY2Vp dmVkUmVzcG9uc2U7CiB9CiAKK2Jvb2wgUmVzb3VyY2VIYW5kbGU6OndpbGxMb2FkRnJvbUNhY2hl KFJlc291cmNlUmVxdWVzdCYsIEZyYW1lKikKK3sKKyAgICBub3RJbXBsZW1lbnRlZCgpOworICAg IHJldHVybiBmYWxzZTsKK30KKwordm9pZCBwcmVmZXRjaEROUyhjb25zdCBTdHJpbmcmKQorewor ICAgIG5vdEltcGxlbWVudGVkKCk7Cit9CisKK1Bhc3NSZWZQdHI8U2hhcmVkQnVmZmVyPiBSZXNv dXJjZUhhbmRsZTo6YnVmZmVyZWREYXRhKCkKK3sKKyAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsK KyAgICByZXR1cm4gMDsKK30KKworYm9vbCBSZXNvdXJjZUhhbmRsZTo6c3VwcG9ydHNCdWZmZXJl ZERhdGEoKQoreworICAgIHJldHVybiBmYWxzZTsKK30KKworYm9vbCBSZXNvdXJjZUhhbmRsZTo6 bG9hZHNCbG9ja2VkKCkKK3sKKyAgICByZXR1cm4gZmFsc2U7Cit9CisKK3ZvaWQgUmVzb3VyY2VI YW5kbGU6OnBsYXRmb3JtU2V0RGVmZXJzTG9hZGluZyhib29sKQoreworICAgIG5vdEltcGxlbWVu dGVkKCk7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK