44441 2010-08-23 11:03:52 -0700 WebPDFView should remove itself as the delegate of its PDFView before being dealloced 2010-08-23 11:29:03 -0700 1 1 1 Unclassified WebKit PDF 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED P2 Normal --- 1 mthole mthole oldest_to_newest 268004 0 mthole 2010-08-23 11:03:52 -0700 WebKit should nil out the PDFView's delegate before releasing it. This is required to fix <rdar://problem/6978204> in PDFKit. 268006 1 65141 mthole 2010-08-23 11:06:05 -0700 Created attachment 65141 Proposed patch 268014 2 65141 mitz 2010-08-23 11:19:55 -0700 Comment on attachment 65141 Proposed patch > Index: WebKit/mac/ChangeLog > =================================================================== > --- WebKit/mac/ChangeLog (revision 65818) > +++ WebKit/mac/ChangeLog (working copy) > @@ -1,3 +1,13 @@ > +2010-08-23 Mike Thole <mthole@apple.com> > + > + Reviewed by NOBODY (OOPS!). > + > + WebKit should nil out PDFView's delegate before releasing it The change is good, but the description isn’t totally accurate. The problem is that the WebPDFView is deallocated while it is still the delegate, not that the PDFView is being released while having a non-nil delegate. 268017 3 mthole 2010-08-23 11:27:58 -0700 Good point Dan. I've updated the title to more accurately reflect the actual problem: "WebPDFView should remove itself as the delegate of its PDFView before being dealloced" 268019 4 mthole 2010-08-23 11:29:03 -0700 Committed revision 65820. 65141 2010-08-23 11:06:05 -0700 2010-08-23 11:19:55 -0700 Proposed patch textmate stdin ODVYZj.txt text/plain 1035 mthole SW5kZXg6IFdlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hh bmdlTG9nCShyZXZpc2lvbiA2NTgxOCkKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDgtMjMgIE1pa2UgVGhvbGUgIDxtdGhvbGVA YXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFdlYktpdCBzaG91bGQgbmlsIG91dCBQREZWaWV3J3MgZGVsZWdhdGUgYmVmb3JlIHJlbGVh c2luZyBpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NDQ0NDEKKworICAgICAgICAqIFdlYlZpZXcvV2ViUERGVmlldy5tbToKKyAgICAgICAgKC1bV2Vi UERGVmlldyBkZWFsbG9jXSk6IFNldCB0aGUgUERGVmlldydzIGRlbGVnYXRlIHRvIG5pbCBiZWZv cmUgcmVsZWFzaW5nIGl0LgorCiAyMDEwLTA4LTIyICBEYW5pZWwgQmF0ZXMgIDxkYmF0ZXNAcmlt LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KSW5kZXg6IFdlYktpdC9t YWMvV2ViVmlldy9XZWJQREZWaWV3Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvV2ViVmll dy9XZWJQREZWaWV3Lm1tCShyZXZpc2lvbiA2NTgxMykKKysrIFdlYktpdC9tYWMvV2ViVmlldy9X ZWJQREZWaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xOTMsNiArMTkzLDcgQEAgLSAodm9pZClk ZWFsbG9jCiB7CiAgICAgW2RhdGFTb3VyY2UgcmVsZWFzZV07CiAgICAgW3ByZXZpZXdWaWV3IHJl bGVhc2VdOworICAgIFtQREZTdWJ2aWV3IHNldERlbGVnYXRlOm5pbF07CiAgICAgW1BERlN1YnZp ZXcgcmVsZWFzZV07CiAgICAgW3BhdGggcmVsZWFzZV07CiAgICAgW1BERlN1YnZpZXdQcm94eSBy ZWxlYXNlXTsK