44436 2010-08-23 10:09:39 -0700 Cannot complete DHS form AR-11 online due to interactive form control validation (affects other high profile sites) 2017-11-18 01:42:31 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Mac OS X 10.6 RESOLVED WONTFIX https://egov.uscis.gov/crisgwi/go?action=coa.cr.Residence P2 Normal --- 28649 59019 1 ap tkent ian mifenton mjs m.kurz+webkitbugs rniwa syoichi tabatkins tkent webkit.review.bot oldest_to_newest 267972 0 ap 2010-08-23 10:09:39 -0700 This form has a field with required="no": <div id="fld-MiddleName"><label for="MiddleName">Middle Name</label><span><input name="coaCreate.MiddleName" id="MiddleName" class=" fv-alpha" required="no" maxlength="18" type="text" value=""/></span></div> I'm seeing this problem with Safari 5.0.1 - not with ToT, but that's only due to the fact that interactive form control validation has been disabled in ToT, I think. 390094 1 90548 tkent 2011-04-21 09:55:22 -0700 Created attachment 90548 Patch 390129 2 90548 ap 2011-04-21 10:28:43 -0700 Comment on attachment 90548 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90548&action=review It seems unlikely that this site is the only one affected. Could you please give an overview of working group discussions on this topic? Was is decided that making sites like this not spec-compliant is acceptable? Were there any other examples mentioned? > Source/WebCore/html/HTMLInputElement.cpp:1222 > + // webkit.org/b/44436 It's probably unnecessary to give a bug link - one can get that from svn blame if the information in the comment is not sufficient. 390403 3 tkent 2011-04-21 15:37:43 -0700 (In reply to comment #2) > It seems unlikely that this site is the only one affected. > > Could you please give an overview of working group discussions on this topic? Was is decided that making sites like this not spec-compliant is acceptable? Were there any other examples mentioned? The following message introduced some other examples of invalid "required" usages. http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2010-August/027647.html I remembered Hixie said he could change the attribute name "required" to another, and it's not done. I'm afraid that the new name is also used to other purposes. 390416 4 ap 2011-04-21 15:54:32 -0700 Thank you! My opinion is that we should probably hold off landing this. The list of affected sites in that e-mail is horrifying, and calls for a more general solution than adding site specific quirks. 393038 5 90548 adele 2011-04-26 16:41:06 -0700 Comment on attachment 90548 Patch r- based on Alexey's last comment. 740425 6 rniwa 2012-10-11 16:48:47 -0700 http://code.google.com/p/chromium/issues/detail?id=154611 I hit this bug as well. We need to change the spec. accordingly. The current specification is clearly incompatible with the Web. 741840 7 168646 tkent 2012-10-15 01:26:14 -0700 Created attachment 168646 Patch 2 rebase 741845 8 tkent 2012-10-15 01:30:39 -0700 (In reply to comment #6) > We need to change the spec. accordingly. The current specification is clearly incompatible with the Web. I think changing the spec is too late. Major browsers already implemented "required" attribute, and the attribute name was not renamed though we discussed it in WHATWG. Google Chrome have had the interactive validation feature for 1.5 years, and I haven't heard compatibility issues other than this one. Site-specific quirk is reasonable. 742059 9 168646 rniwa 2012-10-15 08:31:47 -0700 Comment on attachment 168646 Patch 2 Okay. Sounds like a reasonable solution until we find another site that's broken. 742185 10 ian 2012-10-15 11:01:26 -0700 FWIW, we did consider this pretty carefully at the time. Any attribute name is going to have _some_ issues, and we decided that required=""'s issues were limited enough that we could live with it. (The cost of having an unobvious attribute name being higher than the cost of a few sites breaking.) Do you think I should put this site-specific hack in the spec? (Or to put it another way: do you think other browsers should also have this hack?) 742188 11 tabatkins 2012-10-15 11:02:48 -0700 (In reply to comment #9) > (From update of attachment 168646 [details]) > Okay. Sounds like a reasonable solution until we find another site that's broken. The first step in dealing with this site *should* be to get our DevRel to try and make them fix it. I know the site has resisted fixing themselves when normal web devs have complained, but it's possible that we can throw more weight at it. We should attempt that *before* adding a quirk for them. 742192 12 ian 2012-10-15 11:06:33 -0700 Note that this is broken in Firefox too. And Opera. 742200 13 rniwa 2012-10-15 11:12:10 -0700 This is bad enough that I would expect other browsers to implement the same site-specific quirk at least for now. Leaving the form unusable even for a day is unacceptable because the U.S. government requires non-U.S. citizens to update their address using this form within the 10 days of a move. 742207 14 tabatkins 2012-10-15 11:16:42 -0700 (In reply to comment #13) > This is bad enough that I would expect other browsers to implement the same site-specific quirk at least for now. Leaving the form unusable even for a day is unacceptable because the U.S. government requires non-U.S. citizens to update their address using this form within the 10 days of a move. It's been left "unusable" for months (however long it's been since our support for 'required' hit stable), so taking an additional day (or a week or two) for DevRel to try and fix this properly seems okay. 742212 15 rniwa 2012-10-15 11:25:01 -0700 (In reply to comment #14) > It's been left "unusable" for months (however long it's been since our support for 'required' hit stable), so taking an additional day (or a week or two) for DevRel to try and fix this properly seems okay. That's insane. The only fix ordinary users can make is to use a browser that doesn't do validation instead. You don't seem to understand how important it is for this form to function correctly for millions of users. 742221 16 tabatkins 2012-10-15 11:30:54 -0700 (In reply to comment #15) > (In reply to comment #14) > > It's been left "unusable" for months (however long it's been since our support for 'required' hit stable), so taking an additional day (or a week or two) for DevRel to try and fix this properly seems okay. > > That's insane. The only fix ordinary users can make is to use a browser that doesn't do validation instead. You don't seem to understand how important it is for this form to function correctly for millions of users. No, I understand how important this form is. I also understand, though, that the form is (a) *not* unusable, just *harder* to use - every field becomes required, and (b) this form has been functioning incorrectly in all modern browsers for *years* (since 2010-08-23, at least), and people have somehow muddled through and still submitted their address changes. This suggests that this is *not* an issue that must be solved RIGHT AWAY (though sooner is better, of course), and we have the luxury of taking a little time to try and solve it *correctly* first, rather than putting a quirk in every browser. I have no problem with this quirk being added *after* we've exhausted the DevRel route to get the site fixed properly. I have a *big* problem with this quirk being the first and only way we try to fix the problem. 742228 17 rniwa 2012-10-15 11:37:29 -0700 People are forced to use browsers that don't implement validations like Internet Explorer or like me manually modify the DOM in developer tools to work around the issue. And no, you can't muddle through this form on a browser that prevents submission upon validation. 742230 18 rniwa 2012-10-15 11:42:33 -0700 Also, submitting incorrect information on that form is a crime and could result in the deportation of the person who submitted the form. Hence it's completely unreasonable to expect users to even try "muddling" with the form. Quite frankly, this form not functioning properly is a good enough reason for me to stop using Chrome. 742294 19 tabatkins 2012-10-15 12:41:07 -0700 (In reply to comment #18) > Also, submitting incorrect information on that form is a crime and could result in the deportation of the person who submitted the form. Hence it's completely unreasonable to expect users to even try "muddling" with the form. > > Quite frankly, this form not functioning properly is a good enough reason for me to stop using Chrome. Once again, this has been a problem FOR 2 YEARS. Waiting two weeks for devrel to try and get it fixed properly won't kill anyone. You're making it sound like DHS has been deporting people left and right for the last two years for submitting bad info on this form. 742308 20 ap 2012-10-15 12:46:33 -0700 Have all the other sites mentioned in e-mail linked from comment 3 (<http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2010-August/027647.html>) been changed to not use "required"? I agree that switching to Safari or IE to fill out this form should be a fine workaround ;-) 742436 21 168646 mjs 2012-10-15 14:20:34 -0700 Comment on attachment 168646 Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=168646&action=review > Source/WebCore/html/HTMLInputElement.cpp:1461 > + if (!document()->documentURI().startsWith("https://egov.uscis.gov/", false)) We usually do site-specific hack checks by hostname rather than by URL prefix checking. 742681 22 168646 rniwa 2012-10-15 18:13:41 -0700 Comment on attachment 168646 Patch 2 (In reply to comment #20) > Have all the other sites mentioned in e-mail linked from comment 3 (<http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2010-August/027647.html>) been changed to not use "required"? Oops, I missed that. They have NOT been fixed :( 744443 23 ian 2012-10-17 11:21:48 -0700 (Reply to that was: http://lists.w3.org/Archives/Public/public-whatwg-archive/2010Aug/0403.html ) 903524 24 rniwa 2013-06-25 21:24:36 -0700 Blink added a site specific hack in https://chromium.googlesource.com/chromium/blink/+/6a881460b939c2ae1ef25bfbe659d6291a18a30a. 1371743 25 rniwa 2017-11-14 23:12:12 -0800 DHS has re-written their website now. 1373130 26 ap 2017-11-17 10:17:50 -0800 What about the other sites mentioned in comment 3? This bug tracks all of them. 1373521 27 rniwa 2017-11-18 01:42:31 -0800 (In reply to Alexey Proskuryakov from comment #26) > What about the other sites mentioned in comment 3? This bug tracks all of > them. Hm... we should probably file a new bug to track that. By the way, that hyperlink to WHATWG mailing list message is 404 now :( 90548 2011-04-21 09:55:22 -0700 2012-10-15 01:26:08 -0700 Patch bug-44436-20110421095520.patch text/plain 3292 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogODQ0MDkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzODg1ZWEyMGJiMjhmMzc2 NGE3ZTA5Y2MzZTFiNTRiZGJmNzNlM2MzLi5hMTY0NzliYWI5ZTJmMDUxNzM4M2Y1NzlmMDVjYjM4 NmFmM2YzOWUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDQtMjEgIEtlbnQg VGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIElnbm9yZSByZXF1aXJlZD1ubyBhdHRyaWJ1dGUgZm9yIGVn b3YudXNjaXMuZ292LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NDQ0MzYKKworICAgICAgICBObyBuZXcgdGVzdHMuIFNpdGUtc3BlY2lmaWMgcXVpcmsg aXMgbm90IHRlc3RhYmxlLgorCisgICAgICAgICogaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkhUTUxJbnB1dEVsZW1lbnQ6OnNob3VsZElnbm9yZVJlcXVpcmVk QXR0cmlidXRlKToKKyAgICAgICAgIEFkZCBhIGZ1bmN0aW9uIHRoYXQgcmV0dXJucyB0cnVlIGlm IHNpdGUtc3BlY2lmaWMgcXVpcmtzIGlzIGVuYWJsZWQKKyAgICAgICAgIGFuZCB0aGUgZG9jdW1l bnQgaXMgaW4gaHR0cHM6Ly9lZ292LnVzY2lzLmdvdi8gYW5kIGhhcyByZXF1aXJlZD1uby4KKyAg ICAgICAgKFdlYkNvcmU6OkhUTUxJbnB1dEVsZW1lbnQ6OmlzUmVxdWlyZWRGb3JtQ29udHJvbCk6 CisgICAgICAgICBUaGUgaW5wdXQgaXMgbm90IHJlcXVpcmVkIGlmIHNob3VsZElnbm9yZVJlcXVp cmVkQXR0cmlidXRlKCkgaXMgdHJ1ZS4KKyAgICAgICAgKiBodG1sL0hUTUxJbnB1dEVsZW1lbnQu aDogRGVjbGFyZSBzaG91bGRJZ25vcmVSZXF1aXJlZEF0dHJpYnV0ZSgpLgorCiAyMDExLTA0LTE5 ICBSb2xhbmQgU3RlaW5lciAgPHJvbGFuZHN0ZWluZXJAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1 dEVsZW1lbnQuY3BwCmluZGV4IDYzMDk3OGFjODk1YzA0NGU2NTFmYzY5N2FlNzBmMWJjNzcxYmI2 ZmEuLjM4NDY5Y2ZkYTc0YTU1MmM0NDAxZmRmZGZjNTJiZDI5OWYyM2M4ODEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcApAQCAtNDUsMTEgKzQ1LDEzIEBACiAjaW5j bHVkZSAiS2V5Ym9hcmRFdmVudC5oIgogI2luY2x1ZGUgIkxvY2FsaXplZFN0cmluZ3MuaCIKICNp bmNsdWRlICJNb3VzZUV2ZW50LmgiCisjaW5jbHVkZSAiUGFnZS5oIgogI2luY2x1ZGUgIlBsYXRm b3JtTW91c2VFdmVudC5oIgogI2luY2x1ZGUgIlJlbmRlclRleHRDb250cm9sU2luZ2xlTGluZS5o IgogI2luY2x1ZGUgIlJlbmRlclRoZW1lLmgiCiAjaW5jbHVkZSAiUnVudGltZUVuYWJsZWRGZWF0 dXJlcy5oIgogI2luY2x1ZGUgIlNjcmlwdEV2ZW50TGlzdGVuZXIuaCIKKyNpbmNsdWRlICJTZXR0 aW5ncy5oIgogI2luY2x1ZGUgIldoZWVsRXZlbnQuaCIKICNpbmNsdWRlIDx3dGYvTWF0aEV4dHJh cy5oPgogI2luY2x1ZGUgPHd0Zi9TdGRMaWJFeHRyYXMuaD4KQEAgLTEyMTIsOSArMTIxNCwyMCBA QCB2b2lkIEhUTUxJbnB1dEVsZW1lbnQ6OnVucmVnaXN0ZXJGb3JBY3RpdmF0aW9uQ2FsbGJhY2tJ Zk5lZWRlZCgpCiAgICAgICAgIGRvY3VtZW50KCktPnVucmVnaXN0ZXJGb3JEb2N1bWVudEFjdGl2 YXRpb25DYWxsYmFja3ModGhpcyk7CiB9CiAKK2Jvb2wgSFRNTElucHV0RWxlbWVudDo6c2hvdWxk SWdub3JlUmVxdWlyZWRBdHRyaWJ1dGUoKSBjb25zdAoreworICAgIGlmICghZG9jdW1lbnQoKS0+ cGFnZSgpIHx8ICFkb2N1bWVudCgpLT5wYWdlKCktPnNldHRpbmdzKCktPm5lZWRzU2l0ZVNwZWNp ZmljUXVpcmtzKCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAvLyBBIGZvcm0gaW4gZWdv di51c2Npcy5nb3YgaGFzIDxpbnB1dCByZXF1aXJlZD1ubz4uCisgICAgLy8gd2Via2l0Lm9yZy9i LzQ0NDM2CisgICAgaWYgKCFkb2N1bWVudCgpLT5kb2N1bWVudFVSSSgpLnN0YXJ0c1dpdGgoImh0 dHBzOi8vZWdvdi51c2Npcy5nb3YvIiwgZmFsc2UpKQorICAgICAgICByZXR1cm4gZmFsc2U7Cisg ICAgcmV0dXJuIGZhc3RHZXRBdHRyaWJ1dGUocmVxdWlyZWRBdHRyKSA9PSAibm8iOworfQorCiBi b29sIEhUTUxJbnB1dEVsZW1lbnQ6OmlzUmVxdWlyZWRGb3JtQ29udHJvbCgpIGNvbnN0CiB7Ci0g ICAgcmV0dXJuIG1faW5wdXRUeXBlLT5zdXBwb3J0c1JlcXVpcmVkKCkgJiYgcmVxdWlyZWQoKTsK KyAgICByZXR1cm4gIXNob3VsZElnbm9yZVJlcXVpcmVkQXR0cmlidXRlKCkgJiYgbV9pbnB1dFR5 cGUtPnN1cHBvcnRzUmVxdWlyZWQoKSAmJiByZXF1aXJlZCgpOwogfQogCiB2b2lkIEhUTUxJbnB1 dEVsZW1lbnQ6OmNhY2hlU2VsZWN0aW9uKGludCBzdGFydCwgaW50IGVuZCkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5oIGIvU291cmNlL1dlYkNvcmUv aHRtbC9IVE1MSW5wdXRFbGVtZW50LmgKaW5kZXggMmE5OGIxM2RhMjZiY2M1YzNhZWI0MzExMjU2 Nzg1M2YxZDIyMTcwNC4uODdiNjk1NmU3MjFhZGY5MTBiOGFlNTc5MWVlMjk5OTI1MjcyZmM1ZSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmgKKysrIGIv U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmgKQEAgLTI5MSw2ICsyOTEsNyBA QCBwcml2YXRlOgogICAgIHZpcnR1YWwgaW50IGNhY2hlZFNlbGVjdGlvbkVuZCgpIGNvbnN0IHsg cmV0dXJuIG1fZGF0YS5jYWNoZWRTZWxlY3Rpb25FbmQoKTsgfQogCiAgICAgdmlydHVhbCBib29s IGlzT3B0aW9uYWxGb3JtQ29udHJvbCgpIGNvbnN0IHsgcmV0dXJuICFpc1JlcXVpcmVkRm9ybUNv bnRyb2woKTsgfQorICAgIGJvb2wgc2hvdWxkSWdub3JlUmVxdWlyZWRBdHRyaWJ1dGUoKSBjb25z dDsKICAgICB2aXJ0dWFsIGJvb2wgaXNSZXF1aXJlZEZvcm1Db250cm9sKCkgY29uc3Q7CiAgICAg dmlydHVhbCBib29sIHJlY2FsY1dpbGxWYWxpZGF0ZSgpIGNvbnN0OwogCg== 168646 2012-10-15 01:26:14 -0700 2012-10-15 18:13:41 -0700 Patch 2 bug-44436-20121015172505.patch text/plain 3170 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxMjkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjEyN2MzNWI4NTgxYTlh MWFkZmFhOGRmOTU1YTE4ZDc1YWRkY2QzYS4uZGIwMTAzNTUwNjViZjhlZWVkYjY0Yzk5ZTM0NWU5 M2Y4MGQzNWM4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTEwLTE1ICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBJZ25vcmUgcmVxdWlyZWQ9 bm8gYXR0cmlidXRlIGZvciBlZ292LnVzY2lzLmdvdi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0NDM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBTaXRlLXNwZWNpZmljIHF1aXJr IGlzIG5vdCB0ZXN0YWJsZS4KKworICAgICAgICAqIGh0bWwvSFRNTElucHV0RWxlbWVudC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpIVE1MSW5wdXRFbGVtZW50OjpzaG91bGRJZ25vcmVSZXF1aXJl ZEF0dHJpYnV0ZSk6CisgICAgICAgICBBZGQgYSBmdW5jdGlvbiB0aGF0IHJldHVybnMgdHJ1ZSBp ZiBzaXRlLXNwZWNpZmljIHF1aXJrcyBpcyBlbmFibGVkCisgICAgICAgICBhbmQgdGhlIGRvY3Vt ZW50IGlzIGluIGh0dHBzOi8vZWdvdi51c2Npcy5nb3YvIGFuZCBoYXMgcmVxdWlyZWQ9bm8uCisg ICAgICAgIChXZWJDb3JlOjpIVE1MSW5wdXRFbGVtZW50Ojppc1JlcXVpcmVkRm9ybUNvbnRyb2wp OgorICAgICAgICAgVGhlIGlucHV0IGlzIG5vdCByZXF1aXJlZCBpZiBzaG91bGRJZ25vcmVSZXF1 aXJlZEF0dHJpYnV0ZSgpIGlzIHRydWUuCisgICAgICAgICogaHRtbC9IVE1MSW5wdXRFbGVtZW50 Lmg6IERlY2xhcmUgc2hvdWxkSWdub3JlUmVxdWlyZWRBdHRyaWJ1dGUoKS4KKwogMjAxMi0xMC0x MiAgSWx5YSBUaWtob25vdnNreSAgPGxvaXNsb0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2Vi IEluc3BlY3RvcjogTk1JIHJlbW92ZSBoYW5kIG1hZGUgb2JqZWN0IGJ1aWxkZXJzIHdpdGggYXV0 b21hdGljIGJ1aWxkZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1 dEVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcApp bmRleCAwMjdmNjBmNWU4OGNjZDk5ZmFjMjdjYmQ3ZTlmZWQ4YTg2ZjdmZDc0Li5kN2Q3M2RjNWMz YTYzMTkzMDQwZDM1ZmQ1YTBlMjM4MzVmNzhjYTA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TElucHV0RWxlbWVudC5jcHAKQEAgLTUyLDkgKzUyLDExIEBACiAjaW5jbHVkZSAiTG9jYWxpemVk U3RyaW5ncy5oIgogI2luY2x1ZGUgIk1vdXNlRXZlbnQuaCIKICNpbmNsdWRlICJOdW1iZXJJbnB1 dFR5cGUuaCIKKyNpbmNsdWRlICJQYWdlLmgiCiAjaW5jbHVkZSAiUmVuZGVyVGV4dENvbnRyb2xT aW5nbGVMaW5lLmgiCiAjaW5jbHVkZSAiUmVuZGVyVGhlbWUuaCIKICNpbmNsdWRlICJTZWFyY2hJ bnB1dFR5cGUuaCIKKyNpbmNsdWRlICJTZXR0aW5ncy5oIgogI2luY2x1ZGUgIlNoYWRvd1Jvb3Qu aCIKICNpbmNsdWRlICJTY3JpcHRFdmVudExpc3RlbmVyLmgiCiAjaW5jbHVkZSA8d3RmL01hdGhF eHRyYXMuaD4KQEAgLTE0NTIsOSArMTQ1NCwxOCBAQCB2b2lkIEhUTUxJbnB1dEVsZW1lbnQ6OnVu cmVnaXN0ZXJGb3JTdXNwZW5zaW9uQ2FsbGJhY2tJZk5lZWRlZCgpCiAgICAgICAgIGRvY3VtZW50 KCktPnVucmVnaXN0ZXJGb3JQYWdlQ2FjaGVTdXNwZW5zaW9uQ2FsbGJhY2tzKHRoaXMpOwogfQog Citib29sIEhUTUxJbnB1dEVsZW1lbnQ6OnNob3VsZElnbm9yZVJlcXVpcmVkQXR0cmlidXRlKCkg Y29uc3QKK3sKKyAgICBpZiAoIWRvY3VtZW50KCktPnBhZ2UoKSB8fCAhZG9jdW1lbnQoKS0+cGFn ZSgpLT5zZXR0aW5ncygpLT5uZWVkc1NpdGVTcGVjaWZpY1F1aXJrcygpKQorICAgICAgICByZXR1 cm4gZmFsc2U7CisgICAgaWYgKCFkb2N1bWVudCgpLT5kb2N1bWVudFVSSSgpLnN0YXJ0c1dpdGgo Imh0dHBzOi8vZWdvdi51c2Npcy5nb3YvIiwgZmFsc2UpKQorICAgICAgICByZXR1cm4gZmFsc2U7 CisgICAgcmV0dXJuIGZhc3RHZXRBdHRyaWJ1dGUocmVxdWlyZWRBdHRyKSA9PSAibm8iOworfQor CiBib29sIEhUTUxJbnB1dEVsZW1lbnQ6OmlzUmVxdWlyZWRGb3JtQ29udHJvbCgpIGNvbnN0CiB7 Ci0gICAgcmV0dXJuIG1faW5wdXRUeXBlLT5zdXBwb3J0c1JlcXVpcmVkKCkgJiYgcmVxdWlyZWQo KTsKKyAgICByZXR1cm4gIXNob3VsZElnbm9yZVJlcXVpcmVkQXR0cmlidXRlKCkgJiYgbV9pbnB1 dFR5cGUtPnN1cHBvcnRzUmVxdWlyZWQoKSAmJiByZXF1aXJlZCgpOwogfQogCiB2b2lkIEhUTUxJ bnB1dEVsZW1lbnQ6OmFkZFNlYXJjaFJlc3VsdCgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0 RWxlbWVudC5oCmluZGV4IDQxODRkYzk3N2FmMGM2YWNlYzgxMGIwNTZiNjNjZDBlZGM1NTg1MTMu LjllOTA1MTQwMDQ5YjU3YjExMTMyN2JhYzc5ZjU3ZGY5ZGFlNDZhYzQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTElucHV0RWxlbWVudC5oCkBAIC0zNzMsNiArMzczLDcgQEAgcHJpdmF0ZToKICAg ICB2aXJ0dWFsIHZvaWQgaGFuZGxlQmx1ckV2ZW50KCk7CiAKICAgICB2aXJ0dWFsIGJvb2wgaXNP cHRpb25hbEZvcm1Db250cm9sKCkgY29uc3QgeyByZXR1cm4gIWlzUmVxdWlyZWRGb3JtQ29udHJv bCgpOyB9CisgICAgYm9vbCBzaG91bGRJZ25vcmVSZXF1aXJlZEF0dHJpYnV0ZSgpIGNvbnN0Owog ICAgIHZpcnR1YWwgYm9vbCBpc1JlcXVpcmVkRm9ybUNvbnRyb2woKSBjb25zdDsKICAgICB2aXJ0 dWFsIGJvb2wgcmVjYWxjV2lsbFZhbGlkYXRlKCkgY29uc3Q7CiAgICAgdmlydHVhbCB2b2lkIHJl cXVpcmVkQXR0cmlidXRlQ2hhbmdlZCgpIE9WRVJSSURFOwo=