44425 2010-08-23 08:03:38 -0700 Use the correct library name when compiling with gtk3 2010-08-25 11:17:39 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED DUPLICATE 42026 P2 Normal --- 0 svillar webkit-unassigned webkit.review.bot oldest_to_newest 267910 0 svillar 2010-08-23 08:03:38 -0700 WebKitGtk+ library name is hardcoded in WebKitTools/Scripts/webkitdirs.pm. It's only valid if gtk2 is used. 267912 1 65120 svillar 2010-08-23 08:08:26 -0700 Created attachment 65120 Use webkitgtk+-3.0 if available The library name is still hardcoded, but we detect if it was built against gtk3 and use the proper library in that case 267914 2 webkit.review.bot 2010-08-23 08:12:30 -0700 Attachment 65120 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKitTools/Scripts/webkitdirs.pm:600: Line contains tab character. [whitespace/tab] [5] WebKitTools/Scripts/webkitdirs.pm:601: Line contains tab character. [whitespace/tab] [5] WebKitTools/Scripts/webkitdirs.pm:602: Line contains tab character. [whitespace/tab] [5] WebKitTools/Scripts/webkitdirs.pm:603: Line contains tab character. [whitespace/tab] [5] WebKitTools/Scripts/webkitdirs.pm:604: Line contains tab character. [whitespace/tab] [5] Total errors found: 5 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style. 267918 3 svillar 2010-08-23 08:27:57 -0700 actually a dup *** This bug has been marked as a duplicate of bug 42026 *** 269374 4 65120 xan.lopez 2010-08-25 11:17:39 -0700 Comment on attachment 65120 Use webkitgtk+-3.0 if available Drop from queue. 65120 2010-08-23 08:08:26 -0700 2010-08-25 11:17:39 -0700 Use webkitgtk+-3.0 if available dirs.patch text/plain 783 svillar ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbSBiL1dlYktpdFRv b2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQppbmRleCA2NTMwMjQ0Li5kNTU4NzI3IDEwMDY0NAot LS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KKysrIGIvV2ViS2l0VG9vbHMv U2NyaXB0cy93ZWJraXRkaXJzLnBtCkBAIC01OTcsNyArNTk3LDExIEBAIHN1YiBidWlsdER5bGli UGF0aEZvck5hbWUKICAgICAgICAgcmV0dXJuICIkY29uZmlndXJhdGlvblByb2R1Y3REaXIvbGli d3h3ZWJraXQuZHlsaWIiOwogICAgIH0KICAgICBpZiAoaXNHdGsoKSkgewotICAgICAgICByZXR1 cm4gIiRjb25maWd1cmF0aW9uUHJvZHVjdERpci8kbGlicmFyeU5hbWUvLi4vLmxpYnMvbGlid2Vi a2l0Z3RrLTEuMC5zbyI7CisJaWYgKC1mICIkY29uZmlndXJhdGlvblByb2R1Y3REaXIvJGxpYnJh cnlOYW1lLy4uLy5saWJzL2xpYndlYmtpdGd0ay0zLjAuc28iKSB7CisJICAgIHJldHVybiAiJGNv bmZpZ3VyYXRpb25Qcm9kdWN0RGlyLyRsaWJyYXJ5TmFtZS8uLi8ubGlicy9saWJ3ZWJraXRndGst My4wLnNvIgorCX0gZWxzZSB7CisJICAgIHJldHVybiAiJGNvbmZpZ3VyYXRpb25Qcm9kdWN0RGly LyRsaWJyYXJ5TmFtZS8uLi8ubGlicy9saWJ3ZWJraXRndGstMS4wLnNvIjsKKwl9CiAgICAgfQog ICAgIGlmIChpc0VmbCgpKSB7CiAgICAgICAgIHJldHVybiAiJGNvbmZpZ3VyYXRpb25Qcm9kdWN0 RGlyLyRsaWJyYXJ5TmFtZS8uLi8ubGlicy9saWJld2Via2l0LnNvIjsK