44422 2010-08-23 07:29:09 -0700 `document.compatMode` is `undefined` when using `application/xhtml+xml` 2010-09-14 16:58:12 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED http://mathiasbynens.be/demo/xhtml5 P2 Normal --- 1 mathias abarth abarth ap commit-queue mathias Ms2ger paulirish oldest_to_newest 267894 0 65115 mathias 2010-08-23 07:29:09 -0700 Created attachment 65115 Example XHTML5 document. When served with the correct MIME type (application/xhtml+xml), `document.compatMode` will be undefined. As the title says, `document.compatMode` is `undefined` when using `application/xhtml+xml`. I would have expected a value of "CSS1Compat" instead. You can test this using the example XHTML5 document (see attachment) or on <http://mathiasbynens.be/demo/xhtml5>. 268022 1 ap 2010-08-23 11:35:09 -0700 Confirmed with r65737. 278753 2 abarth 2010-09-14 00:27:22 -0700 Sayth the spec: The compatMode IDL attribute must return the literal string "CSS1Compat" unless the document has been set to quirks mode by the HTML parser, in which case it must instead return the literal string "BackCompat". 278759 3 67525 abarth 2010-09-14 00:52:58 -0700 Created attachment 67525 Patch 278798 4 67525 eric 2010-09-14 03:49:52 -0700 Comment on attachment 67525 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=67525&action=prettypatch Seems fine to me. Can you get into quirks mode for XML? 278805 5 Ms2ger 2010-09-14 04:02:50 -0700 (In reply to comment #4) > (From update of attachment 67525 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=67525&action=prettypatch > > Seems fine to me. Can you get into quirks mode for XML? No. 279015 6 67525 abarth 2010-09-14 10:32:56 -0700 Comment on attachment 67525 Patch Nope. Only the HTML parser can put you in quirk mode (AFAIK). 279202 7 67525 commit-queue 2010-09-14 15:22:03 -0700 Comment on attachment 67525 Patch Rejecting patch 67525 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing,media', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20991 test cases. fast/css/visited-link-hang.html -> failed Exiting early after 1 failures. 6198 tests run. 120.64s total testing time 6197 test cases (99%) succeeded 1 test case (<1%) had incorrect layout Full output: http://queues.webkit.org/results/4038011 279211 8 67525 abarth 2010-09-14 15:40:27 -0700 Comment on attachment 67525 Patch commit-queue bug should be fixed now. 279248 9 67525 abarth 2010-09-14 16:27:31 -0700 Comment on attachment 67525 Patch Clearing flags on attachment: 67525 Committed r67512: <http://trac.webkit.org/changeset/67512> 279249 10 abarth 2010-09-14 16:27:36 -0700 All reviewed patches have been landed. Closing bug. 279256 11 67525 commit-queue 2010-09-14 16:58:12 -0700 Comment on attachment 67525 Patch Rejecting patch 67525 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 1 Last 500 characters of output: tching file WebCore/html/HTMLDocument.cpp Hunk #1 FAILED at 136. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/html/HTMLDocument.cpp.rej patching file WebCore/html/HTMLDocument.h Hunk #1 FAILED at 50. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/html/HTMLDocument.h.rej patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/fast/parser/compatMode-in-xhtml-expected.txt patching file LayoutTests/fast/parser/compatMode-in-xhtml.xhtml Full output: http://queues.webkit.org/results/4027013 65115 2010-08-23 07:29:09 -0700 2010-08-23 07:29:09 -0700 Example XHTML5 document. When served with the correct MIME type (application/xhtml+xml), `document.compatMode` will be undefined. xhtml5.xhtml application/xhtml+xml 242 mathias PCFET0NUWVBFIGh0bWw+CjxodG1sIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hodG1s Ij4KIDxoZWFkPgogIDxtZXRhIGNoYXJzZXQ9InV0Zi04IiAvPgogIDx0aXRsZT5YSFRNTDUsIG9y IEhUTUw1IGluIFhNTCBzZXJpYWxpemF0aW9uIG1vZGU8L3RpdGxlPgogPC9oZWFkPgogPGJvZHk+ CiAgPHA+WEhUTUwgc3Vja3MsIGJ1dCBoZXkg4oCUIHNvIGRvIGJyb3dzZXIgYnVncyE8L3A+CiA8 L2JvZHk+CjwvaHRtbD4= 67525 2010-09-14 00:52:58 -0700 2010-09-14 16:58:12 -0700 Patch bug-44422-20100914005256.patch text/plain 5010 abarth SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NzQ1MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTAtMDktMTQgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBgZG9j dW1lbnQuY29tcGF0TW9kZWAgaXMgYHVuZGVmaW5lZGAgd2hlbiB1c2luZyBgYXBwbGljYXRpb24v eGh0bWwreG1sYAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NDQ0MjIKKworICAgICAgICBNb3ZpbmcgdGhlIGNvbXBhdE1vZGUgSURMIGF0dHJpYnV0ZSBm cm9tIEhUTUxEb2N1bWVudC5pZGwgdG8KKyAgICAgICAgRG9jdW1lbnQuaWRsIGZpeGVzIHRoaXMg YnVnIGFuZCBpbXByb3ZlIGNvbXBsaWFuY2Ugd2l0aCBIVE1MNS4KKworICAgICAgICBUZXN0OiBm YXN0L3BhcnNlci9jb21wYXRNb2RlLWluLXhodG1sLnhodG1sCisKKyAgICAgICAgKiBkb20vRG9j dW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OmNvbXBhdE1vZGUpOgorICAg ICAgICAqIGRvbS9Eb2N1bWVudC5oOgorICAgICAgICAqIGRvbS9Eb2N1bWVudC5pZGw6CisgICAg ICAgICogaHRtbC9IVE1MRG9jdW1lbnQuY3BwOgorICAgICAgICAqIGh0bWwvSFRNTERvY3VtZW50 Lmg6CisKIDIwMTAtMDktMTQgIEppYSBQdSAgPGpwdUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KSW5kZXg6IFdlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAJKHJldmlzaW9uIDY3NDQ0KQor KysgV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02MDgsNiArNjA4 LDExIEBAIHZvaWQgRG9jdW1lbnQ6OnNldENvbXBhdGliaWxpdHlNb2RlKENvbXAKICAgICB9CiB9 CiAKK1N0cmluZyBEb2N1bWVudDo6Y29tcGF0TW9kZSgpIGNvbnN0Cit7CisgICAgcmV0dXJuIGlu UXVpcmtzTW9kZSgpID8gIkJhY2tDb21wYXQiIDogIkNTUzFDb21wYXQiOworfQorCiB2b2lkIERv Y3VtZW50OjpyZXNldExpbmtDb2xvcigpCiB7CiAgICAgbV9saW5rQ29sb3IgPSBDb2xvcigwLCAw LCAyMzgpOwpJbmRleDogV2ViQ29yZS9kb20vRG9jdW1lbnQuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL2RvbS9Eb2N1bWVudC5oCShyZXZpc2lvbiA2NzQ0NCkKKysrIFdlYkNvcmUvZG9tL0RvY3Vt ZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTU3OSw2ICs1NzksOCBAQCBwdWJsaWM6CiAgICAgdm9p ZCBsb2NrQ29tcGF0aWJpbGl0eU1vZGUoKSB7IG1fY29tcGF0aWJpbGl0eU1vZGVMb2NrZWQgPSB0 cnVlOyB9CiAgICAgQ29tcGF0aWJpbGl0eU1vZGUgY29tcGF0aWJpbGl0eU1vZGUoKSBjb25zdCB7 IHJldHVybiBtX2NvbXBhdGliaWxpdHlNb2RlOyB9CiAKKyAgICBTdHJpbmcgY29tcGF0TW9kZSgp IGNvbnN0OworCiAgICAgYm9vbCBpblF1aXJrc01vZGUoKSBjb25zdCB7IHJldHVybiBtX2NvbXBh dGliaWxpdHlNb2RlID09IFF1aXJrc01vZGU7IH0KICAgICBib29sIGluTGltaXRlZFF1aXJrc01v ZGUoKSBjb25zdCB7IHJldHVybiBtX2NvbXBhdGliaWxpdHlNb2RlID09IExpbWl0ZWRRdWlya3NN b2RlOyB9CiAgICAgYm9vbCBpbk5vUXVpcmtzTW9kZSgpIGNvbnN0IHsgcmV0dXJuIG1fY29tcGF0 aWJpbGl0eU1vZGUgPT0gTm9RdWlya3NNb2RlOyB9CkluZGV4OiBXZWJDb3JlL2RvbS9Eb2N1bWVu dC5pZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9kb20vRG9jdW1lbnQuaWRsCShyZXZpc2lvbiA2 NzQ0NCkKKysrIFdlYkNvcmUvZG9tL0RvY3VtZW50LmlkbAkod29ya2luZyBjb3B5KQpAQCAtMjMz LDYgKzIzMyw4IEBAIG1vZHVsZSBjb3JlIHsKICAgICAgICAgLy8gSFRNTCA1CiAgICAgICAgIE5v ZGVMaXN0IGdldEVsZW1lbnRzQnlDbGFzc05hbWUoaW4gRE9NU3RyaW5nIHRhZ25hbWUpOwogCisg ICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBET01TdHJpbmcgY29tcGF0TW9kZTsKKwogICAgICAg ICAvLyBOb2RlU2VsZWN0b3IgLSBTZWxlY3RvciBBUEkKICAgICAgICAgRWxlbWVudCBxdWVyeVNl bGVjdG9yKGluIERPTVN0cmluZyBzZWxlY3RvcnMpCiAgICAgICAgICAgICByYWlzZXMoRE9NRXhj ZXB0aW9uKTsKSW5kZXg6IFdlYkNvcmUvaHRtbC9IVE1MRG9jdW1lbnQuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvaHRtbC9IVE1MRG9jdW1lbnQuY3BwCShyZXZpc2lvbiA2NzQ0NCkKKysrIFdl YkNvcmUvaHRtbC9IVE1MRG9jdW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzYsMTEgKzEz Niw2IEBAIHZvaWQgSFRNTERvY3VtZW50OjpzZXREZXNpZ25Nb2RlKGNvbnN0IFMKICAgICBEb2N1 bWVudDo6c2V0RGVzaWduTW9kZShtb2RlKTsKIH0KIAotU3RyaW5nIEhUTUxEb2N1bWVudDo6Y29t cGF0TW9kZSgpIGNvbnN0Ci17Ci0gICAgcmV0dXJuIGluUXVpcmtzTW9kZSgpID8gIkJhY2tDb21w YXQiIDogIkNTUzFDb21wYXQiOwotfQotCiBFbGVtZW50KiBIVE1MRG9jdW1lbnQ6OmFjdGl2ZUVs ZW1lbnQoKQogewogICAgIGlmIChOb2RlKiBub2RlID0gZm9jdXNlZE5vZGUoKSkKSW5kZXg6IFdl YkNvcmUvaHRtbC9IVE1MRG9jdW1lbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2h0bWwvSFRN TERvY3VtZW50LmgJKHJldmlzaW9uIDY3NDQ0KQorKysgV2ViQ29yZS9odG1sL0hUTUxEb2N1bWVu dC5oCSh3b3JraW5nIGNvcHkpCkBAIC01MCw3ICs1MCw2IEBAIHB1YmxpYzoKICAgICBTdHJpbmcg ZGVzaWduTW9kZSgpIGNvbnN0OwogICAgIHZvaWQgc2V0RGVzaWduTW9kZShjb25zdCBTdHJpbmcm KTsKIAotICAgIFN0cmluZyBjb21wYXRNb2RlKCkgY29uc3Q7CiAgICAgdmlydHVhbCB2b2lkIHNl dENvbXBhdGliaWxpdHlNb2RlRnJvbURvY3R5cGUoKTsKIAogICAgIEVsZW1lbnQqIGFjdGl2ZUVs ZW1lbnQoKTsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDY3NDUxKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDktMTQgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBgZG9jdW1lbnQuY29tcGF0TW9kZWAgaXMgYHVuZGVmaW5lZGAgd2hl biB1c2luZyBgYXBwbGljYXRpb24veGh0bWwreG1sYAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDQ0MjIKKworICAgICAgICBUZXN0IHRoZSB2YWx1ZSBv ZiBjb21wYXRNb2RlIGluIFhIVE1MLiAgSSdtIHRlcnJpYmxlIGF0IFhNTCwgYnV0IHRoaXMKKyAg ICAgICAgdGVzdCBzZWVtcyB0byB3b3JrLgorCisgICAgICAgICogZmFzdC9wYXJzZXIvY29tcGF0 TW9kZS1pbi14aHRtbC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvcGFyc2Vy L2NvbXBhdE1vZGUtaW4teGh0bWwueGh0bWw6IEFkZGVkLgorCiAyMDEwLTA5LTE0ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRvbnkgQ2hh bmcuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L3BhcnNlci9jb21wYXRNb2RlLWluLXhodG1sLWV4 cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3BhcnNlci9jb21wYXRN b2RlLWluLXhodG1sLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zh c3QvcGFyc2VyL2NvbXBhdE1vZGUtaW4teGh0bWwtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpA QCAtMCwwICsxLDIgQEAKK0FMRVJUOiBDU1MxQ29tcGF0CisKSW5kZXg6IExheW91dFRlc3RzL2Zh c3QvcGFyc2VyL2NvbXBhdE1vZGUtaW4teGh0bWwueGh0bWwKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvZmFzdC9wYXJzZXIvY29tcGF0TW9kZS1pbi14aHRtbC54aHRtbAkocmV2aXNpb24gMCkK KysrIExheW91dFRlc3RzL2Zhc3QvcGFyc2VyL2NvbXBhdE1vZGUtaW4teGh0bWwueGh0bWwJKHJl dmlzaW9uIDApCkBAIC0wLDAgKzEsMTUgQEAKKzwhRE9DVFlQRSBodG1sPiAKKzxodG1sIHhtbG5z PSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hodG1sIj4gCisgPGhlYWQ+IAorICA8bWV0YSBjaGFy c2V0PSJ1dGYtOCIgLz4gCisgIDx0aXRsZT5YSFRNTDwvdGl0bGU+IAorIDwvaGVhZD4gCisgPGJv ZHk+IAorIDxzY3JpcHQ+CisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAg ICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICAgIGFsZXJ0KGRvY3Vt ZW50LmNvbXBhdE1vZGUpOworIDwvc2NyaXB0PgorIDwvYm9keT4gCis8L2h0bWw+CisK